TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 21:40:39 +03:00
Code Issues Projects Releases Wiki Activity
290 Commits 237 Branches 1,680 Tags 386 MiB
5ed16075b7
Commit Graph

290 Commits

Author SHA1 Message Date
Fabien "egg" O'Carroll
5ed16075b7 Fixed title conditional to allow for no title 
refs https://github.com/TryGhost/Team/issues/1695

We should allow for an empty string to be passed in as the title,
which means a boolean coercion check is not appropriate, we should
check for null which in this case means to use the default title
 2022-07-28 15:34:00 +01:00
Rishabh
beb8807966 Fixed resize observer error in tests 
- resize observer used in auth frame is not available in Jest, so we mock it instead
- ignores missing methods on resize observer for tests
 2022-07-28 19:01:24 +05:30
Rishabh
9afb36fa53 Disabled context menu edit if editing another comment 
refs https://github.com/TryGhost/Team/issues/1710

- if a comment is in edit mode, it stops opening edit for another comment till existing edit mode is exited
 2022-07-28 18:50:14 +05:30
Peter Zimon
d28f00656c Updated CTA styles 
no issue

- typography and spacing was a bit off in the signup / upgrade CTA boxes
- the line style was inconsistent with the rest of the comments design
- button sizes and spacings needed also a bit of refinement
 2022-07-28 14:19:55 +02:00
Fabien 'egg' O'Carroll
f3f6b2a98f Added ability to change title and hide comment count (#3) 
refs https://github.com/TryGhost/Team/issues/1695

This allows theme developers to customise the output via the
{{comments}} helper
 2022-07-28 12:21:14 +01:00
Peter Zimon
b58970f9e8 Added minor visual improvements 
no issue

- applied typography changes to bio and date line as they were too strong
- padding and positioning of the comment input form was a bit misaligned
 2022-07-28 13:11:39 +02:00
Peter Zimon
2906018b34 Added spinner to submit button 2022-07-28 12:19:15 +02:00
Rishabh
a10c244e7c Updated member count to use total across pagination 
refs https://github.com/TryGhost/Team/issues/1695

- member count was using total comments of current page than all comments across
 2022-07-28 00:22:43 +05:30
Rishabh
91d3864126 v0.2.3 2022-07-27 21:17:37 +05:30
Rishabh
8078c4a495 v0.2.2 2022-07-27 19:38:38 +05:30
James Morris
b444500f45 A few dark mode tweaks to make sure it looks nice 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-27 14:28:56 +01:00
James Morris
3dd1cb026a Added a truncation for mobile for the comments title 2022-07-27 14:22:45 +01:00
James Morris
c69409cbac Updated the included comment count to be dynamic 
- Before it was static, with an X, but now using the variable available
- Do note, this doesn't seem to be showing the right number

refs https://github.com/TryGhost/Team/issues/1695
 2022-07-27 14:03:50 +01:00
James Morris
ffabb79703 Added in the title and comments into the Comments repo, rather than in be in the theme only 
refs https://github.com/TryGhost/Team/issues/1695
 2022-07-27 14:00:20 +01:00
James Morris
457406a86b Added in a cancel button for when replying 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-27 13:39:09 +01:00
James Morris
14dedbf95a Brought the pagination style inline with the reply one 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-27 13:35:35 +01:00
James Morris
1ff7b15a50 Subtle fade in for comments on render and pagination 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-27 11:49:17 +01:00
James Morris
9bd258b461 Commented out Bio stuff for now until it can be wired up 
- Please note the commenting out of code here
- We want to put this back in when Bio is available

refs: https://github.com/TryGhost/Team/issues/1716
 2022-07-27 11:39:11 +01:00
James Morris
8b4b838547 Tweaking up the form shadow with some subtle hover state 
- Added in a shadow hover state for the form but has to be subtle to not show cutoff

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-27 10:46:09 +01:00
James Morris
83928a8965 Removed the testing text for bio 
refs https://github.com/TryGhost/Team/issues/1716
 2022-07-27 10:24:31 +01:00
Djordje Vlaisavljevic
a4fe453bfa Fixed CTA spacing in empty state 
refs #1704
 2022-07-27 11:15:48 +02:00
Rishabh
c1961b30dd Updated to show only single edit box at one time 
refs https://github.com/TryGhost/Team/issues/1710

- if a user is already editing/replying a comment, we shouldn't show other text boxes they can edit as it can be generally confusing
 2022-07-27 14:36:08 +05:30
Djordje Vlaisavljevic
00f2d455da Updated CTA design 
refs #1704
 2022-07-27 10:13:52 +02:00
Djordje Vlaisavljevic
db584379fa Updated empty state design 
refs #1698
 2022-07-27 10:13:36 +02:00
Rishabh
b351e75feb Removed extra comment box when in reply mode 
refs https://github.com/TryGhost/Team/issues/1710

- keeps a single comment box when in reply mode, hiding the main comment box outside
 2022-07-26 22:55:01 +05:30
James Morris
843a79511f Changed the bio in the comment box to bring up the modal 2022-07-26 18:08:18 +01:00
James Morris
7e4f0bf361 Adding in bio position to comments, change to comment layout, changed up mobile design tweaks, new comment form, no global styles on iframes 
- This removes the global styles on the iFrame
- Changes to comment layout for new bio, new position for date and edited tag
- Lots of design tweaks for desktop and mobile

refs https://github.com/TryGhost/Team/issues/1716
 2022-07-26 16:22:45 +01:00
James Morris
550d28cc96 Moved the date up to underneath the name and tweaked over bits 2022-07-26 12:44:49 +01:00
James Morris
531e0036b2 Renamed the add name dialog to better suit including bio 2022-07-26 11:47:36 +01:00
James Morris
b1e1d4e23b Aded in a basic Bio field into the Add Name dialog 2022-07-26 11:45:10 +01:00
Rishabh
1eb16692aa v0.2.1 2022-07-26 15:40:34 +05:30
Rishabh
75503279d4 v0.2.0 2022-07-25 22:40:53 +05:30
Rishabh Garg
3314a03a3b Replaced hardcoded css link with styles from config (#2) 
refs https://github.com/TryGhost/Team/issues/1719

- the stylesheet link was prev hardcoded in the app, which made it impossible to configure from Ghost
- fetches styles url from the data attribute on script instead, which allows app to load styles based on config upstream
 2022-07-25 22:39:23 +05:30
Simon Backx
2e7055622e Fixed reply box redrawing when clicking the button again 
refs https://github.com/TryGhost/Team/issues/1710

Was caused by: mouseDown triggered on Reply button -> editor blurred -> editor closed itself -> onClick on reply opened the form again
 2022-07-22 17:38:28 +02:00
Simon Backx
3fbb7a6c24 Improved Form stability 2022-07-22 17:26:14 +02:00
Simon Backx
45d3ffcf06 Added proper cleanup functions to Form's useEffect 2022-07-22 17:24:02 +02:00
Simon Backx
6550d1b8cc Fixed add name dialog enter transition 2022-07-22 17:20:55 +02:00
Simon Backx
8544dbb1ba Removed old for attribute and readded appear animation in modals 2022-07-22 17:12:28 +02:00
Simon Backx
fd996da083 Refixed selection and flashing by properly stopping propagation 2022-07-22 17:07:17 +02:00
Simon Backx
e5d6a626bd Fixed selection inside forms 2022-07-22 16:34:05 +02:00
James Morris
34724c991e Tons of added styles to make mobile look better 
refs: https://github.com/TryGhost/Team/issues/1712
 2022-07-22 15:14:47 +01:00
Simon Backx
e333ecdb85 Fixed flashing when clicking around comment box when open 
refs https://github.com/TryGhost/Team/issues/1710
 2022-07-22 15:56:05 +02:00
Simon Backx
4bd1181e33 Removed admin auth log 2022-07-22 15:31:27 +02:00
James Morris
b2c7a49398 Removed the unncessary toggle reply prop that was passed 
no issue
 2022-07-22 13:46:12 +01:00
Simon Backx
c2d49d549c Removed default include from comments browse API call 2022-07-22 14:02:35 +02:00
James Morris
0dab85bfe9 Added in some basic hover to the action buttons 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:26:44 +01:00
James Morris
e1648551bf Improved the dropdowns on mobile 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:12:36 +01:00
James Morris
9f93eb75f5 Better blank avatar in dark mode and hover states for pagination 
- The blank avatar needed some work in dark mode and removed bits from svg file
- Added in some hover states for the pagination buttons

refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 11:05:50 +01:00
James Morris
4ab0bdf3b7 Added in conditions to the submit button values to work on mobile 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 10:54:33 +01:00
James Morris
fa411fdbf2 Fixing up some things with the modals and mobile and other bits 
refs https://github.com/TryGhost/Team/issues/1703
 2022-07-22 10:44:31 +01:00