Commit Graph

11317 Commits

Author SHA1 Message Date
Rishabh
71e5d708d4 Reverted "Disabled image editor setting check"
This reverts commit 9d9e296148.

This commit was a temporary fix to load the image editor if the setting was disabled.
2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9 Merged v5.50.2 into main 2023-06-06 19:05:20 +00:00
Ghost CI
924d73e02e v5.50.2 2023-06-06 19:05:19 +00:00
Rishabh
9d9e296148 Disabled image editor setting check
refs https://github.com/TryGhost/Team/issues/3034

Temporarily disables image editor setting check to allow it load by default
2023-06-06 23:59:43 +05:30
Rishabh
6806b88139 Fixed pintura link in image editor integration
refs https://github.com/TryGhost/Team/issues/3034
2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be Added koenig lexical version to feedback submission
refs TryGhost/Team#3381
2023-06-06 12:55:51 -05:00
Ghost CI
c8b713a679 Merged v5.50.1 into main 2023-06-06 14:40:58 +00:00
Ghost CI
6a07d63f38 v5.50.1 2023-06-06 14:40:57 +00:00
Kevin Ansfield
076c2be9aa
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:20:35 +01:00
Kevin Ansfield
d5a547b6ad
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 15:20:22 +01:00
Kevin Ansfield
ed24899fa5
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 15:20:14 +01:00
Kevin Ansfield
dddd2a4111
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:14:22 +01:00
Sanne de Vries
d9a20b0e00 Fixed form embed settings overflowing in x direction
Closes https://github.com/TryGhost/Team/issues/3384
2023-06-06 15:24:08 +02:00
Kevin Ansfield
c11c842b1e
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 13:35:07 +01:00
Kevin Ansfield
48defc4000
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 12:56:33 +01:00
Sanne de Vries
9c9eae1c11 Updated signup embed modal responsiveness
Refs https://github.com/TryGhost/Team/issues/3340
2023-06-06 12:21:11 +02:00
Simon Backx
31549933a1 Removed 200% width in signup form minimal preview
no issue

This change wasn't needed after all
2023-06-06 10:43:32 +02:00
Simon Backx
0ae1dad2d2 Removed signup form preview flickering in Safari and improved responsiveness
no issue

- In Safari, we'll poll longer before animating to the new iframe
- Update the iframe immediately if the last change was a while ago, to improve responsiveness
2023-06-06 10:43:06 +02:00
Sodbileg Gansukh
feac482859 Fixed loading screen flash issue in dark mode
closes https://github.com/TryGhost/Team/issues/3344
2023-06-06 16:21:15 +08:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px
no issue

Optimal resolution for @3x devices
2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled
fixes https://github.com/TryGhost/Team/issues/3385
2023-06-06 09:40:47 +02:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview
no issue
2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
2023-06-05 17:59:18 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
2023-06-05 17:37:43 +02:00
Daniel Lockyer
6c3517f67a
Removed unused top-gh-contribs dependency
- this is currently unused so we can clean it up
2023-06-05 15:58:51 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview
fixes https://github.com/TryGhost/Team/issues/3378
2023-06-05 15:24:59 +02:00
Sodbileg Gansukh
f4c109cfb2 Added small improvements to the image editor UI
refs https://github.com/TryGhost/Team/issues/3208

- added maximum width limit to the editor stage, so the image doesn't get under the editor controls
- made the crop indicator a bit bigger
- fixed image alignment for the vertical layout
2023-06-05 18:27:31 +08:00
Ronald Langeveld
52150d5ffb
Fixed Signup Embed iFrame not loading in Safari (#16935)
refs https://github.com/TryGhost/Team/issues/3375

- Fixed a safari bug that caused the signup embed iframe to be in the
`onLoad` state perpetually, causing it not to render.
2023-06-05 12:01:55 +02:00
Ghost CI
7170b2489e v5.50.0 2023-06-05 08:58:31 +00:00
Kevin Ansfield
bbd511b752
Added beta of the new Ghost editor (#16923)
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the full feature announcement.
2023-06-05 09:46:31 +01:00
Ghost CI
6ac848195c v5.49.3 2023-06-02 15:02:42 +00:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal
no issue
2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925)
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-02 16:07:30 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script
refs https://github.com/TryGhost/Team/issues/3307
2023-06-02 14:36:17 +02:00
Daniel Lockyer
8098f8c53e Updated Admin extensions script functionality
fixes https://github.com/TryGhost/Toolbox/issues/587

- this commit changes two things surrounding the extensions script:
  - moves the script tag from the nav menu to the application template
    so we always load the script irregardless of if the current page has
    a nav menu
  - opens up showing the script to all logged-in users and not just
    Owners as previous
2023-06-02 14:05:40 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Kevin Ansfield
ba6ae472c3
Renamed editor beta route
closes https://github.com/TryGhost/Team/issues/3369

- removes `lexical` from user-visible URL
- only renames path rather than renaming all associated files to keep changeset minimal prior to beta launch
2023-06-02 12:52:57 +01:00
Michael Barrett
108c7c38f6
Removed imageEditor flag (#16921)
refs https://github.com/TryGhost/Team/issues/3337

Removed `imageEditor` flag and moved gated logic to be behind the
`lexicalEditor` flag as part of the labs clean up
2023-06-02 12:07:31 +01:00
Simon Backx
806abf28e4 Added placeholder to member label input for signup form embed modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 12:28:58 +02:00
renovate[bot]
a1ab6737e1 Update dependency @embroider/macros to v1.11.0 2023-06-02 11:01:47 +02:00
Djordje Vlaisavljevic
307380a29e Removed L label next to Lexical posts in post list
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Djordje Vlaisavljevic
559c1e0764 Updated feedback form copy
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Simon Backx
f00b788e6a Moved signup form embed to the membership settings
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 10:15:08 +02:00
Simon Backx
9ff9906670 Added transparent background pattern to minimal signup form preview
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:48:25 +02:00
Simon Backx
5152e0e042 Moved signup form embed to a modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:31:38 +02:00
renovate[bot]
7959f76f44 Update sentry-javascript monorepo to v7.54.0 2023-06-02 09:06:32 +02:00
Jono Mingard
eaa16c2f75 Added simple colour picker to change signup embed background
refs https://github.com/TryGhost/Team/issues/3338
2023-06-02 11:33:08 +12:00
Jono Mingard
024045b9e3 Update signup form text colours to be passed via attributes 2023-06-02 10:59:00 +12:00