TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-30 14:22:07 +03:00
Code Issues Projects Releases Wiki Activity
15,168 Commits 250 Branches 1,686 Tags 401 MiB
60ff6d4267
Commit Graph

15168 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
James Morris
5dc30ba6a9 Added AMP styles for headers as well as more tweaks for email and frontend 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 18:42:25 +00:00
Fabien egg O'Carroll
bdfce42413 Updated @tryghost/html-to-mobiledoc 
no-issue

This includes updates to the html parsers for creating mobiledoc cards
and now works for the before/after cards, as well as fixes for
classnames of existing cards
 2021-12-15 20:16:19 +02:00
Fabien egg O'Carroll
9db1c843c3 Updated Before/After card markup 
refs https://github.com/TryGhost/Team/issues/1249

This removes some superfluous markup as well as renaming the slider
handle classname
 2021-12-15 20:11:16 +02:00
James Morris
ad96ad4baa Next round of styles for headers in frontend and email 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 17:45:01 +00:00
Thibaut Patel
9198e2b0af Updated the headers card 
refs https://github.com/TryGhost/Team/issues/1253

- Added configurable width
- Fixed css class names
 2021-12-15 18:35:19 +01:00
Peter Zimon
4353763de1 Updated file upload frontend styles 2021-12-15 17:44:37 +01:00
Thibaut Patel
3aa60e1e00 Fixed the header card rendering 
refs https://github.com/TryGhost/Team/issues/1253

- the card was failing to render without a subheader
- the subheader is optional so it needs to be rendering in that case
 2021-12-15 16:19:55 +01:00
Fabien egg O'Carroll
6938808276 Improved styling of mismatched aspect ratio sliders 
refs https://github.com/TryGhost/Team/issues/1249

The height:100%; stops taller images escaping the slider component.
 2021-12-15 17:04:06 +02:00
Fabien egg O'Carroll
6f97396c1b Removed focus from slider after use 
refs https://github.com/TryGhost/Team/issues/1249

If we leave focus on the slider than after interacting with it, it will
capture scroll events and move the slider rather than scrolling the
page.
 2021-12-15 16:59:25 +02:00
Fabien egg O'Carroll
c745211ee4 Fixed small images in "wide" before/after card 
refs https://github.com/TryGhost/Team/issues/1249

Because we cannot resize the container of teh slider without affecting
the surrounding content, e.g. in the context of a grid. We need to
stretch images to fit the slider container.

This also applies the `object-fit: cover` property to the slider image
to help with mis-matched aspect ratios
 2021-12-15 16:56:46 +02:00
Fabien egg O'Carroll
16c6e535be Fixed image widths for before/after slider 
refs https://github.com/TryGhost/Team/issues/1249

Instead of attempting to calculate teh width of the container, we leave
one image to fill up space naturally as the browser allows it, and then
use that to set the width of the secondary image.
 2021-12-15 16:32:35 +02:00
Peter Zimon
acd0223f5b Callout style refinements 2021-12-15 14:51:55 +01:00
Thibaut Patel
49170e7ff2 Added a first version of the header card frontend rendering 
refs https://github.com/TryGhost/Team/issues/1253

- Based on the editor card, the css isn't correct yet as it has undefined css variables
 2021-12-15 14:46:00 +01:00
Fabien egg O'Carroll
a21a436f98 Added handle for before/after slider 
refs https://github.com/TryGhost/Team/issues/1249

Using an input as the slider handle meant setting a width of 100% + px,
which could push width over the size of the screen - not good! This
takes the same approach as the CodePen linked below and uses a separate
element, which has the position of it updated by JS in realtime.

https://codepen.io/josephwong2004/pen/NWRGxdR
 2021-12-15 15:16:29 +02:00
Daniel Lockyer
da586b3705 v4.30.1 2021-12-15 13:10:47 +00:00
Daniel Lockyer
66df325721 Updated Admin to v4.30.1 2021-12-15 13:10:47 +00:00
Sam Lord
902f8dbd7e 🎨 Updated Casper to v4.6.0 2021-12-15 13:07:08 +00:00
Daniel Lockyer
1d702ca470 v4.30.0 2021-12-15 12:49:15 +00:00
Daniel Lockyer
8397e9489c Updated Admin to v4.30.0 2021-12-15 12:49:15 +00:00
Peter Zimon
45066b11fd Default card style updates 
- fixed video styles for small videos
- cleaned up callout card typography spacings
 2021-12-15 13:40:26 +01:00
Rishabh Garg
306e565fc1
✨ Added new video card 
refs https://github.com/TryGhost/Team/issues/1229

- new video card allows adding custom video files with thumbnail to post/page
 2021-12-15 18:02:28 +05:30
Rishabh
ffe502fa84 Refined layout for videos with smaller aspect ratio 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-15 17:57:25 +05:30
Peter Zimon
67d0059166 Updated file card markup 
- @tryghost/kg-default-cards@5.14.7
 2021-12-15 13:00:50 +01:00
Peter Zimon
cebbc7ce38
Card css specificity updates (#13895) 
The default CSS styles of the new cards that have been released in the past couple of weeks was overoptimised for overridability. It was done by defining the lowest specificity scores for each card style. This resulted in certain default styles being unusable for a lot of themes – e.g. the text color of a button (which is a a element that is usually defined on a higher specificity) could easily be the same color as its background (accent color by default).

The solution to this issue is to increase the specificity level of globally used default elements (such as a's h1 and other headings, p's etc.) to a medium level so that they have precedence over styles that are defined in most themes. Our baseline specificity score for these default style is 21, which seems to be covering most of the cases in popular themes.

This commit contains CSS updates in card default styles that implement this change.
 2021-12-15 12:58:24 +01:00
Fabien egg O'Carroll
a1df1a8166 Updated gscan to check for before/after card CSS 
refs https://github.com/TryGhost/Team/issues/1249

This ensures that themes which choose to omit default styles for
before/after card include their own.
 2021-12-15 12:38:36 +02:00
Sodbileg Gansukh
aba5382070 Add pointer cursor to audio/video card buttons by default 2021-12-15 16:27:33 +08:00
Rishabh
55ec90f5c9 Fixed inline controls for video card player 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-15 13:20:34 +05:30
Rishabh
b9b2efa25c Added inline attribute for video card loop behavior 
refs https://github.com/TryGhost/Team/issues/1229

Safari/iOS needs `playsinline` attribute on video element to render video player without its own controls
 2021-12-15 12:45:45 +05:30
Rishabh
8b381a1259 Updated gscan rules for video card 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-15 12:11:44 +05:30
Peter Zimon
a3078589dd Updated file styles 2021-12-14 20:50:35 +01:00
Rishabh
4a31a9e847 Added refinements for video card 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-15 00:55:00 +05:30
Rishabh
e21eb935f4 Fixed video player overlay issue on loop 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-15 00:44:49 +05:30
Sanne de Vries
2ac0302da1 Fixed responsive issues for video card 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 19:57:06 +01:00
Rishabh
c158f9ebfc Refined video controls hidden behavior 
no refs

This reverts commit 182899150f.
 2021-12-14 22:41:58 +05:30
Rishabh
182899150f Refined video controls hidden behavior 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 22:40:03 +05:30
Sanne de Vries
e574a8f2b3 Refined video player controls 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 18:04:25 +01:00
Rishabh
e43fe45d24 Removed play icon on video player after first play 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 22:25:30 +05:30
Rishabh
04baa88c23 Fixed video not playing sometimes via player controls 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 22:20:55 +05:30
Peter Zimon
ae2a782987 Audio and file card frontend styles refinements 2021-12-14 17:46:30 +01:00
Rishabh
a6a25dbb77 Updated event handling for custom video player 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 22:15:08 +05:30
Rishabh
61f7f29eed Fixed pause not working for video player 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 22:05:29 +05:30
Rishabh
9ec83214ba Fixed hidden controls for videos on loop 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 21:54:56 +05:30
Sanne de Vries
2364de5696 Added animation to control behavior for video cards 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 17:22:36 +01:00
Rishabh
b8b0a29a2e Refined video player UI behavior 
refs https://github.com/TryGhost/Team/issues/1229

- allows pausing video by clicking on video overlay
 2021-12-14 21:50:27 +05:30
Rishabh
441307c6ad Updated video card player behavior 
refs https://github.com/TryGhost/Team/issues/1229

- refines player control UI behavior on mouseenter
 2021-12-14 21:32:52 +05:30
Sanne de Vries
aa80cf415b Refined video controls behaviour 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 16:51:00 +01:00
Sanne de Vries
79a48df75c Updated video card frontend rendering 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 16:31:42 +01:00
Rishabh
64b3bbf1a6 Refined video controls behavior 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 21:01:22 +05:30
Sam Lord
97c68dd388
Replace error handler middleware with @tryghost/mw-error-handler (#13879) 
refs: https://github.com/TryGhost/Toolbox/issues/137

Extract error handling middleware and replace with a package.
 2021-12-14 15:18:46 +00:00
Rishabh
271d2c02b0 Added video overlay icon handling 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 20:38:07 +05:30