Commit Graph

2306 Commits

Author SHA1 Message Date
Sebastian Gierlinger
89389b3673 Merge pull request #3569 from morficus/issue-3549
fix most recent post stolen by the last logged in user AND only show active users in post-settings-menu drop-down
2014-08-04 10:51:07 +02:00
Sebastian Gierlinger
c3e7b48a6d Merge pull request #3581 from felixrieseberg/iss3541
Autofocus on input fields after routing
2014-08-03 22:22:48 +02:00
Hannah Wolfe
ac4c3a1d62 Merge pull request #3500 from novaugust/markdown-help
Update markdown help modal
2014-08-03 18:05:12 +01:00
Hannah Wolfe
e12f8bb624 Merge pull request #3567 from novaugust/issue#3564
Return to invite new user; invite multiple users in one go
2014-08-03 17:54:59 +01:00
Matt Enlow
07cd654ab9 Return to invite new user; invite multiple users in one go
Closes #3533, Closes #3547, Closes #3531
- invite-new-user always resets role to author now, allowing for multiple invites on one load
- Added confirm action when hitting return in INUModal's email input
- Don't pass users as the model to invite-new-user-modal
- Move invite-new-user reset to a `finally` clause
- invite-new-user always closes on a confirm
2014-08-03 10:31:42 -06:00
Hannah Wolfe
0d5e199632 Merge pull request #3580 from felixrieseberg/iss3543
Insert inline code shortcut for editor
2014-08-03 17:28:39 +01:00
Hannah Wolfe
27710e88d2 Merge pull request #3578 from morficus/issue-3516
Stop event propagation when hitting "enter" in the gh-blur-input component
2014-08-03 17:25:29 +01:00
Hannah Wolfe
a1dad7b59d Merge pull request #3576 from morficus/issue-3523
Error modifying "author" attribute before post record has been created
2014-08-03 17:24:09 +01:00
Matt Enlow
0c2ad482fa Update markdown help modal
Closes #3499
- Swapped out "Cmd" for the symbol. We're all UTF8, right?
- Removed hint for "Inline Code" until we readd its shortcut
2014-08-03 10:24:00 -06:00
Hannah Wolfe
8337762b3d Merge pull request #3579 from morficus/issue-3502
Replacing "touchstart" with "tap" event, provided by hammer.js
2014-08-03 17:23:30 +01:00
Hannah Wolfe
7b380b706b Merge pull request #3535 from rwjblue/properly-transition-on-mobile
Handle toggleing the content screen on mobile.
2014-08-03 17:23:25 +01:00
Hannah Wolfe
7b7573816a Merge pull request #3571 from felixrieseberg/iss3570
Show "Make Owner" only if displayed user is admin
2014-08-03 17:20:54 +01:00
Felix Rieseberg
be683e3d4b Autofocus on input fields after routing
closes #3538, closes #3541
- The “autofocus” property isn’t considered by browsers if the element
is created after the page has been loaded. The Ember cookbook
recommends extending the input type with a manually triggered
autofocus, which I included here.
- This introduces the new helper “gh-focus-input”, an input field
gaining focus even when routing occurs.
2014-08-03 09:16:13 -07:00
Hannah Wolfe
a8f6b31731 Merge pull request #3574 from rwjblue/speed-up-posts-orderby
Small performance tweak for Posts ordering.
2014-08-03 15:05:02 +01:00
Felix Rieseberg
ec188c66d8 Insert inline code shortcut for editor
closes #3543
- Wired up existing code shortcut in codemirror-shortcuts.js in
editor-shortcuts.js
2014-08-02 23:40:12 -07:00
Maurice Williams
da279de71b Replacing "touch start" with "tap" event, provided by hammer.js
fixes #3502
2014-08-03 01:36:46 -04:00
Maurice Williams
cb9f4f7c05 Stop event propagation when hitting "enter" in the gh-blur-input component
fixes #3516
- new behavior is disabled by default
- added new stopEnterKeyDownPropagation property enable new behavior
2014-08-03 00:48:05 -04:00
Maurice Williams
e8f6bcd176 fix most recent post stolen by the last logged in user AND only show active users in post-settings-menu drop-down
fixes #3549 fixes #3528
- instead of grabbing and setting the author after fetching the list of users, get the author info from the models "author" property and set it when that value returns. (3549)
- added filter to the PSM's "authors" attribute to only display active users (3528)
2014-08-02 21:28:02 -04:00
Maurice Williams
4b5aab8306 Error modifying "author" attribute before post record has been created
fixes #3523
- when changing the author, added a check to NOT trigger a save if the post has not been created/saved as yet
2014-08-02 14:35:19 -04:00
Robert Jackson
3bd938a7eb
Small performance tweak for Posts ordering.
* Move publishedAtCompare to standalone function in closure scope
  (allows better browser optimizations).
* Avoid getting the same field (published_at) more than once.
2014-08-02 11:15:55 -04:00
Robert Jackson
ae56c8a8e2
Ensure keyboard navigation matches custom post sorting. 2014-08-02 10:39:26 -04:00
Felix Rieseberg
2f3520a675 Show "Make Owner" only if displayed user is admin
closes #3570
- Added ‘controller.user.isAdmin’ as an condition for displaying the
“make owner” option
2014-08-02 07:02:50 -07:00
Sebastian Gierlinger
d35598457b Merge pull request #3560 from felixrieseberg/iss3537
Descriptive error if user by mail not found.
2014-08-02 13:13:54 +02:00
Sebastian Gierlinger
8b954efbdb Merge pull request #3521 from jaswilli/notifications
Prevent stacking of notifications
2014-08-02 12:54:56 +02:00
Felix Rieseberg
abf251212c Descriptive error if user by mail not found.
closes #3537
- Replaced generic NotFound error with descriptive NotFoundError.
2014-08-01 18:13:33 -07:00
Felix Rieseberg
4c79770580 Admin isn't shown "make owner" option
closes #3558
- Replaced canAssignRoles as "show user" conditional with new
"canMakeOwner"
2014-08-01 13:03:26 -07:00
Jason Williams
0ef7ee4f33 Fix failure in Post API tests.
Refs #3473
- Make sure test is checking the post it expects by verifying
  the post id in the results.
2014-08-01 17:55:27 +00:00
Jason Williams
dd50cca97a Refactor notifications to prevent stacking.
Closes #3511, Closes #3512, Closes #3526
- show* methods now close existing passive notifications by
  default.  They also now take an optional options object where
  existing parameters such as "delayed" and "defaultErrorText"
  can be passed in as well as the new "doNotClosePassive" flag.
- Removed all explicit calls to notifications.closePassive except
  for the few places where it makes sense to call it separately.
2014-08-01 16:57:29 +00:00
Jason Williams
41493e1ccc Add missing model to template render.
Closes #3530, Refs #3474
- Cleanup from #3474 which stopped passing the model into
  the render template call.
2014-08-01 16:29:59 +00:00
Sebastian Gierlinger
063bd3536b Merge pull request #3525 from jaswilli/issue-3510
Sanity check page parameter used in findPage
2014-08-01 18:24:08 +02:00
Jason Williams
938b183707 Sanity check page parameter used in findPage
Closes #3510
- Make sure the page parameter is does not overflow the
  integer data type.
- Added tests.
2014-08-01 14:32:38 +00:00
Sebastian Gierlinger
42c5a32966 Merge pull request #3551 from halfdan/3540-password-reset
Proper messaging on password reset
2014-08-01 15:47:38 +02:00
Fabian Becker
45f2e956d0 Proper messaging on password reset
fixes #3540
- Show proper message when reusing token
- Show message after resetting password
2014-08-01 13:18:53 +00:00
Paul Adam Davis
a7b5c72e68 Change user menu link to a button
Closes #3546

- Change user menu popover toggle from a <a> to a <button>
- Change tests accordingly
2014-08-01 10:56:03 +01:00
Robert Jackson
188265115a
Handle toggleing the content screen on mobile.
Closes #3520.

Move the custom jQuery animation into an action on the controller so
that we can trigger it from within the route if needed.
2014-08-01 02:47:29 -04:00
Jason Williams
0ebccc5c65 Fix tests to ensure correct post is being checked
Refs #3473
- Change tests to not assume that all inserted fixture data
  will end up with the same millisecond-precision time for
  results sorting.  If a test is set up to check the contents
  of a specific fixture extract it explictly from the results.
2014-08-01 05:12:08 +00:00
Hannah Wolfe
59953c6610 Merge pull request #3486 from sebgie/issue#3468
Update spam prevention
2014-08-01 00:10:50 +01:00
Hannah Wolfe
fa4cb9c19d Merge pull request #3496 from jaswilli/refresh
Remove unnecessary hard refresh on signout.
2014-08-01 00:04:39 +01:00
Sebastian Gierlinger
3792598a31 Update spam prevention
closes #3468
- added rate limit to deny more than 5 attempt every hour
- updated spam prevention to be configurable
- added config values spamTimeout, ratePeriod, rateAttempts
- added ratePeriod:1 to config.example.js to prevent functional tests
from hitting the rate limit
- commented spam test, I’ll fix it tomorrow
2014-08-01 00:58:32 +02:00
Sebastian Gierlinger
2200a65954 Merge pull request #3494 from ErisDS/issue-3285
Update importer for MU
2014-08-01 00:52:00 +02:00
Jason Williams
68775b3ef8 Remove unnecessary hard refresh on signout.
Refs #3488
- Hard refresh handled by ember-simple-auth.
2014-07-31 22:41:35 +00:00
Hannah Wolfe
de46cd4a14 Merge pull request #3488 from manuelmitasch/fix-session-invalidation
The page refresh when oauth token has expired was broken.
2014-07-31 23:28:58 +01:00
Hannah Wolfe
756368721e Update importer for MU
closes #3285

- remove apps stuff for now
- if there is a single user, behave the same as before, overriding
  non-critical properties of the single owner user
- if there are multiple users, import them like normal resource
2014-07-31 23:14:57 +01:00
Hannah Wolfe
f4895a4200 Merge pull request #3487 from JohnONolan/notification-copy
Shorter notifications
2014-07-31 22:53:20 +01:00
Hannah Wolfe
91ae72dc82 Merge pull request #3493 from rwjblue/fix-posts-post-author-list
Show posts authored by current user.
2014-07-31 22:41:11 +01:00
Hannah Wolfe
262169fcf8 Merge pull request #3490 from jaswilli/psm
Fix for missing author when switching posts
2014-07-31 22:38:09 +01:00
Robert Jackson
7ca51764d6
Show posts authored by current user.
The current logic allows showing of all EXCEPT the current users posts
(when the current user is an author).

This fixes that.
2014-07-31 17:23:08 -04:00
Jason Williams
fc88f53bae Fix for missing author when switching posts
No Issue
- Fixes the case where the authors dropdown in the
  post settings menu has no author selected after
  switching between posts.
2014-07-31 20:19:52 +00:00
Hannah Wolfe
a04562b349 Merge pull request #3478 from halfdan/fix-pgsql
Fixing pg build.
2014-07-31 20:55:21 +01:00
Hannah Wolfe
a13f460acb Merge pull request #3485 from jaswilli/migration
Fix naming of export file during migration
2014-07-31 20:55:12 +01:00
Hannah Wolfe
6413337c2f Merge pull request #3425 from jgable/fixImporter
Make importer more robust for tags
2014-07-31 20:52:51 +01:00
Manuel Mitasch
2b1720e43b The page refresh when oauth token has expired was broken.
Ember simple-auth action "sessionInvalidationSucceeded" was overriden to display a meaningless message.
2014-07-31 21:49:29 +02:00
Hannah Wolfe
0b55b39cde Changing second half of script placeholders 2014-07-31 19:05:56 +01:00
Sebastian Gierlinger
c5fbe2def3 Merge pull request #3479 from ErisDS/issue-3079
Complete frontend multi-user features
2014-07-31 18:52:16 +02:00
Hannah Wolfe
687197bf31 Updating HTML for script placeholders 2014-07-31 17:42:43 +01:00
Jason Williams
8936b82014 Fix naming of export file during migration
No Issue
- The method that generates a filename for the export during
  a migration returns a promise, not the filename directly,
  so the export file was being named [object Object].
2014-07-31 16:22:05 +00:00
John O'Nolan
854a3041fd Shorter notifications
Basic notifications are unnecessarily verbose and, in some instances, even cause line-wrapping to occur. This change shortens them to short, concsise statements to indicate what action has taken place.
2014-07-31 19:19:47 +03:00
Hannah Wolfe
b7bfc35079 Merge pull request #3476 from rwjblue/moar-shortcuts
Enable uppercase, lowercase, titlecase shortcuts.
2014-07-31 16:50:11 +01:00
Robert Jackson
3cf9034c90 Cleanup CodeMirror shortcuts.
* Add titleize utility function.
  * Capitalizes first word.
  * Capitalizes all words not contained in simple article/conjunction
    list.
* Enable shortcuts for `uppercase`, `lowercase`, and `titlecase`.
* Fix header shortcuts
  * Ensure that header shortcuts do not duplicate text.
  * Make headers idempotent (pressing `ctrl+alt+1` then
    `ctrl+alt+2` does not make `# # # blah`.
2014-07-31 10:53:13 -04:00
Hannah Wolfe
45b4b95b1d Merge pull request #3477 from halfdan/duplicate-notification
Avoids duplicate notification / transition
2014-07-31 15:47:19 +01:00
Hannah Wolfe
194d45fac6 Merge pull request #3480 from jaswilli/issue-3466
Update user roles in store after owner transfer
2014-07-31 15:39:48 +01:00
Hannah Wolfe
1c3cb1bb6a Merge pull request #3472 from morficus/issue-3401
custom slugging capabilities for individual user pages
2014-07-31 15:36:11 +01:00
Hannah Wolfe
26af1e4843 Merge pull request #3471 from novaugust/editor-shortcuts
Keyboard shortcuts for Mac vs All
2014-07-31 15:34:14 +01:00
Hannah Wolfe
f9ff78475b Complete frontend multi-user features
closes #3076

- author RSS pages
- fixes page_url / pagination helper
- add 'author' option to has helper
- tests for author pages, author rss pages and helpers
2014-07-31 15:33:52 +01:00
Matt Enlow
a7444bf338 Keyboard shortcuts for Mac vs All
Closes #3029, Ref #3469
- Editor shortcuts are now built in a separate file, which uses `ctrlOrCmd` to correctly set OS specific shortcuts.
- Removed `newLine` and `selectWord` shortcuts
2014-07-31 08:00:52 -06:00
Jason Williams
baf9138b27 Update user roles in store after owner transfer
Closes #3466
- Transferring the owner role is now done via a separate
  endpoint and not through Ember-Data.  As a result the
  user role data needs to be updated manually.
- Updated the owner endpoint to return a response body
  containing the updated user objects.
- Updated tests.
2014-07-31 13:41:10 +00:00
Sebastian Gierlinger
87b07eb9e0 Merge pull request #3475 from ErisDS/api-clean
User edit & add endpoints cleanup
2014-07-31 15:24:55 +02:00
Sebastian Gierlinger
6ca9e6c657 Merge pull request #3462 from ErisDS/issue-3446
Post list: authors only see their own posts
2014-07-31 15:03:15 +02:00
Fabian Becker
640f4c2915 Fixing pg build.
refs #2499
- Properly reference pg client
- Fix broken sql queries
2014-07-31 12:52:57 +00:00
Fabian Becker
b26e0ec669 Avoids duplicate notification / transition
no ref
- Let application.js handle transition after setup
- Remove duplicate loading of server notifications
2014-07-31 14:22:37 +02:00
Maurice Williams
489cd08d97 custom slugging capabilities for individual user pages
closes #3401
- modifying slug-generator to be more generic
- adding slugging capabilities for /settings/users/:slug
- modified posts to use the updated slug-generator
2014-07-31 08:14:22 -04:00
Robert Jackson
93e728bba2 Redirect to the first available post for current user. 2014-07-31 12:44:22 +01:00
Hannah Wolfe
eecbdc1693 User edit & add endpoints cleanup
- edit and add endpoints don't assume role
- edit and add endpoints cope with no role, role objects, and strings
- resend user invite was failing at one point due to no role being sent, but this shouldn't be required
- other random api cleanup
2014-07-31 12:37:48 +01:00
Hannah Wolfe
23b2ac07d8 Completed post & user list filer by role
closes #3446, closes #3086

- Authors can only ever get to their own posts
- Editors only ever see authors in the user list
2014-07-31 11:23:37 +01:00
Hannah Wolfe
a6c205ac53 Merge pull request #3474 from felixrieseberg/iss3400
User Settings: Display cog based on rights
2014-07-31 09:30:13 +01:00
Felix Rieseberg
e84b6198c4 User Settings: Display cog based on rights
closes #3400
- The user view has been extended to have properties indicating whether
the user has rights to make the displayed user an owner or delete
him/her
- Handlebar conditionals decide whether or not to display the cog
2014-07-31 01:03:03 -07:00
Robert Jackson
f02c2acd71 Limit Posts for Authors.
* Ensures that posts listing only shows posts that the current user
  authored, if they only have the Author role.
* Do not transition into the posts.post route if the current user is
  not the author (but has the Author role). This is needed because
  the API server will always return the post (regardless of the current
  user).
2014-07-31 09:02:49 +01:00
Hannah Wolfe
7919c15e56 Post list: authors see their own posts
issue #3446
2014-07-31 09:02:48 +01:00
Hannah Wolfe
cc995e8ef6 Merge pull request #3371 from javorszky/iss3100
Implement user and related content deletion
2014-07-31 07:51:15 +01:00
Hannah Wolfe
7bf9d021de Merge pull request #3467 from rwjblue/update-validation-to-match-server-error
Update validation to match server error.
2014-07-31 07:46:57 +01:00
Matt Enlow
420500ffab Add keyboard navigation of posts
Closes #3015
- Added stepThroughPosts method to PostsRouter, takes a integer, goes that far, wraps around the array.
- PostsPostRoute notifies the PostsController of which model it currently has, to help stepThroughPosts know who's selected
2014-07-30 22:23:02 -06:00
Jacob Gable
69b871a754 Make importer more robust for tags
Closes #3242

- Add checks for valid fields in tags and posts
- Add unit test with empty tag export data file
- Add unit test with empty post export data file
2014-07-30 22:33:45 -05:00
Gabor Javorszky
8487dada0b Implement user and related content deletion
Closes #3100

* Introduces `destroyByAuhor`, given a context and an id, it will check if context has permission to delete the user by the id, and then deletes all the content where `author_id` is id, and then deletes the user
* Does multiple checks to make sure user exists
* Added a fixture `posts:mu` that creates 4 users belonging to 4 roles, 50 posts that have authors evenly distributed, 5 tags and all 50 have one tag attached to it, evenly distributed.

Caveats / questions

* Started testing
2014-07-31 03:48:59 +01:00
Hannah Wolfe
3de308dc20 Merge pull request #3436 from novaugust/user-role-dropdown
User role dropdown
2014-07-31 02:06:34 +01:00
Matt Enlow
21abed7f9a Add User Role Dropdown
Closes #3402, Closes #3428

-------------------

 ### Components
- Added GhostSelectComponent to handle async select creation (h/t @rwjblue)
- Added GhostRolesSelector (extends GhostSelect) for displaying user role options
- Created StoreInjector for surgically inserting the store into things that normally wouldn't have them.

 ### Users Settings
- InviteNewUserModal now uses GhostRolesSelector & defaults to Author
- The role dropdown for user settings has permissions set per 3402

 ### User Model
- Added `role` property as an interface to getting and setting `roles`
- Refactored anything that set `roles` to set `role`
- isAdmin, isAuthor, isOwner and isEditor are all keyed off of `role` now

 ### Tests
- Added functional tests for Settings.Users
- updated settings.users and settings.users.user screens
- fix spacing on screens

 ### Server Fixtures
- Fixed owner fixture's roles
2014-07-30 17:59:14 -06:00
Robert Jackson
bdbc689232
Update validation to match server error.
When a using the forgottenRoute if you enter an incorrectly formatted
email address you would see the error message 'Invalid Email', however
if you entered an email address that was correctly formatted but missing
the error message would be 'Invalid email address'.

This fixes the discrepancy.
2014-07-30 19:07:42 -04:00
Hannah Wolfe
9f21730648 Merge pull request #3465 from rwjblue/handle-missing-user
Redirect to error404 when user not found.
2014-07-30 22:51:03 +01:00
Hannah Wolfe
5dc457b417 Merge pull request #3443 from halfdan/30850-users-api
Users API advanced browsing
2014-07-30 22:47:55 +01:00
Robert Jackson
3bddb548a5
Redirect to error404 when user not found.
Closes #3459.
2014-07-30 17:43:45 -04:00
Hannah Wolfe
80cbef8cdb Merge pull request #3461 from halfdan/unhandled-rejection
Fix unhandled exception
2014-07-30 22:31:19 +01:00
Hannah Wolfe
c3308fbe2d Merge pull request #3463 from rwjblue/hard-refresh
Perform a hard refresh upon signout.
2014-07-30 22:28:27 +01:00
Hannah Wolfe
5d3788ffe6 Merge pull request #3457 from sebgie/issue#3426
Transfer ownership end point
2014-07-30 22:26:42 +01:00
Hannah Wolfe
8416839bde Merge pull request #3456 from PaulAdamDavis/prevent-auth-autocomplete
Disable autocomplete for setup & signup screens
2014-07-30 22:22:40 +01:00
Hannah Wolfe
06fb658829 Merge pull request #3454 from halfdan/signout-email
Properly remove email notification on signout.
2014-07-30 22:21:41 +01:00
Hannah Wolfe
3c47e630e8 Merge pull request #3453 from PaulAdamDavis/3271-prevent-website-autofill
Disable user settings autocomplete in Chrome
2014-07-30 22:14:32 +01:00
Hannah Wolfe
2251b58571 Merge pull request #3449 from felixrieseberg/iss3383
Stop validation error notification stack
2014-07-30 22:04:31 +01:00
Fabian Becker
29ad30bec8 Fix unhandled exception
no ref
- return result of mail.send
2014-07-30 18:45:00 +00:00
Robert Jackson
7357ece639
Perform a hard refresh upon signout.
Closes #3458.
2014-07-30 14:22:28 -04:00
Fabian Becker
d4fdb07d9c Users API advanced browsing
closes #3085
- active and invited include multiple statuses when fetching
- adjusted data generator
2014-07-30 16:59:27 +00:00
Sebastian Gierlinger
ded6aa6ac0 Transfer ownership end point
closes #3426
- added transfer ownership endpoint
- added owner to roles.permissible
- manually removed owner from roles.browse
- removed hard coded author role
- fixed tests that were passing due to hard coded author role
- added testUtils.setup(‚roles‘)
2014-07-30 17:40:30 +02:00