11 Commits

Author	SHA1	Message	Date
Kevin Ansfield	352c4af1d7	Refactored usage of .get('property') with es5 getters ... no issue - ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod) - [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md) - updates the majority of `object.get('property')` with `object.property` with exceptions: - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters - this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion	2019-03-06 13:54:14 +00:00
Kevin Ansfield	48e3bf003d	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	fda94fedab	ESLint: Alias model in controllers ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/HEAD/docs/rules/alias-model-in-controller.md - replace `model` with a meaningful property name everywhere possible - refactor `design` and `general` settings controllers to use a directly injected settings service rather than passing it in as a "model" to be more explicit	2018-01-12 12:17:56 +00:00
Kevin Ansfield	f622b31b1f	Fix Ember deprecations and warnings (#895) ... no issue - `controller.content` will no longer be an alias to `controller.model` - split relationships and `attrs` in Post model, add missing transforms - fix unknown `error` field in payload warning when `/users/me` returns 404 during tests - fix unsafe style binding warnings	2017-10-13 16:39:49 +07:00
Kevin Ansfield	983110d931	Switched from ember-cli-shims to new module imports (#779) ... no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated	2017-08-22 14:53:26 +07:00
Austin Burdine	bfe542b27d	more shimming of controllers (#110) ... refs #101, #95 - shim controllers that were missed initially	2016-07-06 20:47:30 +01:00
Kevin Ansfield	2f4f6db133	Use es6 across client and add ember-suave to enforce rules ... no issue - add ember-suave dependency - upgrade grunt-jscs dependency - add a new .jscsrc for the client's tests directory that extends from client's base .jscsrc - separate client tests in Gruntfile jscs task so they pick up the test's .jscsrc - standardize es6 usage across client	2015-11-30 10:41:01 +00:00
Kevin Ansfield	5c9a824d53	Standardize on var-less export default across ember app ... no issue - drops the `var Foo = Ember.Thing.extend({}); export default Foo;` syntax in favour of exporting directly, eg: `export default Ember.Thing.extend({})` - discussion on this change [here](https://github.com/TryGhost/Ghost/pull/5340#issuecomment-105828423) and [here](https://github.com/TryGhost/Ghost/pull/5694#discussion-diff-37511606)	2015-10-06 10:59:50 +01:00
John O'Nolan	8a98e1c337	Fixup broken error page styles	2015-06-08 12:14:58 +01:00
Matt Enlow	6d80907c99	Ember init, bower deps, es6 modules	2015-03-11 12:37:41 -06:00
Matt Enlow	589a563b30	The great migration (EAK -> ember-cli)	2015-03-11 12:37:41 -06:00