Commit Graph

2148 Commits

Author SHA1 Message Date
Sebastian Gierlinger
2d7904ab3f Merge pull request #5723 from ErisDS/dep-typeahead
Dep: Remove typeahead
2015-08-26 10:35:57 +02:00
John O'Nolan
f7baac85ff Merge pull request #5715 from dbalders/About-Page-Header
Add Menu to About Ghost Page
2015-08-26 06:04:15 +02:00
Kevin Ansfield
de970a4aba Fix new tags disappearing in PSM when saving post
closes #5708
- when adding a tag give it a throwaway UUID so that every selected/available tag object has a unique identifier for use with selectize
2015-08-25 23:53:19 +01:00
John O'Nolan
58a86d17be Optimise mobile navigation
Make everything a little bit larger on small screens
2015-08-25 18:01:26 +02:00
Hannah Wolfe
cce3a01dfc Dep: Remove typeahead
refs  #5682

- we're now using selectize instead of typeahead, so it isn't needed
2015-08-25 16:26:10 +01:00
Hannah Wolfe
36e0a6b74c Number formatting function for download counter
refs #5652

- safari doesn't support the nice toLocaleString function
- this adds a manual, cross-browser way of adding commas in the right places to long number strings
2015-08-25 15:04:58 +01:00
Hannah Wolfe
6cb45d6939 Don't clear password field until setup is complete
ref #5652

- resolves issues with setup flow for the time being
- password is cleared on deactivate, rather than during step 2
- using transitionToRoute instead of transitionTo to remove deprecation warning
2015-08-25 13:16:39 +01:00
John O'Nolan
f59aa45ea1 Fix splitbutton height regression
Caused by removing display:flexbox from buttons a while back
2015-08-25 13:58:24 +02:00
John O'Nolan
9d5ea5d9be Add white bg to forgotten password link
Lastpass injects its password-fill icon into password inputs, this shows up awkwardly with the forgot-password button. Adding a white BG hides this.

Followup on #5641
2015-08-25 10:20:34 +02:00
David Balderston
0d6fafc969 Add Menu to About Ghost Page
Header on About Page was still missing, so added it in
* Added the header to the about.hbs
2015-08-24 18:27:33 -07:00
Hannah Wolfe
eb1365c4f0 Temporarily disable sourcemaps
- Sourcemaps are adding ~.4mb to the release zip, which is not cool
- Long term, we need to swap this out for a system that will let us do sourcemaps in dev, and
generate a separate non-minified css file without the sourcemap when doing a release
- Short term, I'm disabling sourcemaps & they'll need to be enabled when needed
2015-08-24 18:56:50 +01:00
Kevin Ansfield
643f712624 Validate tag names don't start with commas
closes #5685
- Adds client and server-side validation for tag names starting with commas
- Trim tag names before adding in PSM (tag attributes are already trimmed before saving in TSM)
2015-08-24 16:55:30 +01:00
Kevin Ansfield
d633bf315f Fix alerts disappearing when navigating
closes #5707
- fix disappearing alerts after transitions by not clearing all alerts/notifications when closing menus
- remove `notifications.closeNotifications()` calls left over from needing to clear validation notifications
2015-08-24 16:07:09 +01:00
Hannah Wolfe
566bc03f5f Merge pull request #5694 from kevinansfield/zelda-invite-fixes
Minor UI fixes for invitations
2015-08-24 12:41:43 +01:00
Hannah Wolfe
54f8c8e65f Merge pull request #5691 from acburdine/spin-fix
Fix auto width and height of spin button
2015-08-24 12:07:39 +01:00
John O'Nolan
6a7fa1a183 Merge pull request #5702 from kevinansfield/zelda-signin-updates
Fixes for sign-in error handling
2015-08-24 08:00:13 +02:00
Hannah Wolfe
2972080088 Merge pull request #5682 from kevinansfield/tags-v4
Replace the current tag input with a selectize based input
2015-08-21 21:34:06 +01:00
Hannah Wolfe
7545e4a655 Merge pull request #5699 from kevinansfield/close-nav-menu-on-transition
Mobile nav menu fixes
2015-08-21 21:32:26 +01:00
Hannah Wolfe
5f5f67d171 Merge pull request #5687 from kevinansfield/fix-tags-validation
Add inline error handling and tests for tag creation/editing
2015-08-21 21:31:40 +01:00
Hannah Wolfe
dd8c7da13e Merge pull request #5703 from rwjblue/fix-release-issues
Fix release build issues.
2015-08-21 21:28:37 +01:00
Kevin Ansfield
045e5054a0 Fixes for sign-in error handling
issue #5652, closes #5641
- removes inline errors for empty fields
- separate validation routines for sign-in and forgot password
- highlight fields with errors when trying to submit
2015-08-21 19:38:44 +01:00
Robert Jackson
873f19697d Move myth configuration into Brocfile.js. 2015-08-21 14:37:50 -04:00
Kevin Ansfield
93179c1e6a Add inline error handling when creating/editing tag
closes #5684
- add inline error checking and display to tag name & meta data fields
- add tests for tags screen
2015-08-21 18:06:52 +01:00
Robert Jackson
4955dc104e Merge core/built instead of clearing on every build. 2015-08-21 12:17:39 -04:00
Robert Jackson
058328b2c5 Use ghost.min.css when building for production. 2015-08-21 12:16:21 -04:00
John O'Nolan
a319f349bb Merge pull request #5700 from kevinansfield/inline-error-styles
Style inline-error fields and response test
2015-08-21 16:55:48 +02:00
John O'Nolan
16d7a86810 Merge pull request #5698 from kevinansfield/fix-autonav-flicker-v2
Fix flickering autonav animation
2015-08-21 15:29:05 +02:00
John O'Nolan
659999b5aa Merge pull request #5697 from Gargol/a11y-improvement-for-menu-toggle
Adds 'button' role to toggle menu icon for better a11y
2015-08-21 10:23:43 +02:00
Kevin Ansfield
3dd612a4ee Style inline-error fields and response test
issue #5652
- highlight input border and response text in red
2015-08-20 17:04:37 +01:00
Kevin Ansfield
a6910de08a Mobile nav menu fixes
issue #5483 & #5652
- trigger the close menus action every time a route transition is successful
- close nav menu when clicking "collapse sidebar" button (action chain was incomplete)
2015-08-20 16:49:33 +01:00
Sebastian Gierlinger
a00cbf0f61 Merge pull request #5689 from kevinansfield/fix-property-val-of-undefined
Fix occasional `Cannot read property 'val' of undefined` errors in console
2015-08-20 16:53:47 +02:00
Kevin Ansfield
3efdfdf79f Replace the current tag input with a selectize based input
issue #3800, closes #5648
- uses ember-cli-selectize addon for the tag editing functionality in the PSM
2015-08-20 14:40:56 +01:00
Kevin Ansfield
3d3c6f8bbe Fix flickering autonav animation
- use `transition: left` instead of `transform: translate3d`
- fixes issue where translate3d moves the element immediately then animates resulting in invisible hit areas that cause unexpected hover behaviour whilst animation is in progress
- translate3d is sometimes faster as it doesn't need to constantly re-calculate layout, however in this case the element is positon:absolute and we're only animating opaque elements so the benefit is marginal. Tested on Late-2012 13" retina MBP and framerate was consistently 100fps or higher.
2015-08-20 13:04:26 +01:00
Nazar Gargol
2aed13dfcf Adds 'button' role to toggle icon for better a11y
closes #5696
- adds button role to toggle icon on new zelda menu
2015-08-20 12:51:44 +02:00
Kevin Ansfield
bc6d31701c Minor UI fixes for invitations
issue #5652
- display "Sending Invite..." text after clicking "RESEND" link
- change "Invitation sent" alert to notification
2015-08-20 10:36:36 +01:00
Austin Burdine
a7ed98cc3e fix auto width and height of spin button component
refs #5652
- changes the spin-button so that it only sets the size when the button is submitting instead of all of the time
2015-08-19 23:39:07 -04:00
Kevin Ansfield
a889844188 guard against missing $previewContent/ViewPort in gh-editor.scrollPosition
issue #5659
- fixes occasional issue with editor not rendering due to scrollPosition being requested before the relevant jquery elements have been set
2015-08-19 20:44:59 +01:00
Kevin Ansfield
b74b30ef99 guard against missing editor element in editor-base-controller.save
issue #5659
- Fixes occasional issue with `Uncaught TypeError: Cannot read property 'val' of undefined` errors appearing when navigating quickly to/from the editor. I traced the `save` action calls back to the `autoSave` method - it may warrant further investigation to find out why the throttled/debounced calls are sometimes made when the editor element is non-existent.
2015-08-19 20:43:30 +01:00
Kevin Ansfield
ae695a3e8e Update admin area jquery and jquery-ui dependencies
no issue
- updates jquery from 1.9.x to 2.1.x, dropping support for old IE
- updates jquery-ui from 1.10.4 to 1.11.4
2015-08-19 09:37:02 +01:00
Sebastian Gierlinger
d484c1363b Merge pull request #5672 from jomahoney/signup-image
Update signup form to have profile image upload component
2015-08-16 18:49:13 +02:00
John O'Mahoney
dbeea0f9bd Update signup form to have profile image upload component
closes #5544
- Added profile image into `signup.hbs`
- Added image handling in `signup.js` controller
- Uses session authenticated user to upload image
2015-08-15 13:00:42 +01:00
Jason Williams
76f3ed49a0 Update ember-myth
- ember-myth@0.1.1. Removes console.log debug output.
2015-08-14 22:35:26 -05:00
John O'Nolan
8dd69ddaef Variety of style fixes
- Modal button position tweaked, removed extraneous margin
- Fix user profile full name field and mobile profile-picture
- Added chevron to tag settings men, corrected chevron colour
- Fixed regression in delete-tag button caused by removing flexbox from buttons
- Fixed regression in button positioning on about-ghost page caused by removing flexbox from buttons

See #5652
2015-08-13 10:04:45 +02:00
John O'Nolan
495536fbe3 Fixed publish menu positioning, cleaned up dropdown component
See #5652
2015-08-13 09:09:07 +02:00
John O'Nolan
0c2e6b617c Kill old tag styles 2015-08-13 08:55:41 +02:00
John O'Nolan
eb08826f3e Multiple minor visual style fixes
- Lighter dropdown shadow
- Removed display:flex from .btn because safari can't handle it on <button> elements, where it will immediately set all text-alignment to "left" with no way to change. I haven't been able to find any regressions for this change so far. Can't remember why buttons were supposed to be flexbox anyway. Maybe for icon alignment within buttons, but I can't find any such examples within the app.
- Safari thinks that user-select: all; means a single click should SELECT ALL THE THINGS. Removed/replaced with user-select: text; which makes it behave like Chrome; click and drag to select.
- Increased hit area for "?" button
- Removed :active style for post-edit button on content management screen, adjusted position
- Increased contrast on tag description, tag count, and view blog links

See #5652
2015-08-12 10:29:40 +02:00
John O'Nolan
411df4dbb1 Prevent view titles from being cut off in Safari
See #5652
2015-08-12 09:17:01 +02:00
Hannah Wolfe
6ac7f09043 Merge pull request #5658 from acburdine/tag-fixes
fixed focus and duplication tag issues
2015-08-11 19:42:52 +01:00
Hannah Wolfe
8e76da83b5 Merge pull request #5654 from cobbspur/bugfixes
Lock out email address on signup page
2015-08-11 18:06:12 +01:00
Austin Burdine
96c5d2a2de fixed focus and duplication tag issues
refs #5648
- adds default value to refocus in reloadTypeahead method to fix focus issues
- moves tag input clearing call up to avoid duplication.
2015-08-11 11:04:53 -06:00
cobbspur
e8024c9789 Fix spinner on settings page
refs #5652

- stops spinner from spinning forever on settings screen when saving
2015-08-11 15:26:24 +01:00
cobbspur
04130cf8c1 Lock out email address on signup page
refs #5653

- disables email field
- pull error message from api response
2015-08-11 14:25:30 +01:00
cobbspur
27122091b5 Fix errors for setup and signup
refs #5635

- adds enter action to signup fields
- adds validation text errors
2015-08-10 22:24:10 +01:00
Hannah Wolfe
c174dd27ce Merge pull request #5633 from acburdine/spin-buttons
Add spin buttons
2015-08-10 19:06:32 +01:00
Austin Burdine
2833675238 add spin-button component & implement it
closes #3928
- adds spin-button component & styles
- implements spin-button in places where buttons trigger async tasks
2015-08-10 09:43:50 -06:00
Austin Burdine
16d0965a9e reimplement tag editing component for posts
refs #3800
- remove old tag editor code
- reimplement tag editor as an ember component
- add tag editor component to PSM
2015-08-10 07:22:37 -06:00
Hannah Wolfe
0269f49358 Merge pull request #5640 from cobbspur/errors
Fix server errors for signin
2015-08-10 13:20:53 +01:00
Hannah Wolfe
c2a8d5254c Merge pull request #5634 from acburdine/onboard-fixes
Fixes in setup/three
2015-08-10 13:17:28 +01:00
cobbspur
c6531b491f Fix signin errors
refs #5635

- fixes format for server errors
- changes signin-api validation errors to be text rather than alerts
2015-08-10 12:26:45 +01:00
Austin Burdine
256722a9d3 setup/three fixes
refs #5315
- adds call to loadServerNotifications so that notifications are loaded after setup
- fixes user invite so that you can't invite someone with the same email as you created the owner with
2015-08-09 22:40:27 -06:00
cobbspur
13f9fd9cb0 Fix signup bug
No Issue

- fixes bug that prevents successful signup from invite
2015-08-08 16:04:28 +01:00
cobbspur
5b19463445 Enter key submits form in setup step 2
Issue #5315

 - adds gh-input enter event to trigger setup action
 - removes html for unused password strength hint
2015-08-04 09:36:02 +01:00
Kevin Ansfield
61e5ebdd2f WIP: review uses of notifications.showErrors
issue #5409

`notifications.showErrors` was historically used to display multiple error notifications whether from validation errors or responses form the API. This usage needs to be reviewed as inline validations should handle the validation side and we should be displaying alerts for actual errors.

Eventually `notifications.showErrors` should be left unused and therefore removed.
2015-07-28 12:27:57 +01:00
Kevin Ansfield
7ab232e770 Replace validation notifications with inline validations
issue #5409 & #5336

- update settings/general
- update signin
- update signup
- update edit user
- update reset password
- update setup/three
- remove `formatErrors` function from validationEngine mixin (it's no longer needed as inline validations should handle this instead)
2015-07-28 12:26:34 +01:00
Kevin Ansfield
ee89b11a6a Refactor notifications service & components
issue #5409

- change persistent/passive notification status to alert/notification
- replace showSuccess/Info/Warn/Error with showNotification/showAlert
- fix and clean up notification/alert components
2015-07-28 12:26:11 +01:00
Jason Williams
fd74180c16 Merge pull request #5565 from acburdine/profile-debounce
Refactor setup controller to only pass valid email into profile image component
2015-07-22 09:53:30 -05:00
Jason Williams
58bf77ac3a Merge pull request #5596 from kevinansfield/fix-missing-code-injection-auth-redirect
Fix missing redirect on settings/code-injection when not authenticated
2015-07-22 09:51:28 -05:00
Kevin Ansfield
ac2ae5a788 Fix missing redirect on settings/code-injection when not authenticated
related issue #5412
- code-injection route was overriding `beforeModel` without calling `super` which meant the redirect handling added in `AuthenticatedRoute` was being skipped
2015-07-22 11:31:42 +01:00
Austin Burdine
cd99a2bd29 fix setup controller to pass in only a valid email to the profile-image component
closes #5563
2015-07-21 13:19:09 -04:00
cobbspur
f2d5c5fc26 User Onboarding - flow navigation
closes #5317

- Adds back button to steps 2 and 3
- Prevents user navigating from step 1 to step 3 unless blog has been created
- Prevents user navigating from step 2 to step 3 unless blog has been created
2015-07-21 17:23:04 +01:00
Hannah Wolfe
6fc2b37ab2 Merge pull request #5575 from cobbspur/imageComponent
Disable image upload during setup for non persistent file storage
2015-07-19 23:23:08 +01:00
cobbspur
def08d7939 Disable image upload during setup for non persistent file storage
closes #5550

- passes config.fileStorage into gh-profile-image component
- does not render input tag if fileStorage is set to false
2015-07-18 20:26:27 +01:00
Jason Williams
00ede73105 Use correct property when determining display URL
Closes #5574
2015-07-17 10:23:29 -05:00
John O'Nolan
0659300a23 Merge pull request #5542 from BlueHatbRit/reset-pass-page-style-fix
Correct reset passsword screen markup and styles
2015-07-15 16:56:14 +03:00
John O'Nolan
669d7bdc43 Merge pull request #5555 from halfdan/fix/invite
Fix team/index screen
2015-07-15 16:54:07 +03:00
Rem Zolotykh
c1bf1aedd0 Allow editing blog details on setup
closes #5526
- when user creates blog we set `blogCreated` flag to true and
  depending on it make `POST` or `PUT` request
2015-07-15 03:17:55 +02:00
BlueHatbRit
b37fdda299 Correct reset passsword screen markup
closes #5524
- changed markup to reflect styles of the sign in screen.
- remove html classes that are redundant.
2015-07-14 20:15:00 +01:00
Fabian Becker
37235413e8 Fix team/index screen
- Incorrect message was shown (Invitation sent instead of Invitation not sent)
- Correct colouring of message (new .description-error class)
- Correctly display lastLogin time
- Add colour classes
2015-07-14 18:21:08 +02:00
Hannah Wolfe
ed0b726665 Merge pull request #5534 from Remchi/bug-invite-user
Invited user can sign up successfully
2015-07-13 22:10:16 +01:00
Hannah Wolfe
a59b7183e1 Merge pull request #5546 from acburdine/title-fix-2
Fix blog title not updating after setup
2015-07-12 21:20:45 +01:00
Austin Burdine
97118e61bd fixed some validation bugs
refs #5520
- all errors (or just one if property is specified) are cleared before running the checks to make sure that old errors get cleared
- fixed up validators to be slightly more sane as mutually exclusive tests aren't all being checked if one fails
2015-07-11 13:04:19 -04:00
Austin Burdine
5579d41fcb fix title of blog not updating after setup
closes #5545
- updates config with new blogTitle after setup is finished
2015-07-11 12:34:54 -04:00
Hannah Wolfe
591467c47b Merge pull request #5531 from acburdine/profile-fixes
Fixes the profile image uploader component
2015-07-11 13:17:48 +01:00
Hannah Wolfe
2cbf7aa9df Merge pull request #5517 from jaswilli/issue-5383
Focus on editor if transitioning from new post
2015-07-11 12:39:56 +01:00
Rem Zolotykh
c6bcefe6ae Invited user can sign up successfully
issue #5525
- add `DS.Errors` to `signup` model
- add check for errors: run `showErrors` method only if errors are defined, like in `signin` controller
2015-07-10 23:20:00 +02:00
Jason Williams
a7a5fe8cd3 Refactor role selects; pause transition if saving
Refs #5501
- Switch role select dropdowns from gh-select based components to
  gh-select-native.
- Prevent transition out of editor while there is an in-flight save.
2015-07-09 12:10:00 -05:00
Jason Williams
d8b49e6092 Rework gh-activating-list-item for new link-to 2015-07-08 18:37:15 -05:00
Austin Burdine
1b2e6ef78f profile image component fixes
closes #5528
- adds empty email message to setup validation
- fixes uploads so they actually work
- fixes gravatar to not disappear when an invalid file is selected
2015-07-07 17:13:45 -04:00
Hannah Wolfe
e807379ee3 Merge pull request #5355 from acburdine/onboard-profile
Add profile image upload component
2015-07-07 17:23:58 +01:00
Hannah Wolfe
8f8c5bb340 Merge pull request #5453 from cobbspur/teampermissions
Change permissions for team area
2015-07-06 20:54:29 +01:00
John O'Nolan
841a071cee Merge pull request #5507 from lukaszklis/colour-fixes
Removed left overs from SASS to Myth conversion
2015-07-06 19:26:04 +03:00
Austin Burdine
39b7630a6d added profile image component
closes #5334
- adds component for profile images (with optional gravatar)
- integrates image profile component into setup form
2015-07-05 17:37:22 -04:00
Hannah Wolfe
a6cf84b060 Merge pull request #5514 from halfdan/fix/5436
Reload user after import
2015-07-05 20:51:39 +01:00
Hannah Wolfe
1568cf01fb Merge pull request #5399 from acburdine/inline-errors
Add inline errors
2015-07-05 20:36:27 +01:00
Austin Burdine
b1ecc53cfc adds inline errors to validation
closes #5336
- creates gh-form-group component to handle form group status
- refactors current validation methods to work on a per-property basis
- adds gh-error-message component to render error message
- removes (comments out) tests that pertain to the old notifications until the new inline validation is added
2015-07-05 14:02:06 -04:00
Jason Williams
b7be8b8cfc Focus on editor if transitioning from new post
Closes #5383
2015-07-04 13:59:09 -05:00
cobbspur
acb1cc6283 Change permissions for team area
closes #5434

- remove transition away from team page to user page of authors
- hide invite button from authors
- hide invited users from authors
- adjusted gh-user-can and renamed to gh-user-can-admin
- hide password reset on owners profile from administrators
- hide input field for owner email from administrators pending api fix
- fix up tests
2015-07-03 20:06:45 +01:00
Fabian Becker
776826f576 Reload user after import
fixes #5436
2015-07-03 13:27:36 +02:00
Łukasz Kliś
8050e06fda Removed lighten left over from SASS to Myth conversion
Refs #5314
- replaced SASS's `lighten` with Myth's `color(x lightness())`
2015-07-03 07:46:38 +02:00
Łukasz Kliś
8bc8dc0532 Added multiline "placeholder" to 3rd step of setup
Closes #5459
- added a PNG background with 2 emails addresses as a "placeholder"
- added a `required` attribute for textarea in 3rd step of the setup
- taking an advantage of `:valid` pseudo-class to hide the background
  picture with email addresses
2015-07-01 23:14:27 +02:00