Hannah Wolfe
829e8ed010
Expanded requires of lib/common i18n and events
...
- Having these as destructured from the same package is hindering refactoring now
- Events should really only ever be used server-side
- i18n should be a shared module for now so it can be used everywhere until we figure out something better
- Having them seperate also allows us to lint them properly
2021-05-03 17:14:52 +01:00
Thibaut Patel
375c71fc6a
🔒 Added a way to hide the secret settings once they are set
...
issue https://github.com/TryGhost/Team/issues/621
2021-04-16 17:05:16 +02:00
Fabien O'Carroll
8880cc82c7
Refactored usage of the pre v4 "slack" setting
...
refs https://github.com/TryGhost/Ghost/issues/10318
- Change/compatibility table for this changeset:
Importer
+ "slack_username" import
- "slack_url" ignore
+ "slack.username" import
- "slack.url" ignore
v3 & canary/v4 Admin APIs
GET /settings/ (browse)
+ "slack_username" present in response
+ "slack_url" present in response
+ "slack" present in response
GET /settings/:settingName (read)
+ "slack_username" present in response
+ "slack_url" present in response
+ "slack" present in response
PUT /settings/ (edit)
+ "slack_username" updates setting
+ "slack_url" updates setting
+ "slack" !NOTE! updates setting unless "slack_username" or "slack_ur"l are set (updated keys take priority)
v2 Admin API
GET /settings/ (browse)
- "slack_username" NOT present in response
- "slack_url" NOT present in response
+ "slack" present in response
GET /settings/:settingName (read)
- "slack_username" ignored (404)
- "slack_url" ignored (404)
- "slack" present in response
PUT /settings/ (edit)
- "slack_username" ignored (no error)
- "slack_url" ignored (no error)
+ "slack" updates setting
2021-02-15 15:25:54 +13:00
Thibaut Patel
af9c5fd2f1
💡 Split the v3 endpoint from the canary endpoint
...
refs https://github.com/TryGhost/Team/issues/221
2021-01-22 16:32:03 +13:00
