Commit Graph

2243 Commits

Author SHA1 Message Date
Kevin Ansfield
61e5ebdd2f WIP: review uses of notifications.showErrors
issue #5409

`notifications.showErrors` was historically used to display multiple error notifications whether from validation errors or responses form the API. This usage needs to be reviewed as inline validations should handle the validation side and we should be displaying alerts for actual errors.

Eventually `notifications.showErrors` should be left unused and therefore removed.
2015-07-28 12:27:57 +01:00
Kevin Ansfield
7ab232e770 Replace validation notifications with inline validations
issue #5409 & #5336

- update settings/general
- update signin
- update signup
- update edit user
- update reset password
- update setup/three
- remove `formatErrors` function from validationEngine mixin (it's no longer needed as inline validations should handle this instead)
2015-07-28 12:26:34 +01:00
Kevin Ansfield
ee89b11a6a Refactor notifications service & components
issue #5409

- change persistent/passive notification status to alert/notification
- replace showSuccess/Info/Warn/Error with showNotification/showAlert
- fix and clean up notification/alert components
2015-07-28 12:26:11 +01:00
Jason Williams
fd74180c16 Merge pull request #5565 from acburdine/profile-debounce
Refactor setup controller to only pass valid email into profile image component
2015-07-22 09:53:30 -05:00
Jason Williams
58bf77ac3a Merge pull request #5596 from kevinansfield/fix-missing-code-injection-auth-redirect
Fix missing redirect on settings/code-injection when not authenticated
2015-07-22 09:51:28 -05:00
Kevin Ansfield
ac2ae5a788 Fix missing redirect on settings/code-injection when not authenticated
related issue #5412
- code-injection route was overriding `beforeModel` without calling `super` which meant the redirect handling added in `AuthenticatedRoute` was being skipped
2015-07-22 11:31:42 +01:00
Austin Burdine
cd99a2bd29 fix setup controller to pass in only a valid email to the profile-image component
closes #5563
2015-07-21 13:19:09 -04:00
cobbspur
f2d5c5fc26 User Onboarding - flow navigation
closes #5317

- Adds back button to steps 2 and 3
- Prevents user navigating from step 1 to step 3 unless blog has been created
- Prevents user navigating from step 2 to step 3 unless blog has been created
2015-07-21 17:23:04 +01:00
Hannah Wolfe
6fc2b37ab2 Merge pull request #5575 from cobbspur/imageComponent
Disable image upload during setup for non persistent file storage
2015-07-19 23:23:08 +01:00
cobbspur
def08d7939 Disable image upload during setup for non persistent file storage
closes #5550

- passes config.fileStorage into gh-profile-image component
- does not render input tag if fileStorage is set to false
2015-07-18 20:26:27 +01:00
Jason Williams
00ede73105 Use correct property when determining display URL
Closes #5574
2015-07-17 10:23:29 -05:00
John O'Nolan
0659300a23 Merge pull request #5542 from BlueHatbRit/reset-pass-page-style-fix
Correct reset passsword screen markup and styles
2015-07-15 16:56:14 +03:00
John O'Nolan
669d7bdc43 Merge pull request #5555 from halfdan/fix/invite
Fix team/index screen
2015-07-15 16:54:07 +03:00
Rem Zolotykh
c1bf1aedd0 Allow editing blog details on setup
closes #5526
- when user creates blog we set `blogCreated` flag to true and
  depending on it make `POST` or `PUT` request
2015-07-15 03:17:55 +02:00
BlueHatbRit
b37fdda299 Correct reset passsword screen markup
closes #5524
- changed markup to reflect styles of the sign in screen.
- remove html classes that are redundant.
2015-07-14 20:15:00 +01:00
Fabian Becker
37235413e8 Fix team/index screen
- Incorrect message was shown (Invitation sent instead of Invitation not sent)
- Correct colouring of message (new .description-error class)
- Correctly display lastLogin time
- Add colour classes
2015-07-14 18:21:08 +02:00
Hannah Wolfe
ed0b726665 Merge pull request #5534 from Remchi/bug-invite-user
Invited user can sign up successfully
2015-07-13 22:10:16 +01:00
Hannah Wolfe
a59b7183e1 Merge pull request #5546 from acburdine/title-fix-2
Fix blog title not updating after setup
2015-07-12 21:20:45 +01:00
Austin Burdine
97118e61bd fixed some validation bugs
refs #5520
- all errors (or just one if property is specified) are cleared before running the checks to make sure that old errors get cleared
- fixed up validators to be slightly more sane as mutually exclusive tests aren't all being checked if one fails
2015-07-11 13:04:19 -04:00
Austin Burdine
5579d41fcb fix title of blog not updating after setup
closes #5545
- updates config with new blogTitle after setup is finished
2015-07-11 12:34:54 -04:00
Hannah Wolfe
591467c47b Merge pull request #5531 from acburdine/profile-fixes
Fixes the profile image uploader component
2015-07-11 13:17:48 +01:00
Hannah Wolfe
2cbf7aa9df Merge pull request #5517 from jaswilli/issue-5383
Focus on editor if transitioning from new post
2015-07-11 12:39:56 +01:00
Rem Zolotykh
c6bcefe6ae Invited user can sign up successfully
issue #5525
- add `DS.Errors` to `signup` model
- add check for errors: run `showErrors` method only if errors are defined, like in `signin` controller
2015-07-10 23:20:00 +02:00
Jason Williams
a7a5fe8cd3 Refactor role selects; pause transition if saving
Refs #5501
- Switch role select dropdowns from gh-select based components to
  gh-select-native.
- Prevent transition out of editor while there is an in-flight save.
2015-07-09 12:10:00 -05:00
Jason Williams
d8b49e6092 Rework gh-activating-list-item for new link-to 2015-07-08 18:37:15 -05:00
Austin Burdine
1b2e6ef78f profile image component fixes
closes #5528
- adds empty email message to setup validation
- fixes uploads so they actually work
- fixes gravatar to not disappear when an invalid file is selected
2015-07-07 17:13:45 -04:00
Hannah Wolfe
e807379ee3 Merge pull request #5355 from acburdine/onboard-profile
Add profile image upload component
2015-07-07 17:23:58 +01:00
Hannah Wolfe
8f8c5bb340 Merge pull request #5453 from cobbspur/teampermissions
Change permissions for team area
2015-07-06 20:54:29 +01:00
John O'Nolan
841a071cee Merge pull request #5507 from lukaszklis/colour-fixes
Removed left overs from SASS to Myth conversion
2015-07-06 19:26:04 +03:00
Austin Burdine
39b7630a6d added profile image component
closes #5334
- adds component for profile images (with optional gravatar)
- integrates image profile component into setup form
2015-07-05 17:37:22 -04:00
Hannah Wolfe
a6cf84b060 Merge pull request #5514 from halfdan/fix/5436
Reload user after import
2015-07-05 20:51:39 +01:00
Hannah Wolfe
1568cf01fb Merge pull request #5399 from acburdine/inline-errors
Add inline errors
2015-07-05 20:36:27 +01:00
Austin Burdine
b1ecc53cfc adds inline errors to validation
closes #5336
- creates gh-form-group component to handle form group status
- refactors current validation methods to work on a per-property basis
- adds gh-error-message component to render error message
- removes (comments out) tests that pertain to the old notifications until the new inline validation is added
2015-07-05 14:02:06 -04:00
Jason Williams
b7be8b8cfc Focus on editor if transitioning from new post
Closes #5383
2015-07-04 13:59:09 -05:00
cobbspur
acb1cc6283 Change permissions for team area
closes #5434

- remove transition away from team page to user page of authors
- hide invite button from authors
- hide invited users from authors
- adjusted gh-user-can and renamed to gh-user-can-admin
- hide password reset on owners profile from administrators
- hide input field for owner email from administrators pending api fix
- fix up tests
2015-07-03 20:06:45 +01:00
Fabian Becker
776826f576 Reload user after import
fixes #5436
2015-07-03 13:27:36 +02:00
Łukasz Kliś
8050e06fda Removed lighten left over from SASS to Myth conversion
Refs #5314
- replaced SASS's `lighten` with Myth's `color(x lightness())`
2015-07-03 07:46:38 +02:00
Łukasz Kliś
8bc8dc0532 Added multiline "placeholder" to 3rd step of setup
Closes #5459
- added a PNG background with 2 emails addresses as a "placeholder"
- added a `required` attribute for textarea in 3rd step of the setup
- taking an advantage of `:valid` pseudo-class to hide the background
  picture with email addresses
2015-07-01 23:14:27 +02:00
Hannah Wolfe
16a8c8220a Merge pull request #5477 from acburdine/title-fix
Fix blog title in nav menu not updating
2015-06-26 20:13:27 +01:00
Hannah Wolfe
c0570db675 Merge pull request #5484 from JohnONolan/O
Fix mobile display bugs on user list
2015-06-26 13:11:40 +01:00
John O'Nolan
e912bc0cde Fix mobile display bugs on user list
See #5483
2015-06-24 19:53:01 +01:00
Jason Williams
feac9682d0 Update Ember to 1.13.2
- Refactor to handle deprecations including removal of
  all Views, ArrayControllers, and ItemControllers.
2015-06-24 11:47:28 -05:00
John O'Nolan
4b5fc201a2 Main colour audit
Clean up grey colours by mixing in slightly more blue, standardise appearance across different parts of the app and move closer to brand  colours.
2015-06-24 13:37:37 +01:00
John O'Nolan
f57c0c672a Firefucks
Firefox can't do flexbox, because why would a modern browser be able to do flexbox? Cray.
Closes #5438, Closes #5401 - same fix but vh unit because % unit is hella unreliable.
2015-06-24 12:17:49 +01:00
John O'Nolan
38a5797211 Fight fire with overflow.
Prevents firefox from allowing blog title to overflow. This is an incredibly stupid fix for an incredibly stupid browser bug. Firefox is the worst modern browser in the world at basic layout rendering. Could someone let them know please? Closes #5430 as replacement.
2015-06-24 12:16:58 +01:00
John O'Nolan
061f3171ee First pass colour audit
This gets rid of old and un-used, or lesser-used colour variables.
2015-06-24 12:15:48 +01:00
Austin Burdine
816a02bbc7 fix blog title not updating in nav menu
closes #5474
- sets the blogTitle property of config when the title setting is changed
2015-06-23 14:15:36 -04:00
cobbspur
029e79b494 Take Trashcan off of url screen for image uploader
closes #5433
- add gh-input class to inputs
- stop the incorrect addition of trash can on url page
- fix trigger of upload success to show loading in editor
- fix duplicate url field for images outside of editor when there is no file storage
2015-06-23 13:14:04 +01:00
Jason Williams
40a176c772 Fix up editor/preview scroll and post list loading
Refs #5381
- Invoke this._super() so mixed in lifecycle hooks run.
2015-06-22 11:35:17 -05:00
Hannah Wolfe
dc5fd0f3e7 Merge pull request #5455 from jomahoney/grunt-failure
Removes whitespace issue that was preventing grunt init from working
2015-06-20 23:54:46 +01:00