TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-28 05:14:12 +03:00
Code Issues Projects Releases Wiki Activity
28,963 Commits 250 Branches 1,686 Tags 400 MiB
713635b49f
Commit Graph

66 Commits

Author SHA1 Message Date
Simon Backx
82a3133ace
Added replies/likes count and limited replies to comments (#15206) 
refs https://github.com/TryGhost/Team/issues/1723

- Added count.replies to comments
- Added replies endpoint
- Limited returned replies to 3.
- Replaced likes_count with count.likes in comments
- Instead of fetching all the likes of a comment to determine the total count, we'll now use count.likes
- Instead of fetching all the likes of a comment to determine whether a member liked a comment, we'll now use count.liked (which returns the amount of likes of the current member, being 0 or 1). This is mapped to `liked` to make it more natural to work with.

The `members.test.snap` file changed because we no longer include `liked: false` if we didn't fetch the liked relation. And in the comments events of the activity feed the liked property is therefore removed.

These changes requires an update to the `bookshelf-include-count` plugin:
- Updated to also work for nested relations
- This moves the count queries from the `bookshelf-include-count` plugin to the `countRelations` method of each model.
- Updated to keep the counts after saving a model (crud.edit didn't return the counts before)
 2022-08-10 16:12:35 +02:00
Daniel Lockyer
a9cffd9550
Pinned all dependencies 
- we should pin all dependencies so we know what is getting shipped in
  the application
 2022-07-27 08:44:50 +02:00
renovate[bot]
679634342a
Pinned dependencies (#15100) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2022-07-26 16:06:00 +02:00
Daniel Lockyer
b72c4482dc
Added c8 to update-check-service 
- this must have been missed off when the package was first created,
  but is now required so we can track code coverage
 2022-07-26 15:36:07 +02:00
Daniel Lockyer
08abfcafd1
Remove linting as posttest step 
- linting is handled separately (in CI and locally, as it's a git
  pre-push hook) so we shouldn't also be running it after tests
 2022-07-26 15:26:21 +02:00
Daniel Lockyer
0a5f600dfe
Tidied up package README and LICENSE files 
- we shouldn't need individual LICENSE files because these packages
  won't be published, so the top-level one applies
- also cleaned up README files to remove mentions of Lerna monorepos and
  install instructions
 2022-07-26 15:22:10 +02:00
Daniel Lockyer
255eb0726b
Cleaned up package metadata 
refs https://github.com/TryGhost/Toolbox/issues/354

- set packages to `private: true`
- removed repository link - these packages won't be published so this
  link won't be seen anywhere
- removed `publishConfig`
 2022-07-26 15:08:05 +02:00
Daniel Lockyer
5fc7ba59d3
Reset package versions back to 0.0.0 
refs https://github.com/TryGhost/Toolbox/issues/354

- these packages won't be published from now on, so setting the versions
  back to 0.0.0 keeps them clean
 2022-07-26 14:57:43 +02:00
Naz
c5b8d073d7 Published new versions 
- @tryghost/adapter-manager@0.2.31
 - @tryghost/api-version-compatibility-service@0.3.0
 - @tryghost/bootstrap-socket@0.2.20
 - @tryghost/config-url-helpers@0.1.8
 - @tryghost/constants@1.0.5
 - @tryghost/database-info@0.3.5
 - @tryghost/email-content-generator@0.1.2
 - @tryghost/image-transform@1.0.32
 - @tryghost/job-manager@0.8.24
 - @tryghost/limit-service@1.1.3
 - @tryghost/minifier@0.1.15
 - @tryghost/moleculer-service-from-class@0.2.26
 - @tryghost/mw-api-version-mismatch@0.1.4
 - @tryghost/mw-error-handler@1.0.1
 - @tryghost/mw-session-from-token@0.1.32
 - @tryghost/mw-update-user-last-seen@0.1.6
 - @tryghost/package-json@1.0.21
 - @tryghost/pretty-cli@1.2.27
 - @tryghost/promise@0.1.18
 - @tryghost/release-utils@0.7.15
 - @tryghost/security@0.3.1
 - @tryghost/session-service@0.1.42
 - @tryghost/settings-path-manager@0.1.7
 - @tryghost/update-check-service@0.3.4
 - @tryghost/version-notifications-data-service@0.1.2
 - @tryghost/zip@1.1.25
 2022-05-09 18:25:48 +08:00
Renovate Bot
82b83743a7 Update dependency sinon to v14 2022-05-09 00:14:50 +00:00
Naz
e5d097fbae Published new versions 
- @tryghost/adapter-manager@0.2.30
 - @tryghost/api-version-compatibility-service@0.1.2
 - @tryghost/bootstrap-socket@0.2.19
 - @tryghost/config-url-helpers@0.1.7
 - @tryghost/constants@1.0.4
 - @tryghost/database-info@0.3.4
 - @tryghost/email-content-generator@0.1.0
 - @tryghost/image-transform@1.0.31
 - @tryghost/job-manager@0.8.23
 - @tryghost/limit-service@1.1.1
 - @tryghost/minifier@0.1.14
 - @tryghost/moleculer-service-from-class@0.2.25
 - @tryghost/mw-api-version-mismatch@0.1.2
 - @tryghost/mw-error-handler@0.2.3
 - @tryghost/mw-session-from-token@0.1.31
 - @tryghost/mw-update-user-last-seen@0.1.5
 - @tryghost/package-json@1.0.20
 - @tryghost/pretty-cli@1.2.26
 - @tryghost/promise@0.1.17
 - @tryghost/release-utils@0.7.14
 - @tryghost/security@0.2.17
 - @tryghost/session-service@0.1.41
 - @tryghost/settings-path-manager@0.1.6
 - @tryghost/update-check-service@0.3.3
 - @tryghost/version-notifications-data-service@0.1.1
 - @tryghost/vhost-middleware@1.0.25
 - @tryghost/zip@1.1.24
 2022-05-04 17:21:51 +08:00
Renovate Bot
6f93c82c5a Update Test & linting packages 2022-05-02 14:01:35 +00:00
Renovate Bot
9589755925 Update Test & linting packages 2022-05-02 13:58:34 +00:00
Daniel Lockyer
14a087536f Published new versions 
- @tryghost/minifier@0.1.12
 - @tryghost/mw-error-handler@0.1.7
 - @tryghost/update-check-service@0.3.2
 - @tryghost/zip@1.1.21
 2022-03-24 11:02:25 +00:00
Renovate Bot
6a805a436d Update dependency @tryghost/errors to v1 2022-03-24 10:39:08 +00:00
Daniel Lockyer
cfb1ded0d0 Published new versions 
- @tryghost/job-manager@0.8.19
 - @tryghost/release-utils@0.7.11
 - @tryghost/update-check-service@0.3.1
 - @tryghost/vhost-middleware@1.0.21
 2022-02-04 14:27:23 +01:00
Daniel Lockyer
636d884322 Moved @tryghost/update-check-service from Core monorepo 
no issue

- this packages belongs in here and means we can archive the Core repo
  once complete
 2022-01-20 15:25:00 +00:00
Renovate Bot
d9ebfa3a37 Update Test & linting packages 2022-01-20 15:18:35 +00:00
John O'Nolan
fd9bbf906e 2022 2022-01-06 10:17:41 +00:00
Sam Lord
4d4847144f Published new versions 
- @tryghost/update-check-service@0.3.0
 2021-12-07 10:49:05 +00:00
Sam Lord
d407fd1325 @tryghost/update-check-service: Don't allow logging to be passed in to constructor 
refs: https://github.com/TryGhost/Toolbox/issues/146
 2021-12-07 10:48:01 +00:00
renovate[bot]
feabbc2fca Update dependency @tryghost/logging to v2 (#63) 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
 2021-12-06 12:58:06 +00:00
Daniel Lockyer
836a3f433b Published new versions 
- @tryghost/update-check-service@0.2.5
 2021-10-28 14:59:07 +01:00
Renovate Bot
6c6133c35b Update dependency @tryghost/logging to v1 2021-10-28 14:58:35 +01:00
Daniel Lockyer
1ba35ed0e6 Published new versions 
- @tryghost/maintenance@0.1.6
 - @tryghost/update-check-service@0.2.4
 2021-10-18 09:50:32 +02:00
Renovate Bot
f71eec2a60 Update dependency mocha to v9.1.3 2021-10-18 09:47:21 +02:00
Renovate Bot
c6f4e725ff Update dependency @tryghost/logging to ^0.2.0 2021-10-18 09:47:09 +02:00
Naz
455f2c060f Published new versions 
- @tryghost/maintenance@0.1.5
 - @tryghost/update-check-service@0.2.3
 2021-10-06 22:32:15 +02:00
Naz
20fc1649f4 Fixed alert notifications being sent out to non-active users 
refs https://linear.app/tryghost/issue/CORE-63/restrict-update-service-notifications-to-active-admins

- It only makes sense to notify active users about a notification of 'alert' or any other type really.
 2021-10-06 22:31:06 +02:00
Renovate Bot
b29f519857 Update dependency mocha to v9.1.2 2021-09-28 08:22:13 +00:00
Sam Lord
3b0a94cadb Published new versions 
- @tryghost/maintenance@0.1.4
 - @tryghost/update-check-service@0.2.2
 2021-09-22 15:38:26 +01:00
Sam Lord
ea88c86ccb Switched Ignition for @tryghost/debug & unpinned deps 
no issue

Unpinning dependencies to ensure deps stay up to date when used in Ghost. Removed Ignition because deprecated in favour of using @tryghost/debug
 2021-09-22 15:38:09 +01:00
Sam Lord
cce1c0fe67 Published new versions 
- @tryghost/maintenance@0.1.3
 - @tryghost/update-check-service@0.2.1
 2021-09-22 14:40:41 +01:00
Sam Lord
70f7dd500c Update @tryghost/logging in update-check-service 
no issue

Prevents update check service from creating a separate logger. TODO: Ensure this is kept in sync with Ghost's version
 2021-09-22 14:40:00 +01:00
Renovate Bot
9725d5b3c0 Update dependency mocha to v9.1.1 2021-08-31 07:48:45 +00:00
Renovate Bot
d08cf7a8d4 Update dependency mocha to v9.1.0 2021-08-23 03:00:02 +00:00
Renovate Bot
c14ae3052e Update dependency sinon to v11.1.2 2021-07-28 14:22:50 +00:00
Renovate Bot
4b976d3e0c Update dependency mocha to v9.0.3 2021-07-27 04:02:33 +00:00
Renovate Bot
13a8b5386c Update Test & linting packages 2021-07-06 04:14:03 +00:00
Naz
c06fe94469 Published new versions 
- @tryghost/maintenance@0.1.2
 - @tryghost/update-check-service@0.2.0
 2021-07-02 18:56:12 +04:00
Naz
664b933bc8 Removed logging dependency from update check constructor 
refs https://github.com/TryGhost/Team/issues/727

- The latest code standards require using @tryghost/logging module instead of injecting it as a parameter in the construcotr
- Left it as an optional constructor parameter to make testing easier
 2021-07-02 18:54:50 +04:00
Naz
98a64ed0f8 Removed i18n dependency from update check constructor 
refs https://github.com/TryGhost/Team/issues/727

- The latest code standards require using tpl module in combination with local messages object instead of i18n  injected in the constructor
 2021-07-02 18:48:12 +04:00
Naz
7ea81dc50d Fixed uk -> us English wording 2021-06-24 17:44:09 +04:00
Renovate Bot
e77e20e6eb Update dependency mocha to v9 2021-06-23 17:01:28 +00:00
Naz
bc3ea7e12e Skipped notificaiton processing when no valid data 
refs https://github.com/TryGhost/Team/issues/754

- When there are no message objects coming from the external update check service in the response there is no need to continue to process the data and fire off unneeded queries
 2021-06-23 19:14:47 +04:00
Naz
65d863d74b Added debug calls 
refs https://github.com/TryGhost/Team/issues/754

- These debug messages are useful to see what kind of data came in and was processed by the update check
 2021-06-23 19:13:11 +04:00
Naz
b0af1f9ddb Switched configurations to use main instead of master 
no issue

- The repo was migrated to main branch as "main" and needed update in configs
 2021-06-23 19:04:16 +04:00
Naz
9e5fe475c8 Improved code safety in update check's check method 
refs https://github.com/TryGhost/Team/issues/754

- The api call can also generate an error which would bubble up to a client. This is not a good design if the client has to know to handle internal errors of the module
- By having try block wrap around whole block it makes the error handling behave the same way throughout the check process
 2021-06-23 18:57:45 +04:00
naz
d45ef018fe Added UpateCheckService usage example 2021-06-03 21:41:38 +12:00
Naz
74a949e38c Published new versions 
- @tryghost/maintenance@0.1.1
 - @tryghost/update-check-service@0.1.0
 2021-06-03 13:11:58 +04:00