Commit Graph

11086 Commits

Author SHA1 Message Date
Vikas Potluri
a9cb8adacc
Refactored tests to destructure common lib import (#11838) 2020-05-25 09:49:38 +01:00
Vikas Potluri
9254f94407
Refactored migrations to destructure common lib import (#11837) 2020-05-25 09:48:50 +01:00
Renovate Bot
a345db6e3d
Update dependency mocha to v7.2.0 2020-05-25 00:23:07 +00:00
Renovate Bot
caa1244492 Update dependency js-yaml to v3.14.0 2020-05-22 21:59:04 +01:00
Vikas Potluri
4ac88dce10
Refactored common lib import to use destructuring (#11835)
* refactored `core/frontend/apps` to destructure common imports
* refactored `core/frontend/services/{apps, redirects, routing}` to destructure common imports
* refactored `core/frontend/services/settings` to destructure common imports
* refactored remaining `core/frontend/services` to destructure common imports
* refactored `core/server/adapters` to destructure common imports
* refactored `core/server/data/{db, exporter, schema, validation}` to destructure common imports
* refactored `core/server/data/importer` to destructure common imports
* refactored `core/server/models/{base, plugins, relations}` to destructure common imports
* refactored remaining `core/server/models` to destructure common imports
* refactored `core/server/api/canary/utils/serializers/output` to destructure common imports
* refactored remaining `core/server/api/canary/utils` to destructure common imports
* refactored remaining `core/server/api/canary` to destructure common imports
* refactored `core/server/api/shared` to destructure common imports
* refactored `core/server/api/v2/utils` to destructure common imports
* refactored remaining `core/server/api/v2` to destructure common imports
* refactored `core/frontend/meta` to destructure common imports
* fixed some tests referencing `common.errors` instead of `@tryghost/errors`
   - Not all of them need to be updated; only updating the ones that are
causing failures
* fixed errors import being shadowed by local scope
2020-05-22 19:22:20 +01:00
Marco Zehe
3af9611778
🐛 Removed incorrect a11y roles from navigation template (#11833)
closes #11832.

- These hide the actual links from accessibility aids and are not appropriate to use in this context.
2020-05-22 18:19:35 +01:00
Rish
65656a9cf4 Removed global bodyParser middleware for members app
no issue

- Removes global bodyParser middleware for membersApp and adds it to specific endpoints
- Removes global boolParser middleware for membersApp

We added bodayParser middleware to memebrsApp in [this](fe3eab1836) commit to read json requests for members update endpoint, but that had issues with stripe webhook parsing for `/webhooks` endpoint as stripe expects raw data to be passed down.
2020-05-22 14:34:40 +05:30
Kevin Ansfield
21d38b2d37 Added label to known filter params for members
no issue

- updated `filter` plugin with appropriate label relationship and replacement config for NQL
- fleshed out member and label fixture data and tools to facilitate tests
2020-05-21 18:44:52 +01:00
Kevin Ansfield
225544331c Split members admin API tests between acceptance and regression
no issue

- moved typical "happy path" tests for members admin API from regression to acceptance
2020-05-21 18:44:52 +01:00
Renovate Bot
a23def6253 Update dependency sanitize-html to v1.24.0 2020-05-21 07:43:21 +01:00
Renovate Bot
5e5c498493 Update dependency uuid to v8.1.0 2020-05-20 23:09:02 +01:00
Fabien O'Carroll
4c3bd0e2e9 Added stripeDirect config to admin api w/ default
no-issue

The flag currently defaults to `true` as we are still using stripe
direct. We expose it on the admin api config endpoint so that the
Ghost-Admin client can use it to conditionally render
2020-05-20 16:47:58 +02:00
Rish
530760cfd0 Bumped @tryghost/members-api to 0.18.5
refs https://github.com/TryGhost/members.js/issues/26

- Updates magic link token handling to read and update name on member signup
2020-05-20 16:54:48 +05:30
Renovate Bot
2bd44ebee8
Update dependency @tryghost/members-ssr to v0.7.9 2020-05-20 09:15:55 +00:00
Rishabh Garg
fe3eab1836
Added member update endpoint with session auth (#11824)
- Allows member logged in with valid session to update their profile info - name, email, subscribed(newsletter subscription status)
- Adds new util method for formatted member response on the endpoints
- Adds common middlewares for body/bool parser and maintenance
- Adds `subscribed` status to member response
2020-05-20 14:37:58 +05:30
Peter Zimon
c2470bcddb
Fixed truncated URL for password reset email (#11827)
no issue

- shows the full URL instead of a truncated link in password reset email body. This is required for security and usability reasons (copy/paste)
2020-05-20 08:22:37 +01:00
Daniel Lockyer
1f5b031bfa v3.16.1 2020-05-20 07:30:35 +01:00
Daniel Lockyer
d4f06e07cb Updated Ghost-Admin to v3.16.1 2020-05-20 07:30:34 +01:00
Aileen Nowak
86ab62704b
🐛 Fixed structured data issue for publisher logo (#11826)
closes #11304

- Google requires an `ImageObject` to be always returned for `publisher.logo` (https://developers.google.com/search/docs/data-types/article)
- The previous fix 3f5daa60c8 added a second nested `url` error and got therefore reverted with 7ac614030d
- This commit updates the image object generation fn to **always** return an `ImageObject` with minimum of `url` and `@type` properties. If dimensions are available, we'll pass those in there as well
2020-05-20 18:16:20 +12:00
Nazar Gargol
2d41e5cc88 🐛 Fixed permission for "Administrator" to be able to edit post visibility
closes #11825

- The initial implementation had a typo in a role name which didn't allow "Administrator" to edit post's "visibility" attribute
- Added unit tests to check administrator specific role and visibility attribute permission
2020-05-20 17:47:27 +12:00
Renovate Bot
efdc230c7d
Update dependency @tryghost/members-ssr to v0.7.8 2020-05-19 16:44:05 +00:00
Rish
96b26d22f2 Bumped @tryghost/members-api to 0.18.4
refs https://github.com/TryGhost/members.js/issues/20 , https://github.com/TryGhost/members.js/issues/29

- Adds metadata option to stripe checkout session for passing member info like name
- Updates subscription api to allow updating plan by nickname
- Refactored update member method to pick passed fields only and return with subscriptions
2020-05-19 22:12:50 +05:30
Renovate Bot
3fc5cc021d
Update dependency @tryghost/session-service to v0.1.3 2020-05-18 20:19:28 +00:00
Renovate Bot
48a63dd99e
Update dependency @tryghost/mw-session-from-token to v0.1.3 2020-05-18 18:17:39 +00:00
Hannah Wolfe
2876178dcf 🐛 Fixed logic error in navigation for isSecondary
closes #11772

- Ensures that isSecondary is a boolean true or false
- Added tests that cover the bug, switching to using compile because the helpers have to be run together
- TODO: all tests for helpers should be switched to compile, it's SO MUCH easier
2020-05-18 19:15:28 +01:00
Renovate Bot
d15dce9086
Update dependency @tryghost/image-transform to v0.2.3 2020-05-18 15:16:57 +00:00
Renovate Bot
0cda4de484
Update dependency @tryghost/adapter-manager to v0.1.5 2020-05-18 13:48:01 +00:00
Daniel Lockyer
1da51ea8dc v3.16.0 2020-05-18 14:43:53 +01:00
Daniel Lockyer
fb146a7e75 Updated Ghost-Admin to v3.16.0 2020-05-18 14:43:53 +01:00
Renovate Bot
17ee76c013
Update dependency mock-knex to v0.4.9 2020-05-13 17:15:11 +00:00
Renovate Bot
419ffea5cf
Update dependency @lodder/grunt-postcss to v2.0.3 2020-05-12 16:15:37 +00:00
Renovate Bot
399c0e4773
Update dependency eslint-plugin-ghost to v1.4.1 2020-05-11 09:16:31 +00:00
Renovate Bot
f2defba264
Update dependency @tryghost/vhost-middleware to v1.0.4 2020-05-08 23:14:16 +00:00
Renovate Bot
ddaa289338
Update dependency @tryghost/session-service to v0.1.2 2020-05-08 21:13:24 +00:00
Renovate Bot
803a0b697a
Update dependency @tryghost/mw-session-from-token to v0.1.2 2020-05-08 19:13:26 +00:00
Renovate Bot
9a0aaaa34f
Update dependency @tryghost/image-transform to v0.2.2 2020-05-08 17:15:18 +00:00
Renovate Bot
fbad5b199f
Update dependency @tryghost/adapter-manager to v0.1.4 2020-05-08 15:58:44 +00:00
Hannah Wolfe
4af0a127cd Update dependency @tryghost/zip to v1.1.0
closes #11794

- Update to use the latest version of zip, which has dotfile support
2020-05-08 16:46:15 +01:00
Hannah Wolfe
998eb62e22 Added success indicator for members magic links
- Add a query param that indicates whether signin/up succeeded or failed
- Add unit tests for all 3 possible cases for the createSessionFromMagicLink middleware
- Added an acceptance test to show the behaviour works in principle
2020-05-08 13:17:51 +01:00
Daniel Lockyer
11f7834800 v3.15.3 2020-05-08 12:17:18 +01:00
Daniel Lockyer
5b03f0bf0f Updated Ghost-Admin to v3.15.3 2020-05-08 12:17:18 +01:00
Hannah Wolfe
fce596970f
Update config.yml
- Add docs and emoki
2020-05-08 11:44:34 +01:00
Hannah Wolfe
0d05f5abdf
Delete --anything-else.md
- Remove old issue template in favour of new links in config.yml file
2020-05-08 11:37:32 +01:00
Hannah Wolfe
758e67ea5f
Update config.yml
- Remove security as this is already added to the list via SECURITY.md
2020-05-08 11:36:36 +01:00
Hannah Wolfe
b5a7921707
Create config.yml
- Disable blank issues
- Provide important links for support, security and ideas
2020-05-08 11:35:29 +01:00
Daniel Lockyer
d9bc5e0c16 Reverted oembed-parser dependency to 1.3.7
no issue

- oember-parser 1.3.8/1.3.9 specify a minimum Node version of `>= 10.14.2`
- a problem with CI allowed this package to be updated, despite not
  matching our allowed minimum supported Node version
- this commit reverts back to the previous version, and this package
  will be bumped when we increase our minimum versions
2020-05-08 11:28:14 +01:00
Daniel Lockyer
3c5839fa8d Reverted metascraper packages to 5.11.9
no issue

- metascraper packages >= 5.11.10 have a dependency on got >= 11.0
- this has the minimum node version requirement set to `">=10.19.0"`
- our current minimum required node version is `10.13.0`, breaking installs for versions in between
- this reverts back metascraper packages to `5.11.9` to fix the minimum node version requirement
2020-05-08 11:28:14 +01:00
Daniel Lockyer
0e1170593c Enforced proper Node versions in CI
no issue

- a recent regression was not caught by CI because we only specify major
  versions
- this change will temporarily fail in CI until the fix for the
  regression is implemented
2020-05-08 07:44:34 +01:00
Daniel Lockyer
89a56b9fd8 v3.15.2 2020-05-07 21:59:02 +01:00
Daniel Lockyer
d1b71f463c Updated Ghost-Admin to v3.15.2 2020-05-07 21:59:02 +01:00