Commit Graph

192 Commits

Author SHA1 Message Date
Jason Williams
77af056fd0 Reset slug input text box after invalid input.
No Issue
- When an invalid, all whitespace slug is entered into the
  slug input in the post settings menu, it's rejected but
  the input's value still remains the same.  This resets the
  input back to its original value.
- Added test for the above behavior.
- Only show success notification if slug was actually changed.
- Convert whitespace from tabs to spaces in post-settings-menu.hbs
2014-08-18 21:10:57 +01:00
Hannah Wolfe
4ca21a7d75 Merge pull request #3805 from TryGhost/gui-update-yolo
Gui Update
2014-08-18 19:20:40 +01:00
Hannah Wolfe
30661f8ddb Merge pull request #3762 from blia/dev
Fixed TypeError when updating slug
2014-08-17 16:02:14 +01:00
John O'Nolan
d323b495a7 Implement new button markup 2014-08-17 14:57:07 +03:00
Jason Williams
09ede03ce4 Revert post status on failed save.
Refs #3667, Refs #3776
- If saving a post fails, revert its status back to the
  pre-save value.
- Added tests to check post status after failed save attempt
  on both new and existing posts.
2014-08-15 00:22:10 +00:00
Hannah Wolfe
153a0c818f Merge pull request #3776 from felixrieseberg/iss3667
Ensure editor awareness if publishing fails
2014-08-14 21:19:21 +01:00
Hannah Wolfe
801ca568e4 Merge pull request #3738 from felixrieseberg/iss3728
Error notification if send test mail returns 500
2014-08-14 20:38:08 +01:00
Felix Rieseberg
beba43b8f3 Ensure editor awareness if publishing fails
closes #3667
- If the ‘save’ function on a new post fails, the local Ember model
still beliefs that the status is ‘published’, resulting in wrong
buttons. A simple catch fixes that.
2014-08-14 11:05:05 -07:00
Kirill Yakovenko
a0d5817203 Fix TypeError when updating slug
- added check slug before trim
2014-08-12 17:46:14 +03:00
Felix Rieseberg
4cd78e3e4d Error notification if send mail api returns 500
closes #3728
- If the mail config is broken, the ajax call will fail with 500 and
not return an error.
- This change catches 500 and wraps the error in a notification.
2014-08-11 09:15:12 -07:00
Robert Jackson
970ccff961 Ensure that slug is always synced for User form. 2014-08-11 11:42:53 +01:00
Robert Jackson
9e07e18d2a Ensure PSM author is reset when changing posts. 2014-08-10 10:40:04 -04:00
Felix Rieseberg
69348b5bbb Error if user has already been invited
closes #3681
2014-08-08 16:41:16 -07:00
Hannah Wolfe
0e8e6e1baa Merge pull request #3706 from jaswilli/invite-fixup
Close invite user modal immediately after submit.
2014-08-08 22:58:29 +01:00
Jason Williams
75299bab24 Close invite user modal immediately after submit.
Closes #3672, Closes #3673, Closes #3680
- Close and reset modal immediately after submit instead
  of waiting until after processing has finished.
2014-08-08 20:44:03 +00:00
Jake Wright
71104558b7 Reset email form value on success
closes #3663
- Set value of email input as nil string
2014-08-08 02:52:19 +01:00
shindakun
5d7630607b Transition to signin with error message on invalid token not 500 error screen
closes #3548
- Add error to hidenav, removes menubar from error screen.
- Wrap atob() in a try/catch
- Added regex to try and validate if params.token at least looks like base64
2014-08-06 08:08:02 -07:00
Robert Jackson
0a9bde7702 Restore original display after window resizing.
fixes #3597
2014-08-06 09:04:43 +01:00
Hannah Wolfe
6a1d7c7a18 Merge pull request #3550 from halfdan/3542-forgotten-user
Properly show message when resetting password.
2014-08-06 02:18:30 +01:00
Jason Williams
3242c5b4a9 Cleanup from notifications refactor.
Refs #3521
2014-08-06 00:13:56 +00:00
Fabian Becker
e9e6aa1732 Changing User.read API to default to active users.
refs #3542
- Properly handle forgotten screen (ember)
- Change Users API to only return active users on read
- Adjust tests
2014-08-06 00:30:48 +02:00
Maurice Williams
bac71559f3 prevent revoking invite for already active users
closes #3563
- before attempting to revoke an invitation, get updated model info
- reload route and show warning if user info has changed
2014-08-05 00:35:46 -04:00
Felix Rieseberg
d4626ede74 Working delete user modal & button
closes #3529
- Created ‘delete user’ modal (similar to the ‘delete post’ modal) and
controller
-  Modal will be opened if ‘Delete User’ is selected in the user
setting cog menu
2014-08-04 13:29:24 -07:00
Sebastian Gierlinger
1c104c8f00 Merge pull request #3569 from morficus/issue-3549
fix most recent post stolen by the last logged in user AND only show active users in post-settings-menu drop-down
2014-08-04 10:51:07 +02:00
Hannah Wolfe
b2be3bc365 Merge pull request #3567 from novaugust/issue#3564
Return to invite new user; invite multiple users in one go
2014-08-03 17:54:59 +01:00
Matt Enlow
cb2f911b07 Return to invite new user; invite multiple users in one go
Closes #3533, Closes #3547, Closes #3531
- invite-new-user always resets role to author now, allowing for multiple invites on one load
- Added confirm action when hitting return in INUModal's email input
- Don't pass users as the model to invite-new-user-modal
- Move invite-new-user reset to a `finally` clause
- invite-new-user always closes on a confirm
2014-08-03 10:31:42 -06:00
Hannah Wolfe
4db3cb06e4 Merge pull request #3576 from morficus/issue-3523
Error modifying "author" attribute before post record has been created
2014-08-03 17:24:09 +01:00
Hannah Wolfe
05ce783bd5 Merge pull request #3535 from rwjblue/properly-transition-on-mobile
Handle toggleing the content screen on mobile.
2014-08-03 17:23:25 +01:00
Maurice Williams
44dd5ed286 fix most recent post stolen by the last logged in user AND only show active users in post-settings-menu drop-down
fixes #3549 fixes #3528
- instead of grabbing and setting the author after fetching the list of users, get the author info from the models "author" property and set it when that value returns. (3549)
- added filter to the PSM's "authors" attribute to only display active users (3528)
2014-08-02 21:28:02 -04:00
Maurice Williams
6ee5ba2291 Error modifying "author" attribute before post record has been created
fixes #3523
- when changing the author, added a check to NOT trigger a save if the post has not been created/saved as yet
2014-08-02 14:35:19 -04:00
Robert Jackson
a5b30bc3ba Small performance tweak for Posts ordering.
* Move publishedAtCompare to standalone function in closure scope
  (allows better browser optimizations).
* Avoid getting the same field (published_at) more than once.
2014-08-02 11:15:55 -04:00
Jason Williams
1c6216777c Refactor notifications to prevent stacking.
Closes #3511, Closes #3512, Closes #3526
- show* methods now close existing passive notifications by
  default.  They also now take an optional options object where
  existing parameters such as "delayed" and "defaultErrorText"
  can be passed in as well as the new "doNotClosePassive" flag.
- Removed all explicit calls to notifications.closePassive except
  for the few places where it makes sense to call it separately.
2014-08-01 16:57:29 +00:00
Fabian Becker
c2c8e92e8f Proper messaging on password reset
fixes #3540
- Show proper message when reusing token
- Show message after resetting password
2014-08-01 13:18:53 +00:00
Robert Jackson
9912c2bfed Handle toggleing the content screen on mobile.
Closes #3520.

Move the custom jQuery animation into an action on the controller so
that we can trigger it from within the route if needed.
2014-08-01 02:47:29 -04:00
Jason Williams
27e14b7ad9 Fix for missing author when switching posts
No Issue
- Fixes the case where the authors dropdown in the
  post settings menu has no author selected after
  switching between posts.
2014-07-31 20:19:52 +00:00
Hannah Wolfe
34dbc13893 Merge pull request #3477 from halfdan/duplicate-notification
Avoids duplicate notification / transition
2014-07-31 15:47:19 +01:00
Hannah Wolfe
cfcc30b65e Merge pull request #3480 from jaswilli/issue-3466
Update user roles in store after owner transfer
2014-07-31 15:39:48 +01:00
Jason Williams
038632e9a6 Update user roles in store after owner transfer
Closes #3466
- Transferring the owner role is now done via a separate
  endpoint and not through Ember-Data.  As a result the
  user role data needs to be updated manually.
- Updated the owner endpoint to return a response body
  containing the updated user objects.
- Updated tests.
2014-07-31 13:41:10 +00:00
Fabian Becker
1fffc74247 Avoids duplicate notification / transition
no ref
- Let application.js handle transition after setup
- Remove duplicate loading of server notifications
2014-07-31 14:22:37 +02:00
Maurice Williams
e6115c4126 custom slugging capabilities for individual user pages
closes #3401
- modifying slug-generator to be more generic
- adding slugging capabilities for /settings/users/:slug
- modified posts to use the updated slug-generator
2014-07-31 08:14:22 -04:00
Matt Enlow
975f925561 Add User Role Dropdown
Closes #3402, Closes #3428

-------------------

 ### Components
- Added GhostSelectComponent to handle async select creation (h/t @rwjblue)
- Added GhostRolesSelector (extends GhostSelect) for displaying user role options
- Created StoreInjector for surgically inserting the store into things that normally wouldn't have them.

 ### Users Settings
- InviteNewUserModal now uses GhostRolesSelector & defaults to Author
- The role dropdown for user settings has permissions set per 3402

 ### User Model
- Added `role` property as an interface to getting and setting `roles`
- Refactored anything that set `roles` to set `role`
- isAdmin, isAuthor, isOwner and isEditor are all keyed off of `role` now

 ### Tests
- Added functional tests for Settings.Users
- updated settings.users and settings.users.user screens
- fix spacing on screens

 ### Server Fixtures
- Fixed owner fixture's roles
2014-07-30 17:59:14 -06:00
Hannah Wolfe
3b81cca49c Merge pull request #3457 from sebgie/issue#3426
Transfer ownership end point
2014-07-30 22:26:42 +01:00
Hannah Wolfe
cf048b72b2 Merge pull request #3449 from felixrieseberg/iss3383
Stop validation error notification stack
2014-07-30 22:04:31 +01:00
Sebastian Gierlinger
a18b58a2f6 Transfer ownership end point
closes #3426
- added transfer ownership endpoint
- added owner to roles.permissible
- manually removed owner from roles.browse
- removed hard coded author role
- fixed tests that were passing due to hard coded author role
- added testUtils.setup(‚roles‘)
2014-07-30 17:40:30 +02:00
Felix Rieseberg
7cf0a25381 Stop validation error notification stack
closes #3383
- Calls closePassive() if a new validation error is thrown to display
only the latest validation error
2014-07-30 08:07:34 -07:00
Hannah Wolfe
949252f5ed Merge pull request #3447 from jaswilli/auth
Fixup signin and signout
2014-07-30 14:13:02 +01:00
Jason Williams
d19c3ae9d1 Fixup signin and signout
No Issue
- Move authentication related handlers to the Application route.
- Switch Sign Out from a button to a link.  Use the signout route
  to handle invalidating the session and redirecting instead of
  an action from a button.
- Clear error messages on signin page when pressing log in button.
- Errors are now always shown on sign in screen and a success
  notification is shown after sign out.
- Update functional tests.
2014-07-29 20:58:43 +00:00
Sebastian Gierlinger
bb5ca7c272 Fix Invitations
no issue
- added `invited-pending` when resending invitation
- promise chain was missing a return statement
- email error was masked and front end showed success notification
2014-07-29 15:35:48 +02:00
Hannah Wolfe
05afe8afb2 Improve importer error messaging
closes #3274

- Ensure that validation errors are always handled by moving them into the
  importer
- Ensure that db errors are handled consistently across sqlite and mysql
- Change the errors to be output in a table, with a short failure notification
- Add tests for 003 importing bad files
2014-07-29 12:02:18 +01:00
Maurice Williams
3397790204 Removing "author" role-label
closes #3427
- adding conditional statement to now display users with role "author"
2014-07-29 01:50:34 -04:00