Commit Graph

7219 Commits

Author SHA1 Message Date
Daniel Lockyer
c70ca8dcbc Merged v4.8.2 into main
v4.8.2
2021-06-24 13:19:38 +01:00
Daniel Lockyer
539fbf040c v4.8.2 2021-06-24 13:16:51 +01:00
Daniel Lockyer
023820eddd Merged v4.8.1 into main
v4.8.1
2021-06-24 11:20:17 +01:00
Daniel Lockyer
c1149889c6 v4.8.1 2021-06-24 11:19:09 +01:00
Rishabh
38a499a531 🐛 Fixed stripe connect modal not closing
closes https://github.com/TryGhost/Ghost/issues/13090

The `X` on stripe connect modal is not closing the popup as the updated modal changes was not wiring the close method.

Note: Clicking outside the popup to close it was still working
2021-06-24 14:52:06 +05:30
Rishabh
4665e64103 🐛 Fixed default currency for MRR stats on dashboard
closes https://github.com/TryGhost/Team/issues/799

- previous logic was still using `stripe_plans` for MRR currency, which is not used anymore
- updates first product's currency as default mrr currency
2021-06-24 14:51:39 +05:30
Peter Zimon
81ae1afcaa Added inner scrolling for benefits list (alpha) 2021-06-23 15:12:08 +02:00
Kevin Ansfield
1206889b0d Fixed editor flex breakouts squashing sidebar in settings menu redesign
no issue

- added `--editor-sidebar-width` CSS variable directly in `index.html` so it doesn't get removed by `postcss-custom-properties` (we use `preserve: false` to avoid problems with `postcss-color-mod-function`)
- adjusted editor CSS
  - added max-width calc on container element to prevent browser from increasing the element's width beyond what would allow the sidebar to display at it's desired width
  - adjusted the editor flex breakout styles to work with a non-100vw width by using the sidebar width variable
- updated labs post settings menu component to set the `--editor-sidebar-width` variable to the actual width of the sidebar element
  - avoids need to have multiple classes with fixed widths to adjust editor and breakout sizes
2021-06-23 13:54:40 +01:00
Peter Zimon
516825e41f Fixed Multiple products alpha feature name case style 2021-06-23 11:58:59 +02:00
Sanne de Vries
f15bce5c2d Updated design for new fixed post settings menu 2021-06-22 20:51:31 +02:00
Peter Zimon
c078b639c2 Benefit list width refinement (alpha) 2021-06-22 16:59:58 +02:00
Peter Zimon
a02711c2a2 Refined benefits list (alpha) 2021-06-22 16:44:16 +02:00
Daniel Lockyer
4e6b59f295 v4.8.0 2021-06-22 15:25:52 +01:00
Sanne de Vries
3fc538eb4a Fixed feature image indicator alignment 2021-06-22 13:45:45 +02:00
Sanne de Vries
223a7f35c3 Added feature image indicator 2021-06-22 13:12:41 +02:00
Kevin Ansfield
1c9b7bba9d Fixed number of post save retry attempts
refs ac094821c8

- 2 attempts were used to speed up development, should have been 6 to match the 30seconds total retry period
2021-06-22 12:11:35 +01:00
Rishabh
1df55f76f7 Fixed product save handling on membership settings
no refs

- the settings save on memberships was incorrectly relying on developerExperiments flag instead of multipleProducts feature flag
2021-06-22 14:19:08 +05:30
Kevin Ansfield
bc950e655f Fixed error when editing settings
no issue

- the `newsletter_show_header` setting has been removed on the server side but was still being included by the client when saving the settings model resulting in a `Resource not found error, cannot edit setting. Problem finding setting: newsletter_show_header` error
2021-06-22 09:06:39 +01:00
Kevin Ansfield
a8c05f4be7 Fixed linting errors
refs ac094821c8

- stray console.logs
2021-06-21 18:15:17 +01:00
Kevin Ansfield
ac094821c8 Improved "Server unreachable" error handling in editor
refs https://github.com/TryGhost/Team/issues/788

- automatically retry any failed save attempts every 5 seconds for up to 30 seconds
- only show error bar after when we completely give up
- clear error bar if a later save is successful
- update error message to specify there's a connection problem and to retry with Cmd+S
- notify Sentry of a successful save after an initial failure including the number of attempts that were made and the total time for save to succeed in seconds
2021-06-21 18:13:45 +01:00
Sanne de Vries
81bfc3c6f6 Updated feature image button in editor 2021-06-21 16:27:13 +02:00
Kevin Ansfield
2770c73bab Fixed tests
refs 37a6197f81

- fixed find/replace whoopsie with `slugGenerator.generateSlug()`
- updated editor controller unit tests to match rename
2021-06-21 15:18:11 +01:00
Kevin Ansfield
37a6197f81 Renamed editor tasks to use xTask naming
no issue

- helps indicate that you're dealing with an ember-concurrency task object rather than a function/action so you know to use `perform` and that you have access to derived state
2021-06-21 15:05:41 +01:00
Sanne de Vries
0744119299 Fixed feature image caption vs alt text spacing issue 2021-06-21 16:00:49 +02:00
Kevin Ansfield
e322709f95 Updated newsletter design settings modal for new settings (#2013)
refs https://github.com/TryGhost/Team/issues/793
requires https://github.com/TryGhost/Ghost/pull/13074

- replaced main email design settings modal component with labs component and removed conditional
- removed `labs-newsletter-settings` class and cleaned up CSS
2021-06-21 13:40:54 +01:00
Peter Zimon
6011142428 Portal settings spacing refinement 2021-06-21 14:32:35 +02:00
Sanne de Vries
33d86c5dd5 Updated feature image design in editor 2021-06-21 12:03:40 +02:00
Kevin Ansfield
3f13aec6b8 Lock file maintenance 2021-06-21 10:19:50 +01:00
renovate[bot]
770b7735b8 Update dependency @tryghost/helpers to v1.1.47 (#2014)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 10:15:33 +01:00
renovate[bot]
fe4607ad0c Update dependency @tryghost/timezone-data to v0.2.45 (#2015)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 09:58:31 +01:00
renovate[bot]
bd582c19f4 Update dependency ember-fetch to v8.1.0 (#2012)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 09:56:50 +01:00
renovate[bot]
a13e36e6ff Update dependency broccoli-funnel to v3.0.8 (#2011)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 09:56:30 +01:00
renovate[bot]
0dca4580ab Update dependency @sentry/ember to v6.7.1 (#2009)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 09:56:16 +01:00
renovate[bot]
88b137fc28 Update dependency ember-cli-inject-live-reload to v2.1.0 (#2007)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-06-21 09:55:37 +01:00
Rishabh Garg
274044e253 Added UI for portal products (#2010)
refs https://github.com/TryGhost/Team/issues/768

- adds portal products selection UI behind flag on portal settings screen
2021-06-21 14:21:48 +05:30
Rishabh
cde942f5bc Updated product benefits handling
refs https://github.com/TryGhost/Team/issues/792

- adds list of product benefits, if available, to main memebrship screen
- updates benefits management on product detail screen
2021-06-21 14:06:17 +05:30
Rishabh
dc6b2884f1 Added model and validator for product's benefit item
refs https://github.com/TryGhost/Team/issues/792

- updates product model to read product's list of benefits
- adds transformer to return emberArray with list of product benefits
- adds new model for each product benefit
- adds validator for new product benefit
2021-06-21 14:05:01 +05:30
Rishabh
e5a24c8bb3 Wired removing complimentary product action to API
refs https://github.com/TryGhost/Team/issues/769

- wired removing comp product action button to API, allowing removing comped subscription for member
2021-06-21 12:32:20 +05:30
Renovate Bot
129377a59a Update dependency eslint to v7.29.0 2021-06-18 21:16:59 +00:00
Kevin Ansfield
fc21cd836a 🎨 Opened member email settings up to Administrator staff users
no issue

- previously only Owner staff users could access the email settings screens despite Administrators having server-side permissions to change the related settings
2021-06-18 18:43:38 +01:00
Sanne de Vries
4961b35692 Added feature image caption to newsletter template preview 2021-06-18 18:50:20 +02:00
Sanne de Vries
e2a136609a Updated email design settings layout 2021-06-18 17:22:23 +02:00
Peter Zimon
821c087871 Refined complimentary for multiple products (alpha) 2021-06-18 16:58:00 +02:00
Rishabh
9b228659da Added dummy benefits section to products
refs https://github.com/TryGhost/Team/issues/792

- adds new hardcoded benefits section as prototype in Products modal
2021-06-18 19:09:14 +05:30
Kevin Ansfield
d96046cf1b Handled SecurityError when accessing iframe in <GhSiteIframe>
no issue

- when a site has a separate front-end and admin URL the `site` screen could throw errors due to cross-origin access to the iframe content
- detect the error and fall back to a less efficient forced refresh on guid change
2021-06-18 13:08:19 +01:00
Rishabh
176ed4a260 Fixed member product modal not closing
no refs

- Added missing close handling for member product modal
2021-06-18 16:28:53 +05:30
Rishabh
bc25dbdefa Fixed modal errors in stripe connect and member product
refs 909bd60db3

- The modal actions for glimmer modal components need to define `actions.confirm` separately and add confirmAction to handle both enter and manual confirmation
2021-06-18 16:24:18 +05:30
Kevin Ansfield
922e4e6b32 Fixed unhandled errors from billing app for non-owner users
no issue

- if the identities endpoint returned an expected 403 for non-owner/admin users we weren't handling it resulting in an error that could bubble up into error reporting services
2021-06-18 10:34:30 +01:00
Kevin Ansfield
909bd60db3 Fixed errors when enter key is pressed in modals
no issue

- enter key when a modal is displayed will always trigger the `confirm` action, if it's not provided then the base modal will throw a `You must override the "confirm" action ...` error
2021-06-18 10:12:46 +01:00
Peter Zimon
178733a521 Added benefits container to add/edit product (alpha) 2021-06-18 10:51:10 +02:00