Commit Graph

1667 Commits

Author SHA1 Message Date
Felix Rieseberg
bf1a0e4b04 gh-trim-focus-input autofocus fix for iOS Safari
Closes #4446
- Mobile Safari doesn’t support the HTML5 `autofocus` attribute, but
also doesn’t play nice with jQuery’s `focus()` and `select()` methods.
- Mobile Safari wouldn’t automatically select the input field anyway,
so this PR simply removes the “jumping input fields” error without
changing any actual behaviour.
- Disallowing the programmatic selection of input fields (with select,
focus or similar methods) is apparently considered a feature rather
than a bug (ref http://bugs.jquery.com/ticket/12789)
- `autofocus` attribute is now only set on non-iOS devices
2014-12-02 09:14:32 -08:00
Jason Williams
6c8abe5481 Change anchors without hrefs to buttons. 2014-12-02 15:02:37 +00:00
Hannah Wolfe
cd92f9ab45 Merge pull request #4560 from cobbspur/labs
Move ugly debug to Settings  Labs
2014-12-02 10:34:17 +00:00
cobbspur
920e36f8e0 Move ugly debug to Settings Labs
closes #4534

- Adds new Labs route
- Wires route in settings page
- Move and rename debug templates and logic to labs
- Redirect /debug to settings/labs
2014-12-01 19:19:08 +00:00
Paul Adam Davis
6a4bd3b770 Cleanup layout Sass
Continues on from #4441

- Reformats the layout Sass files (comments, white space)
- DRY up small chunks of CSS to make it more comprehensible
2014-12-01 16:06:53 +00:00
John O'Nolan
1e7b892f79 Introduce sitemap XSL template
Based on Yoast's All in One SEO plugin for WordPress implementation
2014-12-01 16:10:14 +02:00
Hannah Wolfe
bb1ee6f7d0 Merge pull request #4551 from jaswilli/editor-401-modal
Do not display "auth failed" modal on clean posts.
2014-12-01 11:04:59 +00:00
Hannah Wolfe
4b71aeeddb Merge pull request #4531 from Gargol/issue-4485
Cleans up HTML data attributes on body in default.hbs
2014-12-01 10:54:19 +00:00
Paul Adam Davis
a75a9d9421 Allow notifications to sit over the nav bar
Closes #4379

- Adjusts the `.viewport` `z-index` propetty to allow notificatons to sit over the nav bar

Looks like a weird fix, but inheritence of z-index was the issue here.
2014-12-01 10:31:29 +00:00
Jason Williams
eee9d4c779 Do not display "auth failed" modal on clean posts.
Refs #4543
- Check EditorController.isDirty before displaying the
  authorization failed modal dialog.  This prevents the modal
  appearing immediately upon entering the editor in cases where
  auth has failed prior to opening the editor.
2014-11-30 20:53:59 +00:00
Jason Williams
42d8e82c13 Prevent silent failures and recover after error.
Refs #4543
- Alway return model out of save handler so sub-classes which
  call this._super() on save have a model on success and failure.
- Always return resolved promise out of post slug generator.
- Test the errors object in the error notification helper to avoid
  throwing an unhandled exception and silently failing.
- Consider a post model "dirty" if it is in an error state.
2014-11-30 20:38:24 +00:00
Nazar Gargol
b35aecc712 Cleans up HTML data attributes on body in default.hbs
closes #4485

- removes data attributes used on body in default.hbs
- introduces new way to generate configuration through meta tags
- config initializer consumes configurations from the meta tags using parser
- moves blog_title helper/value to be a property in a configuration api
2014-11-29 17:09:43 +01:00
Hannah Wolfe
4937bfa4ff Merge pull request #4542 from jaswilli/misc-cleanup
Miscellaneous client cleanup
2014-11-29 16:05:37 +00:00
John O'Nolan
7f84c45a9a Merge pull request #4533 from PaulAdamDavis/logo-no-hover-bg
Swap nav item & logo style order
2014-11-29 16:54:14 +01:00
John O'Nolan
21fdf6b214 Merge pull request #4536 from PaulAdamDavis/labs-icon
Add Labs, Nav & Grab icons
2014-11-29 16:53:52 +01:00
Jason Williams
d196b87f1b Miscellaneous client cleanup
No issue
- Consolidate extension of Ember.Router.
- Remove unneeded local jshint flags and '_' as a global.
- Cleanup client README.md.
- Fix error message.
2014-11-29 02:42:08 +00:00
Hannah Wolfe
0fa35b325c Merge pull request #4522 from felixrieseberg/iss4487
Dynamic Titles in Ghost Admin
2014-11-28 19:06:44 +00:00
Paul Adam Davis
56b097ac22 Add Labs, Nav & Grab icons
References #4535, #4534

- Add an Atom icon for Labs page
- Adds Compass and Grab icons for the Navigation page
2014-11-28 15:29:29 +00:00
Paul Adam Davis
89f0f38c83 Swap nav item & logo style order
Closes #4532

- Swaps the order of nav-item and .ghost-logo styles, as .ghost-logo was being overwritten by .nav-item, allowing a hover state
2014-11-28 10:21:14 +00:00
Felix Rieseberg
da4270ce35 Dynamic Titles in Ghost Admin
- Every route can set a title token that is combined with the blog’s
title, resulting in titles like ‘Content - Test Blog’.
- Subroutes are supported (‘Settings - General - Test Blog’)
- The blog’s name is applied to and taken from the `config` object to
spare Ember a REST call via `store.find(‘settings’)`.
- Tests have been changed to test for the new titles.
- The initially proposed solution
(https://github.com/paddle8/ember-document-title) doesn’t play nice
with EAK, which is why I went with this solution
(https://gist.github.com/machty/8413411) by Ember.JS core dev @Machty.
2014-11-27 15:41:00 -08:00
Robert Jackson
404743f170 Add initial client unit test. 2014-11-26 23:20:50 -05:00
Hannah Wolfe
a1ab6b4a13 Merge pull request #4502 from felixrieseberg/iss4431
Ensure Post Image Uploader Reset
2014-11-25 19:07:32 +00:00
Felix Rieseberg
634a095711 Ensure Post Image Uploader Reset
Closes #4431

- The PSM does not reset on a transition from editor (existing post) to
editor (new post). If the existing post had a cover image, the image
uploader would not be reset during the transition and appear slightly
broken in the editor for the new post.
- In this PR: A reference to the uploader is saved, allowing the route
for editor/new to instruct the PSM controller to have the uploader
reset.
2014-11-24 09:43:17 -08:00
Hannah Wolfe
e125c3cb05 Merge pull request #4513 from PaulAdamDavis/close-tag-settings-on-exit
Close tag settings menu on transition
2014-11-24 16:27:15 +00:00
Paul Adam Davis
ba67a02b9b Larger edit tag hit area
Closes #4505

- Increases the size of hit area on tags settings pages
- Comments out the styles for nested tags as these will need revisiting
2014-11-24 11:08:02 +00:00
Paul Adam Davis
ea75b3270c Close tag settings menu on transition
Closes #4504

- Adds a `willTransition` action that closes the tag settings menu when transitioning to another page
2014-11-23 21:17:29 +00:00
Hannah Wolfe
4436242e9b Merge pull request #4501 from jaswilli/routes
Fix up single post routes.
2014-11-23 21:15:23 +00:00
Hannah Wolfe
ce9f2bc683 Merge pull request #4489 from novaugust/tags-client-basics
Tags management api hookup
2014-11-22 10:57:46 +00:00
Hannah Wolfe
e35d8eea61 Merge pull request #4482 from harrykiselev/patch-1
Posts view: some DRY.
2014-11-22 10:17:10 +00:00
Matt Enlow
26268d7667 Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code
2014-11-21 16:24:28 -07:00
Jason Williams
1d59d0648b Fix up single post routes.
No Issue
- Add local store lookup back to edit route.
- Prevent entry into route when an author is not the owner of a post
  even if model is passed in.
- Clean up references to pagination as there's no pagination going on.
2014-11-21 21:56:49 +00:00
Hannah Wolfe
266034c993 Merge pull request #4488 from Gargol/issue-4415
Loads correct screen after author refreshes page in editor
2014-11-20 19:45:51 +00:00
John O'Nolan
e1cfc2349f Merge pull request #4401 from PaulAdamDavis/sass-cleanup
Update Patterns Sass Formatting
2014-11-20 19:05:15 +01:00
Nazar Gargol
cf5ff983c7 Loads correct screen after author refreshes page in editor
closes #4415
- corrected logic around author check
- fixes a bug where it was possible to see editor for other author posts
2014-11-20 00:11:42 +01:00
Hannah Wolfe
3d138be586 Merge pull request #4469 from PaulAdamDavis/permalink-improvs
Improvements to the permalinks UI
2014-11-19 20:46:32 +00:00
Harry V. Kiselev
91966180b9 Posts view: some DRY. 2014-11-20 00:00:10 +04:00
Paul Adam Davis
29b5a1c2eb Update Tags Management Markup
References #4248

- Updates the markup & classes for the tag management settings menu, as they've fallen behind now we've renamed the 'right-outlet' to 'settings-menu'
2014-11-19 16:07:11 +00:00
Hannah Wolfe
edfcc9ac71 Fixing logic for editors deleting themselves
no issue
- no user is allowed to delete their own account
2014-11-18 12:01:01 +00:00
Hannah Wolfe
d02d2315dd Fix issue with editor and images
ref #4459

- move initMarkers back to its original home
- add new test that a post with an image can be edited
2014-11-17 21:55:12 +00:00
Hannah Wolfe
c18527de44 Revert "Update PSM Date and Time to be Selectable Instead of Text" 2014-11-17 17:09:01 +00:00
Matt Enlow
066f18a82a Scroll post-item-view into view
Closes #3998
- Scroll the active post into view on page load
- If the active post changes and the newly active post is offscreen, scroll it into the middle of the screen
2014-11-17 09:50:49 -07:00
Hannah Wolfe
4330a24179 Merge pull request #4466 from VictorVation/url-validation
Improve validation for user.website
2014-11-17 15:43:25 +00:00
Paul Adam Davis
ebc9c32d06 Improvements to the permalinks UI
Closes #4454

* Relies on Flexbox more heavily
* Adds JS to simulate how it should work
2014-11-17 15:37:32 +00:00
Hannah Wolfe
dcca72c800 Merge pull request #4459 from novaugust/slow-save-errors#4400
Fix high latency autosave bug in editor.new
2014-11-17 15:18:12 +00:00
Paul Davis
c226701801 Merge pull request #4448 from dbalders/master
Update PSM Date and Time to be Selectable Instead of Text
2014-11-17 11:24:10 +00:00
Victor Szeto
18dc5d650d Improve validation for user.website
closes #4444
- validate URL without protocol in server and client
- when saving url, add `http://` if the url doesn't have a protocol
2014-11-17 00:40:43 -05:00
David Balderston
fc22161680 Update PSM Date to be Selectable 2014-11-16 11:59:09 -08:00
Matt Enlow
19c3a5c023 Add self to list of filtered users for editors
Closes #4412
2014-11-16 09:36:37 -07:00
Matt Enlow
4394e4f38f Fix high latency autosave bug in editor.new
Closes #4400
- Added focusCursorAtEnd property to codemirror component, to set the cursor at document end on load. Used for posts that have been edited
- centralized codemirror init code in component
2014-11-16 08:53:02 -07:00
Matt Enlow
89a2f4d246 Merge pull request #4457 from jaswilli/tags
Fix post tags input.
2014-11-15 08:37:07 -07:00