Rishabh
54b27f7d55
Fixed offers playwright test for redemption count
...
- updates check of redemption count using data test attributes to avoid unreliable member count check
2023-01-06 18:39:38 +05:30
Simon Backx
6593c3e4a6
🐛 Fixed warnings not visible when uploading theme with fatal errors
...
refs https://github.com/TryGhost/Team/issues/2393
Small bug if you upload a theme that has fatal errors, in development mode the warnings are not visible.
2023-01-06 13:54:09 +01:00
Simon Backx
7b3712a15b
Added visible theme errors in admin ( #16081 )
...
refs https://github.com/TryGhost/Team/issues/2393
- During boot and loading the active theme, we now cache the result of
the gscan validation. Cache configuration can happen in
`adapters.cache.gscan`
- We now also return non-fatal errors when activating or adding a theme.
- When the `themeErrorsNotification` feature flag is on, we fetch the
active theme (which includes the validation information) when loading
admin
- If the currently active theme has errors, we show an error
notification that can open the error modal
- Added a new endpoint: `/ghost/api/admin/themes/active/` that returns
the result of the last gscan validation of the active theme. If no cache
is available, it will run a new gscan validation.
- Added new permissions for the active action/endpoint (author, editor,
administrator)
2023-01-06 13:44:27 +01:00
Rishabh
30c9dfd68d
Fixed failing playwright test to remove member labels
...
- the test was using incorrect test state that was copied over from adding label test
- also adds guard for empty newsletters in member filters as in some cases it might not exist as found by test
2023-01-06 16:17:34 +05:30
renovate[bot]
78384dd9eb
Update dependency ember-template-lint to v5.3.1
2023-01-06 00:21:56 +00:00
Ghost CI
adbf6427ae
v5.27.0
2023-01-05 16:22:40 +00:00
Simon Backx
d34f07f408
🐛 Fixed admin loading member counts for authors and editors
...
no issue
When using admin as a user with author or editor permissions, admin tried to load the member counts in order to display them in the menu. But authors and editors are not allowed to see the members. So the request returned a 403.
It is not necessary to load the member counts for authors and editors, so we can just skip the request.
2023-01-05 16:37:01 +01:00
Peter Zimon
bfe1915924
Theme error list design refinements
...
refs. https://github.com/TryGhost/Team/issues/2393
- style for theme error list was outdated
2023-01-05 13:19:34 +01:00
Djordje Vlaisavljevic
5b8a44772b
Fixed settings menu header and tags overlapping
...
no refs
2023-01-05 12:08:03 +00:00
Peter Zimon
84cdf0c46c
Added static version of theme errors notification
...
refs. https://github.com/TryGhost/Team/issues/2393
- a labs flag had to be created so we avoid working in branches
- permanent notification toast was added to make theme errors more discoverable
- static modal was needed to hold theme error details
2023-01-05 11:38:17 +01:00
Peter Zimon
74fd5d4b04
Portal settings design bugfixes
...
no refs.
- Stripe Connect footer in the Portal settings sidebar was covering settings on small screens
- the border for Stripe Connect box was not visible in dark mode
- the "Save and Close" button background was not visible in dark mode in Portal settings
2023-01-04 18:04:01 +01:00
renovate[bot]
218136060e
Update sentry-javascript monorepo to v7.29.0
2023-01-04 17:23:05 +01:00
renovate[bot]
e291c18371
Update dependency ember-modifier to v4 ( #15990 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-modifier](https://togithub.com/ember-modifier/ember-modifier ) |
[`3.2.7` ->
`4.0.0`](https://renovatebot.com/diffs/npm/ember-modifier/3.2.7/4.0.0 ) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>ember-modifier/ember-modifier</summary>
###
[`v4.0.0`](https://togithub.com/ember-modifier/ember-modifier/blob/HEAD/CHANGELOG.md#v400-2022-12-13 )
[Compare
Source](https://togithub.com/ember-modifier/ember-modifier/compare/v3.2.7...v4.0.0 )
##### 🚀 Enhancement
-
[#​498](https://togithub.com/ember-modifier/ember-modifier/pull/498 )
Update signature of constructor for class-based modifiers
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​327](https://togithub.com/ember-modifier/ember-modifier/pull/327 )
auto-publish unstable packages to NPM
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 🐛 Bug Fix
-
[#​372](https://togithub.com/ember-modifier/ember-modifier/pull/372 )
Include `blueprints` folder in published tarball
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 📝 Documentation
-
[#​504](https://togithub.com/ember-modifier/ember-modifier/pull/504 )
docs: Fix typo in TypeScript class based example
([@​HeroicEric](https://togithub.com/HeroicEric ))
##### 🏠 Internal
-
[#​539](https://togithub.com/ember-modifier/ember-modifier/pull/539 )
Sync with latest v2 addon and cli-typescript blueprints
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​328](https://togithub.com/ember-modifier/ember-modifier/pull/328 )
run `npx ember-cli-update --to=4.3.0` to align with blueprint
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 2
- Eric Kelly ([@​HeroicEric](https://togithub.com/HeroicEric ))
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-04 15:13:15 +00:00
Peter Zimon
9d924efe92
Updated Stripe Connect buttons
...
no refs.
- Stripe Connect in Portal was not discoverable enough
- we used the old Stripe Connect buttons everywhere
2023-01-04 15:29:56 +01:00
Rishabh
f5aa07a095
🐛 Removed free trial message shown on portal for invite only sites
...
closes https://github.com/TryGhost/Team/issues/2361
If a free trial tier existed on site and its set to 'Invite only' in membership settings, the free trial copy still showed on portal.
- removes free trial copy from portal if site is invite only
- adds playwright test to make sure free trial copy is not shown for invite only sites
2023-01-04 17:11:55 +05:30
Daniel Lockyer
1af31bab1a
ℹ️ Added support for Node 18
...
refs https://github.com/TryGhost/Toolbox/issues/488
- Node 18 is now LTS so we're adding support for it
- this adds Node 18.12.1 (the latest security release) to our supported
ranges and CI
2023-01-04 11:27:39 +01:00
Daniel Lockyer
aa08fc72e7
Updated Koenig packages
...
refs https://github.com/TryGhost/Toolbox/issues/488
- these packages add support for Node 18 and drop support for Node 12
2023-01-04 11:27:39 +01:00
Kevin Ansfield
ea9c8c03fe
Update dependency ember-template-lint to v5.3.0 ( #16062 )
...
refs https://github.com/TryGhost/Ghost/pull/15550
Pulled out of the rolled up node+ember-js+ember-template rollup linter update PR as it required fairly extensive changes.
- bumped package
- renamed `no-down-event-binding` to `no-pointer-down-event-binding`
- disabled `no-pointer-down-event-binding` rule
- disabled `no-triple-curlies` rule
- ran `yarn lint:hbs --fix`
- updated integration tests to match Octane syntax
- fixed various one-off errors
- updated .lint-todo
2023-01-04 09:39:32 +00:00
renovate[bot]
f6db0640a6
Update dependency @ember/test-helpers to v2.9.3 ( #16011 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@ember/test-helpers](https://togithub.com/emberjs/ember-test-helpers )
| [`2.8.1` ->
`2.9.3`](https://renovatebot.com/diffs/npm/@ember%2ftest-helpers/2.8.1/2.9.3 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>emberjs/ember-test-helpers</summary>
###
[`v2.9.3`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.3 ):
Release 2.9.3
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.2...v2.9.3 )
##### 🐛 Bug Fix
-
[#​1305](https://togithub.com/emberjs/ember-test-helpers/pull/1305 )
\[backport] Avoid unnecessary dependencies on `@glimmer` types
([@​dfreeman](https://togithub.com/dfreeman ))
##### Committers: 1
- Dan Freeman ([@​dfreeman](https://togithub.com/dfreeman ))
###
[`v2.9.2`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.2 ):
Release 2.9.2
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.1...v2.9.2 )
##### 🐛 Bug Fix
-
[#​1302](https://togithub.com/emberjs/ember-test-helpers/pull/1302 )
\[backport] Remove the index signature from `TestContext`
([@​chriskrycho](https://togithub.com/chriskrycho ))
- Backporting
[#​1301](https://togithub.com/emberjs/ember-test-helpers/pull/1301 )
Remove the index signature from `TestContext`
([@​dfreeman](https://togithub.com/dfreeman ))
-
[#​1303](https://togithub.com/emberjs/ember-test-helpers/pull/1303 )
`TestContext.resumeTest()` returns `void`, not `Promise<void>`
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### Committers: 1
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
- Dan Freeman ([@​dfreeman](https://togithub.com/dfreeman ))
###
[`v2.9.1`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v291-2022-12-16 )
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.0...v2.9.1 )
***Note:** these were all back-ported from master since they could go
out on 2.9. This will be the last 2.9 release unless there are critical
bug fixes here!*
##### 🐛 Bug Fix
- Let ESLint have its way about docstring location
([`a8fac83`](https://togithub.com/emberjs/ember-test-helpers/commit/a8fac83 ))
- DOC: API: add render helper examples
([`f476a20`](https://togithub.com/emberjs/ember-test-helpers/commit/f476a20 ))
- Tweak TS style for indexing multiple types (for getElement)
([`f01ad9f`](https://togithub.com/emberjs/ember-test-helpers/commit/f01ad9f ))
- Use export type for RenderingTestContext
([`2dc5077`](https://togithub.com/emberjs/ember-test-helpers/commit/2dc5077 ))
- Tweak TS style for indexing multiple types
([`3214483`](https://togithub.com/emberjs/ember-test-helpers/commit/3214483 ))
- Address PR feedback
([`5e87a54`](https://togithub.com/emberjs/ember-test-helpers/commit/5e87a54 ))
- DOC: API: add DOM query helper examples
([`83b7f5f`](https://togithub.com/emberjs/ember-test-helpers/commit/83b7f5f ))
- Export type for Target
([`335019d`](https://togithub.com/emberjs/ember-test-helpers/commit/335019d ))
- Upgrade expect-type and fix issues the new version reveals
([`bae5e33`](https://togithub.com/emberjs/ember-test-helpers/commit/bae5e33 ))
- Correctly handle special char keyCodes with Shift
([`d537923`](https://togithub.com/emberjs/ember-test-helpers/commit/d537923 ))
- Add tab type test
([`64f40d5`](https://togithub.com/emberjs/ember-test-helpers/commit/64f40d5 ))
- Generate documentation
([`939f29f`](https://togithub.com/emberjs/ember-test-helpers/commit/939f29f ))
- Ensure types reflect optional-ness of tab options
([`95285cc`](https://togithub.com/emberjs/ember-test-helpers/commit/95285cc ))
- Fix typesVersions config again
([`53fa899`](https://togithub.com/emberjs/ember-test-helpers/commit/53fa899 ))
- Clean up public-types after pack
([`b9dcbca`](https://togithub.com/emberjs/ember-test-helpers/commit/b9dcbca ))
###
[`v2.9.0`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v290-2022-12-14 )
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.8.1...v2.9.0 )
##### 🚀 Enhancement
-
[#​1269](https://togithub.com/emberjs/ember-test-helpers/pull/1269 )
Re-export hasEmberVersion (and its type) from
[@​ember/test-helpers](https://togithub.com/ember/test-helpers )
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1278](https://togithub.com/emberjs/ember-test-helpers/pull/1278 )
perf: Remove excessive destroy call
([@​runspired](https://togithub.com/runspired ))
-
[#​1234](https://togithub.com/emberjs/ember-test-helpers/pull/1234 )
Introduce public TypeScript support
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### 🐛 Bug Fix
-
[#​1277](https://togithub.com/emberjs/ember-test-helpers/pull/1277 )
Actually publish .d.ts
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1270](https://togithub.com/emberjs/ember-test-helpers/pull/1270 )
Fix typesVersions path
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1233](https://togithub.com/emberjs/ember-test-helpers/pull/1233 )
Add more keyCode mappings ([@​CvX](https://togithub.com/CvX ))
##### 📝 Documentation
-
[#​1259](https://togithub.com/emberjs/ember-test-helpers/pull/1259 )
DOCS: API: publish docs for tab
([@​geneukum](https://togithub.com/geneukum ))
##### Committers: 5
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
- Chris Thoburn ([@​runspired](https://togithub.com/runspired ))
- Geordan Neukum ([@​geneukum](https://togithub.com/geneukum ))
- Jarek Radosz ([@​CvX](https://togithub.com/CvX ))
- Krystan HuffMenne
([@​gitKrystan](https://togithub.com/gitKrystan ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 18:04:35 +00:00
Daniel Lockyer
99c775be23
ℹ️ Bumped minimum Node version to 14.18.0
...
refs https://github.com/TryGhost/Toolbox/issues/488
- this is needed so we can bump some dependencies
- given how old these versions are, users should probably update past
this anyway
2023-01-03 18:54:39 +01:00
renovate[bot]
cd1cdd869f
Update dependency ember-in-viewport to v4.1.0 ( #15795 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-in-viewport](https://togithub.com/dockyard/ember-in-viewport ) |
[`4.0.2` ->
`4.1.0`](https://renovatebot.com/diffs/npm/ember-in-viewport/4.0.2/4.1.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>dockyard/ember-in-viewport</summary>
###
[`v4.1.0`](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0 )
[Compare
Source](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:51 +00:00
renovate[bot]
6f6f816077
Update dependency ember-css-transitions to v4.3.2 ( #15846 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[ember-css-transitions](https://miguelcobain.github.io/ember-css-transitions )
([source](https://togithub.com/miguelcobain/ember-css-transitions )) |
[`4.2.0` ->
`4.3.2`](https://renovatebot.com/diffs/npm/ember-css-transitions/4.2.0/4.3.2 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>miguelcobain/ember-css-transitions</summary>
###
[`v4.3.2`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v432-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.1...v4.3.2 )
##### 🐛 Bug Fix
-
[#​117](https://togithub.com/miguelcobain/ember-css-transitions/pull/117 )
Handle no ownConfig scenario (for real)
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
###
[`v4.3.1`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v431-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.0...v4.3.1 )
##### 🐛 Bug Fix
-
[#​116](https://togithub.com/miguelcobain/ember-css-transitions/pull/116 )
Handle no ownConfig scenario
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
###
[`v4.3.0`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v430-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.2.0...v4.3.0 )
##### 🚀 Enhancement
-
[#​113](https://togithub.com/miguelcobain/ember-css-transitions/pull/113 )
Add opt-in integration with
[@​ember/test-waiters](https://togithub.com/ember/test-waiters )
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​109](https://togithub.com/miguelcobain/ember-css-transitions/pull/109 )
Update glint import path to template-registry
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 📝 Documentation
-
[#​115](https://togithub.com/miguelcobain/ember-css-transitions/pull/115 )
Add Glint support page to docs
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 🏠 Internal
-
[#​114](https://togithub.com/miguelcobain/ember-css-transitions/pull/114 )
Fix flaky tests
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​112](https://togithub.com/miguelcobain/ember-css-transitions/pull/112 )
Rename addon folder to ember-css-transitions
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​111](https://togithub.com/miguelcobain/ember-css-transitions/pull/111 )
update v2 addon setup
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi40IiwidXBkYXRlZEluVmVyIjoiMzQuMjYuNCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:23 +00:00
renovate[bot]
5ff142bd49
Update dependency liquid-wormhole to v3 ( #16003 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [liquid-wormhole](https://togithub.com/pzuraq/liquid-wormhole ) |
[`2.1.5` ->
`3.0.0`](https://renovatebot.com/diffs/npm/liquid-wormhole/2.1.5/3.0.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>pzuraq/liquid-wormhole</summary>
###
[`v3.0.0`](https://togithub.com/pzuraq/liquid-wormhole/blob/HEAD/CHANGELOG.md#v300-2022-12-13 )
[Compare
Source](https://togithub.com/pzuraq/liquid-wormhole/compare/v2.1.5...v3.0.0 )
##### 💥 Breaking Change
- [#​75](https://togithub.com/pzuraq/liquid-wormhole/pull/75 )
Ember >= 3.24, node >= 14
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​72](https://togithub.com/pzuraq/liquid-wormhole/pull/72 )
Update liquid-fire, remove getowner polyfill
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​67](https://togithub.com/pzuraq/liquid-wormhole/pull/67 ) ci:
drop support for node 4.x and node 6.x
([@​alexdiliberto](https://togithub.com/alexdiliberto ))
##### 🚀 Enhancement
- [#​74](https://togithub.com/pzuraq/liquid-wormhole/pull/74 ) Add
Embroider support
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​73](https://togithub.com/pzuraq/liquid-wormhole/pull/73 )
Various Ember updates
([@​rwwagner90](https://togithub.com/rwwagner90 ))
##### Committers: 2
- Alex DiLiberto
([@​alexdiliberto](https://togithub.com/alexdiliberto ))
- Robert Wagner ([@​rwwagner90](https://togithub.com/rwwagner90 ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:21:58 +00:00
renovate[bot]
fe454d8a33
Update dependency @babel/plugin-proposal-decorators to v7.20.7 ( #16043 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@babel/plugin-proposal-decorators](https://babel.dev/docs/en/next/babel-plugin-proposal-decorators )
([source](https://togithub.com/babel/babel )) | [`7.20.5` ->
`7.20.7`](https://renovatebot.com/diffs/npm/@babel%2fplugin-proposal-decorators/7.20.5/7.20.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>babel/babel</summary>
###
[`v7.20.7`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7207-2022-12-22 )
[Compare
Source](https://togithub.com/babel/babel/compare/v7.20.5...v7.20.7 )
##### 👓 Spec Compliance
- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#​15223](https://togithub.com/babel/babel/pull/15223 ) fix:
Deleting super property should throw
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-helpers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`, `babel-plugin-transform-object-super`
- [#​15241](https://togithub.com/babel/babel/pull/15241 ) fix:
Throw correct error types from sed ant class TDZ helpers
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
##### 🐛 Bug Fix
- `babel-parser`, `babel-plugin-transform-typescript`
- [#​15209](https://togithub.com/babel/babel/pull/15209 ) fix:
Support auto accessors with TypeScript annotations
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-traverse`
- [#​15287](https://togithub.com/babel/babel/pull/15287 ) Fix
`.parentPath` after rename in `SwitchCase`
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-plugin-transform-typescript`, `babel-traverse`
- [#​15284](https://togithub.com/babel/babel/pull/15284 ) fix: Ts
import type and func with duplicate name
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-plugin-transform-block-scoping`
- [#​15278](https://togithub.com/babel/babel/pull/15278 ) Fix tdz
analysis for reassigned captured for bindings
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-plugin-proposal-async-generator-functions`, `babel-preset-env`
- [#​15235](https://togithub.com/babel/babel/pull/15235 ) fix:
Transform `for await` with shadowed variables
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-generator`, `babel-plugin-proposal-optional-chaining`
- [#​15258](https://togithub.com/babel/babel/pull/15258 ) fix:
Correctly generate `(a ?? b) as T`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-plugin-transform-react-jsx`, `babel-types`
- [#​15233](https://togithub.com/babel/babel/pull/15233 ) fix: Emit
correct sourcemap ranges for `JSXText`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-core`, `babel-helpers`,
`babel-plugin-transform-computed-properties`, `babel-runtime-corejs2`,
`babel-runtime-corejs3`, `babel-runtime`
- [#​15232](https://togithub.com/babel/babel/pull/15232 ) fix:
Computed properties should keep original definition order
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#​15223](https://togithub.com/babel/babel/pull/15223 ) fix:
Deleting super property should throw
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-generator`
- [#​15216](https://togithub.com/babel/babel/pull/15216 ) fix:
Print newlines for leading Comments of `TSEnumMember`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
##### 💅 Polish
- `babel-plugin-transform-block-scoping`, `babel-traverse`
- [#​15275](https://togithub.com/babel/babel/pull/15275 ) Improve
relative execution tracking in fn exprs
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
##### 🏠 Internal
- `babel-helper-define-map`, `babel-plugin-transform-property-mutators`
- [#​15274](https://togithub.com/babel/babel/pull/15274 ) Inline &
simplify `@babel/helper-define-map`
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-core`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-block-scoping`,
`babel-plugin-transform-classes`,
`babel-plugin-transform-destructuring`,
`babel-plugin-transform-parameters`,
`babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`,
`babel-preset-env`, `babel-traverse`
- [#​15200](https://togithub.com/babel/babel/pull/15200 ) Rewrite
`transform-block-scoping` plugin
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
##### 🏃♀️ Performance
- `babel-helper-compilation-targets`
- [#​15228](https://togithub.com/babel/babel/pull/15228 ) perf:
Speed up `getTargets`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:45:34 +00:00
renovate[bot]
e264616808
Update dependency ember-resolver to v8.1.0 ( #16035 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-resolver](https://togithub.com/ember-cli/ember-resolver ) |
[`8.0.3` ->
`8.1.0`](https://renovatebot.com/diffs/npm/ember-resolver/8.0.3/8.1.0 ) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>ember-cli/ember-resolver</summary>
###
[`v8.1.0`](https://togithub.com/ember-cli/ember-resolver/blob/HEAD/CHANGELOG.md#v810-2022-12-20 )
[Compare
Source](https://togithub.com/ember-cli/ember-resolver/compare/v8.0.3...v8.1.0 )
Back-ports built-in TypeScript support from 9.0.0 (see below) to
decouple that from the Ember 4.x upgrade.
##### 🚀 Enhancement
- [#​839](https://togithub.com/ember-cli/ember-resolver/pull/839 )
Backport types to 8.x
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### Committers: 1
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:38 +00:00
renovate[bot]
9955cdc3ba
Update dependency testem to v3.10.1 ( #16034 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [testem](https://togithub.com/testem/testem ) | [`3.10.0` ->
`3.10.1`](https://renovatebot.com/diffs/npm/testem/3.10.0/3.10.1 ) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>testem/testem</summary>
### [`v3.10.1`](https://togithub.com/testem/testem/releases/tag/v3.10.1 )
[Compare
Source](https://togithub.com/testem/testem/compare/v3.10.0...v3.10.1 )
#### What's Changed
- build(deps): bump socket.io from 4.5.3 to 4.5.4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1609 ](https://togithub.com/testem/testem/pull/1609 )
- build(deps-dev): bump sinon from 14.0.2 to 15.0.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1611 ](https://togithub.com/testem/testem/pull/1611 )
- build(deps-dev): bump socket.io-client from 4.5.3 to 4.5.4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1610 ](https://togithub.com/testem/testem/pull/1610 )
- build(deps-dev): bump eslint from 8.28.0 to 8.30.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1616 ](https://togithub.com/testem/testem/pull/1616 )
- build(deps-dev): bump sinon from 15.0.0 to 15.0.1 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1617 ](https://togithub.com/testem/testem/pull/1617 )
- Scope testem assets with a prefix by
[@​stepankuzmin](https://togithub.com/stepankuzmin ) in
[https://github.com/testem/testem/pull/1615 ](https://togithub.com/testem/testem/pull/1615 )
#### New Contributors
- [@​stepankuzmin](https://togithub.com/stepankuzmin ) made their
first contribution in
[https://github.com/testem/testem/pull/1615 ](https://togithub.com/testem/testem/pull/1615 )
**Full Changelog**:
https://github.com/testem/testem/compare/v3.10.0...v3.10.1
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4wIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:07 +00:00
renovate[bot]
bde3dc8087
Update dependency ember-basic-dropdown to v6.0.2 ( #15809 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-basic-dropdown](http://ember-basic-dropdown.com )
([source](https://togithub.com/cibernox/ember-basic-dropdown )) |
[`6.0.1` ->
`6.0.2`](https://renovatebot.com/diffs/npm/ember-basic-dropdown/6.0.1/6.0.2 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>cibernox/ember-basic-dropdown</summary>
###
[`v6.0.2`](https://togithub.com/cibernox/ember-basic-dropdown/blob/HEAD/CHANGELOG.md#​602 )
[Compare
Source](https://togithub.com/cibernox/ember-basic-dropdown/compare/v6.0.1...d6395e07adfa13037617fd2b051623d2f9bfde58 )
- Relax dependency on ember-style-modifier so version 1.0 is also
allowed
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMS42IiwidXBkYXRlZEluVmVyIjoiMzQuMjEuNiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:39:21 +00:00
renovate[bot]
be31f8e9fe
Update dependency @embroider/macros to v1.10.0 ( #15874 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@embroider/macros](https://togithub.com/embroider-build/embroider ) |
[`1.9.0` ->
`1.10.0`](https://renovatebot.com/diffs/npm/@embroider%2fmacros/1.9.0/1.10.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>embroider-build/embroider</summary>
###
[`v1.10.0`](https://togithub.com/embroider-build/embroider/blob/HEAD/CHANGELOG.md#embroidermacros-190---1100 )
- BUGFIX: template macros could have pre-moved appRoot in their
packageCache
- ENHANCEMENT: expose simplified transforms API for use with
babel-plugin-ember-template-compilation
Previously, we used MacrosConfig.astTransforms() which gave you
transforms in
the reverse order they were expected to run, for compatibility with the
wacky
ordering in class ember-cli-htmlbars. Now we also offer
`MacrosConfig.transforms()` which provides them in a format compatible
directly with babel-plugin-ember-template-compilation 2.0, which uses
the more natural order and which supports
plugins-as-strings-to-be-loaded in addition to just plain functions.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:38:47 +00:00
renovate[bot]
435d5da3ff
Update sentry-javascript monorepo to v7.28.1
2023-01-03 14:27:06 +01:00
Kevin Ansfield
581f0b34b4
🐛 Fixed missing validation of offer amounts in the admin panel ( #16022 )
...
closes https://github.com/TryGhost/Team/issues/2380
- improved offer validation for `amount` field to cover all type/amount cases
- added validate-on-blur to the amount field to match our standard validation behaviour
- added re-validation of the amount field when the type is changed and the amount gets reset
- removed the internal parsing of a decimal trial days entry to an integer so the field value matches what is set internally and we let the user know that partial trial days are not supported
Non-user-facing refactors:
- renamed `_saveOfferProperty` to `_updateOfferProperty` to better reflect what it does
- fixed missing indentation for conditional blocks in the offer template
2023-01-03 09:23:11 +00:00
renovate[bot]
c0b700147e
Update dependency eslint to v8.31.0
2023-01-03 07:22:01 +00:00
Ghost CI
65252c361a
v5.26.4
2022-12-30 16:00:45 +00:00
Ghost CI
85db1838d9
v5.26.3
2022-12-23 16:01:11 +00:00
Ghost CI
42f5743e86
v5.26.2
2022-12-20 12:15:51 +00:00
Ghost CI
1f5a752b71
v5.26.1
2022-12-16 16:01:00 +00:00
Ghost CI
26be3b9ccd
v5.26.0
2022-12-16 12:49:22 +00:00
Simon Backx
6a266be239
🐛 Fixed archived offers return button not working ( #16023 )
...
fixes https://github.com/TryGhost/Team/issues/2374
When clicking 'Show active offers' in the archived offers view, it would
always return to an empty offers list, even when there are active
offers.
2022-12-16 11:32:05 +01:00
Sodbileg Gansukh
74cb362f87
✨ Added theme docs link to the design settings ( #16014 )
...
no refs
- this adds a theme documentation link to the design settings footer if there's an URL set in the package.json of the theme. An example of the package.json property: "docs": "https://example.com "
2022-12-15 20:06:08 +08:00
Ronald Langeveld
ce53c76fdf
✨ Added newsletter subscription filtering to members ( #16006 )
...
closes https://github.com/TryGhost/Team/issues/2012
- Members can now be filtered based on the newsletters they are
subscribed to.
- Defaults to the existing newsletter filtering if user does not have
more than 1 newsletter.
2022-12-15 16:06:47 +07:00
Ghost CI
64e44444c1
v5.25.5
2022-12-14 17:21:38 +00:00
Elena Baidakova
00c2b71502
🐛 Fixed slug saving in editor ( #16007 )
...
refs TryGhost/Team#2294
- If user enter the slug name and then leave the post page, we should
wait until the slug would be saved on backend. The problem can be
reproduced with slow internet connection.
2022-12-14 19:39:01 +04:00
Kevin Ansfield
a69ffb94c1
Added playwright test for publishing posts for specific tiers
...
refs https://github.com/TryGhost/Team/issues/2371
- test publishes a post with access for a single tier then checks the front-end with no member, member on wrong tier, and member on right tier
2022-12-14 12:20:55 +00:00
Kevin Ansfield
8e7d6400b0
Updated .lint-todo file
...
refs c3487fea41
2022-12-14 12:09:33 +00:00
Kevin Ansfield
b402b1643e
Prevented throwing errors unnecessarily in editor plus menu and link toolbar
...
closes sentry Admin-423
- there may be times when the mousemove event handler fires when the document is not in a ready state resulting in an attempt to get a document position that doesn't exist
- should fix `Could not find parent section from element node` errors
2022-12-14 11:57:54 +00:00
Kevin Ansfield
c3487fea41
Refactored <GhBenefitItem>
...
refs https://github.com/TryGhost/Ghost/issues/14101
- migrated component to Glimmer
- swapped usage of `ValidationState` mixin for `{{validation-status}}` modifier
- updated modifier to accept custom error/success classes
- removed unnecessary/unused code in the `gh-benefit-item.js` backing class
2022-12-14 11:57:54 +00:00
Rishabh
25c530293f
Added playwright tests for forever and multiple month offers
...
- adds test that cover creating and signing up to multiple-month/forever offers
- checks that the offer information is shown to members during signup and in account detail
2022-12-14 17:13:20 +05:30
Daniel Lockyer
6f4e663d74
Updated @tryghost dependencies ( #16005 )
...
- also includes `knex-migrator` with a simple `sqlite3` bump
2022-12-14 11:18:55 +07:00
renovate[bot]
7c3dc6f3ed
Update sentry-javascript monorepo to v7.26.0
2022-12-14 08:07:58 +07:00
Daniel Lockyer
0482db4818
Merged v5.25.4 into main
2022-12-14 07:25:47 +07:00
Ghost CI
fa9f6007bf
v5.25.4
2022-12-13 15:16:49 +00:00
Sodbileg Gansukh
6878b18341
Added Taste and Episode themes ( #15991 )
...
no refs
- added two new themes, Taste and Episode to the admin
- updated theme screenshots that weren't up-to-date with the latest changes added to the themes
- some theme screenshot files were JPGs and replaced them with PNGs for consistency
2022-12-13 23:03:21 +08:00
Elena Baidakova
1c74d3304a
Added url to help doc for disabled emails ( #15993 )
...
refs TryGhost/Team#2323
2022-12-13 12:57:51 +04:00
renovate[bot]
f94d8fdcc2
Update dependency fs-extra to v11
2022-12-13 10:59:55 +07:00
renovate[bot]
a8610b524b
Update sentry-javascript monorepo to v7.25.0
2022-12-13 10:59:06 +07:00
Elena Baidakova
88b056dc86
Added Playwright member's actions tests ( #15968 )
...
refs TryGhost/Team#2371
- check that members can unsubscribe from newsletters by toggling
preferences in their account settings
- check that member can log out
2022-12-12 10:13:08 +04:00
renovate[bot]
3550c629e4
Update dependency ember-auto-import to v2.5.0
2022-12-12 11:17:40 +07:00
renovate[bot]
1fc553e258
Update sentry-javascript monorepo to v7.24.2
2022-12-12 10:42:56 +07:00
Ghost CI
8d7aa3079f
v5.25.3
2022-12-09 16:01:15 +00:00
Kevin Ansfield
9fd87f565d
Migrated <GhValidationStatusContainer> to {{validation-status}} modifier
...
no issue
- moved logic from `<GhValidationStatusContainer>` to a new `validation-status` modifier
- removes a usage of the `ValidationState` mixin
- migrated uses of the component to a mixin
- paves the way for full removal of the `ValidationState` mixin in later refactors (mixins are deprecated)
- migrated `<GhFormGroup>` to a glimmer component
- swapped the extend of `GhValidationStatusContainer` to usage of the `validation-status` modifier with a template-only component
- updated all `<GhFormGroup>` to use the standard `class=""` instead of `@classNames=""` and `@class=""`
- allows `data-test-*` attributes to be added to uses of `<FormGroup>` to help when complex components are grouped as a form input
2022-12-09 12:38:35 +00:00
Sanne de Vries
9b819698e8
Fixed title attributes on headings in editor toolbar
...
No ref
2022-12-09 10:10:34 +07:00
Simon Backx
e7572fc111
Added Playwright test for disabled subscription access
...
refs https://github.com/TryGhost/Team/issues/2371
Portal should be disabled on the frontend, sending as a newsletter should no longer be an option when publishing
2022-12-08 17:58:03 +01:00
Djordje Vlaisavljevic
82aa9522dc
Added playwright test for updating atier
...
refs TryGhost/Team#2371
- Tests that tier details can be updated
- Tests that the updates are reflected in Portal
2022-12-08 17:40:42 +01:00
Sanne de Vries
0ebb3cbefe
Added Playwright "Post visibility" tests
...
Refs https://github.com/TryGhost/Team/issues/2371
- Tests whether the post access selection of public, members, or paid-members matches the expected post visibility on the frontend.
2022-12-08 11:26:44 +07:00
Simon Backx
b615c9f7d2
Added post scheduling Playwright test and loosened time restrictions ( #15960 )
...
refs https://github.com/TryGhost/Team/issues/2371
- Adds a test that schedules a post 5 seconds in the future and waits
for it to be published
- Reduced the time restrictions for scheduling:
- The minimum time in the frontend is now 5 seconds in the future (came
from 5 minutes in the future)
- The time picker now suggests 10 minutes in the future instead of the
minimum scheduling time (came from 5 minutes)
- In the backend, a post will be allowed to be scheduled if it is at
least 2 minutes in the past (came from 2 minutes in the future)
- The scheduler will publish a post if it is at least 5 minutes in the
past, and maximum 5 minutes in the future (came from 2 minutes)
2022-12-07 17:29:36 +01:00
Djordje Vlaisavljevic
2464d45b4a
Added playwright test for creating additional tier
...
refs TryGhost/Team#2371
- Tests that an additional tier can be created and that it'll appear in portal settings unselected by default
2022-12-07 17:26:11 +01:00
Rishabh Garg
b6db85a5d6
Added playwright test for free member upgrade via portal ( #15961 )
...
refs https://github.com/TryGhost/Team/issues/2371
- tests that a free member can upgrade to a paid tier via stripe checkout and the payment details are reflected in portal and member detail page on admin
2022-12-07 21:41:55 +05:30
Ghost CI
e323d6162c
Merged v5.25.2 into main
2022-12-07 09:04:25 +00:00
Ghost CI
a014817aa9
v5.25.2
2022-12-07 09:04:22 +00:00
Kevin Ansfield
df6de75c80
Disabled stripping of test selectors in all builds
...
no issue
- we want to run e2e tests against production Ghost instances and having test selectors available means much less brittle tests
- only real impact from keeping the selectors is extra file size in production builds but that is minimal (~6KB gzipped at time of commit)
2022-12-07 08:54:04 +00:00
Ronald Langeveld
a302e8289f
Added Unsplash API config to Lexical ( #15948 )
...
no issue
- added default headers and app_id for React-Koenig-Lexical to consume.
2022-12-07 09:20:11 +07:00
Kevin Ansfield
1f06407878
Fixed "Cannot destructure property 'ratio'" errors
...
sentry ADMIN-C05
- resizing the window (or changing orientation) when viewing a single photo inside the Unsplash image selector was throwing errors because the event handler `setZoomedSize()` call was not passed the same arguments as the typical call made in `modify()`
- moved the `element` and `ratio` properties onto the class so they are preserved and ready to be used without being explicitly passed in when `setZoomedSize()` is called as part of an event
2022-12-06 17:23:38 +00:00
Kevin Ansfield
65de55ae89
Fixed unnecessary identity requests and 403s for non-Owner accounts ( #15949 )
...
no issue
`<GhBillingIframe>` generates a request to the `/identities/` endpoint every time Admin is accessed for all users, however that endpoint is only accessible to users with the Owner role meaning we have a lot of unnecessary 403 errors in event logs and the developer console.
- added early exit when we know the logged in user doesn't have the Owner role
- removed the subscription fetching code that wasn't reachable (`token` was always `undefined`)
- the BMA sends subscription data as soon as it's available so the extra fetch isn't necessary
2022-12-06 15:20:57 +00:00
Kevin Ansfield
b68686fe9c
Fixed 403 newsletters request for contributors when opening editor
...
closes https://github.com/TryGhost/Team/issues/2242
Contributors don't have permission to fetch `/newsletters/` but the publish flow was sending a request every time a contributor opened a post in the editor creating noise in event logs and in the developer console.
- disabled the newsletters fetch when the logged in user is a contributor
- contributors can't publish so the "missing" data has no effect on the publish flow as it's not used
2022-12-06 11:18:29 +00:00
Simon Backx
58ba154ed7
🐛 Hid the analtyics page for editors
...
fixes https://github.com/TryGhost/Team/issues/2302
The analytics page should not be visible for Editors (and doesn't work currently anyway). This commit removes the button that goes to the analytics page for editors and authors.
2022-12-06 11:10:58 +01:00
Ghost CI
54b693a359
Merged v5.25.1 into main
2022-12-06 05:14:41 +00:00
Ghost CI
55b0f564ba
v5.25.1
2022-12-06 05:14:37 +00:00
Kevin Ansfield
1685a84a27
Fixed incorrect property access
...
refs 0e181c84b2
2022-12-05 17:17:47 +00:00
Kevin Ansfield
0e181c84b2
Added user role to captured Sentry data
...
closes https://github.com/TryGhost/Team/issues/2241
- as part of the authenticated application setup, update the captured Sentry data with the user role
- helps narrow things down when we see permission errors pop up due to requests being made for endpoints that the current user doesn't have permission to access
2022-12-05 17:15:55 +00:00
Kevin Ansfield
3817f583fa
🐛 Fixed unexpected "unsaved changes" modal when deleting a member
...
closes https://github.com/TryGhost/Team/issues/2275
When deleting a member, after confirming deletion another "unsaved changes" modal popped up. From that point, if you clicked to stay you remained on the member screen with stale data (the member was still deleted) resulting in further errors when any attempt to make changes was made.
- prevented the unsaved changes check running for a deleted member because it would always return `true` in that case
- ensured the data setup for the unsaved changes check still occurs when a member is accessed directly via the URL
- previously it was skipped because the data setup only occurred inside `fetchMemberTask` but that isn't called when the route already loaded the model via it's `model()` hook
2022-12-05 11:48:37 +00:00
Elena Baidakova
0caf8bff18
Renamed all references to "Flagged as spam email" ( #15938 )
...
closes TryGhost/Team#2352
2022-12-05 12:07:26 +04:00
Elena Baidakova
f09ed78af2
Fixing the misalignment of avatar between member activity and member detail ( #15939 )
...
closes TryGhost/Team#2356
2022-12-05 11:59:17 +04:00
renovate[bot]
cdca9d73b3
Update Test & linting packages
2022-12-02 23:05:46 +00:00
Rishabh
e74ba81276
Refined email debug screen error handling
...
refs https://github.com/TryGhost/Team/issues/2327
2022-12-02 21:29:07 +05:30
Simon Backx
6ae9b49e73
Added post title to email debug page
2022-12-02 16:51:51 +01:00
Peter Zimon
cd5a85021a
Fixed member name alignment on email debug screen
...
refs. https://github.com/TryGhost/Team/issues/2327
- on the first two tabs of the email debug screen, the member email wasn't aligned properly when there was no name for a member
2022-12-02 16:16:01 +01:00
Rishabh
ddb61c3b3c
Wired static expand error logic on email debug
...
refs https://github.com/TryGhost/Team/issues/2327
- wires the static handling of error message on debug screen with real error
2022-12-02 20:41:08 +05:30
Ghost CI
d9ed6bcdb8
v5.25.0
2022-12-02 15:00:48 +00:00
Peter Zimon
768ba2be50
Minor UI fixes on email debug screen
...
refs. https://github.com/TryGhost/Team/issues/2327
2022-12-02 15:49:23 +01:00
Peter Zimon
c7600407bd
Fixed text color bug in box button links
2022-12-02 15:46:52 +01:00
Peter Zimon
f562d19f3c
Updated error display styles for error debug
...
refs. https://github.com/TryGhost/Team/issues/2327
- Some minor CSS style changes were needed for errors on the email debug screen. Also we weren't showing any message i - for whatever reason - there was no data for batches.
2022-12-02 15:13:07 +01:00
renovate[bot]
c7d10c2d49
Update Node.js to v18
2022-12-02 14:07:37 +00:00
Simon Backx
fc12767917
Wired up retry button on debug page
2022-12-02 14:57:03 +01:00
Peter Zimon
e0c52d0670
Added static expand error logic to email debug
...
refs. https://github.com/TryGhost/Team/issues/2327
- The length of the error messages for temporary and permanent failure tabs on the email debug screen can be arbitrary. This degrades scannability and limits the number of displayed rows in the list. Adding an expand button to the error message makes sense since the errors might repeat and the error code + the beginning of the message can be enough to understand them. Also this allows more rows to be displayed per screen.
2022-12-02 14:49:28 +01:00
Simon Backx
b81cc13e48
Fixed email batches and recipient pagination
2022-12-02 14:49:21 +01:00
Simon Backx
928a73c536
Fixed email debug page always showing error + breadcrumb
2022-12-02 14:45:06 +01:00
Peter Zimon
9b276e6aa2
Added empty state handling to email debug tabs
...
refs. https://github.com/TryGhost/Team/issues/2327
- the lists and tables were completely empty when there was no error or some data was missing
2022-12-02 13:34:30 +01:00
Rishabh
cee94217a8
Fixed lint
2022-12-02 16:22:59 +05:30
Rishabh
d82cfb1d57
Updated static error message on debug screen
...
refs https://github.com/TryGhost/Team/issues/2327
- updates major error message on email debug screen from the email model
2022-12-02 16:12:48 +05:30
Rishabh Garg
a8a879ef53
Wired email debug screen with API ( #15919 )
...
refs https://github.com/TryGhost/Team/issues/2327
- wires email debug screen with real data from API
- fetches email batch data for showing all batches along with those errored
- fetches all recipient failures - temporary and permanent
- shows email settings that was used for sending out the email
2022-12-02 14:38:40 +05:30
renovate[bot]
46bb38b18a
Update sentry-javascript monorepo to v7.23.0
2022-12-02 11:59:31 +07:00
Peter Zimon
7df63d67b4
Added static "Settings" tab to debug screen
...
refs. https://github.com/TryGhost/Team/issues/2327
- there was only a placeholder for the Settings tab, this adds the structure so we can test and wire in dynamic data
2022-12-01 18:14:55 +01:00
Kevin Ansfield
a855973ac6
Wired up top-of-document handling in Lexical editor
...
closes https://github.com/TryGhost/Team/issues/2285
- added passthrough of `cursorDidExitAtTop` action so the editor can trigger title input focus on key commands that trigger the cursor to leave the top of document
2022-12-01 16:46:06 +00:00
Peter Zimon
a51f3a124d
Added static batch errors to error debug
...
refs. https://github.com/TryGhost/Team/issues/2327
- the batch errors tab content was just a placeholder, this adds static version to be able to test and wire it in
2022-12-01 17:30:13 +01:00
Peter Zimon
dee00e36a0
Added static UI to email debug screen
...
refs. https://github.com/TryGhost/Team/issues/2327
- static UI was needed on the email debug screen for testing and backend wiring
2022-12-01 15:13:48 +01:00
Fabien "egg" O'Carroll
6849a4ef66
Removed mock data from event fetcher
...
closes https://github.com/TryGhost/Team/issues/2277
This data is no longer needed since we wired up to the mailgun implementation
2022-12-01 20:19:59 +07:00
Rishabh Garg
a5ca64f693
Added basic email debug design ( #15914 )
...
refs https://github.com/TryGhost/Team/issues/2327
As part of improving visibility for email failures, this change adds a new debug screen that allows visualising the email failures for a post. The screen is hidden on the UI for now and only accessible via URL directly.
Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
2022-12-01 17:58:37 +05:30
Kevin Ansfield
a1ee04b08f
Wired up title->editor keyboard handling in Lexical editor
...
closes https://github.com/TryGhost/Team/issues/2286
- use the `registerAPI` prop to get access to a basic API for focusing and inserting paragraphs
- replaced commented mobiledoc based title key handling with lexical handling
2022-11-30 22:04:02 +00:00
Elena Baidakova
95c3a68c34
Updated the filter naming in Post Analytics ( #15898 )
...
closes TryGhost/Team#2329
- Replace 'Received' on 'Sent' in member's filter
- Moved links for feedback analytics from chart to table
2022-11-30 17:39:37 +04:00
renovate[bot]
40c4ae4e00
Update dependency @babel/plugin-proposal-decorators to v7.20.5
2022-11-30 12:28:57 +07:00
Elena Baidakova
86abab4f1d
Remove member's activity double scrolling ( #15897 )
...
closes TryGhost/Team#2325
2022-11-29 16:08:11 +04:00
Ghost CI
4a3ac50a82
Merged v5.24.2 into main
2022-11-28 17:36:37 +00:00
Ghost CI
a176d1d36f
v5.24.2
2022-11-28 17:36:34 +00:00
Elena Baidakova
1b784b5ec5
Added events to Post Analytics page ( #15886 )
...
closes TryGhost/Team#2313
- Added Sent event to Post analytics and Members feed. Now post can be
Sent or Received or Bounced.
- Excluded Delivered event from Sent filter on backend.
2022-11-28 17:43:35 +04:00
Elena Baidakova
fbf761b0ac
Fixed post title in the filter dropdown on the Members page ( #15884 )
...
closes TryGhost/Team#2265
2022-11-28 16:47:50 +04:00
Ghost CI
d9b4057fe1
Merged v5.24.1 into main
2022-11-28 11:51:06 +00:00
Ghost CI
2a28fa411b
v5.24.1
2022-11-28 11:51:02 +00:00
Elena Baidakova
1161ab98f9
Rename column to Sent on Dashboard ( #15883 )
...
closes TryGhost/Team#2321
2022-11-28 11:22:35 +04:00
Ghost CI
e1279c74b4
v5.24.0
2022-11-25 15:00:47 +00:00
Kevin Ansfield
d4ea9c877d
Fixed editor key commands throwing errors when range has no section
...
closes Sentry ADMIN-CC8
closes Sentry ADMIN-DDM
closes Sentry ADMIN-C9F
- there are situations where the editor range when key commands are triggered does not have a head section which then throws errors due to the commands assuming there will always be a section present
- added a guard to key commands that use the head section to abort early and fall back to default Mobiledoc behaviour when the section is missing
2022-11-25 08:56:38 +00:00
Elena Baidakova
0bdccb6497
Update member activity dropdown ( #15875 )
...
closes TryGhost/Team#2250
2022-11-24 20:21:43 +04:00
Kevin Ansfield
ef71d52ec0
Fixed Cannot read properties of null (reading 'offsetHeight') errors in markdown card
...
closes sentry ADMIN-CAV
- the mobile nav element is not always displayed so we should assume we can read it's `offsetHeight` property
2022-11-24 12:52:16 +00:00
Kevin Ansfield
37d9e8bb8b
Fixed Cannot set properties of null (setting 'scrollTop') errors in <GhHtmlIframe>
...
closes sentry ADMIN-C7S
- we can't guarantee that the iframe being swapped to has rendered yet at the time we swap iframes so we need a guard around the `contentDocument.body` property existing before setting it's `scrollTop` value
2022-11-24 12:52:16 +00:00
Elena Baidakova
54f075b330
Update the suppression notice front-end ( #15869 )
...
closes TryGhost/Team#2288
2022-11-24 10:02:57 +04:00
Hannah Wolfe
e4dbf9b0fd
Updated error fallbacks to generic error message
...
refs: https://github.com/TryGhost/Team/issues/1121
- We've decided on one preferred message for unexpected errors
- We want to use this everywhere where we don't know what to display
- We now have a GENERIC_ERROR_MESSAGE constant that we should use
2022-11-23 21:49:40 +00:00
Elena Baidakova
e1ba0f6a2d
Fixed member avatar size ( #15871 )
...
closes TryGhost/Team#2279
2022-11-23 20:01:23 +04:00
Hannah Wolfe
32353f2920
Removed detail rule from showAPIError
...
refs: https://github.com/TryGhost/Team/issues/1121
- showAPIError is a method intended for formatting errors from the Ghost API
- Ghost API Errors do not have a detail field, therefore this code was redundant
- there are also no related tests
- removing now because I'm trying to cleanup and streamline all our error handling code
2022-11-23 15:56:58 +00:00
Hannah Wolfe
c740eecaec
Fixed duplicate error messages from API
...
refs: https://github.com/TryGhost/Team/issues/1121
- In certain cases our API sends the same data for message and context.
- We will also fix this server-side, but we should also be smart in the UI and not show duplicate info
2022-11-23 15:56:58 +00:00
renovate[bot]
0ca3031df1
Update sentry-javascript monorepo to v7.21.1
2022-11-23 15:15:14 +00:00
Kevin Ansfield
9ceecba5fd
Added TransitionAborted errors to Sentry's ignore list
...
no issue
- "unhandled" `TransitionAborted` errors almost always occur as part of expected application behaviour and were causing a lot of noise in Sentry making it harder to track down real errors
- when a `TransitionAborted` error occurs outside of expected behaviour it will usually be accompanied by other errors that do get logged
- there's a long-standing Ember issue about how aborted transition errors should be handled at https://github.com/emberjs/ember.js/issues/12505
2022-11-23 13:23:47 +00:00
Kevin Ansfield
d15f740a3f
Fixed TaskCancelation errors
...
sentry issue: ADMIN-AY5
- added guards for cancelation errors where we're casting tasks to promises
- see http://ember-concurrency.com/docs/task-cancelation-help for full details
2022-11-23 10:42:40 +00:00
renovate[bot]
e4e8df44dd
Update sentry-javascript monorepo to v7.21.0
2022-11-23 12:29:15 +07:00
Kevin Ansfield
3a9209b6a8
Fixed some minor formatting issues
...
no issue
- indented conditional template code
- grouped tracked properties together
2022-11-22 13:15:08 +00:00
Kevin Ansfield
f25cc00236
Fixed product card throwing "Cannot read properties of undefined (reading 'url')" errors
...
closes https://github.com/TryGhost/Team/issues/2295
Problem:
- `<GhUploader>` is not yet converted to an Octane component so it's arguments are not read-only
- when a file is selected it sets it's `files` property which in turn updates the tracked `files` property that was passed in, and then again updates it to an empty file list when the input field is cleared
- that tracked property was never cleared once the product image was uploaded resulting in a "re-upload" attempt with an empty file list every time the product card was put back into edit mode
Fix:
- added a guard in `<GhUploader>` so it doesn't try to upload an empty file list if one is passed in as an attribute
- added a reset of the tracked `files` property in the product card once the image upload is complete
2022-11-22 13:13:42 +00:00
renovate[bot]
955605572e
Update dependency testem to v3.10.0
2022-11-22 17:38:30 +07:00
Elena Baidakova
48a47a8289
Removed duplicate icons for events ( #15854 )
...
closes TryGhost/Team#2264
2022-11-21 14:50:39 +04:00
Ronald Langeveld
c70a1f262d
Added image upload progress to Koenig-Lexical-Editor ( #15852 )
...
ref https://github.com/TryGhost/Team/issues/2237
- Adds an upload progress function, to be used with Koenig-Lexical.
2022-11-21 10:52:37 +07:00
renovate[bot]
0c2a62f47c
Update Test & linting packages
2022-11-18 23:04:37 +00:00
Ghost CI
a3376fe502
v5.23.0
2022-11-18 15:00:50 +00:00
Simon Backx
6c84e10e46
Added email stability feature flag
...
no issue
2022-11-18 15:46:18 +01:00
Elena Baidakova
696cdea4d9
Add member's email status on member page ( #15844 )
...
closes TryGhost/Team#2270
- Show emails status depending on the reason email was blocked
(spam/fail)
2022-11-18 15:55:21 +04:00
Elena Baidakova
9d6bcdba47
Added spam event to feed in frontend admin ( #15847 )
...
closes TryGhost/Team#2248
2022-11-18 14:33:48 +04:00
Ronald Langeveld
08232bd538
Cleaned up GA Flags ( #15762 )
...
closes https://github.com/TryGhost/Team/issues/2126
- Cleaned up the following GA flags: `newsletterPaywall`, `freeTrial`, `compExpiring`, `searchHelper`, `emailAlerts`, `fixNewsletterLinks`.
2022-11-18 16:09:25 +07:00
renovate[bot]
426c515f83
Update dependency ember-template-lint to v4.18.2
2022-11-18 01:29:10 +00:00
Hannah Wolfe
dfffa309a8
Improved member importer error handling ( #15843 )
...
refs: https://github.com/TryGhost/Team/issues/1121
- This makes several key changes to the way errors are handled in the member importer, to ensure that we only show error messages to users that we wrote.
- Fundamentally, we no longer trust all API errors, and instead only trust a set of very specific API errors. Anything outside of that is replaced with a generic error message.
- Also switches the server-side error generated for email verification (which can throw during member import) to be a HostLimitError, as that is a more appropriate class.
- Note: there are many other parts of Ghost admin that need a similar overhaul, and a similar change we need to introduce server side to fully resolve the underlying issue of bubbling up code errors to the UI.
2022-11-17 19:41:39 +00:00
Peter Zimon
5bb2b2c614
Added modal-import-content to lint todo
2022-11-17 18:15:17 +01:00
Peter Zimon
75fea80de6
Fixed screen flicker in content import modal
...
no refs.
- the "Uploading" step on the content import modal was empty which resulted in a quick flicker during upload.
2022-11-17 18:11:11 +01:00
Sam Lord
bbbef3555f
Fixed lint-todo file after rebase
...
no issue
2022-11-17 14:40:24 +00:00
Rishabh
26aa19c36a
Added import modal lint errors to todo
2022-11-17 14:40:24 +00:00
Rishabh
3c5b523a43
Revert "Updated ember action usage"
...
This reverts commit 31b4d34b90
2022-11-17 14:40:24 +00:00
Rishabh
9dea8f13d8
Updated ember action usage
2022-11-17 14:40:24 +00:00
Sam Lord
881f0b33be
Fixed lint issues
...
no issue
2022-11-17 14:40:24 +00:00
Peter Zimon
4068d8c65c
Fixed content importer UI logic and email
...
- `result` parameter was wrongly passed to email
- email subject condition was reversed
- udpated email copy (still WIP)
- removed console.log from admin file selector
2022-11-17 14:40:24 +00:00
Sam Lord
4fb05ab165
Prevent warnings from being displayed in email after content import
...
no issue
Warnings that aren't useful shouldn't be displayed, especially when this is likely someone's first experience of Ghost.
2022-11-17 14:40:24 +00:00
Peter Zimon
d0c2af7a15
Fixed API params
2022-11-17 14:40:24 +00:00
Peter Zimon
739efa5a36
Fixed file upload bug
2022-11-17 14:40:24 +00:00
Peter Zimon
3eaa00bddb
Restructured modal open logic
...
no refs.
- Navigating to `/settings/labs/import` opened the modal but also transitioned to a blank page in the background. Restructured content import modal so it's opening on top of the Labs page.
2022-11-17 14:40:24 +00:00
Sam Lord
5619348c26
Replaced "Open Importer" button with one that works
...
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
d5f8a2b59d
WIP importer modal
...
no issue
2022-11-17 14:40:24 +00:00
Ronald Langeveld
e0787b4e83
✨ Added specific newsletter support for bulk unsubscribes ( #15742 )
...
closes https://github.com/TryGhost/Team/issues/2013
Added support to bulk unsubscribe a selected (filtered) list on members from specific, selected newsletters.
2022-11-16 14:29:00 +07:00
renovate[bot]
72b57db2e8
Update dependency ember-template-lint to v4.18.1
2022-11-15 14:11:52 +00:00
Ghost CI
b2bcfb24e3
Merged v5.22.11 into main
2022-11-15 14:08:47 +00:00
Ghost CI
0b7f64604e
v5.22.11
2022-11-15 14:08:44 +00:00
Simon Backx
cdccf5c46a
Reduced default post relations ( #15798 )
...
fixes https://github.com/TryGhost/Team/issues/2085
Don't load relations we don't need anymore for the posts table. And
reload the individual post when we open the analytics page with more
relations that we actually need.
2022-11-15 10:17:26 +01:00
Elena Baidakova
2d61d5e94e
Added suppression list feature flag ( #15821 )
...
closes TryGhost/Team#2247
2022-11-14 16:50:19 +04:00
Kevin Ansfield
17932759d3
Re-generated .lint-todo
...
no issue
- cleans up completed todo's and extends the ignore->warn period
2022-11-14 09:55:34 +00:00
Kevin Ansfield
f92c62b59a
Switched API key regeneration modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
- migrated Zapier controller to native class syntax
- fixed regeneration confirmation text not being visible on Zapier screen
2022-11-14 09:55:34 +00:00
Kevin Ansfield
283babe574
Removed unused early-access modal
...
no issue
- modal was added when tiers were first introduced as a beta feature but is no longer being used
2022-11-14 09:55:34 +00:00
Kevin Ansfield
332dd4fbf1
Switched editor re-authenticate modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
- simplified unauthed save behaviour because we now have a promise for the modal enabling us to wait for the modal to close before continuing
2022-11-14 09:55:34 +00:00
Kevin Ansfield
f74913cfb6
Switched snippet update modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-11-14 09:55:34 +00:00
Kevin Ansfield
d4398cacf7
Switched publish limit upgrade modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-11-14 09:55:34 +00:00
James Morris
42bf847142
Cleaning up and formalizing how events show across all activity feeds
...
- There was some formatting problems on the Dashboard with certain events
- There was inconsitencies with how we formatted some events over others
- Removed 'on' and just using '-' for all
refs https://github.com/TryGhost/Team/issues/2243
2022-11-11 15:18:03 +00:00
Ghost CI
718657a8f4
v5.22.10
2022-11-11 15:00:40 +00:00
Kevin Ansfield
2d6f48093e
Renamed {{scroll-to}}'s shouldScroll argument to when
...
no issue
- `when` makes the modifier a little easier to read for it's typical use-case, eg:
- `{{scroll-to when=(eq entry.slug this.entry)}}`
- `{{scroll-to when=(eq this.focusArea "analytics")}}`
2022-11-11 11:53:53 +00:00
Kevin Ansfield
8ae28ed309
Copied "from analytics" changes over to lexical editor
...
no issue
- changes were made to the default editor to adjust the header nav options when accessed from an analytics page but they weren't copied over to the duplicate editor route/controller we use for the in-development lexical editor
2022-11-11 09:49:26 +00:00
Simon Backx
28e4eb60ae
🐛 Fixed offer links with an archived tier ( #15792 )
...
refs https://github.com/TryGhost/Team/issues/2233
**Problem**
When a user clicks an offer link that has an archived tier, the site
blocks and you are no longer able to scroll. This is because the product
for that offer can't be found. This has been fixed by updating the
`isActiveOffer` helper to also check for the existence of the
corresponding tier.
**Solution**
- You no longer are able to create new offers if there are no active
tiers
- A custom message is shown that instructs the user to create a new tier
if there are not active tiers on the offers page
- Improved detection of changes in tiers by correctly reloading the
members utils service after tier changes
- Portal redirects to the homepage for offers with an archived tier
(same behaviour as invalid offers)
- Offers of an archived tier are no longer visible in the dashboard
2022-11-11 10:11:34 +01:00
Simon Backx
7c3d75ade7
🐛 Fixed pasting newlines in post titles ( #15794 )
...
fixes https://github.com/TryGhost/Team/issues/2193
- When pasting a title with a newline, we now trim the string and clear newslines before pasting.
- When sending the slug to the backend to generate a unique slug, we now sluggify it in the frontend before adding it to the URL to prevent issues with unsupported characters (causing possible routing problems in Pro).
2022-11-10 14:43:15 +01:00
Simon Backx
b821c84b9e
Cleaned up member filters ( #15784 )
...
fixes https://github.com/TryGhost/Team/issues/2134
fixes https://github.com/TryGhost/Team/issues/2133
- Moved all filters to separate files to make the filter component a lot more readable and easier to maintain.
- Removed long switch style code from hbs for filter column values
- Filters for features that are disabled (such as open tracking, click tracking or member attribution) are now hidden when they are disabled
- The open rate column in the members table is now only visible if open tracking is enabled
2022-11-10 11:05:12 +01:00
Simon Backx
c2dfb2b579
🐛 Fixed link click counts for duplicate links ( #15789 )
...
refs https://github.com/TryGhost/Team/issues/2213
When an email contains multiple links to the same destination, that link
is only shown once on the analytics page. The total displayed count is
not summed correctly.
2022-11-10 10:51:26 +01:00
Simon Backx
a5c4091620
Fixed analytics page feedback chart filter button links
...
no issue
Clicking the 'see members' button in the feedback chart tooltip went to a page with a hardcoded post id instead of the actual post id.
2022-11-10 10:38:09 +01:00
renovate[bot]
b74029697f
Update dependency webpack to v5.75.0
2022-11-09 16:17:31 +00:00
Elena Baidakova
d542fadd63
Adjusted feedback title to dark theme ( #15793 )
...
closes TryGhost/Team#2236
2022-11-09 19:19:27 +04:00
James Morris
2fb6fcabb2
Changed post and page rows go to editor plus code and styles cleanup
...
- Made the majority of the row go to the editor instead
- Removed illegal nested hyperlinks and cleaned up other markup
- Removed some feature flag code around this page and fixed styles for them
- Improved some dark mode styling
- Lots of refactoring with code and styles
refs https://github.com/TryGhost/Team/issues/2223
2022-11-08 14:29:11 +00:00
renovate[bot]
d4c0224fd8
Update dependency ember-template-lint to v4.18.0
2022-11-08 13:10:42 +00:00
Ghost CI
4b7dd71851
Merged heads/v5.22.9 into main
2022-11-08 09:04:04 +00:00
Ghost CI
f274275ef3
v5.22.9
2022-11-08 09:04:01 +00:00
Elena Baidakova
a605679bfa
Moved all code for feedback chart to one file ( #15774 )
...
closes TryGhost/Team#2143
- All logic for feedback pie chart was spread through multiple files. It
would be difficult to scale it. Now it is encapsulated in one file.
2022-11-08 09:42:32 +04:00
renovate[bot]
8fa9f1e7e6
Update Test & linting packages
2022-11-07 20:39:48 +00:00
Ghost CI
92c3d1e933
Merged heads/v5.22.8 into main
2022-11-07 16:13:43 +00:00
Ghost CI
5f9e354cae
v5.22.8
2022-11-07 16:13:40 +00:00
Elena Baidakova
b526c4b719
Add tests to tabs and events pagination ( #15757 )
...
closes TryGhost/Team#2128
2022-11-07 16:32:06 +04:00
Aileen Nowak
f2c0bff9df
Updated <GHBillingIframe> to not leak event listeners
...
no issue
refs dac5cca899
2022-11-07 11:59:14 +00:00
Ghost CI
1575304627
Merged heads/v5.22.7 into main
2022-11-07 10:46:01 +00:00
Ghost CI
96aa0e6ba6
v5.22.7
2022-11-07 10:45:58 +00:00
renovate[bot]
12023804de
Update dependency eslint to v8.27.0
2022-11-07 01:32:41 +00:00
Ghost CI
81566aca88
v5.22.6
2022-11-04 15:00:38 +00:00
Sanne de Vries
2aa0ccde4f
Fixed button group padding on email preview screen
...
No ref
2022-11-04 17:41:19 +07:00
Kevin Ansfield
91c3c9eece
Fixed lexical editor not loading
...
refs https://github.com/TryGhost/Ghost/pull/15763
- the config service no longer exists, we need to use the object registered at `config:main` instead to grab the editor url
2022-11-04 09:25:52 +00:00
Daniel Lockyer
c32a013087
Merged v5.22.5 into main
...
v5.22.5
2022-11-04 13:05:33 +07:00
Ghost CI
a06bc369bc
v5.22.5
2022-11-04 04:55:45 +00:00
Kevin Ansfield
443867639f
Deleted unused modal-whats-new component file
...
no issue
- backing class still existed for a component that previous had it's template removed
2022-11-03 17:18:37 +00:00
