Commit Graph

6090 Commits

Author SHA1 Message Date
Elena Baidakova
29c440743c Disabled feedback dropdown closing on outside click
no issue
2023-05-17 15:06:37 +04:00
Michael Barrett
93599315ab
Move duplicate post functionality out of labs (#16812)
no issue

Removed the labs check for the duplicate post functionality making it
available for everybody
2023-05-17 11:44:07 +01:00
Michael Barrett
94c863f189
Implemented post slug update on duplicated post title update (mobiledoc) (#16811)
no issue

Updated the slug generation logic so that when a mobiledoc post is
duplicated and the title is edited, the slug gets updated to reflect the
new title of the post. See lexical implementation here:
https://github.com/TryGhost/Ghost/pull/16802
2023-05-17 10:11:01 +01:00
Sodbileg Gansukh
d61249a335 Fixed double scrollbar issue in members list
closes https://github.com/TryGhost/Team/issues/2765
2023-05-17 14:27:39 +08:00
Elena Baidakova
9abd9fac71 Cleaned up the feedback form after sending the message
no issue
2023-05-17 09:21:48 +04:00
Steve Larson
64662c986b Changed successful feedback send text
no refs
2023-05-16 13:03:40 -05:00
Rishabh
2c1cab6c42 Updated css handling for admin-x-settings package
refs https://github.com/TryGhost/Team/issues/3151

- adds root classname for admin-x settings app so class names can be scoped inside
- adds new preflight.css for resetting admin styles for admin-x app
- moved font to assets/font so it can be picked for both demo app and Admin
2023-05-16 21:08:49 +05:30
Elena Baidakova
57d5f544d8
Updated inlined feedback form (#16794)
refs TryGhost/Team#3214

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 92b2412</samp>

This pull request refactors and simplifies the feedback system for the
lexical editor feature. It replaces the nested modal with a new
`FeedbackLexical` component that can be used in different contexts. It
also removes unused code and files related to the old feedback modal.
2023-05-16 16:16:57 +04:00
Michael Barrett
ef0b863c2b
🐛 Fixed validation error when creating 0% offer (#16803)
closes https://github.com/TryGhost/Team/issues/3073

Fixed validation error when creating 0% offer. Issue was occurring due
to a falsy check on the offer value. Have resolved by having a more
strict check on the offer value based on the possible empty value it can
be - If creating a new offer without providing an offer value, the value
will be `undefined`. If supplying an offer value, then removing the
offer value, the value will be an empty string. This check prevents `0`
being classed as an invalid value.
2023-05-16 12:03:37 +01:00
Michael Barrett
965e9700a0
🐛 Fixed link to translation information in general settings (#16804)
closes https://github.com/TryGhost/Team/issues/3212

The link in the description for the publication language setting in
general settings was pointing to an outdated page
(https://ghost.org/docs/i18n/). This fix updates the link to point at
https://ghost.org/docs/faq/translation/
2023-05-16 12:03:21 +01:00
Djordje Vlaisavljevic
75aa3d1186 Updated feedback widget design inside Editor
no refs
2023-05-16 11:49:01 +01:00
Michael Barrett
43f55521c0
Implemented post slug update on duplicated post title update (#16802)
no issue

Updated the slug generation logic so that when a post is duplicated and
the title is edited, the slug gets updated to reflect the new title of
the post
2023-05-16 10:47:40 +01:00
Rishabh
f9ac201891 Handled missing config for new admin-x settings routing
refs https://github.com/TryGhost/Team/issues/3151

- handles redirection to old settings if the config for admin-x is missing and new settings route is opened
2023-05-16 12:27:18 +05:30
Rishabh
31779c95b5 Added feature flag for new admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- allows toggling route to new settings screen in react

Co-authored-by: Peter Zimon <zimo@ghost.org>
2023-05-16 12:23:24 +05:30
Rishabh
bf2a2eeb63 Added route for new admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- adds route in Admin for opening new settings screen in react
- adds new config for passing `adminX` to Admin
- loads adminX settings from package in Admin UI when new route is opened

Co-authored-by: Peter Zimon <zimo@ghost.org>
2023-05-16 12:23:24 +05:30
Sodbileg Gansukh
0e97cc3a11 Fixed double scrollbar issue on Pages
closes https://github.com/TryGhost/Team/issues/3219

- the pages template had a leftover .gh-list-sticky and it was causing an additional scrollbar inside the list
- removing the unncessary element fixes the issue
2023-05-16 12:27:37 +08:00
Elena Baidakova
86e84e35cb
Replaced modal feedback on dropdown in editor (#16793)
refs TryGhost/Team#3213

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 2a96438</samp>

This pull request enhances the feedback modal feature in the lexical
editor. It improves the layout and appearance of the modal and its
trigger button, and uses a dropdown component to show and hide the
modal.
2023-05-15 17:15:34 +04:00
Djordje Vlaisavljevic
6812e026b0 Commented out inlined beta feedback form on Published post page
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
5ae2425fb6 Hid inlined Labs beta feedback form
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
8640acf94e Moved feedback button to the left side of editor
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
1e3d78a937 Added inlined feedback form design to post published page
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
d82ad53bab Fixed bug where closing modal takes you to dashboard
no refs
2023-05-15 10:35:16 +01:00
Sodbileg Gansukh
c1b6d70b3d Added enter key support to tier benefits
closes https://github.com/TryGhost/Team/issues/2950

- when adding/editing tiers, benefits used to be added only when the plus button was pressed
- this adds enter key support for adding new benefits, same as how the navigation items are added
2023-05-15 16:47:20 +08:00
Michael Barrett
59fe794b0c
Implemented duplicate post functionality (#16767)
refs: https://github.com/TryGhost/Team/issues/3139 https://github.com/TryGhost/Team/issues/3140

- Added duplicate post functionality to post list context menu
  - Currently only a single post can be duplicated at a time
  - Currently only enabled via the `Making it rain` flag
- Added admin API endpoint to copy a post - `POST ghost/api/admin/posts/<post_id>/copy/`
- Added admin API endpoint to copy a page - `POST ghost/api/admin/pages/<page_id>/copy/`
2023-05-15 09:30:32 +01:00
Sodbileg Gansukh
77dda7beba Fixed long URL scrolling in members activity
refs https://github.com/TryGhost/Team/issues/2616

- long urls were causing scrolls in the members activity
- now the urls are broke into multiple lines, so that it's easier to understand/copy them
2023-05-15 16:00:11 +08:00
Sodbileg Gansukh
828c1df6ac Capitalize the homepage event in the members activity
refs https://github.com/TryGhost/Team/issues/2616
2023-05-15 16:00:11 +08:00
Fabien "egg" O'Carroll
ecb90c88ca 🐛 Fixed visibility of the post history feature
We had side stepped the existing checks of lexical and the feature flag when
checking if a published post was sent as an email. This takes into account the
existing checks to make sure the feature isn't leaked without the flag
2023-05-12 17:34:52 -04:00
Sag
d86ac17e31
Added fetchLabels to the Lexical config (#16774)
closes https://github.com/TryGhost/Team/issues/3183
- fetches all existing labels
- returns "id" and "name" fields
2023-05-11 16:36:56 +02:00
Steve Larson
080a1c92d8 fixed linter errors
no refs
2023-05-11 08:14:11 -05:00
Steve Larson
26389507ed Revert "Reverted "Add lexical feedback (#16772)""
This reverts commit 0a9f280a75.
2023-05-11 08:12:25 -05:00
Naz
3eebeb608c
Added collections feature flag
closes https://github.com/TryGhost/Team/issues/3165

- This feature flag is here to gate the development of Collections 2.0 feature
2023-05-11 16:31:45 +07:00
Elena Baidakova
bfa9ea88a2 Removed p wrapper for announcement bar
refs TryGhost/Team#3147
2023-05-11 13:22:05 +04:00
Daniel Lockyer
0a9f280a75
Reverted "Add lexical feedback (#16772)"
This reverts commit 72ed8f56f6.
2023-05-11 11:08:18 +02:00
Steve Larson
72ed8f56f6
Add lexical feedback (#16772)
no refs
- add lexical feedback modal in the editor, labs, and publish workflows
- modal is a basic textarea form

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
2023-05-10 17:40:55 -05:00
Jono M
62f7600aa4
Update search text highlighting to escape HTML (#16760)
refs: https://github.com/TryGhost/Team/issues/2390

Escapes each matched and non-matched segment of the post title in the
admin search field, to make sure they're displayed in plain text but
still have matches highlighted.
2023-05-11 09:53:05 +12:00
Sodbileg Gansukh
13e9c65860 Removed unnecessary tabindex property 2023-05-10 15:43:30 +08:00
Sodbileg Gansukh
b668ca3943 Fixed newsletter clicks not updating in Safari
refs https://github.com/TryGhost/Team/issues/2619

- blur event occurs before mouseup event is called, so when the update button was clicked, the update function has never been called in Safari
- this replaces the mouseup with mousedown which is called before the blur event, so the links are updated properly
2023-05-10 15:40:57 +08:00
Ronald Langeveld
8a08cf3628
Added signupCard feature flags (#16763)
no issue

This pull request adds a new experimental feature flag `signupCard` to
the Ghost admin app, which enables a signup card component in the
lexical editor that's currently being worked on. 
The feature flag can be toggled from the settings/labs
UI and is read from the server-side configuration.
2023-05-09 16:27:36 +02:00
Rishabh Garg
c6a75cf015
Integrated image editor for staff and tag admin pages (#16755)
refs https://github.com/TryGhost/Team/issues/3145

- includes image editing for generic upload image components to extend
image editing capabilities to other areas in Admin
- allows image editing for tag images and staff user images
2023-05-08 15:22:25 +05:30
Elena Baidakova
9df8e89806 Revert "Removed p wrapper for koenig-lexical-input (#16754)"
This reverts commit 9051ea62aa.
2023-05-08 12:15:37 +04:00
Elena Baidakova
07e979698d Revert "Checked whether initialHtml in lexical input has a paragraph"
This reverts commit dd26448dcf.
2023-05-08 12:15:25 +04:00
Elena Baidakova
dd26448dcf Checked whether initialHtml in lexical input has a paragraph
refs TryGhost/Team#3147
2023-05-08 11:07:18 +04:00
Elena Baidakova
9051ea62aa
Removed p wrapper for koenig-lexical-input (#16754)
refs TryGhost/Team#3147

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 7dfd8bf</samp>

This file adds a function to clean and format the HTML of the
`koenig-lexical-editor-input` component and passes it to the
`HtmlOutputPlugin` component.
2023-05-08 10:04:14 +04:00
Simon Backx
6566903df5
Cleaned up member attribution flag (#16745)
no issue

This commit removes the `memberAttribution` feature flag from the
codebase. Some CSS classes are not removed as removing them and updating
the associated CSS files have side effects sadly.
2023-05-05 15:04:14 +02:00
Rishabh Garg
6c131de6eb
Added image editing feature for publication logo and cover (#16741)
refs https://github.com/TryGhost/Team/issues/3145

- adds image editing functionality(behind flag) using pintura
integration to publication logo and cover
2023-05-05 16:30:34 +05:30
Elena Baidakova
4207c9d0d1
Added browser tests for announcement bar (#16742)
refs TryGhost/Team#3122

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 87727d9</samp>

Added `data-testid` attributes to various elements in the announcement
bar settings feature to enable Playwright testing. Fixed a potential bug
with the `visibilitySettings` getter in the `visibility.js` component.
Added Playwright tests for the announcement bar settings feature in
`announcement-bar-settings.spec.js`.
2023-05-05 14:11:26 +04:00
Simon Backx
05bba5135d
Cleaned up sourceAttribution flag (#16740)
no issue

This commit removes the `sourceAttribution` feature flag from the
codebase.
2023-05-05 10:57:26 +02:00
Simon Backx
fbed93b866
🐛 Added missing history logs for post/page bulk actions (#16734)
no issue

The post/page bulk actions weren't logged in the history log / actions
table.

This change adds support for logging bulk actions.
- New `addActions` static method on models. It creates an action log in
the database for multiple models at once. If only one model was edited,
deleted or added, it will fallback to `addAction`
- `addAction` can also be called statically now
- `actionName` option is now supported when using `addActions`,
`addAction`, and as a result also in all bulk manipulation methods, and
CRUD methods. This allows you to replace the default '5 posts edited'
into something more specific like '5 posts featured'
- Fixed support for null resource_id in the parse-history-event helper
- Removed the default 'published' status requirement when using
Post.findOne for internal queries.
2023-05-05 09:45:36 +02:00
Simon Backx
848b2d82a1
Cleaned up suppressionList feature flag (#16736)
no issue

This pull request removes the `suppressionList` feature flag and all its
dependencies from the codebase. It makes the suppression list feature
the default and consistent behavior for all email events and
newsletters. It simplifies the UI, logic, and data related to email
events and newsletters. It affects several files in the
`ghost/admin/app`, `ghost/core/core`, and `ghost/members-api`
directories.
2023-05-04 14:47:04 +02:00
Simon Backx
17a6217cc7 🐛 Fixed members breadcrumbs when not coming from analytics
fixes https://github.com/TryGhost/Team/issues/2404

This change introduces a new 'post' query parameter to the members and member routes.

Previously, the members route would check if the previous route was the analytics page, and then show the breadcrumbs to go back to the analytics page. But when navigating to the members page from the menu, we don't want to show the breadcrumbs. To accomplish this, the routes that point to the members page from the analytics page now specifically pass on the post id in the query parameters. The query parameter is then passed on from the members page to the member page.

`directlyFromAnalytics` is still used in the member route, to know wheter we came from the members page or from the analytics page (changes the breadcrumbs). This doesn't need to go via a query parameter (figured that would make the url too long/complex).

The resetController method is now implemented and resets the filter and/or fromAnalytics post id if required (when going from members to member, we don't want to reset it because the we would lose the filter going back).
2023-05-04 11:20:33 +02:00