Commit Graph

5413 Commits

Author SHA1 Message Date
Peter Zimon
441146d316 🐛 Style fix for custom views
no refs.
- fixed misalignment of expand button for site custom views
2020-02-10 16:05:57 +01:00
Daniel Lockyer
4225f414e0 Version bump to 3.5.1 2020-02-10 12:55:55 +00:00
Peter Zimon
4ce559a169 Updated staff delete modal copy 2020-02-10 12:41:35 +00:00
Peter Zimon
fc46a97b18 Updated copy 2020-02-10 12:41:35 +00:00
Peter Zimon
0382ea7336 Added note about site backup to delete popup 2020-02-10 12:41:35 +00:00
Kevin Ansfield
9186280ac9 updated to use new model._meta
- use model._meta to access the meta object in the delete response
- removed unused `_deleteUser` method
- move the success/failure method bodies into the main `deleteUser` task to improve readability
- added a timeout after calling `_exportDb()` so that the iframe is not removed from the DOM immediately after it's `src` value is set due to a transition away from the member screen
2020-02-10 12:41:35 +00:00
Kevin Ansfield
7bb24df7b9 Added hacky method for accessing meta value of single-record requests
no issue

- Ember Data does not support accessing meta data included in the response to single-record requests such as save/delete
- approach to allow it taken from https://github.com/emberjs/data/pull/4077#issuecomment-200780097
2020-02-10 12:41:35 +00:00
Nazar Gargol
f42f2a29a3 Rewrote delete into generator function
- Wasn't necessary, but thought this might fix the problem when there's no 'meta' in the reponse object
2020-02-10 12:41:35 +00:00
Nazar Gargol
70524c55a4 Basic flow for triggering db export on user deletion 2020-02-10 12:41:35 +00:00
Kevin Ansfield
8883a1e6f6 Lock file cleanup
no issue

- previous `yarn.lock` was missing some cleanup
2020-02-05 16:19:00 +00:00
Daniel Lockyer
32de94197f Version bump to 3.5.0 2020-02-05 11:42:31 +00:00
Nazar Gargol
21aaf7a46a Renamed members subscribed flag label
no issue

- This change comes to keep the name consistent to the naming used in the CSV import file - `subscribed_to_emails`
2020-02-04 13:27:51 +08:00
Peter Zimon
767ce72212 💄Added shadow to What's new footer
no refs.
- improved discoverability of having more content/scrollable area by adding a small shadow to the footer
2020-02-03 20:58:20 +01:00
Peter Zimon
1756180025 🐛 Fixed mobile style bug for sidebar views
no refs.
- fixed the size of the expand/collapse chevron in sidebar for mobile
2020-02-03 20:18:51 +01:00
Kevin Ansfield
a3c71b8ba8 Fixed query params not resetting when deleting a custom view
no issue

- added a `transitionTo` after deleting a custom view that transitions to the `posts` route with default query params
- refactored `reset-posts-query` helper to a more generic `reset-query-params` helper
  - moved default query params definitions to this helper and expose them so we have a single source of truth
  - exposed `resetQueryParams()` function from the helper for use outside of templates
  - adjust the function and helper behaviour to accept the route name as the first param so that `router.currentRouteName` can be used as a generic reset
2020-02-03 16:38:14 +00:00
Peter Zimon
2c137f0b38 Refined sidebar view icons
no refs.
- replaced icons for custom views for circles so it's more scannable
2020-02-03 14:45:18 +01:00
Kevin Ansfield
1adae0d041 Fixed missing default views when user.accessibility is null
no issue

- removed an old guard that was exiting early when `user.accessibility` was null which meant that the default views were never being inserted into the custom views list
2020-02-03 12:34:23 +00:00
Kevin Ansfield
7c205c1a55 Fixed "Authorization failed" errors during setup and signin
no issue

- the `custom-views` and `navigation` services would trigger their observers immediately when `this.session.user` changed but that would occur before authentication had fully finished which was resulting in the `this.session.user` access triggering a request with no cookie/an old cookie set and causing a 403 error that interrupted the setup and authentication flows
2020-02-03 12:27:18 +00:00
Kevin Ansfield
2226861e17 🐛 Fixed deletion of custom integrations
no issue

- the named arguments for the `<GhTaskButton>` in the integration deletion modal were missing the `@` prefix
2020-01-30 16:48:37 +00:00
Kevin Ansfield
2a77c0fe51 Added default and custom post views (filters) to the admin sidebar (#1474)
no issue

- list custom post views in collapsable sidebar navigation
  - default views: Draft, Scheduled, Published (except for contributors)
  - record expanded/collapsed state of the navigation menus in user settings via new `navigation` service
- adds `customViews` service that manages custom views
  - provides list of default views
  - gives access to "active" custom view based on current route and query params
  - manages loading/saving of custom views to user settings
- show "Add view" button in the content filter when the posts list has been filtered
- show "Edit view" button in the content filter when the posts list filter matches a saved view

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2020-01-30 15:35:36 +00:00
Kevin Ansfield
2b37f6aaae Version bump to 3.4.0 2020-01-28 17:23:42 +00:00
Naz Gargol
76c1341666 Added "Complimentary" plan toggle (#1476)
refs TryGhost/Ghost#11537

- Adds support for "Complimentary" plan toggle only when editing an existing member. The same functionality for adding a new member was left out intentionally for simplicity sake. 

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2020-01-28 11:27:19 +07:00
Kevin Ansfield
1e77a4c915 Removed <GhDownloadCount>
no issue

- the count.ghost.org service is being shut down
- replaced the fetch+poll component with a hardcoded figure
2020-01-27 09:51:45 +00:00
renovate[bot]
c8625d6a42 Update dependency @tryghost/kg-parser-plugins to v0.9.0 (#1483)
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
2020-01-27 09:27:28 +00:00
Renovate Bot
c815191d41 Update ember core 2020-01-27 04:16:57 +00:00
Renovate Bot
3472f332e3 Update dependency @tryghost/kg-clean-basic-html to v0.1.5 2020-01-27 03:16:30 +00:00
Renovate Bot
910250006f Update dependency @tryghost/timezone-data to v0.2.19 2020-01-27 02:16:55 +00:00
Renovate Bot
05bb69b7d9 Update dependency @tryghost/helpers to v1.1.22 2020-01-27 01:16:27 +00:00
Rish
32cceb8a54 Fixed members chart dropdown style
no issue

We switched to angle bracket syntax and some PowerSelect properties were not properly auto configured here which enabled search box on members chart range dropdown
2020-01-23 13:46:37 +05:30
Daniel Lockyer
ba6389aaf5 Added Node 10 testing to CI
no issue

- we want to test on all supported Node versions
2020-01-22 12:47:50 +07:00
Kevin Ansfield
1e46306129 Fixed linting 2020-01-21 17:48:54 +00:00
Kevin Ansfield
4b40346ff4 Cleaned up unused code in bookmark card
no issue

- the `willDestroyElement` hook is referencing event handlers that aren't used in the bookmark card
- stopped setting `type` in the card payload as it's not used anywhere (possible hangover from when bookmarks were a type of embed card)
2020-01-21 17:45:33 +00:00
Peter Zimon
397e18c7c0 🐛 Fixed dark mode link input bug
no refs.
- fixed style bug for link input in Koenig having no blue border in dark mode
2020-01-21 12:27:30 +01:00
Peter Zimon
d2ac367371 🐛 Fixed button style for staff creation
no refs.
- Fixed Create button being visually detached and incorrect size on the Create (staff) account screen
2020-01-21 12:14:35 +01:00
Kevin Ansfield
d873f929e1 Changed content filters to show "unknown" if a deleted tag/author is selected
refs https://github.com/TryGhost/Ghost-Admin/pull/1474

- show some indicitive text rather than a blank dropdown button when type/author/tag/order query param is present but doesn't match something in our data sets (eg, if a tag/author has been deleted or a query param has been incorrectly typed)
2020-01-20 15:40:32 +00:00
Kevin Ansfield
9cad64cd76 Fixed toaster notification not clearing
no issue

- we switched to using native event listeners rather than jQuery but were still looking for the jQuery-specific `event.originalEvent`
2020-01-20 15:30:24 +00:00
Kevin Ansfield
942e09db9d Lock file maintenance 2020-01-20 09:27:10 +00:00
renovate[bot]
5d9458283e Update dependency ember-composable-helpers to v3.1.0 (#1471)
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
2020-01-20 09:21:13 +00:00
renovate[bot]
0dc30910a2 Update dependency ember-cli-chart to v3.6.0 (#1470)
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
2020-01-20 09:20:33 +00:00
Renovate Bot
28ce0b0dc3 Update dependency ember-route-action-helper to v2.0.8 2020-01-20 07:23:51 +00:00
Renovate Bot
0263b02ffa Update dependency ember-infinity to v2.0.3 2020-01-20 06:18:15 +00:00
Renovate Bot
50b88fba05 Update dependency ember-concurrency to v1.1.5 2020-01-20 05:18:07 +00:00
Renovate Bot
7c8ddab16a Update dependency autoprefixer to v9.7.4 2020-01-20 04:18:14 +00:00
Renovate Bot
51f272b235 Update dependency ember-cli-htmlbars to v4.2.2 2020-01-20 03:17:48 +00:00
Renovate Bot
55a41c6bb5 Update dependency @tryghost/timezone-data to v0.2.18 2020-01-20 02:18:50 +00:00
Renovate Bot
b3a184d5a3 Update dependency @tryghost/helpers to v1.1.21 2020-01-20 01:18:57 +00:00
Kevin Ansfield
ba4c53134f Upgraded eslint-plugin-ghost and fixed new linter errors
no issue

- update imports for `@ember-data` package (https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md)
- use `computed.reads` where applicable (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-computed-macros.md)
- fix usage of `scheduleOnce` so that functions are only scheduled once (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-incorrect-calls-with-inline-anonymous-functions.md)
2020-01-16 17:01:12 +00:00
Kevin Ansfield
2231dd84c2 Migrated to <AngleBracketSyntax /> (#1460)
no issue

Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md

We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere.

This simplifies the rules for what template code is referring to...

`<Component>` = a component
`{{helper}}` = a helper (or locally assigned handlebars variable)
`{{this.foo}}` = data on the template backing context (a component/controller)
`{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments)

- ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories:
  - `app/templates`
  - `lib/koenig-editor/addon/templates`
- removed positional params from components as angle bracket syntax does not support them
  - `gh-feature-flag`
  - `gh-tour-item`
  - `gh-cm-editor`
  - `gh-fullscreen-modal`
  - `gh-task-button`
- updates some code that was missed in 3c851293c1 to use explicit this
2020-01-16 15:14:03 +00:00
Kevin Ansfield
0f8610a6e9 Extracted duplicated posts/pages filter into a component
no issue

- posts and pages (and their corresponding `-loading` counterparts) templates were all duplicating a lengthy section of handlebars
- extracted the duplicated handlebars into a template for easier design changes or upgrading of `ember-power-select`
- moved generation of the "selected" CSS classes into the template to clean up code in the controller
2020-01-15 15:15:20 +00:00
Kevin Ansfield
7c7c4962f9 Upgraded ember-power-* addons (#1459)
no issue

- bump deps
- adjust usage for breaking changes... 
  - https://github.com/cibernox/ember-power-select/blob/master/CHANGELOG.md#300-beta1
  - https://github.com/cibernox/ember-basic-dropdown/blob/master/CHANGELOG.md#200-beta3
  - https://github.com/cibernox/ember-power-datepicker/blob/master/CHANGELOG.md#070
- update overridden component and template files to match latest addon code
  - switch to class syntax w/decorators
  - adjust for angle bracket syntax
2020-01-15 13:53:51 +00:00