Commit Graph

521 Commits

Author SHA1 Message Date
Mikkel Hoegh
1a4c13a63f Refactor click handlers on upload button.
closes #2028
- Instead of binding and unbinding the click event, bind the data to the
  outer scope so we can use a standard click handler.
- Use removeProp instead of setting the property to false when enabling.
- Use the `disabled` as value when disabling.
2014-01-27 21:35:24 +00:00
Hannah Wolfe
288b09b280 Merge pull request #2049 from javorszky/iss-1841
Guard against multiple signup events
2014-01-27 13:33:55 -08:00
Hannah Wolfe
a0eb29eb87 Post settings don't render on change
fixes #1908

- each individual update function handles rendering its own item on success or failure, rather than re-rendering the whole group
- also resolved a bug where the published date didn't get reset properly on error
2014-01-27 10:55:22 +00:00
Gabor Javorszky
d02b92373e Guard against multiple signup events
Fixes #1841
* Added initial flag "no" for submission into Signup View
* Flag set to "yes" if submit button clicked
* Error thrown if flag is "yes", thus no subsequent submission sent to API
* Flag set to "no" if ajax returns with error
2014-01-26 22:38:50 +00:00
Hannah Wolfe
e81893a7ef Merge branch '0.4-maintenance'
Conflicts:
	core/server/config/paths.js
	core/test/unit/config_spec.js
2014-01-26 16:11:02 +00:00
Harry Wolff
ba386f1e37 Have NProgress called for all ajax calls
fixes #2011

- rather than trigger NProgress for fetch calls
 I’ve moved it to be used for all sync calls

- issue #2011 was a result of NProgress only being
 called during a fetch() call, which when saving
 is not used - save() is.  Sync is used by all
 ajax calls.
2014-01-26 00:09:01 -05:00
redwallhp
c9e5aee296 Minor code cleanup of editor keyboard shortcut actions.
Signed-off-by: redwallhp <matt@ntugo.com>
2014-01-25 21:23:17 -05:00
John O'Nolan
c3e3d688ab Larger min-height for textareas, and size based on font size 2014-01-21 14:35:47 +07:00
John O'Nolan
35d2fc99d7 Prevent form field descriptions from becoming unwieldily long
Yes that’s a word. As of now.
2014-01-21 14:33:05 +07:00
Hannah Wolfe
9715e1994d Merge pull request #1950 from Damiya/1893-fix
Enable Escape key to close tag suggestion popup
2014-01-20 06:28:15 -08:00
Hannah Wolfe
659cda19e7 Merge pull request #1951 from Damiya/1902-fix
Prevent stacking of password mismatch notification on /reset/
2014-01-20 06:12:25 -08:00
Hannah Wolfe
a0ebf1198d General cleanup
- Cleanup some todos, comments, and unused variables
2014-01-19 21:08:39 +00:00
Jakob Gillich
03c16bae24 Show character limit below blog description textarea
closes #1970
2014-01-17 21:39:43 +01:00
Jason Williams
553cb35913 Show message and don't start if javascript files have not been built
fixes #1782
- added builtFilesExist function to check for files during startup.
  If built files do not exist Ghost startup is stopped and a link
  to the documentation is displayed.
- exported a scriptFiles object from server/helpers.
- added a builtScriptPath to the paths module.
- removed "js-msg" about missing javascript from the UI.
2014-01-15 19:10:43 +00:00
Kate von Roeder
09b35b77d9 Prevent stacking of password mismatch notification on /reset/
closes #1902
- Missing call to clearEverything caused the new notifications to pile up on multiple failed submissions
2014-01-14 13:58:38 -08:00
Kate von Roeder
bafc27d454 Enable Escape key to close tag suggestion popup
closes #1893
- Checking the contents of search term after evaluating the keycode caused the suggestion box to be hidden and immediately reshown
- Moving the if/else to the top of the function enables us to fix the issue without complicating the suggestion update logic
2014-01-14 13:17:06 -08:00
Hannah Wolfe
2705a28da9 Publish date and time display fix
no issue

- add @ symbol to ensure date and time are clear
2014-01-13 02:39:08 +00:00
Hannah Wolfe
f166440334 No select or text cursor on rendered preview
fixes #1595

- prevents the backspace key from doing terrible things
2014-01-11 16:05:33 +00:00
Zach Schneider
1007e8e5ad Prevented duplicate binding of upload button on debug importer
Fixes #1899
2014-01-10 18:08:24 -05:00
Hannah Wolfe
e5cd8eb3be Change help text wording on settings page 2014-01-10 20:05:38 +00:00
Hannah Wolfe
3e3e90daf5 Merge pull request #1894 from ErisDS/issue-1558
Notifications can be dismissed with ESC
2014-01-09 13:24:41 -08:00
Hannah Wolfe
ce75435865 Notifications can be dismissed with ESC
issue #1558

- this is a partial / short term fix for the problem with extra long notifications, so that there is at least one way to remove them.
2014-01-09 20:34:16 +00:00
Hannah Wolfe
cd750b11fb Merge pull request #1888 from hswolff/additional-ux
Update placeholder of published data in editor
2014-01-09 05:04:09 -08:00
Harry Wolff
1c8b96fea3 Update placeholder of published data in editor
fixes #1351

- when a post has a published_at value show a blank
placeholder

- when a post doesn’t have a published_at
value then show the required published at value
format
2014-01-07 23:13:16 -05:00
Jacob Gable
260252e511 Fix hanging loading bar on deleting a post
Closes #1869

- Added an additional event listener for destroy event, then a listener
on the model for the sync event to finish the progress bar loader
2014-01-07 18:56:00 -06:00
John O'Nolan
3c1a7e03b5 Fixed tag display issues
The tags UI is pretty messed up all round. This fix makes it work properly at least on desktop. Mobile needs a lot more love. This is a followup to #1774 and most problems stemming originally from #710
2014-01-07 23:29:59 +01:00
John O'Nolan
febd6599ad Fix John being stupid
See #1878
2014-01-07 22:20:32 +01:00
John O'Nolan
460bcfdd1a Speed up heinous slow animations 2014-01-07 22:19:52 +01:00
John O'Nolan
4b4d9d822f Update post settings checkbox
* Fixed display bug in firefox, cause firefox is utter shit. Closes #1878
* Fixed minor animation bug where checkmark was missing transitions on click
2014-01-07 21:54:16 +01:00
John O'Nolan
e5d6a91ab2 Get rid of old todos
Cause they’re already fucking done
2014-01-07 19:20:16 +01:00
Harry Wolff
3213a0aa3d Extending halfdan’s work for UX settings improvements
#1351

- prevent a new post (not saved on server) from
updating its slug/date to the server

- fix jshint

- add back creation of a posts slug upon a post creation

- update for rebasing

- hide ability to ‘delete this post’ from post settings
menu when a post hasn’t yet been saved to the server
2014-01-06 21:33:24 -05:00
Fabian Becker
1b19fdb64a New Post UX behaviour.
refs #1351
- Make generateSlug a static method on base model
- Change client behaviour (unfinished)
- Add new getSlug API method
2014-01-06 21:05:17 -05:00
Sebastian Gierlinger
01f79c2921 Use ajax for import
closes #1854
- added blueimp file upload to debug.js
- changed POST /ghost/api/v0.1/db to be used with AJAX
- cache invalidation header should now work for import
- moved busboy middleware invocation to routes/api and routes/admin
- moved api.db.import to api.db.importContent (I hated the [] notation)
- moved api.db.export to api.db.exportContent (see above)
2014-01-06 22:55:43 +00:00
Hannah Wolfe
ee6c22b6e1 New URL helper - URL consistency fixes
fixes #1765
fixes #1811
issue #1833

New UrlFor functions

- moved body of url helper to config.path.urlFor, which can generate a URL for various scenarios
- urlFor can take a string (name) or object (relativeUrl: '/') as the first
  argument - this is the first step towards issue #1833
- also added config.path.urlForPost which is async and handles getting
  permalink setting
- frontend controller, ghost_head helper, cache invalidation all now use
  urlFor or urlForPost all urls should be correct and consistent

URL Consistency Improvements

- refactored invalidateCache into cacheInvalidationHeader which returns a
  promise so that url can be generated properly by urlForPost
- moved isPost from models to schema, and refactored schema to have a tables object
- deleted posts now return the whole object, not just id and slug,
  ensuring cache invalidation header can be set on delete
- frontend controller rss and archive page redirects work properly with subdirectory
- removes {{url}} helper from admin and client, and replaced with adminUrl
  helper which also uses urlFor
- in res.locals ghostRoot becomes relativeUrl, and path is removed
2014-01-06 15:15:48 +00:00
John O'Nolan
169a04bfc3 Disabled styles for disabled buttons
Duh
2014-01-03 22:13:02 +01:00
John O'Nolan
9754e837c0 Merge pull request #1828 from ddoolin/fix-tag-suggestion-and-padding
Fixes showing tag suggestions and tag container padding
2014-01-03 13:04:16 -08:00
Devin Doolin
8d082215ca Fixes showing tag suggestions and tag container padding
fixes #1774
- Delayed showing the tag suggestions popup unless matching tags were found
- Changed the padding-left on the added tag container to 8px from 20px to fall in line with the left shadow overlay
2014-01-03 04:42:59 -05:00
cobbspur
03c7e1e917 disable save button during image uploads
closes #1661

- disables save button at beginning of image upload
- enable save button at image upload fail, at image upload and download success and also at dropzone init
2014-01-02 21:32:23 +00:00
Hannah Wolfe
faa50b09b9 Shared folder asset handling
fixes #1659, fixes #1668

- removed relative asset url from css
- added asset helper to client
- updated references to shared assets
- added functional tests
2013-12-28 18:29:33 +00:00
Hannah Wolfe
4b491fbd6e Path, url and subdir cleanup & test
issue #1754

- remove path (it was only used once, and not needed)
- change webroot to subdir
- add unit tests for config.paths
- various other cleanup
- renamed client-side ghostRoot to subdir
- added url helper for client
2013-12-28 16:09:56 +00:00
Hannah Wolfe
13e41ed378 Adding messaging that deleting is permanent 2013-12-27 13:50:47 +00:00
Hannah Wolfe
0d188ae5dc Merge pull request #1743 from sebgie/issue#1445
Delete all content (posts and tags)
2013-12-27 04:52:58 -08:00
John O'Nolan
e47441e7d4 Set min-height on user profile cover image
Fixes #1752
2013-12-27 13:32:51 +01:00
Sebastian Gierlinger
0c20e80f70 Delete all content (posts and tags)
closes #1445
- added delete button to ‚ugly debug tools‘
- added api call to delete all content
- added /db to cache invalidation routes
2013-12-25 01:05:20 +01:00
Matt Hughes
2e69992d9b Improved comma tag completion on international keyboard layouts
Reported in issue #1475
- `String.localeCompare` can be more reliable for keys that do not relate to cursor movement
- Adds a third key handler (`keypress`) that contains the character code rather than physical key
- `COMMA` key constant no longer required (unless `,` char should be a constant?)
2013-12-24 10:38:05 -05:00
Hannah Wolfe
9c38d1a2d3 Date helper fix, moment breaks with null values
fixes #1730
2013-12-21 21:43:38 +00:00
Hannah Wolfe
12c7a571e2 Merge pull request #1716 from ErisDS/post-order
API refactor / cleanup
2013-12-21 12:46:57 -08:00
Hannah Wolfe
007aec2e07 Merge pull request #1704 from ErisDS/featured-star
Markup & style fixes for post list statuses
2013-12-21 12:37:39 -08:00
Hannah Wolfe
3205f6d673 Merge pull request #1653 from AgtLucas/master
Fix typo?
2013-12-20 07:24:37 -08:00
Hannah Wolfe
1565c0004b API refactor / cleanup
closes #1303

- removed where and orderBy from being passed from the API through to bookshelf, and ultimately knex
- ordering is now consistent across both front and backend, which fixes #1303
- validated / cleaned up all the API parameters
- added API tests for the status and staticPages parameters
2013-12-20 13:07:01 +00:00
Hannah Wolfe
11f57448c4 Markup & style fixes for post list statuses
fixes #1703, fixes #1712

- featured star appears immediately for both draft and published items
- featured star is never red & alignment /style is updated
- improved markup and styling of statuses in general
- added to feature tests
2013-12-20 12:29:47 +00:00
Hannah Wolfe
b62923633b Bug fixes, undefined should not be a string 2013-12-15 11:36:01 +00:00
Hannah Wolfe
3ef7f36ece CSS and layout fixes for image uploader
closes #1673
- dropzone icon doesn't appear when filestorage is false
- proper cursor and no selection on icon
- cleaned up some sass
2013-12-14 15:55:44 +00:00
Hannah Wolfe
09d8329712 Merge pull request #1648 from KingKarl85/api-slashes
backbonejs model conflict with connect-slashes
2013-12-12 04:47:59 -08:00
Karl Mikkelsen
84bda76c18 backbonejs model conflict with connect-slashes
close #1648
- backbonejs model doesn't include tailing slash by default
- connect-slashes returns 301 for GET without tailing slash
- overwrote backbone model url method to include tailing slash
2013-12-11 21:33:01 +11:00
Lucas
9c0e7be43a Fix typo? 2013-12-10 09:54:19 -02:00
Harry Wolff
f08633d1a6 Debounce post settings events
fixes #1582
2013-12-07 16:26:06 -05:00
Sebastian Gierlinger
56de932492 Fix error when uploading logo/cover image
closes #1616
- removed pars from model
- changed checkbox handling
2013-12-06 16:43:53 +01:00
Hannah Wolfe
0c5b315d54 Scoping tag styling to the tag control
fixes #1309
2013-11-28 19:09:25 +00:00
Hannah Wolfe
b8c9128d20 Merge pull request #1577 from halfdan/527-subdir-admin
Fix Admin interface with sub directories
2013-11-28 05:14:23 -08:00
Hannah Wolfe
5165386f0d Improvements to date handling in post settings menu
issue #1350, #1351

- make sure we don't fire save if the date hasn't changed - and removes a few errors
2013-11-28 12:37:34 +00:00
Hannah Wolfe
c03f475c6d Content pane update for static pages
fixes #1350

- no concept of published page
2013-11-28 10:48:50 +00:00
Fabian Becker
62f656cc53 Subdir support for admin interface
refs #527
2013-11-27 09:57:38 +00:00
Manuel Gellfart
1fd03b846b Restructure error and success messages for the editor.
closes #1368
- merged the Maps for Error/Notification Messages into one JSON-structure
- this structure is more translation-friendly and influenced by I18n-standards.

Merged the Error and Message Map into one structure

The new JSON-structure is more translation friendly and similiar to i18n.
2013-11-26 01:00:46 +01:00
Hannah Wolfe
a85e5cd265 Merge pull request #1548 from bastilian/improve_image_uploader_ui
Improve image uploader UI
2013-11-24 10:07:38 -08:00
Daniel Hanson
f0c7af3be7 Modified ghostdown markdown extension to allow for 4+ inline underscores
See #1113
- added additional regex rule to replace 4+ underscores with their coded equivalent: &#95;
2013-11-24 17:39:01 +01:00
Hannah Wolfe
d7a29d069f Merge pull request #1550 from bastilian/fix_1532
Fix tag input field
2013-11-23 14:37:30 -08:00
Hannah Wolfe
5ec7a95d54 Merge pull request #1533 from jgillich/permalinks
Add Customisable Permalinks
2013-11-23 14:29:02 -08:00
Sebastian Gräßl
da38d1ae9f fix tag input field
closes #1532
- giving higher priority to css selector for .tag-input in order to override global input-style
- remove padding set by global input-style to align nicely with already set tags
2013-11-23 19:45:42 +01:00
Hannah Wolfe
0f96b718ae Merge pull request #1534 from jgable/passwordReset
Improved Password Reset Tool
2013-11-23 08:44:08 -08:00
Sebastian Gräßl
003ae8f4f9 Improve image uploader UI
closes #1356
- add button to toggle back to uploader from image-url interface
- put save button next to url-input
- make box-height consistent
- position ui-elements to have equal padding all around to border
2013-11-23 17:33:38 +01:00
Jakob Gillich
a2cb218d9a Add Customisable Permalinks 2013-11-23 17:02:17 +01:00
Hannah Wolfe
9842a2e016 Merge pull request #1544 from ErisDS/client-model-fix
Bugfix handle model and collection separately
2013-11-22 14:07:36 -08:00
Hannah Wolfe
ddc135f222 Bugfix handle model and collection separately
issue #1533

- replaces templateModel which was a weird hybrid with progressModel and progressCollection
2013-11-22 21:48:37 +00:00
Jacob Gable
2020c3dddb Improved Password Reset Tool
Closes #1471

- add api and User model methods for generating and validating tokens
- add routes and handlers for reset password pages
- add client styles and views for reset password form
- some basic integration tests for User model methods
2013-11-22 10:46:19 -06:00
Jakob Gillich
8ac1afe65d Remove unneccessary type conversion 2013-11-22 17:21:25 +01:00
Hannah Wolfe
ad67b0dd50 Merge pull request #1485 from Archanium/MinorIssues
Danish language file and a correction to Markdown modal
2013-11-19 04:35:13 -08:00
Thomas Faurbye Nielsen
bbba5d36c1 Correct the Markdown for emphasis 2013-11-19 12:59:04 +01:00
Hannah Wolfe
7d253f20e4 Merge pull request #1353 from thgaskell/1350-static-page-checkbox
Allow user to set static page before saving
2013-11-19 03:29:35 -08:00
Hannah Wolfe
bf867ec6fd Remove inline script from default.hbs
closes #1268
2013-11-16 18:47:55 +00:00
Michael Bradshaw
3125bd5575 Add support for SVG images 2013-11-12 11:37:54 -07:00
Hannah Wolfe
682853537f Merge pull request #1446 from JohnONolan/notifications
Growl style desktop notifications
2013-11-12 04:15:35 -08:00
Hannah Wolfe
a6fcf8cac7 Merge pull request #1440 from JohnONolan/post-settings
Post settings refactor
2013-11-12 03:50:56 -08:00
John O'Nolan
d85826b821 Growl style desktop notifications
First pass. See #1349
2013-11-12 09:58:45 +01:00
John O'Nolan
6e3abb1ad4 Complete post-settings menu refactor 2013-11-12 09:19:02 +01:00
Hannah Wolfe
07d98c333f Merge pull request #917 from jgable/publishedAtTime
Allow published_at times to be specified
2013-11-11 14:45:58 -08:00
Jakob Gillich
a20d2f3f82 Show "Write a new Post" message when there are no posts
closes #1308
2013-11-11 22:14:01 +01:00
Jacob Gable
38ced35054 Allow published_at times to be specified
Fixes #907

- Modified the PostSettings view to use moment.js formats that include hours and minutes
- Add 12:00 to value if it is not specified
2013-11-11 14:43:47 -06:00
Hannah Wolfe
e995b95e6a Merge pull request #1331 from zacgeis/dirtymessage-fix 2013-11-11 09:42:35 +00:00
Hannah Wolfe
3df01ab2c7 Preventing incorrectly shown unload alert
issue #1327

- IE9 fires an unload when using Backbone.history.navigate which meant the alert always got shown on first save when the url changes from from /editor/ to /editor/id. Not sure if other browsers do this, but this workaround fixes it
2013-11-11 09:36:29 +00:00
Hannah Wolfe
5b230d6013 Moving dirty editor handling out of uploadMgr
issue #1327

- just moved to be in editor obj, everything else is the same
2013-11-11 09:14:18 +00:00
Zach Geis
b70b712c97 Displays alert if editor is dirty before unload
closes #1327
- Prevents user from accidently losing changes
2013-11-11 09:00:15 +00:00
Fabian Becker
2da011a834 Fix page errors during builds.
fixes #1434
2013-11-10 23:46:09 +00:00
John O'Nolan
cf7b03bfff Kill iCheck cause Hannah says it has genital warts. 2013-11-08 14:38:23 +01:00
Fabian Becker
b5c8789c54 Properly format publish date.
fixes #1335
2013-11-05 17:44:13 +00:00
John O'Nolan
650eee85ab Make webkit autocomplete login styles less heinous
Fixes #771
2013-11-03 09:29:59 +01:00
Hannah Wolfe
dfa75f0c74 Merge pull request #1345 from halfdan/944-crazy-notifications
Fix notification stacking.
2013-11-01 09:00:56 -07:00
Ben Gladwell
b809bdbe1c Remove unparam:true from jslint config in Gruntfile.js
issue #1365
- added /*jslint unparam:true*/ to functions where absolutely necessary
- added /*jslint unparam:true*/ to functions in which keeping parameter
  list added clarity to the underlying api, even when those parameters
  are not currently used
- removed unused parameters in a few places
2013-10-31 14:02:34 -04:00
John O'Nolan
d08f0ab7b7 Improved image cancel button
* Removed duplicate references
* Adjusted hover styles
* Imroved visibility of icon on dark images
2013-10-30 14:35:24 +01:00
John O'Nolan
329359a6b7 Fix bug where image-delete icon was on top of floating headers 2013-10-30 14:20:44 +01:00