Commit Graph

28900 Commits

Author SHA1 Message Date
James Morris
415dfa97b3 Refactored and cleared out some unneeded Dashboard CSS
no issue
2022-07-14 10:37:10 +01:00
James Morris
551db84966 Small fix for email newsletter setting arrow placement
no issue
2022-07-14 09:52:26 +01:00
Ronald Langeveld
a0c8db46fb
Member Counter template helpers (#15013)
ref https://github.com/TryGhost/Team/issues/1667

Introducing 2 new helper handlebars tags, `{{total_members}}` and `{{total_paid_members}}` ideal for Member Sites who want to display these metrics to incentivise users to upgrade.
2022-07-14 10:10:02 +02:00
renovate[bot]
b6818b77bd Update dependency @playwright/test to v1.23.3 2022-07-14 08:42:49 +01:00
Simon Backx
d65aa08772
Added access-control-max-age to content API preflight requests (#15026)
refs https://github.com/TryGhost/Team/issues/1676

- Added maxAge option to content API
- Added maxAge to members API
- Added maxAge to frontend site preflights (probably not used, but it was configured, so added to be sure)
- Added config option to change default maxAge of preflight requests
2022-07-14 09:09:53 +02:00
renovate[bot]
000fc98f24
Update dependency analytics-node to v6.1.0 2022-07-13 20:00:15 +00:00
Djordje Vlaisavljevic
048b0470da Updated lint-todo 2022-07-13 18:25:54 +02:00
Djordje Vlaisavljevic
5ad99f79a9 Added unique aria-labels to form elements 2022-07-13 18:25:46 +02:00
Djordje Vlaisavljevic
a710dd3c06 Removed option to close the modal by clicking behind it 2022-07-13 17:28:29 +02:00
Djordje Vlaisavljevic
82808d69f5 Made the "back" buttons have unique aria-label attributes 2022-07-13 17:27:24 +02:00
Djordje Vlaisavljevic
6e0bd66063 Updated lint-todo 2022-07-13 17:26:35 +02:00
Kevin Ansfield
cb6e1679e9 Fixed modalOptions.ignoreBackdropClick not always being picked up
no issue

- the modal instance on `this.top` inside the background click handler is not always a direct instance so we need to check both `.options` and `._options` when looking for the desired click ignore behaviour
2022-07-13 16:02:34 +01:00
Djordje Vlaisavljevic
1158555084 Set canonical post placeholder value to post URL 2022-07-13 16:59:28 +02:00
Daniel Lockyer
de23ddb626
Merged v5.3.1 into main
v5.3.1
2022-07-13 12:57:10 +01:00
Daniel Lockyer
a644cc14c1 Merged v5.3.1 into main
v5.3.1
2022-07-13 12:56:50 +01:00
Daniel Lockyer
efe4bd8a1d v5.3.1 2022-07-13 12:55:34 +01:00
Daniel Lockyer
3f380e266d v5.3.1 2022-07-13 12:55:34 +01:00
Daniel Lockyer
5efa9c01ac Updated Admin to v5.3.1 2022-07-13 12:55:34 +01:00
Simon Backx
5f63060f78 🐛 Excluded plan changes from paid subscribers graph in dashboard
refs https://github.com/TryGhost/Team/issues/1673

When a user switches plan, the paid subscribers delta chart on the dashboard displays the change as a cancellation plus a new subscription. This display is misleading and confusing - instead, plan changes should be excluded from the paid subscribers delta chart.
2022-07-13 13:46:45 +02:00
Simon Backx
90461c42d2
Added subscriber signup and cancellation deltas to stats API (#15023)
refs https://github.com/TryGhost/Team/issues/1673

When a user switches plan, the paid subscribers delta chart on the dashboard displays the change as a cancellation plus a new subscription. This display is misleading and confusing - instead, plan changes should be excluded from the paid subscribers delta chart.

To accomplish this, we added new properties to the API (signups and cancellations) that can be used to exclude plan changes in the statistics.

Changes in `@tryghost/stats-service`: d0dd218fc7

Related admin changes: https://github.com/TryGhost/Admin/pull/2425
2022-07-13 13:45:24 +02:00
Naz
02541031ec Updated webhook snapshots
refs TryGhost/Toolbox#340
refs TryGhost#13451

- Fixed the snapshot files which had to include new fields like "comment_notifications" as well as other properties that came along with the hacky solution to the webhook's auhor inclusion bug
- Also documented the "roles" being included inconsistently across different events - it's a BUG and should be looked into one day when we care enough.
2022-07-13 23:05:27 +12:00
Naz
ba061d86e8 🐛 Fixed missing authors in webhook payload
closes https://github.com/TryGhost/Toolbox/issues/340
closes https://github.com/TryGhost/Ghost/issues/13451

- Webhook subscribers were receiving post request payloads without `authors` and `primary_author` properties.
- The behavior was due to missing "originalOptions" property that is needed to correctly serialize the model to json on the model layer.
- A more holistic approach would be to pass the options somehow along with the model with the event. This would require a deeper rework though
2022-07-13 23:05:27 +12:00
Fabien 'egg' O'Carroll
86905aaad8
🐛 Fixed cookies when running Ghost without SSL (#15022)
As part of the updates to auth cookies we switched to SameSite=None
which requires an SSL connection. Local development, and some
production sites do not use SSL and so the cookie is invalid and a
session is unable to be created with the browser.
2022-07-13 11:27:28 +01:00
Fabien 'egg' O'Carroll
7d85a434b2
🐛 Fixed cookies when running Ghost without SSL (#15022)
As part of the updates to auth cookies we switched to SameSite=None
which requires an SSL connection. Local development, and some
production sites do not use SSL and so the cookie is invalid and a
session is unable to be created with the browser.
2022-07-13 10:49:06 +01:00
renovate[bot]
a23cf94b60
Update dependency image-size to v1.0.2 2022-07-12 15:25:08 +00:00
Daniel Lockyer
815fdc9235 v5.3.0 2022-07-12 16:24:02 +01:00
Daniel Lockyer
3c63a01eec v5.3.0 2022-07-12 16:24:01 +01:00
Daniel Lockyer
9284469fb5 Updated Admin to v5.3.0 2022-07-12 16:24:01 +01:00
Daniel Lockyer
8d0c88e9ef 🎨 Updated Casper to v5.2.0 2022-07-12 16:24:01 +01:00
Naz
0bc66558c3 Added unit test coverage to the user service
refs https://github.com/TryGhost/Ghost/issues/15008

- Added basic coverage for the reset all passwords frlow to pass the test coverage bar
2022-07-13 03:06:04 +12:00
Naz
db125ec0b9 Added post tag assignment on user deletion
closes https://github.com/TryGhost/Ghost/issues/15008

- To improve searchability of the posts written by a removed user we are adding an internal tag to all the posts the user was an author or a co-author of
- This improvement should make managing and disovering deleted user's post way easier
2022-07-13 03:06:04 +12:00
Naz
2956c1e88a Migrated test to more readable syntax
no issue

- A bit of a cleanup before touching this test suite. The use of `done` in tests is soooo outdated
2022-07-13 03:06:04 +12:00
Simon Backx
63f2cfdd32 Fixed comments fixtures being created in parallel
refs https://ghost.slack.com/archives/C02G9E68C/p1657633760754589?thread_ts=1657624324.578099&cid=C02G9E68C

- The two comment fixtures are created in parallel
- Second one is created while the first one doesn't exist yet, which causes a FK constraint error
2022-07-12 15:59:55 +02:00
Daniel Lockyer
e7ccdedb8d
Updated .npmignore
- added `Gruntfile.js` - this file is only for development
- added `ghost-*.tgz` - this avoid packaging other packaged Ghost
  archives
- added `!core/frontend/src/admin-auth/*.html` - this re-adds the Admin Auth
  HTML file that would otherwise be excluded from the build
2022-07-12 14:09:01 +01:00
Sanne de Vries
be2744c27f Updated activity feed empty state icon 2022-07-12 14:03:40 +01:00
Sanne de Vries
18102f309b Fixed empty state icons in dark mode 2022-07-12 13:49:24 +01:00
Sanne de Vries
be0fb41636 Updated webhook actions to dotdotdot menu 2022-07-12 13:38:51 +01:00
Rishabh Garg
b9285b456b
Bumped new built-in search to GA (#15017)
refs https://github.com/TryGhost/Team/issues/1665

- bumps new search feature to GA from alpha
- allows sites to trigger new built-in search feature via `data-ghost-search` attribute or navigation link( `#/search` )
2022-07-12 17:57:11 +05:30
Naz
c7de8d3358 Updated copy for user deletion modal
refs https://github.com/TryGhost/Ghost/issues/15008

- When the user is removed the new flow adds a special tag and reassignes all the user-owned posts to the owner user. Updated copy to inform about this behavior clearly
2022-07-13 00:26:13 +12:00
Fabien 'egg' O'Carroll
34ddbcd52e
Fixed admin auth asset loading (#15018)
The copyStatic method relies on the dest directory existing, which is
done created the minify method. We've reordered the calls to fix the
issue, but we're still left with the copyStatic method being dependent
on the minify method. Adding the `@private` jsdoc tag removes these
from the public interface, so that the dependency is encapsulated in
this module via the `load` method.

We've also awaited the result of the copyStatic method to avoid
dangling promises.
2022-07-12 13:25:28 +01:00
Simon Backx
61e1ee07dc Bumped Portal to 2.3.0 to include comment notification settings
refs https://github.com/TryGhost/Team/issues/1664

- This doesn't require a feature flag, as comments are disabled by default + UI is hidden if comments are disabled
2022-07-12 13:58:20 +02:00
Sanne de Vries
abc11a8028 Fixed broken activity filter empty state 2022-07-12 12:47:48 +01:00
Sanne de Vries
ea2bbef4c1 Fixed broken icon for activity empty state 2022-07-12 12:28:57 +01:00
Sanne de Vries
ea92f89c1d Removed unused contributors code and images 2022-07-12 11:38:08 +01:00
Simon Backx
0292b4868b Reduced minimum required test coverage for functions
refs https://ghost.slack.com/archives/C02G9E68C/p1657607789883059?thread_ts=1657522575.865029&cid=C02G9E68C

Tests are failing because of the minimum required test coverage for functions. We'll need to fix it up later.
2022-07-12 10:24:02 +02:00
Fabien "egg" O'Carroll
34047737b8 Updated comments helper to inject comments-ui version
refs https://github.com/TryGhost/Team/issues/1664

This is required so that the comments ui can correctly load assets from unpkg
2022-07-12 10:24:02 +02:00
Kevin Ansfield
d05b94a975 Added build step for admin-auth asset files
refs https://github.com/TryGhost/Team/issues/1664

- ensures source files are copied to the correct place and minified on boot and when frontend src files are changed in development
2022-07-12 10:24:02 +02:00
Kevin Ansfield
6ea545afe1 Added comment-counts script
refs https://github.com/TryGhost/Team/issues/1664
2022-07-12 10:24:02 +02:00
Simon Backx
e1a3adea6a Updated message handler for dynamic admin urls
refs https://github.com/TryGhost/Team/issues/1664
2022-07-12 10:24:02 +02:00
Simon Backx
a6842e8a20 Added support for blockquote in comments
refs https://github.com/TryGhost/Team/issues/1664
2022-07-12 10:24:02 +02:00