Commit Graph

29857 Commits

Author SHA1 Message Date
Kevin Ansfield
89d4e3daf9
Updated error messages for invalid mobiledoc+lexical post/page API requests (#15477)
closes https://github.com/TryGhost/Team/issues/1896

- updated message to be clearer, added context and help
2022-09-27 10:30:28 +01:00
Fabien "egg" O'Carroll
d3030cb87d Fixed query param typo for newsletter source attribution
The attribution tracking script uses the `ref` param, not `rel`
2022-09-27 10:25:29 +01:00
Djordje Vlaisavljevic
4858baf2df Added doughnut chart titles
refs https://github.com/TryGhost/Team/issues/1905
2022-09-27 10:55:27 +02:00
Djordje Vlaisavljevic
87ad7d1df3 Updated font weight for source
refs https://github.com/TryGhost/Team/issues/1953
2022-09-27 10:51:51 +02:00
Djordje Vlaisavljevic
83f88e1586 Added pointer cursor to column names
refs https://github.com/TryGhost/Team/issues/1941
2022-09-27 10:02:27 +02:00
Djordje Vlaisavljevic
5d5fc33d2c Updated MRR widget design
refs https://github.com/TryGhost/Team/issues/1932
2022-09-27 09:53:41 +02:00
Sanne de Vries
ac7d7427e9 Fixed padding on member-limit notification box on publish page
Refs https://github.com/TryGhost/Team/issues/1885
2022-09-27 11:27:58 +07:00
Daniel Lockyer
9818634b63
Merged v5.16.1 into main
v5.16.1
2022-09-27 11:21:48 +07:00
Ghost CI
ddb9c1b30c v5.16.1 2022-09-27 05:21:10 +01:00
Rishabh
0349acb7e3 Updated content cta to use global accent color property
refs https://github.com/TryGhost/Ghost/pull/15471#discussion_r979902374

- the accent color value used by default content cta was copying the global site property which is redundant, and can be directly used
- originally, the accentColor property was extended to allow a fallback value for content ctas, but was later removed as we added default value to global site property directly
- the accentColor property is now deprecated and will be removed in next version, as existing themes might be relying on it for custom cta helpers
2022-09-27 09:41:54 +05:30
Rishabh
1410a4237e 🐛 Fixed default content CTA message to reflect page vs post
closes https://github.com/TryGhost/Team/issues/1898

- the default content cta always used the terminology as `post` when showing message that users don't have access to some content
- this caused confusion when users were looking at a page and message showed "This post is for subscribers only"
- updates the message to correctly reflect `page` vs `post` on the default cta
2022-09-27 09:41:54 +05:30
renovate[bot]
9eb3c84a23
Updated @tryghost dependencies (#15434)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-09-27 08:31:35 +07:00
Daniel Lockyer
6e3da6921e
Removed MySQL 5 from CI
closes https://github.com/TryGhost/Toolbox/issues/396

- we no longer support MySQL 5 so we shouldn't be running CI against it
- this cleans up use of MySQL 5 in GHA
2022-09-27 08:03:53 +07:00
renovate[bot]
7d21e192b2
Update metascraper to v5.31.1 2022-09-26 20:28:26 +00:00
Rishabh Garg
b1b3c72642
Added sorting for attribution data on dashboard (#15474)
refs https://github.com/TryGhost/Team/issues/1941

- sorts attribution table and chart on signups or paid conversions
2022-09-26 23:29:30 +05:30
James Morris
83e608c25b Changed link clicks to newsletter links for analytics page
refs https://github.com/TryGhost/Team/issues/1968
2022-09-26 18:12:06 +01:00
James Morris
8bef3b9e34 The new post list rows match the edit or analytics button
refs https://github.com/TryGhost/Team/issues/1965
2022-09-26 18:09:52 +01:00
Kevin Ansfield
e3db911108
🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473)
closes https://github.com/TryGhost/Team/issues/1885

- adds limit check for members to the `PublishOptions` class when it's constructed to set a `publishDisabledError` property if the limit check fails
  - if `publishOptions.publishDisabledCheck` is present, all publish options in the publish flow are disabled, the underlying error message is shown, and the continue button is removed to prevent filling in everything only to find at the end of the process that publishing fails
- added handling for a `HostLimitError` error from the API when confirming publishing so the proper underlying message is displayed instead of the confusing "Host limit error, cannot edit post" error
  - this is a backup measure for any instances where you're under the max members limit when starting the publish flow but are over the limit when you reach the end of the publish flow
2022-09-26 17:37:35 +01:00
James Morris
ad2cb3ae11 Lots of visual tweaks to the post list table
refs https://github.com/TryGhost/Team/issues/1965
2022-09-26 17:30:39 +01:00
Simon Backx
86022b136b
Allowed free signups regardless of Portal settings (#15472)
fixes https://github.com/TryGhost/Team/issues/1966

- Currently you can only do a free self signup when 'free' is enabled in Portal or when Stripe is disabled
- Some themes, such as the Edition theme add a free signup form to the theme. That theme stops working if we don't allow self signup.
- The portal settings shouldn't be used to determine if free signup is allowed or not.
2022-09-26 18:25:06 +02:00
Simon Backx
d132b723da Added unit tests to link-redirects package
fixes https://github.com/TryGhost/Team/issues/1958
2022-09-26 18:13:05 +02:00
Djordje Vlaisavljevic
ac661c19b7 Updated copy
refs https://github.com/TryGhost/Team/issues/1953
2022-09-26 17:26:01 +02:00
Djordje Vlaisavljevic
74873c7e48 Updated the heading text
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 17:25:27 +02:00
Djordje Vlaisavljevic
3a9143cacc Removed the medium info from the subscription box
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 17:20:14 +02:00
Djordje Vlaisavljevic
f9ce3239ee Updated the heading text
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 17:19:12 +02:00
Djordje Vlaisavljevic
bb0b9c4261 Added rotation to the details toggle arrow
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 17:12:56 +02:00
Djordje Vlaisavljevic
bdc43d8f66 Updated table design
refs https://github.com/TryGhost/Team/issues/1941
2022-09-26 17:12:25 +02:00
Djordje Vlaisavljevic
752cf1a607 Added static sort indicator to the table
refs https://github.com/TryGhost/Team/issues/1941
2022-09-26 15:53:26 +02:00
Djordje Vlaisavljevic
64d4ddbaca Updated logic for showing member profile attribution
refs https://github.com/TryGhost/Team/issues/1953
2022-09-26 15:52:39 +02:00
Djordje Vlaisavljevic
81e15f823b Updated logic for showing member profile attribution
refs https://github.com/TryGhost/Team/issues/1953
2022-09-26 15:44:53 +02:00
Djordje Vlaisavljevic
6461e814db Updated font weight
refs https://github.com/TryGhost/Team/issues/1941
2022-09-26 15:32:18 +02:00
Djordje Vlaisavljevic
d024bd60fc Updated attribution widget design
refs https://github.com/TryGhost/Team/issues/1941
2022-09-26 15:30:20 +02:00
Simon Backx
281cd2e7a3
Renamed count.conversions to count.paid_conversions in posts (#15460)
fixes https://github.com/TryGhost/Team/issues/1943
2022-09-26 14:25:27 +02:00
Djordje Vlaisavljevic
acd1de3983 Removed chart border on hover
refs https://github.com/TryGhost/Team/issues/1905
2022-09-26 13:38:56 +02:00
James Morris
97af5c3731 Added a small tweak to the percentages on post list
refs https://github.com/TryGhost/Team/issues/1965
2022-09-26 12:30:54 +01:00
James Morris
7e780681d9 Looking to improve the post list rows again for email clicks
refs https://github.com/TryGhost/Team/issues/1965
2022-09-26 12:30:54 +01:00
James Morris
c92267c900 Realignement of the post list items for email clicks
no issue
2022-09-26 12:30:54 +01:00
Daniel Lockyer
a94c93e1c0
Added yarn build command
refs https://github.com/TryGhost/Toolbox/issues/390

- this allows us to run `yarn build` and make it output a .tgz file
  which can be installed with `ghost install --archive ...`
2022-09-26 18:28:30 +07:00
Djordje Vlaisavljevic
ceadb2634f Updated MRR widget design
refs https://github.com/TryGhost/Team/issues/1932
2022-09-26 13:21:05 +02:00
Djordje Vlaisavljevic
4941627128 Added show/hide behaviour to subscription box details
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 13:20:31 +02:00
Djordje Vlaisavljevic
b9c7fe316b Updated attribution widget design
refs https://github.com/TryGhost/Team/issues/1941
2022-09-26 12:14:06 +02:00
Kevin Ansfield
2de0c1358f 🐛 Fixed product card not displaying with just an image+button
closes https://github.com/TryGhost/Team/issues/1877

- bumped `@tryghost/kg-default-cards` which includes updated "should render" dependencies that adds a fully enabled button to the list of possible requirements for the product card to render. Now any one of the following will render the product card:
  - title is present
  - description is present
  - button url is enabled and button text+url are present
2022-09-26 09:38:49 +01:00
Simon Backx
bf008bee2d 🐛 Fixed deleting users with draft posts
fixes https://github.com/TryGhost/Team/issues/1945

- When deleting a user, a private tag is assigned to their existing posts.
- In that loop, it tries to find the post, but the post model had a default filter to only return published posts.
- An error was thrown because the post model was not fetched.
2022-09-26 10:19:33 +02:00
renovate[bot]
d02401c1f0
Update dependency eslint to v8.24.0 2022-09-26 06:58:26 +00:00
Naz
4528cba1b9 Changed Content API caching to public
refs https://github.com/TryGhost/Toolbox/issues/410

- Private cache control was preventing browser or shared caches from storing Content APIs response. The type of data served through the Content API is very much of a "public" nature, so should be cacheable.
- Right now the 'max-age' value of 'cache-control' header is hardcoded to '0', without 'must-revalidate' value, to allow browsers to cache content slightly more aggressively. In the future the 'max-age' value will most-likely become configurable to allow even more aggressive HTTP caching.
2022-09-26 14:54:50 +08:00
Naz
7b009bf1fe Enabled shared caching of 404 error responses
refs https://github.com/TryGhost/Toolbox/issues/410

- The 'private' value in 'Cache-Control' response header for all errors made it impossible for shared caches (e.g.: Fastly, Cloudflare) to cache 404 responses efficiently.
- The change substitutes 'max-age=0' which should not effect the browser cache behavior but would allow shared caches to process such requests efficiently.
- A more loose caching logic only applies to 404 responses from GET requests that are not user-specific (non-authenticated, non-cookie containing requests)
2022-09-26 14:54:50 +08:00
Naz
2acb0fca74 Refactored error cache control logic to middleware
refs https://github.com/TryGhost/Toolbox/issues/410

- This is groundwork for split cache-control rules for Admin app endpoints and the rest of Ghost apps.
2022-09-26 14:54:50 +08:00
Rishabh
190031f38c Added modal for showing all attribution sources
refs https://github.com/TryGhost/Team/issues/1941

- limits the source attribution list to top 5 on dashboard, and shows all sources on clicking on `Other` link

Fixed lint
2022-09-26 10:43:05 +05:30
Rishabh
baaf64405a Refined details toggle on member subscription box
refs https://github.com/TryGhost/Team/issues/1904
2022-09-26 10:43:05 +05:30
Rishabh
f4e6f00077 Refined attribution chart to show custom tooltips
refs https://github.com/TryGhost/Team/issues/1905
2022-09-26 10:43:05 +05:30