Commit Graph

572 Commits

Author SHA1 Message Date
Daniel Lockyer
6dc1d08590 Re-enabled general eslint rules in TS config
refs https://github.com/TryGhost/DevOps/issues/50

- when creating a TS config in our `eslint-plugin-ghost` dependency, I
  only extended the recommended config, which left out a lot of
  stylistic things we used to enforce in JS
- this fixes that by bumping the dependency to a version which extends
  those shared configs, and fixes all the code that currently goes
  against those rules
2023-09-08 13:47:42 +02:00
Simon Backx
d40b8c7d63 Released comments-ui v0.13.1 2023-09-06 17:33:42 +02:00
renovate[bot]
d15aed0d0a Update tiptap monorepo to v2.1.8 2023-09-05 06:40:46 +00:00
Daniel Lockyer
c6cb35074a Updated linting and testing packages 2023-09-01 15:51:17 +02:00
renovate[bot]
d5e273a3ac Update dependency @headlessui/react to v1.7.17 2023-08-31 15:03:57 +00:00
renovate[bot]
d58f5dcc9f Update tiptap monorepo to v2.1.7 2023-08-31 14:33:11 +00:00
renovate[bot]
f977227d18 Update dependency postcss to v8.4.29 2023-08-30 08:29:32 +02:00
renovate[bot]
24300120c2 Update dependency vitest to v0.34.3 2023-08-29 18:52:13 +01:00
renovate[bot]
ad1743816a Update dependency @playwright/test to v1.37.1 2023-08-29 08:38:03 +01:00
Simon Backx
7a7c11c7ec Released comments-ui v0.13.0 2023-08-24 11:05:19 +02:00
Simon Backx
e9703f6a15
Extended translations beta to comments (#17801)
refs https://github.com/TryGhost/Product/issues/3504
2023-08-24 10:33:03 +02:00
Simon Backx
375a6d37c2
Added support for i18n in comments-ui (#17797)
refs https://github.com/TryGhost/Product/issues/3504

- This adds support for translations, but doesn't yet translate every
possible string in the app.
- Only active if beta translations is enabled
2023-08-23 13:57:37 +00:00
renovate[bot]
f9589ff7bd Update dependency vitest to v0.34.2 2023-08-23 11:45:02 +01:00
renovate[bot]
26bdba9d4c Update dependency concurrently to v8.2.1 2023-08-22 17:39:36 +01:00
Simon Backx
f1b51729fc
Converted Comments-UI App to TypeScript and React hooks (#17760)
refs https://github.com/TryGhost/Product/issues/3504

- App component now uses React hooks intead of React class component
- App is now written in TypeScript
- All JavaScript is now removed from the Comments-UI project
- Removed `PopupNotification` because these were never displayed
- Removed `action` from AppContext (never used)
- Moved options parsing out of `index.ts` into a separate utility file,
similar to the signup-form
- Improved reliability of some editor tests by always waiting for the
editor to be focused (was not always the case) + added an utility method
for this
2023-08-18 13:30:59 +00:00
Simon Backx
850cc7a9a1
Moved old comment tests to Playwright (#17750)
refs https://github.com/TryGhost/Product/issues/3504
2023-08-17 12:47:08 +02:00
Simon Backx
c8daf2e514
🐛 Fixed comments admin menu not visible when not logged in as member (#17749)
refs https://github.com/TryGhost/Product/issues/3504

- When you are logged in as an admin, but not as a member, no buttons
showed (discovered in new e2e tests)
- Added E2E tests for admin actions
2023-08-17 09:20:40 +00:00
renovate[bot]
e1d92d642a Update dependency postcss to v8.4.28 2023-08-16 06:08:42 +02:00
renovate[bot]
2e86693eb6 Update dependency autoprefixer to v10.4.15 2023-08-14 07:56:13 +02:00
renovate[bot]
4d6e52b28c Update dependency @playwright/test to v1.37.0 2023-08-11 08:53:10 +02:00
renovate[bot]
0424915a31 Update dependency @vitejs/plugin-react to v4.0.4 2023-08-09 11:43:08 +02:00
renovate[bot]
1353b04c9d Update dependency vite-plugin-css-injected-by-js to v3.3.0 2023-08-09 11:28:50 +02:00
renovate[bot]
98dc4d7b06 Update dependency vite to v4.4.9 2023-08-09 10:09:03 +02:00
renovate[bot]
9f85124a2e Update dependency vitest to v0.34.1 2023-08-09 09:54:48 +02:00
renovate[bot]
ca7d829915 Update dependency vite to v4.4.8 2023-08-09 09:50:54 +02:00
Daniel Lockyer
c97cc08455 Updated ESLint config for React+Typescript packages
refs https://github.com/TryGhost/DevOps/issues/50

- `react-app` comes from `eslint-config-react-app`, which is a CRA package
- we're moving away from that so this commit switches the linting over
  to a more recently updated plugin
- once that was removed, we started using a newer version of
  `@typescript-eslint/eslint-plugin`, so there were plenty of
  updates/exemptions to make
2023-07-27 11:40:31 +02:00
Daniel Lockyer
33e2b39295 Removed old versions of @typescript-eslint/{eslint-plugin,parser}
refs https://github.com/TryGhost/DevOps/issues/50

- this helps prevent old versions of the dependency from lingering
  around (especially when it's unused)
2023-07-25 16:48:54 +02:00
renovate[bot]
3830401d55 Update dependency @playwright/test to v1.36.2 2023-07-25 12:26:15 +02:00
renovate[bot]
5ca8c1f568 Update dependency vite to v4.4.7 2023-07-24 20:56:39 +02:00
Daniel Lockyer
d0f9c8cf0c Deduplicated eslint and eslint-plugin-ghost to top-level package.json
refs https://github.com/TryGhost/DevOps/issues/50

- this deduplicates where we define the version of `eslint` and
  `eslint-plugin-ghost` so it's easier to maintain
2023-07-24 16:21:47 +02:00
renovate[bot]
7fc8fd1696 Update tiptap monorepo to v2.0.4 2023-07-24 10:33:33 +00:00
renovate[bot]
401c1a0d10 Update dependency postcss to v8.4.27 2023-07-21 14:42:30 +02:00
renovate[bot]
7cdc87ed99 Update dependency vite to v4.4.6 2023-07-21 12:31:29 +02:00
renovate[bot]
9a24877e7d Update dependency vite to v4.4.5 2023-07-21 09:23:51 +02:00
Daniel Lockyer
52df88cf63 Updated tiptap monorepo to v2.0.3
- also adds `@tiptap/pm` as this is requires in v2.0.0 and removes the
  resolutions as they are no longer needed
2023-07-19 12:08:52 +02:00
renovate[bot]
b6439457e6 Update dependency vite-plugin-css-injected-by-js to v3.2.1 2023-07-17 21:42:43 +02:00
renovate[bot]
8e4393d16f Update dependency @playwright/test to v1.36.1 2023-07-17 09:48:14 +02:00
renovate[bot]
2f76f07dff Update dependency vite to v4.4.4 2023-07-14 11:04:59 +02:00
renovate[bot]
b8870dec99 Update dependency tailwindcss to v3.3.3 2023-07-14 08:58:58 +02:00
renovate[bot]
6a13e5e737 Update dependency postcss to v8.4.26 2023-07-14 08:16:06 +02:00
renovate[bot]
707f2501c5 Update dependency prosemirror-model to v1.19.3 2023-07-13 14:07:23 +02:00
renovate[bot]
828d3e4a1a Update dependency @playwright/test to v1.36.0 2023-07-11 20:53:08 +02:00
renovate[bot]
bef119fa0f Update dependency vite to v4.4.3 2023-07-11 17:17:23 +02:00
renovate[bot]
7dce046786 Update Test & linting packages 2023-07-11 15:26:07 +02:00
renovate[bot]
40d05189fe Update dependency @headlessui/react to v1.7.15 2023-07-11 12:46:55 +00:00
renovate[bot]
e81ae6b9a6 Update dependency prosemirror-model to v1.19.2 2023-07-11 08:59:51 +02:00
renovate[bot]
9dd1f97bb0 Update dependency vite to v4.4.2 2023-07-10 18:17:28 +02:00
renovate[bot]
40ecd47500 Update dependency prosemirror-transform to v1.7.3 2023-07-10 18:10:10 +02:00
renovate[bot]
9f7b68adf6 Update dependency prosemirror-state to v1.4.3 2023-07-10 17:59:12 +02:00
renovate[bot]
9a5c13309e Update dependency vitest to v0.33.0 2023-07-10 16:23:32 +02:00
renovate[bot]
0c309454cf Update dependency @vitejs/plugin-react to v4.0.3 2023-07-10 15:40:54 +02:00
renovate[bot]
ea9cc21a0c Update dependency @vitejs/plugin-react to v4.0.2 2023-07-10 13:48:58 +02:00
Daniel Lockyer
fb0807c8c5 Prevented git tags from being created for apps
refs https://ghost.slack.com/archives/C02G9E68C/p1688983916615989?thread_ts=1687341349.559679&cid=C02G9E68C

- these cause issues with our PR workflow because we can't push tags in
  a PR and the commit is rebased onto `main` so the hash changes
- this disables tags for now
2023-07-10 13:09:28 +02:00
renovate[bot]
44d38e4d4e Update dependency vite-plugin-css-injected-by-js to v3.2.0 2023-07-10 10:29:23 +02:00
renovate[bot]
0e5a98e43e Update dependency postcss to v8.4.25 2023-07-10 10:20:30 +02:00
Daniel Lockyer
1aeac9777e Enabled parallel testing for Playwright tests of apps
- we should allow parallel test execution because it's faster than
  serial
2023-07-04 16:08:06 +02:00
renovate[bot]
74f2e08b16 Update dependency vitest to v0.32.4 2023-07-04 12:24:03 +02:00
renovate[bot]
a04a4293cb Update dependency vite-plugin-css-injected-by-js to v3.1.2 2023-06-28 16:21:00 +02:00
Simon Backx
5c843545d8 Added comments-ui editor E2E tests
refs https://github.com/TryGhost/Team/issues/3504
2023-06-28 13:08:35 +02:00
Simon Backx
e6fe60ed37 Added E2E test for colorScheme in comments-ui
refs https://github.com/TryGhost/Team/issues/3504
2023-06-27 16:28:53 +02:00
Simon Backx
23fc00ae60 Added E2E tests for comments-ui accent color option
refs https://github.com/TryGhost/Team/issues/3504

This also fixes an issue where the signup button would become transparent when the accent color option was not set
2023-06-27 16:28:53 +02:00
Simon Backx
81970fbe01 Added E2E test for avatarSaturation on comments-ui
refs https://github.com/TryGhost/Team/issues/3504
2023-06-27 16:28:53 +02:00
Simon Backx
331533d724
Migrated Comments-UI to TypeScript (#17129)
refs https://github.com/TryGhost/Team/issues/3504

This migrates comments-ui to TypeScript. Only `App.js` is left to
migrate, but since this isn't using hooks yet, it will need a bigger
rewrite so this will need to happen in a separate PR.
2023-06-27 14:51:37 +02:00
Simon Backx
9135ca92e0 Added Playwright test for comment reply pagination
refs https://github.com/TryGhost/Team/issues/3504
2023-06-22 19:09:21 +02:00
Simon Backx
8d6fb51908 Added Playwright tests to comments-ui
refs https://github.com/TryGhost/Team/issues/3504

Not complete yet, but contains the basic structure and a few tests that work and should run in CI.
2023-06-22 15:06:13 +02:00
Simon Backx
ab86e0d901 Removed Sentry and unused data options from comments-ui
refs https://github.com/TryGhost/Team/issues/3504

- Sentry was never setup and we don't use it
- Styles have been moved to inline JS styles (no separate css file generated)
- App version was never used
- Improved current script tag detection
2023-06-22 15:06:13 +02:00
Simon Backx
098d2ad3d9 Updated comments-ui eslint rules
refs https://github.com/TryGhost/Team/issues/3504

- Use same rules as signup-forms
- Updates files for the new rules
2023-06-22 10:39:39 +02:00
Daniel Lockyer
dfd5c50b80
Configured yarn dev to allow starting Comments-UI
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for easier development with Comments-UI
2023-06-22 10:23:05 +02:00
Daniel Lockyer
130c9c3c6f
Updated test:unit script for Comments-UI
refs https://github.com/TryGhost/Toolbox/issues/400

- this package won't pass tests on Node 16 because of the use of
  `fetch`, but that's ok because we publish using Node 18 anyway
- this switches the test command to just ensuring the package can build
2023-06-22 10:01:07 +02:00
Daniel Lockyer
8fc09b9433
Removed unneeded files
refs https://github.com/TryGhost/Toolbox/issues/400

- these files are no longer needed now the package is in the monorepo
2023-06-22 09:57:43 +02:00
Daniel Lockyer
5da9264ea7
Updated lockfile
- removed the imported one from comments-ui repo
2023-06-22 09:51:25 +02:00
Simon Backx
60f969c9c2 Locked resolutions of tiptap and prosemirror 2023-06-22 08:35:17 +02:00
Simon Backx
fbd268272a Fixed linting issues 2023-06-21 17:25:47 +02:00
Daniel Lockyer
346b9ff9e2 Added missing dependencies
- both eslint and jsdom are needed to correctly run linting + tests
2023-06-21 17:22:07 +02:00
Daniel Lockyer
fcce6d8519 Removed react-scripts dependency
refs 13d3d0cde6

- this is no longer needed because we've migrated to Vite
2023-06-21 17:19:14 +02:00
Daniel Lockyer
2df3caa159 Removed use of Cypress eslint plugin
refs 13d3d0cde6

- we removed cypress in the referenced commit so this is no longer
  needed
2023-06-21 17:18:00 +02:00
Simon Backx
0f86300757 Added missing changes from previous commit
no issue

Updated package and yarn.lock
2023-06-21 15:37:12 +02:00
Simon Backx
13d3d0cde6 Migrated from Webpack to Vite and updated dependencies
refs https://github.com/TryGhost/Team/issues/3504

- Removed Cypress. Tests will get replaced by Playwright
- Removed unused files and HTML files
- Updated scripts to work similar to Portal, Signup-Form
- Updated to pinned dependencies and removed unused dependencies
2023-06-21 15:28:01 +02:00
renovate[bot]
a441d9dab3 Update dependency react-error-overlay to v6.0.11 2023-06-21 14:43:21 +02:00
renovate[bot]
7a7013dc9c Update dependency bson-objectid to v2.0.4 2023-06-21 14:43:08 +02:00
renovate[bot]
2666b2cec4 Update dependency source-map-explorer to v2.5.3 2023-06-21 14:42:51 +02:00
renovate[bot]
bc0a741df4 Update dependency cypress to v10.11.0 2023-06-21 14:42:39 +02:00
renovate[bot]
777ea0912c Update dependency minimist to v1.2.8 2023-06-21 12:46:16 +02:00
renovate[bot]
ddec966e5d Update dependency tailwindcss to v3.3.2 2023-06-21 12:46:05 +02:00
renovate[bot]
e98d9e3f3c Update dependency chokidar to v3.5.3 2023-06-21 12:41:49 +02:00
renovate[bot]
6e0e9e02ca Update dependency postcss to v8.4.24 2023-06-21 12:41:39 +02:00
renovate[bot]
e8f5ea0f33 Update dependency serve-handler to v6.1.5 2023-06-21 12:41:12 +02:00
Daniel Lockyer
8d611112a1 Updated Renovate config to quietJS
- this is our homegrown Renovate preset that should keep things quiet around here
2023-06-21 12:35:40 +02:00
Daniel Lockyer
08aef4fbb4 Pinned dependencies
- this is an app so we want to pin dependencies to ensure we know what
  version they're using
2023-06-21 12:26:56 +02:00
renovate[bot]
94242ec627 Update dependency @testing-library/react to v12.1.5 2023-06-21 12:19:41 +02:00
renovate[bot]
5a426e5575 Update dependency @testing-library/jest-dom to v5.16.5 2023-06-21 12:17:06 +02:00
renovate[bot]
7a7629620b Add renovate.json 2023-06-21 12:15:03 +02:00
Daniel Lockyer
33fa048c7e Pinned dependencies
- Comments-UI is an app so we should pin the dependencies to ensure we
  know what version it is running
2023-03-21 09:59:12 +01:00
Daniel Lockyer
fac4ec7876 Fixed minor linting issues
- these classes needed to be reordered to satisfy eslint-plugin-tailwindcss
2023-03-17 12:19:52 +01:00
Sodbileg Gansukh
1892be929b v0.12.4 2023-03-14 18:46:10 +08:00
Rishabh
7aa1281e45 Fixed build script not working on Node 18.x
- `yarn start:dev` was failing with `error:0308010C:digital envelope routines::unsupported` without the `--openssl-legacy-provider` option on Node 18. Currently react-scripts@4.x doesn't support Node 18, so until we upgrade to use react-scripts@5.x we'll need to pass in this change for build scripts
2023-03-14 15:42:40 +05:30
Sodbileg Gansukh
be7e3f3e62 Fixed invisible top border issue of the form input (#14)
refs https://github.com/TryGhost/Team/issues/2615
2023-03-14 18:11:49 +08:00
James Morris
4abbb0a8ca v0.12.3 2022-11-11 15:33:51 +00:00
James Morris
a41259be27 Fix the word break for long links in comments on mobile
refs https://github.com/TryGhost/Team/issues/2245
2022-11-11 15:31:34 +00:00
James Morris
9bcdfb911d Removed the duplicate sm config
refs https://github.com/TryGhost/Team/issues/2244
2022-11-11 15:25:57 +00:00