TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-21 01:41:46 +03:00
Code Issues Projects Releases Wiki Activity
33,481 Commits 250 Branches 1,686 Tags 378 MiB
8eefaee591
Commit Graph

33481 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Lockyer
0ec539f084
Switched browser tests back to standard CI machines 
- these larger machines aren't giving us much benefit and cost more
  money, so we're better off with the standard machines right now
 2023-03-20 21:34:18 +01:00
Simon Backx
a5dff4207e Moved posts service to its own package 
fixes https://github.com/TryGhost/Team/issues/2778

It is easier to add extra classes using the latest patterns if it has its own package.
 2023-03-20 16:06:42 +01:00
Elena Baidakova
aca8c5805c Improved members-actions e2e browser test 
refs TryGhost/Team#2667
- Added notification check before checking that user successfully unsubscribed from all newsletters. It helps to make the test more stable
 2023-03-20 18:48:35 +04:00
Simon Backx
07ec33fb3a
Added latest posts to email template (#16448) 
refs https://github.com/TryGhost/Team/issues/2769

Needs some extra styling and design, this is only a minimal version
behind the feature flag.
 2023-03-20 14:30:42 +01:00
Simon Backx
6d8388c5bb Fixed migration version for show latest posts 
no issue

The migration was added to 5.39, but this was not correct. It should have been added to 5.40. This commit fixes moves the migration to the right folder. Running the migration twice locally will skip it because it detects the table is already correct.
 2023-03-20 14:18:30 +01:00
Simon Backx
f2860e745c Added placeholder latest posts to newsletter preview 
refs https://github.com/TryGhost/Team/issues/2768

Added a placeholder to be replaced with some better design and styling.
 2023-03-20 11:30:16 +01:00
Simon Backx
f38d799ae2 Wired up showLatestPosts in admin 
fixes https://github.com/TryGhost/Team/issues/2766

Edit showLatestPosts column via admin.
 2023-03-20 11:26:19 +01:00
Simon Backx
a513542b56
Added show_latest_posts column to newsletter table (#16402) 2023-03-20 11:10:49 +01:00
Sodbileg Gansukh
4aef61ce66 Fixed member list loading UI spacing 
refs https://github.com/TryGhost/Team/issues/2743
 2023-03-20 13:55:51 +08:00
renovate[bot]
827d2abf55 Update dependency @testing-library/react to v12.1.5 2023-03-17 23:38:13 +00:00
Sanne de Vries
1b0adcf4ab Fixed missing stub for DNS in GhostMailer Direct tests 
- without this, Node will try and resolve the domain name but local DNS
  resolvers can take a while to timeout, which causes the tests to timeout
- `nodemailer-direct-transport` calls `dns.resolveMx`, so if we stub that
  function and return an empty array, we can avoid any real DNS lookups
 2023-03-17 18:16:30 +01:00
Simon Backx
a6654b5e6c Updated GhostMailer Direct unit tests to async await style 
no issue

Tests were timing out for some users, probably because not all errors are caught.
 2023-03-17 17:34:01 +01:00
Ghost CI
7f1f6a7249 v5.39.0 2023-03-17 16:00:48 +00:00
Steve Larson
0a4d568f19 updated snapshot 
no refs
-updated snapshot to pass tests
 2023-03-17 10:57:50 -05:00
Daniel Lockyer
cad7082aee Added concurrency group to Browser tests 
- by using the same group (the workflow name), we should be able to
  limit the concurrency to 1 execution, which might help with some
  flaky tests we keep seeing
 2023-03-17 16:35:17 +01:00
Daniel Lockyer
a6966913dd Switched around CI machine allocation 
- now the vast majority of our flaky tests are gone, we don't need the
  bigger machines
- however, browser tests seem to be a little slow, so we can try giving
  them more power than the defaults
- this should also help with resource contention when we have multiple
  jobs running at the same time, as we have double the numbers of
  runners on the free machines
 2023-03-17 16:35:17 +01:00
Peter Zimon
9d25c2a058 Fixed mobile size footer buttons in newsletters 
refs. https://github.com/TryGhost/Team/issues/2740

- alignment of buttons in the footer of newsletter email template was off
 2023-03-17 16:34:23 +01:00
Steve Larson
067b35de6b fixed member newsletter test 
no refs
-fixed flaky test that seemed to have sync issues with fixture data and db
 2023-03-17 10:27:09 -05:00
Rishabh
3d68cd4544 Fixed incorrect newsletter ref for internal links 
refs TryGhost/Team#2755

Previous change for outbound tagging had incorrectly changed the internal links ref for newsletter to include domain. This change fixes it back to use newsletter name for internal links.
 2023-03-17 20:55:52 +05:30
Simon Backx
92fc5bdf70 Fixed email service unit tests for duplicate email buttons 2023-03-17 16:09:50 +01:00
Simon Backx
b3c410a923 Reverted stats snapshot change 2023-03-17 16:06:00 +01:00
Simon Backx
c591f1f86a Updated email batch sending snapshots 2023-03-17 16:00:14 +01:00
Sanne de Vries
48a3159d3d Added mobile feedback buttons to email template 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 15:58:14 +01:00
renovate[bot]
b7a7a54b43 Update dependency react-error-overlay to v6.0.11 2023-03-17 15:21:26 +01:00
renovate[bot]
101549b3df Update asdf-vm/actions action to v2 2023-03-17 15:15:35 +01:00
Daniel Lockyer
b7a03ca765 🐛 Fixed mainEntityOfPage property within page metadata 
fixes https://github.com/TryGhost/Ghost/issues/16367
refs https://github.com/schemaorg/schemaorg/discussions/3274

- after a discussion with the schemaorg maintainers, it looks like
  `mainEntityOfPage` should refer to the entity itself vs the parent
  entity
- this commit updates the code to use the entity URL and fixes the
  associated tests
 2023-03-17 15:13:28 +01:00
Simon Backx
f67b38daf4 Fixed posts and email wrappers in worker threads 
refs https://ghost.slack.com/archives/C02G9E68C/p1679055933852679

- The posts api is used in the update-check job. This also uses the email wrapper, which needs the email-service
- The email service is not initalized in the worker threads, this causes an error
- Adds a check, because this part is optional in worker threads
 2023-03-17 14:10:33 +01:00
Simon Backx
9bdffdf89d Fixed body style dropdown overflow issue 
no issue

When opening the 'body style' dropdown in the newsletter settings, the dropdown was not completely visible. The next 'liquid' tab covered the dropdown. This makes some adjustments to the overflow of the liquid containers and z-index of the buttons and containers to fix that.

It also removes overflow-y: auto from one of the containers because it cropped the shadow if the dropdown, while that container could never scroll (parent is scrollable).
 2023-03-17 12:00:24 +01:00
Daniel Lockyer
3302f4125e
Added support to yarn dev for --search to launch Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this makes development more fluid by allowing developers to use the
  local Sodo-Search code
 2023-03-17 11:51:42 +01:00
renovate[bot]
680e3bf270 Update sentry-javascript monorepo to v7.43.0 2023-03-17 11:40:12 +01:00
Daniel Lockyer
945bae34cc
Updated Sodo-Search dependencies 
- these were the easy ones to bump, the rest require bigger changes or
  more investigation
 2023-03-17 11:30:02 +01:00
Daniel Lockyer
d1392e3b8a
Deleted superfluous .editorconfig file 
- this is not needed as we have one at the top-level
 2023-03-17 11:30:02 +01:00
Daniel Lockyer
73c1438561
Updated Sodo-Search package.json 
refs https://github.com/TryGhost/Toolbox/issues/400

- this brings it inline with Portal's, which is a similar project
 2023-03-17 11:30:02 +01:00
Sanne de Vries
0d8d5a8119 Updated typography in email design preview 
Refs https://github.com/TryGhost/Team/issues/2714
 2023-03-17 11:19:30 +01:00
Simon Backx
005b5f20fb Added E2E tests for comment CTA 
fixes https://github.com/TryGhost/Team/issues/2727

Adds some E2E tests and snapshots for comment CTA in all possible situations.
 2023-03-17 11:12:47 +01:00
Daniel Lockyer
ddc6d60927
Added missing yarn test:unit command to Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this is needed for CI tests
 2023-03-17 10:48:25 +01:00
Daniel Lockyer
8d9b8739d9
Added Sodo-Search build folders to gitignore 
refs https://github.com/TryGhost/Toolbox/issues/400

- these don't need to be tracked in git
 2023-03-17 10:44:51 +01:00
Daniel Lockyer
a18da88073
Added .yarnrc config to Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows the git tag and commit to be correctly formed for new
  Sodo-Search releases
 2023-03-17 10:41:47 +01:00
Daniel Lockyer
2c72f3c97b
Merged Sodo-Search gitignore with top-level one 
refs https://github.com/TryGhost/Toolbox/issues/400

- we don't need multiple gitignores because it can produce weird
  behaviour with some tools
 2023-03-17 10:34:21 +01:00
Daniel Lockyer
94201281e3
Updated lockfile 2023-03-17 10:32:28 +01:00
Daniel Lockyer
9cc202aae3
Imported code and history from Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for a better dev experience by having the code in the
  monorepo
 2023-03-17 10:31:20 +01:00
Simon Backx
6058b2db22 Removed ghost comments link test 
no issue

Accidentally left when committing.
 2023-03-17 10:28:47 +01:00
Simon Backx
298e3da745 Fixed comment CTA button link 
refs https://github.com/TryGhost/Team/issues/2672

- Use #ghost-comments instead of #ghost-comments-root
- Fixed snapshots
 2023-03-17 10:27:23 +01:00
Simon Backx
423337a048 Fixed snapshots 2023-03-17 10:24:21 +01:00
Sanne de Vries
6821750a3a Fixed spacing between post title and metadata in email template 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 10:17:56 +01:00
Sanne de Vries
717ed114f4 Fixed center aligned post title in emails 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 10:07:17 +01:00
Daniel Lockyer
3f3cf76c37 Updated react-scripts to v5 
refs https://github.com/TryGhost/Toolbox/issues/400

- this fixes various build issues when it's moved into the Ghost
  monorepo
 2023-03-17 09:52:12 +01:00
Chris Raible
0640b9c4aa
Modified outbound link tagger to use ?ref=domain instead of ?ref=siteTitle (#16431) 
refs TryGhost/Team#2755

- Outbound link tagger will now append ?ref=example.com or ?ref=example.ghost.io instead of ?ref=siteTitle
 2023-03-17 14:18:26 +05:30
Simon Backx
25f4974846 ✨ Added comment CTA in newsletters 
fixes https://github.com/TryGhost/Team/issues/2672

- Moves the feature from behind the flag
- Also hides the comment CTA for email only posts

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-03-17 09:38:55 +01:00
Simon Backx
86446e4c86 ✨ Added option to remove post title from newsletters 
fixes https://github.com/TryGhost/Team/issues/2673

Adds a new option to hide the post title section from newsletters.

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-03-17 09:38:55 +01:00