TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 13:54:35 +03:00
Code Issues Projects Releases Wiki Activity
39,832 Commits 237 Branches 1,680 Tags 387 MiB
8f9dbcd0ea
Commit Graph

39832 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
renovate[bot]
cb453febe9 Update benchmark-action/github-action-benchmark action to v1.20.4 2024-10-23 13:22:37 +02:00
Daniel Lockyer
9c6992535b Refactored URL service code to aid with debugging 
- replaced a couple of uses of lodash.each in favor of native for loops
- tidied up `debug` statements and spacing
- pulled out common statements into variables
 2024-10-23 13:17:54 +02:00
Sodbileg Gansukh
c11c516e14
Made unsubscribe from all button sticky on scroll (#21381) 
ref DES-785
 2024-10-23 19:07:29 +08:00
Ludovic Toinel
182a07278d
Added missing lang attribute to html tag for AMP 
refs https://github.com/ampproject/amphtml/blob/main/docs/spec/amp-html-components.md

SEMRush was giving back issues on AMP analysis due to this missing attribute
 2024-10-23 18:05:46 +07:00
Michael Barrett
5492e64988
Updated admin-x-activitypub URL to point at shorter cached version (#21378) 
no refs
 2024-10-23 11:36:16 +01:00
Fabien O'Carroll
0cb435fe4d Added breaking test for ghost_head including portal script 
refs https://linear.app/ghost/issue/ONC-254
refs https://github.com/TryGhost/Ghost/issues/20771

The reason that recommendations aren't working is because portal isn't loaded,
which handles the data-attributes having the event listeners added to them.
 2024-10-23 08:58:52 +01:00
Ghost CI
df1da8ac24 Merged v5.97.2 into main 2024-10-23 07:56:20 +00:00
Ghost CI
0f718a13f1 v5.97.2 2024-10-23 07:56:19 +00:00
Cathy Sarisky
de3b9b1ec5
🐛 Fixed recommendations popup not opening 
closes https://linear.app/ghost/issue/ONC-254
closes #20771

The portal script, which is responsible for handling the recommendations popup,
was only loaded into the front end if either members or donations are enabled.
We're adding an extra condition to load it if recommendations are enabled.

We may want to consider splitting out this functionality into several scripts,
so that we don't have to load _everything_ if only one feature is enabled, but
that is outside the scope of this issue.
 2024-10-23 14:49:10 +07:00
Michael Barrett
c6bfd0f98f
Moved ActivityPub labs flag to (private) beta (#21363) 
no refs
 2024-10-23 08:36:15 +01:00
Daniël van der Winden
8615bd538b
MRR/Members chart axis fix (#21359) 
fixes
https://linear.app/ghost/issue/DES-869/dashboard-mrr-member-chart-axis-is-making-flat-growth-look-like

A slight decline/increase on the MRR/members chart was shown as a very
dramatic shift. These changes will make the chart appear more gradual
when the changes are small. 

The chart will effectively "zoom in" on the
range where the values fluctuate. The y-axis minimum is 95% of the lowest data point, and the maximum is 105% of the highest data point. That way there's a small buffer above and below the data range, and the chart as a whole doesn't have the overly dramatic drops/peaks.

I've tested it with hardcoded values, as well as values inserted via the
API, and the charts look a lot better.

**Before**
<img width="1257" alt="1 - chart before"
src="https://github.com/user-attachments/assets/8d59fc38-0a57-4a7a-a83f-06e045057f45">
<img width="1255" alt="2 - chart before"
src="https://github.com/user-attachments/assets/46476d88-3991-4253-a5bc-76591ea67e39">

**After (same two values)**
<img width="1260" alt="3 - chart after"
src="https://github.com/user-attachments/assets/d5bcfdb2-40dd-4655-afd4-ba19a62d76b9">
<img width="1263" alt="4 - chart after"
src="https://github.com/user-attachments/assets/6c8cf189-6497-482e-9414-a7d77c00c533">

**Gradual decline**
<img width="1259" alt="5 - chart gradual"
src="https://github.com/user-attachments/assets/5ec2b470-f1d2-45cd-aba5-5f11e6e718fd">
<img width="1250" alt="6 - chart gradual"
src="https://github.com/user-attachments/assets/b6dd67ab-0b5e-47db-a9ef-d4ae10b78f73">

**More pronounced decline**
<img width="1270" alt="7 - chart dramatic"
src="https://github.com/user-attachments/assets/c43215c3-a687-47be-ab05-70fee855a345">
<img width="1256" alt="8 - chart dramatic"
src="https://github.com/user-attachments/assets/55ae833b-e47d-441a-98e0-fcfa2e9734a0">
<img width="1258" alt="9 - chart dramatic"
src="https://github.com/user-attachments/assets/b9fdef8f-61fa-4315-a662-b37eea2259d3">
 2024-10-23 09:02:30 +02:00
Princi Vershwal
3f1fa96003
Updated code for fetching location (#21368) 
Ref:
https://linear.app/ghost/issue/ENG-1660/undefined-location-when-logging-in-on-ios
 2024-10-23 06:43:42 +01:00
Ronald Langeveld
1e8bb253bf
Added Best Comment to top of API output (#21374) 
ref PLG-220

- Added the ability to move the Best comment to the first entry when
order=best is passed as params.
 2024-10-23 09:48:16 +09:00
Michael Barrett
1b468f333b
Added buttons to show more data on profile in admin-x-activitypub (#21373) 
no refs
 2024-10-22 21:29:46 +01:00
Djordje Vlaisavljevic
26133095ea Added excerpt to Ghost posts 
ref https://linear.app/ghost/issue/AP-124/view-full-article
 2024-10-22 21:02:42 +01:00
Djordje Vlaisavljevic
773ce016b0 Made Following button disabled 
ref https://linear.app/ghost/issue/AP-501/updated-suggested-users
 2024-10-22 21:02:42 +01:00
Djordje Vlaisavljevic
36d15a4b40 Updated suggested users list 
ref https://linear.app/ghost/issue/AP-501/updated-suggested-users
 2024-10-22 21:02:42 +01:00
Michael Barrett
63afb15356
Added button to show more followers on profile in admin-x-activitypub (#21371) 
no refs
 2024-10-22 20:56:14 +01:00
Michael Barrett
e9914d8fe5
Fixed followers list on profile in admin-x-activitypub app (#21370) 
refs
[AP-489](https://linear.app/ghost/issue/AP-489/followers-showing-unknown-on-user-profile)

Fixed the followers list on profile in admin-x-activitypub app by
utilising a custom endpoint to fetch a list of expanded followers
seeming though the followers endpoint only returns follower id's
 2024-10-22 20:21:12 +01:00
Michael Barrett
b9768f99e9
Added posts to the user profile in admin-x-activitypub (#21369) 
refs
[AP-484](https://linear.app/ghost/issue/AP-484/render-posts-on-user-profile)

Added posts to the user profile in admin-x-activitypub
 2024-10-22 19:54:05 +01:00
Michael Barrett
febb7f720e
Used attributedTo for the Like activities on the profile page (#21367) 
refs
[AP-487](https://linear.app/ghost/issue/AP-487/likes-on-profile-info-displaying-incorrect-actor-info)

Used `attributedTo` for the `Like` activities on the profile page of the
`admin-x-activitypub` app
 2024-10-22 17:02:04 +01:00
Ghost CI
1626a0c537 Merged v5.97.1 into main 2024-10-22 15:20:32 +00:00
Ghost CI
7dc0c87b44 v5.97.1 2024-10-22 15:20:30 +00:00
Fabien 'egg' O'Carroll
1739bdb9be 🐛 Fixed hidden comments still appearing 
refs https://linear.app/ghost/issue/ONC-469

Hidden comments were not being purged from the cache, which resulted
in stale data being served, and hidden comments being visible.
 2024-10-22 22:08:37 +07:00
Fabien 'egg' O'Carroll
73e0727cc4
🐛 Fixed hidden comments still appearing 
refs https://linear.app/ghost/issue/ONC-469

Hidden comments were not being purged from the cache, which resulted
in stale data being served, and hidden comments being visible.
 2024-10-22 22:02:24 +07:00
Michael Barrett
94584489b4
Added graceful handling of suggested profile errors in admin-x-activitypub (#21366) 
no refs

Added graceful handling of suggested profile errors in
admin-x-activitypub
 2024-10-22 15:49:21 +01:00
Djordje Vlaisavljevic
f214213859 Improved how we handle Like notifications 
ref https://linear.app/ghost/issue/AP-480/handle-likes-received-on-replies

- Clicking a notification now opens Article/Note in the drawer
- When the liked post is a reply, the content of the reply is shown in the notification
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
936ff85efb Updated welcome screen copy and link 
ref https://forum.ghost.org/t/activitypub-beta-start-here/51780
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
7e7aee92c5 Removed Comment button in drawer view 
ref https://linear.app/ghost/issue/AP-498/remove-items-from-post-view-in-sidebar
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
51913a7990 Removed button for resizing the drawer 
ref https://linear.app/ghost/issue/AP-498/remove-items-from-post-view-in-sidebar
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
797a34f9e2 Removed static Unfollow button from Following tab 
ref https://linear.app/ghost/issue/AP-499/remove-unfollow-buttons-from-following-tab-on-your-profile
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
8846cb9d19 Removed static Delete button from the dropdown 
ref https://linear.app/ghost/issue/AP-420/i-can-see-a-delete-action-on-posts-that-are-not-mine
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
ba43678964 Fixed z-index issue 
ref https://linear.app/tryghost/issue/AP-464/feed-view-refinements
 2024-10-22 15:42:25 +01:00
renovate[bot]
eb85af051f Update tiptap monorepo to v2.9.0 2024-10-22 13:57:37 +00:00
Michael Barrett
e75de41eac
Filtered out non-follower activities on home feed of the admin-x-activitypub app (#21362) 
refs
[AP-477](https://linear.app/ghost/issue/AP-477/incorrect-posts-in-home-feed)

Filtered out non-follower activities on home feed of the
`admin-x-activitypub` app
 2024-10-22 14:42:43 +01:00
Michael Barrett
f7fbb6edcd
Moved ActivityPub labs flag to (private) beta (#21363) 
no refs
 2024-10-22 12:45:45 +01:00
Cathy Sarisky
1ce5dc34ca
🐛 fixed routing error when no recommendations (#21251) 
no ref.

The default routing for the portal app is a signup page. When a site has
no recommendations, the result of triggering that page (by following a
link that goes there) is a prompt to sign up, or a notification that one
cannot sign up, if membership is disabled.

This patch adds a "No recommendations" message, which will be shown if a
user follows a recommendations link (#/portal/recommendations) on a site
without recommendations. While we shouldn't end up there very often,
it'll make a lot more sense when it does!
 2024-10-22 11:34:44 +01:00
Djordje Vlaisavljevic
7bc510f1c9 Bumped admin-x-activitypub to 0.1.5 
no ref
 2024-10-22 10:57:58 +01:00
Djordje Vlaisavljevic
6bc933f149 Fixed breakpoint for large screens 
ref https://linear.app/tryghost/issue/AP-464/feed-view-refinements
 2024-10-22 10:57:58 +01:00
Djordje Vlaisavljevic
5af25e1433 Bump admin-x-activitypub to 0.1.4 
no ref
 2024-10-22 09:33:40 +01:00
Michael Barrett
2f70d29baa
Reverted revert of reply filtering in admin-x-activitypub (#21357) 
no refs
 2024-10-22 09:33:34 +01:00
Djordje Vlaisavljevic
7c32527159
Updated ActivityPub design (#21327) 
ref https://linear.app/ghost/issue/AP-476/remove-static-buttons-from-notifications-and-resolve-css-issues, https://linear.app/ghost/issue/AP-449/remove-follow-button-and-component, https://linear.app/ghost/issue/AP-448/add-loading-state-for-home-tab, https://linear.app/ghost/issue/AP-446/update-top-nav-bar-design

- Added the Suggestions sidebar
- Added real data to `Your profile` tab
- Switched navigation in top-bar to text-based
- Added loading states to Home and Activity tabs
- Fixed overflow and z-index CSS issues
- Removed `Unfollow` modal since now have a more user-friendly way to follow users
- Changed link color to blue
 2024-10-21 20:24:36 +01:00
Michael Barrett
4277c2a9d5
Reverted reply filtering in admin-x-activitypub (#21355) 
refs
[TryGhost/Ghost#21258](https://github.com/TryGhost/Ghost/pull/21258)

Reverted reply filtering in `admin-x-activitypub` that was added in as a
temporary fix
 2024-10-21 16:06:52 +01:00
Daniël van der Winden
66a78dc2b1
Fixed history action icons (#21354) 
fixes
https://linear.app/ghost/issue/DES-784/action-icons-have-wrong-z-index-are-hidden-beneath-user-avatars

Action icons next to each item in History were obscured by the staff
user's avatar. This fix resolves that.
 2024-10-21 14:42:40 +00:00
Kevin Ansfield
a4e3ef012c Improved validation behaviour on 2fa code verification screen 
closes https://linear.app/ghost/issue/ENG-1672

- removed input on-blur validation because it can be triggered when clicking reset button giving a misleading error state
- added client-side validation for 6-digit code
- added validation when submitting the form
- added error reset when typing in the code field, including removal of button failure state, so it's clearer you're in a new submit state
 2024-10-21 12:32:29 +01:00
Kevin Ansfield
6c4de6a937 Updated 2fa flow copy 
closes https://linear.app/tryghost/issue/ENG-1654
closes https://linear.app/tryghost/issue/ENG-1656
closes https://linear.app/tryghost/issue/ENG-1657

- updated copy
- improved error handling when verification fails
- refactored some duplication of steps in Admin authentication tests
 2024-10-21 11:01:40 +01:00
Sam Lord
85d305ebf7 Added browser tests for 2fa 2024-10-21 11:01:40 +01:00
Kevin Ansfield
2bf626bf6c Added explicit 2fa required error detection 
no issue

- previously we determined any 403 response was an indication that we should switch to the 2fa input screen during sign-in
- added a custom error that explicitly looks for an error with our `2FA_TOKEN_REQUIRED` code so we don't have any confusion when a non-2fa 403 is received for any reason and to have the option of moving away from the 403 if needed without breaking the client
- test to ensure our error 2fa-required error detection works correctly
- extracted duplicate steps in the authentication tests into a helper function
- fixed authentication tests so they better represent our API output of `errors` being an array
 2024-10-21 11:01:40 +01:00
Kevin Ansfield
df6eb7bfda Fixed flash of button error state when redirected to 2fa screen 
closes https://linear.app/tryghost/issue/ENG-1652/

- returning `undefined` from a task is equivalent to failing
- switched to returning `true` when we get the 2fa required error so the button stays in the neutral/success state
- added `SUCCESS` and `FAILURE` consts to better reflect control flow when returning from tasks and ensured we always return a value
 2024-10-21 11:01:40 +01:00
Sam Lord
3ed1f6a8ca Added tests for sessions API with 2fa enabled 2024-10-21 11:01:40 +01:00