TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-08 04:03:12 +03:00
Code Issues Projects Releases Wiki Activity
7,366 Commits 247 Branches 1,686 Tags 346 MiB
91e5bddf3a
Commit Graph

9 Commits

Author SHA1 Message Date
Kevin Ansfield
1ad2c05d37 Bumped eslint-plugin-ghost and fixed linter errors 
no issue

- new linting rules that needed fixing:
   - calling `super` in lifecycle hooks
   - no usage of String prototype extensions
 2021-07-15 15:27:29 +01:00
Kevin Ansfield
1447a57aa8 Fixed enter key in brand accent form triggering error 
no issue

- pressing enter in the accent field would attempt to submit the form and trigger the confirm action
- no confirm action was present on the modal component meaning the base modal confirm action would trigger a invalid usage error
- we don't want enter in the accent field to save, instead we want to blur the element and trigger a preview update
 2021-06-18 09:42:32 +01:00
Rishabh Garg
85c2628049 Added validation to not allow empty accent color (#1863) 
closes https://github.com/TryGhost/Team/issues/535

To ensure accent color is always set for a site, this updates brand settings screen and launch wizard to not allow empty accent color to be set or updated, adding the relevant error on the page which needs to be fixed before saving or continuing on the screens.

- Shows error message for empty accent color on brand settings and launch wizard
- Shows error message for invalid accent color on brand settings and launch wizard
- Blocks save and continue with invalid/empty accent color on brand settings and launch wizard

Co-authored-by: Peter Zimon <zimo@ghost.org>
 2021-03-09 23:55:06 +05:30
Kevin Ansfield
3cd1eb5826 Standardised brand settings form behaviour 
closes https://github.com/TryGhost/Team/issues/506

- launch wizard and brand settings both shared the same design and behaviour for customising brand settings but used duplicated code that had diverged
- extracted the more up-to-date behaviour from the launch wizard into a component
- updated brand settings and launch wizard to use the new component

changes to brand settings modal behaviour:
- preview is no longer interactive
- switches to using iframe contents replacement instead of `postMessage`
 2021-03-02 17:10:43 +00:00
Kevin Ansfield
2c95cae248 Minor cleanup 
no issue

- remove `async` from non-async actions
- tidy up template indentation/spacing
 2021-02-17 16:00:12 +00:00
Kevin Ansfield
16324fd2a4 Fixed brand settings not resetting when cancelling 
no issue

- trigger modal close once save task has finished
- reset unsaved changes when closing the modal (eg, cancel button clicked)
- removed unused code that had been copied over from an old controller
 2021-02-17 15:48:35 +00:00
Kevin Ansfield
734674d299 Fixed error when closing branding modal 
no issue

- clean up event listeners when component is destroyed
- add guard for iframe existing when attempting to replace preview contents
 2021-02-17 15:39:51 +00:00
Hannah Wolfe
e75720d390 Updated brand settings modal to use new preview 
- the new preview mode doesn't require settings to be saved in advance
- TODO: prevent interaction with the iframe a la portal
Notes:
 - this works by sending a post message to the frontend with a custom header
 - generated HTML is loaded into the iframe using postMessage
 - we can possibly write the HTML direct to the iframe - something to experiment with later
 2021-02-17 13:54:47 +00:00
Peter Zimon
04d9caefed Updated navigation (#1832) 
no issue

Updated settings navigation to a completely redesigned flow for Ghost 4.0 🎉

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
Co-authored-by: Fabien O'Carroll <fabien@allou.is>
Co-authored-by: Rish <zrishabhgarg@gmail.com>
 2021-02-02 16:08:06 +00:00