Commit Graph

149 Commits

Author SHA1 Message Date
Rishabh
9391b31635 Fixed eslint error for regex templating
refs https://github.com/TryGhost/Team/issues/1665
refs https://github.com/babel/babel-eslint/issues/681

- eslint throws error on using template string with regex due to a bug, this changes the way regex is generated by string addition instead
2022-07-09 14:08:10 +02:00
Rishabh
4d0026deb6 Updated highlighting for excerpts
refs https://github.com/TryGhost/Team/issues/1665

- updates highlight logic for excerpts to show the right text
- breaks highlights by individual words instead of search sentence
2022-07-09 13:50:43 +02:00
Rishabh
ca4b5c6ed1 v0.1.6 2022-07-08 12:27:35 +02:00
Rishabh
f94582225c Disabled background scroll on search
refs https://github.com/TryGhost/Team/issues/1665

- disables background scroll on main page when search is opened to avoid scroll leak
2022-07-08 12:05:02 +02:00
Rishabh
eb59bea5c7 Removed author and tag sections with invalid urls
refs https://github.com/TryGhost/Team/issues/1665

- if taxonomy is disabled, author and tag urls are 404s.
- removes author/tag section if 404
2022-07-08 11:32:57 +02:00
Sanne de Vries
64bb0b3c50 Truncated search placeholder on mobile 2022-07-08 11:04:59 +02:00
Rishabh
4fdeb02b55 v0.1.5 2022-07-08 10:59:47 +02:00
Rishabh
a9b3265d12 Added loader for indexing
refs https://github.com/TryGhost/Team/issues/1665

- adds loading indicator while search index is setup from site data
2022-07-08 10:58:56 +02:00
Rishabh
604cde2633 Disabled keyboard shortcut for missing data attributes
refs https://github.com/TryGhost/Team/issues/1665

- in case no data-ghost-search attributes on a site, the keyboard shortcut to enable search is disabled
- allows site owners to completely disable search on their site
2022-07-08 10:47:36 +02:00
Rishabh
f722cab8b5 Removed merge error
refs https://github.com/TryGhost/Team/issues/1665
2022-07-08 10:46:22 +02:00
Rishabh
1e57af8fdd Moved fetching site data to first load of search popup
refs https://github.com/TryGhost/Team/issues/1665

- previously the search was loading site data on load for indexing, which adds unnecessary load if search is not used
- moves data fetch and indexing to when the search popup is opened first time avoiding unnecessary fetch
2022-07-08 10:39:41 +02:00
Rishabh
c30cb19650 Removed dummy data
refs https://github.com/TryGhost/Team/issues/1665

- removes dummy data for tests
2022-07-08 10:39:38 +02:00
Djordje Vlaisavljevic
5ade92c78d Added the loading state 2022-07-08 10:30:35 +02:00
Djordje Vlaisavljevic
b72bd2c85c Added the loading icon 2022-07-08 10:30:35 +02:00
Sanne de Vries
8167a9649b Updated highlighted keywords in result titles 2022-07-08 10:18:36 +02:00
Naz
13d4749949 Fixed internal tags showing up in the search results
refs https://github.com/TryGhost/Team/issues/1665

- By default we don't want to show internal tags in search results
2022-07-08 09:34:13 +02:00
Rishabh
233a1c2e4c v0.1.4 2022-07-07 17:08:17 +02:00
Sanne de Vries
6487c00f21 Improved search modal animation 2022-07-07 17:00:48 +02:00
Rishabh
6a8f1bd4dc Fixed invalid text data in highlighting
refs https://github.com/TryGhost/Team/issues/1665

- fixes crash on missing text string when highlighting
2022-07-07 16:43:05 +02:00
Sanne de Vries
cac01cb24b Updated clear search icon 2022-07-07 16:39:59 +02:00
Sanne de Vries
504e0b7446 Added cancel button to mobile view 2022-07-07 16:36:51 +02:00
Djordje Vlaisavljevic
790b34fc6c Updated spacing on smaller screens 2022-07-07 16:36:16 +02:00
Djordje Vlaisavljevic
f63d550f9c Made the search icon switch to clear button 2022-07-07 16:17:53 +02:00
Djordje Vlaisavljevic
c20b0bfa35 Removed unnecessary icons 2022-07-07 16:17:53 +02:00
Djordje Vlaisavljevic
61e5223885 Added a new clear button 2022-07-07 16:17:53 +02:00
Djordje Vlaisavljevic
a81777b987 Made the animation slightly faster 2022-07-07 16:17:53 +02:00
Rishabh
9678922357 v0.1.3 2022-07-07 16:09:49 +02:00
Rishabh
e4213a223d Added search highlight on title and excerpt
refs https://github.com/TryGhost/Team/issues/1665

- adds bold highlight for search term for title and excerpt
- needs logic to truncate to show excerpt highlight if it cuts out
2022-07-07 16:08:31 +02:00
Rishabh
70cbf57f35 v0.1.2 2022-07-07 15:18:43 +02:00
Djordje Vlaisavljevic
aede4046d8 Removed the outline in Safari 2022-07-07 14:43:08 +02:00
Rishabh
86cba694c2 Added pagination to post results
refs https://github.com/TryGhost/Team/issues/1665

- adds pagination for large post data sets using show more button
2022-07-07 14:40:45 +02:00
Naz
fc264e4108 Switched tokenization in search index
refs https://github.com/TryGhost/Team/issues/1665

- The search should support partial forward lookup to match `foobar` when `fo` or `foob` is typed.
- More about the matching mechanism here: https://github.com/nextapps-de/flexsearch#tokenizer-prefix-search
2022-07-07 14:27:04 +02:00
Naz
32a36057a9 Fixed test for search index
no issue

- The tests had to be updated to match the shape of updated resource queries (limits, ordering, etc.)
2022-07-07 14:22:07 +02:00
Naz
089edbc39c Added 10k limit to resource queries
refs https://github.com/TryGhost/Team/issues/1665

- When requesting 'all' resource the search could experience significant performance degradation and would be unresponsive when there are large amounts of posts/tags/authors on the site
- The limit of 10 000 records was chosen as a stopgap solution for experiments in live environment. Once we verify this limit is not causing much trouble, we could increase it if neede
2022-07-07 12:58:41 +02:00
Naz
ec68dc303c Removed plaintext formats from posts request
refs https://github.com/TryGhost/Team/issues/1665
refs https://github.com/TryGhost/Ghost/issues/10396

- Content API has been updated to return clean results for `excerpt` without require a hacky "&formats=plaintext" parameter
2022-07-07 12:55:08 +02:00
Naz
df3d6cee74 Swapped elasticlunr with flexsearch
refs https://github.com/TryGhost/Team/issues/1665

- elasticlunr in an abandoned package with quite a lot of security vulnerabilities. it also has worse performance memory/processing wise comparing to flexsearch (benchmark: https://nextapps-de.github.io/flexsearch/bench/)
- fusejs was another option that was consideres. it was not chosed due to it's poor performance.
2022-07-07 12:52:09 +02:00
Naz
11f7e89ee3 Added missing tagsIndex initialization
refs https://github.com/TryGhost/Team/issues/1665

- It is not striclty necessary for the tagsIndex declaration to be in the constructor, but it gives a very clear indication of which variables are a part of the class.
2022-07-07 12:52:08 +02:00
Djordje Vlaisavljevic
831014859e Removed unnecessary border 2022-07-07 12:30:55 +02:00
Djordje Vlaisavljevic
552118d02f Added static examples of highlighted keywords in posts results 2022-07-07 12:08:13 +02:00
Rishabh
d24ea3ce55 Updated script url to use admin url
refs https://github.com/TryGhost/Team/issues/1665

- replaces usage of site url to admin url as script only needs admin url for setup
- updates tests
2022-07-07 11:09:53 +02:00
Naz
44c8969192 Switched URL calls to use Content API SDK
refs https://github.com/TryGhost/Team/issues/1665

-  The Content API SDK is the recommended way to interact with the API
2022-07-07 09:41:39 +02:00
Rishabh
2ef8eb0586 Handled opening search popup with data attribute
refs https://github.com/TryGhost/Team/issues/1665

- allows opening search popup in themes with custom data attribute
2022-07-06 17:48:59 +02:00
Rishabh
3369e92627 Removed show more button 2022-07-06 17:48:12 +02:00
Rishabh
bd08f01b8c Added keyboard navigation for search results
refs https://github.com/TryGhost/Team/issues/1665

- adds keyboard navigation for search results using arrow up/down
2022-07-06 17:23:17 +02:00
Djordje Vlaisavljevic
62b4add780 Updated how modal height is calculated 2022-07-06 16:01:26 +02:00
Rishabh
5058e46ec8 Fixed App test
- search url for opening modal was updated
2022-07-06 15:56:20 +02:00
Rishabh
52d00ecc72 Fixed keyboard shortcut for opening search
refs https://github.com/TryGhost/Team/issues/1665

- fix browser hijack of cmd/ctrl + k shortcut for search
2022-07-06 15:52:44 +02:00
Djordje Vlaisavljevic
4743c3939f Switched breakpoint from md to sm 2022-07-06 15:41:28 +02:00
Sanne de Vries
5114157564 Truncated long author and tag names 2022-07-06 15:35:45 +02:00
Djordje Vlaisavljevic
85c7e5c984 Fixed merge conflict issues 2022-07-06 15:34:56 +02:00