1
0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-29 22:01:49 +03:00
Commit Graph

46 Commits

Author SHA1 Message Date
Sanne de Vries
c08723b7aa
Fixed error message position to be visible on minimal form ()
Closes https://github.com/TryGhost/Team/issues/3386
2023-06-06 15:05:24 +02:00
Simon Backx
b641859242 Released Signup Form v0.0.2 2023-06-05 15:30:05 +02:00
Simon Backx
498629d9a9 Fixed encoded html character in signup form success message translation
no issue
2023-06-02 14:38:54 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script
refs https://github.com/TryGhost/Team/issues/3307
2023-06-02 14:36:17 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Ronald Langeveld
4fcaabe563
Added initial i18n implementation for Signup-form ()
closes https://github.com/TryGhost/Team/issues/3307

This commit includes several important updates to add internationalisation (i18n) support within the signup form package:

- Modified the translate script in `package.json` to include translations for the signup form.
- Added a new test for the signup form resources in `i18n.test.js`.
- Updated `tsconfig.json` to allow synthetic default imports.
- Made updates to `package.json`, including adding a prebuild command for `@tryghost/i18n` to ensure typescript declaration files get built.
- added `vite-plugin-commonjs` so we can bundle commonjs packages to be useable by the browser.
- In `App.tsx`, imported the `i18n` library and created an `i18n` instance for the `signup-form` namespace. This `i18n` instance's `t` function was added to the application context.
- Updated the `AppContextType` in `AppContext.ts` to include the `t` function from i18n​

Co-authored-by: Daniel Lockyer <hi@daniellockyer.com>
2023-06-02 11:02:52 +02:00
renovate[bot]
17acd2437b Update dependency typescript to v5.1.3 2023-06-02 09:06:20 +02:00
Jono Mingard
024045b9e3 Update signup form text colours to be passed via attributes 2023-06-02 10:59:00 +12:00
Simon Backx
27c9d6c12e Fixed signup form E2E tests for removed email on success page 2023-06-01 18:09:57 +02:00
Sanne de Vries
8aea35b78b Fixed linting errors due to tailwind class ordering
No ref
2023-06-01 18:02:35 +02:00
Sanne de Vries
3923b5cc88 Updated embeddable signup form to be responsive
Refs https://github.com/TryGhost/Team/issues/3334
2023-06-01 17:43:28 +02:00
Simon Backx
c929cecb11 Fixed linting issues in Frame component 2023-06-01 14:43:34 +02:00
Simon Backx
c88926d365 Fixed linting issue 2023-06-01 14:42:36 +02:00
Simon Backx
279a734f68 Added fixed logo height in signup form
refs https://github.com/TryGhost/Team/issues/3346
2023-06-01 14:39:52 +02:00
Simon Backx
bcaf95f506 Updated signup form with minimal style to use automatic height and minimum height
refs https://github.com/TryGhost/Team/issues/3295
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685620939701309?thread_ts=1685614059.121599&cid=C04TMVA1D7A

- The error message of the minimal style form is not visible
- Use minimum height instead of fixed height
- Automatically update height
- Fixed issues with iframe inline style causing spacing and layout jumps
2023-06-01 14:36:00 +02:00
renovate[bot]
2a739cf248 Update dependency vitest to v0.31.4 2023-06-01 13:41:39 +02:00
Simon Backx
17e9b803e4 Added POC for resizing iframe to fit outer container
refs https://github.com/TryGhost/Team/issues/3295
2023-06-01 12:06:48 +02:00
renovate[bot]
c2e0514665 Update dependency vitest to v0.31.3 2023-06-01 11:09:06 +02:00
renovate[bot]
70960f27f6 Update dependency concurrently to v8.1.0 2023-06-01 11:08:55 +02:00
Simon Backx
a2a79cec0e Added support for yarn dev --signup
no issue

Added support for `--signup` to `yarn dev`. This will make sure that the signup form preview server is served (with rebuilding) and can be used in admin (instead of using the published version). This is also automatically started when using `yarn dev --all`, but with a twist:

If you only run `yarn dev --all`, it will only build and watch the production build of the signup form. If you use `yarn dev --signup` or `yarn dev --all --signup` it will also serve the demo app on `http://localhost:6173`.
2023-06-01 10:20:37 +02:00
Simon Backx
7e27d3f3e8
Added signup form attribution ()
fixes https://github.com/TryGhost/Team/issues/3331

This adds attribution tracking to the signup form. It sends a newly
created url history when sending the signup API call, this url history
will get translated to a proper attribution and saved on the backend. We
send a history with only a single item that contains the referrer
source, medium and path of the Embed form.

This also makes some changes to the E2E tests so that the tests run
in an https environment instead of about:blank.
2023-06-01 10:18:11 +02:00
renovate[bot]
2edaf2c42c Update dependency vitest to v0.31.2 2023-06-01 09:44:15 +02:00
Jono Mingard
c63b0e1a1a Fixed signup form e2e tests to check new colour options
refs https://github.com/TryGhost/Team/issues/3338
2023-06-01 14:55:03 +12:00
Jono Mingard
80b9030805 Updated signup form to support configuring background and button color
refs https://github.com/TryGhost/Team/issues/3338

* background and button color can be passed in the script tag dataset
* text color is calculated automatically from background/button color
2023-06-01 14:43:57 +12:00
Jono M
257d84a4b1
Added storybook to signup form ()
refs https://github.com/TryGhost/Team/issues/3299
2023-06-01 11:22:43 +12:00
Fabien 'egg' O'Carroll
32f4861176
Bumped eslint-plugin-ghost ()
- This includes changes to support PascalCase filenames for interfaces
- Also bumps newer packages to use the latest version to avoid conflicts
with the underlying eslint-plugin-filenames package
2023-05-31 16:36:32 -04:00
Sanne de Vries
5df2403b61 Fixed linter failing due to Tailwind class ordering
No ref
2023-05-30 15:58:58 +02:00
Sanne de Vries
c9d0424636 Updated embeddable signup form styles
Refs https://github.com/TryGhost/Team/issues/3334
2023-05-30 15:39:11 +02:00
Simon Backx
6dddf3ee67 Fixed old label usage of signup form demo
refs 644051e3e9
2023-05-30 14:10:27 +02:00
Simon Backx
644051e3e9 Fixed labels for signup form
fixes https://github.com/TryGhost/Team/issues/3316
fixes https://github.com/TryGhost/Team/issues/3313

Instead of using a comma separated list of labels, we now use multiple data properties: data-label-1, data-label-2, etc.
2023-05-30 14:06:25 +02:00
Simon Backx
ced0a3e792 Fixed signup-form-tests GitHub workflow
refs https://ghost.slack.com/archives/C02G9E68C/p1685446707169999

- `actions/setup-node` has a bug where it doesn't parse paths where the path is pretty-printed with colors, so we have to explicitly disable colors
- Added whitespace change inside signup-form to trigger new CI run
2023-05-30 13:41:38 +02:00
Simon Backx
dbcdc8219d Added E2E tests for API in signup form
fixes https://github.com/TryGhost/Team/issues/3330
2023-05-30 11:58:39 +02:00
renovate[bot]
f4ac82fd3d Update storybook monorepo to v7.0.18 2023-05-30 10:51:42 +02:00
renovate[bot]
d5db684aeb Update dependency vite to v4.3.9 2023-05-29 17:25:09 +02:00
renovate[bot]
610ba33513 Update dependency postcss to v8.4.24 2023-05-29 07:52:39 +02:00
Simon Backx
b382c3e7e6 Released Signup Form v0.0.1 2023-05-25 10:21:29 +02:00
renovate[bot]
d71eb04bbc Update dependency @playwright/test to v1.34.3 2023-05-25 09:12:55 +02:00
Simon Backx
8208f174f7 Fixed signup-form package.json formatting 2023-05-24 15:07:41 +02:00
Simon Backx
fd3393c562 Added Playwright tests to Signup Form
refs https://github.com/TryGhost/Team/issues/3298
2023-05-24 15:06:44 +02:00
Simon Backx
8fd2468995 Added testable production build for signup-form
fixes https://github.com/TryGhost/Team/issues/3297

This adds a new preview page to test the signup-form script as a production build, instead of using ESM.
2023-05-24 11:41:12 +02:00
renovate[bot]
de1d925c8c Update storybook monorepo to v7.0.15 2023-05-24 11:21:11 +02:00
Jono M
86499aaf01
Updated signup form options to react to changes ()
refs https://github.com/TryGhost/Team/issues/3293
2023-05-24 11:08:02 +02:00
Jono Mingard
03fb1b188c Tweaked type definitions in signup form 2023-05-24 15:53:04 +12:00
Sag
4358f329d0 Fixed default Ghost url in dev environment
no issue
2023-05-23 17:11:04 +02:00
Simon Backx
1f9818d9c8 Cleaned up signup-form package file and unused files 2023-05-23 14:59:27 +02:00
Simon Backx
4c2635670b
Added signup-form package ()
fixes https://github.com/TryGhost/Team/issues/3275
fixes https://github.com/TryGhost/Team/issues/3279
fixes https://github.com/TryGhost/Team/issues/3278

This pull request adds a new signup form package to the Ghost core
repository. The signup form package is a React component, embeddable on
any site, that renders a form for users to subscribe to a Ghost site.
2023-05-23 14:58:33 +02:00