TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 05:37:34 +03:00
Code Issues Projects Releases Wiki Activity
37,279 Commits 235 Branches 1,678 Tags 380 MiB
94a181ce2a
Commit Graph

119 Commits

Author SHA1 Message Date
renovate[bot]
1c03280223 Update dependency @storybook/addon-styling to v1.3.2 2023-07-04 13:44:25 +02:00
renovate[bot]
8e8c64c622 Update storybook monorepo to v7.0.25 2023-07-04 12:44:42 +02:00
renovate[bot]
74f2e08b16 Update dependency vitest to v0.32.4 2023-07-04 12:24:03 +02:00
renovate[bot]
aa8cbb9fa3 Update dependency typescript to v5.1.6 2023-06-29 08:24:30 +02:00
renovate[bot]
58b54333a5 Update dependency typescript to v5.1.5 2023-06-28 16:21:27 +02:00
renovate[bot]
5bcbb2de41 Update storybook monorepo to v7.0.24 2023-06-27 16:56:47 +02:00
renovate[bot]
2c6f30b4b8 Update dependency @storybook/addon-styling to v1.3.1 2023-06-27 07:33:22 +02:00
renovate[bot]
0a6b3d6b99 Update dependency vite-plugin-commonjs to v0.8.0 2023-06-26 08:51:09 +02:00
Simon Backx
8d6fb51908 Added Playwright tests to comments-ui 
refs https://github.com/TryGhost/Team/issues/3504

Not complete yet, but contains the basic structure and a few tests that work and should run in CI.
 2023-06-22 15:06:13 +02:00
renovate[bot]
e723365cd5 Update storybook monorepo to v7.0.23 2023-06-22 12:31:42 +02:00
Hannah Wolfe
3a58b6402a Update dependency eslint-plugin-ghost to v3.2.0 
refs: https://github.com/TryGhost/Toolbox/issues/595

- Adds custom rules for node assert
- Enforces assert/strict as an error
 2023-06-21 10:34:37 +01:00
Hannah Wolfe
6161f94910
Updated to use assert/strict everywhere (#17047) 
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
 2023-06-21 09:56:59 +01:00
Simon Backx
3e932458a4 Released Signup Form v0.1.3 2023-06-21 10:48:22 +02:00
Simon Backx
40f71cb79b 🐛 Fixed accessibility issue with hidden success message in signup form 
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686928938857799

The button read 'Subscribe email sent' on screen readers.
 2023-06-21 10:38:27 +02:00
Daniel Lockyer
1be11e4648
Fixed include path for signup-form translations 
- this fixes the path after we moved the signup-form folder between
  workspace folders
 2023-06-21 09:12:28 +02:00
renovate[bot]
e3c9af380c Update dependency @storybook/testing-library to v0.2.0 2023-06-21 08:12:26 +02:00
Daniel Lockyer
5c4ef092b6 Updated vitest to v0.32 
refs https://github.com/TryGhost/Ghost/pull/16949
refs https://github.com/vitest-dev/vitest/releases/tag/v0.32.0

- contains a switch from `@vitest/coverage-c8` to `@vitest/coverage-v8`
  as this is now required in 0.32
 2023-06-20 14:54:04 +02:00
renovate[bot]
ea3ab6beb6 Update dependency @vitejs/plugin-react to v4.0.1 2023-06-20 08:09:23 +02:00
Daniel Lockyer
2173fd9ef9 Moved signup-form to apps/ folder 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-19 09:43:33 +02:00