TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-23 02:41:50 +03:00
Code Issues Projects Releases Wiki Activity
9,453 Commits 250 Branches 1,686 Tags 392 MiB
97afc8aa28
Commit Graph

9453 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Fabien O'Carroll
d31395412b Removed sandbox from apps service 
no-issue

The instansiation of a Module object was only used so that we could
override the require method inside external apps, now we have no support
for them, we are free to require the internal apps directly. This has no
functionality change.
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
4696d70de0 Refactored app proxy module to not use Constructor 
no-issue

Rather than creating a whole instance, we can replace it with a helper
method - his is less memory intensive and a little easier to parse for
something this small.
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
ca8c5c4907 Removed app permissions module and updated loader 
no-issue

The permissions module is no longer necessary as we only suppot internal
apps, which have all permissions. This allowed us to delete the module,
but required that we update the loader to remove references to it.
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
e4db1eed81 Removed support for external apps from Proxy 
no-issue

This also removes the need for permissions, as internal apps have all permissions
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
4b74c11abb Removed installAppByName method 
no-issue

Only external apps needed the install step, we can safely remove this now.
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
ad9d142174 Refactored Sandbox to be singleton 
no-issue
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
fd9fc92dd5 Removed external app support in Sandbox 
no-issue
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
fc1aa58dc0 Removed external app support from app service loader 
no-issue
 2019-04-16 11:05:33 +02:00
Fabien O'Carroll
d63d3f77eb Removed external app support from app service init 
no-issue
 2019-04-16 11:05:33 +02:00
Rishabh Garg
62f5bdac4c
Updated to use count words/images helpers from SDK (#10686) 
refs #10618

- Added @tryghost/helpers dependency to use Ghost-SDK helpers
- Updated countWords, countImages helpers and removed local copy
 2019-04-16 08:00:01 +05:30
Fabien O'Carroll
5460de9c58 Updated gscan to 2.5.0 
no-issue

This includes a bump to handlebars -> 4.1.2, which fixes a potential RCE
https://github.com/wycats/handlebars.js/blob/v4.1.2/release-notes.md#v412---april-13th-2019
 2019-04-15 14:30:37 +02:00
Fabien O'Carroll
0f5ca616b8 Updated express-hbs to 1.1.1 
no-issue

This includes a bump to handlebars -> 4.1.2, which fixes a potential RCE
https://github.com/wycats/handlebars.js/blob/v4.1.2/release-notes.md#v412---april-13th-2019
 2019-04-15 14:30:37 +02:00
Fabien O'Carroll
32a4798d76 Added skip of active/installed apps settings during import (#10681) 
no issue
- the `{active,installed}_apps` settings related to a very old, minimally implemented, unreleased, and problematic approach to custom apps
- this is the first step towards full removal of the old "apps" concept

Credits: Kacper Szurek
 2019-04-15 11:10:10 +01:00
Rish
9e6733ecab Updated subscription data in member request 
no issue

- Added subscription amount to member subscription data
 2019-04-13 10:44:43 +05:30
Rishabh Garg
c03ca79c66
Added Admin API for deleting members (#10673) 
no issue

- Added new API to delete members
- Added methods to handle e2e member deletion
- Deleting member via Admin leads to
  - Removal of member from payment processor and cancelling all active subscriptions immediately
  - Removal of member information from DB
 2019-04-13 10:38:56 +05:30
Nazar Gargol
a7385f5e10 Version bump to 2.19.4 2019-04-09 19:30:37 +08:00
Nazar Gargol
f080721601 Updated Ghost-Admin to 2.19.4 2019-04-09 19:30:37 +08:00
Nazar Gargol
095d022a5e Updated Casper to 2.9.9 2019-04-09 19:30:37 +08:00
Rishabh Garg
35c4da710a
🐛 Fixed sitemap generation with correct date and images value (#10668) 
closes #10640

- Updated sitemap resources data to include certain fields
- Fixes sitemap date and images value
- Updated date handling for sitemap nodes
 2019-04-09 12:43:07 +05:30
Naz Gargol
87b37556c8
Improved error context usage (#10669) 
refs #10571

- Reduced the amount of log output for collision errors
- Improved data passed into `errorDetails` during theme check
- After discovering https://github.com/TryGhost/Ghost/blob/9810834/core/server/services/themes/index.js#L56-L57 wasn't able to remove `checkedTheme` from `context`. Left a note to be refactored later
 2019-04-09 13:00:56 +08:00
Fabien O'Carroll
3f52c404d4 Removed coverage tasks from Gruntfile 
refs #9441
 2019-04-08 18:23:35 +02:00
Fabien O'Carroll
3df6b71607 Removed vim specific ignores 
refs #9441
 2019-04-08 18:23:17 +02:00
Fabien O'Carroll
687d79166f Removed coverage report 
refs #9441
 2019-04-08 18:23:17 +02:00
Fabien O'Carroll
a28fa4bf42 Removed duplicate entries 
refs #9441
 2019-04-08 18:23:17 +02:00
Fabien O'Carroll
da25356e22 Added .gitignore template from slimer repo 
refs #9441

1ae82d4325/packages/generator-slimer/generators/gitroot/templates/gitignore.tpl
 2019-04-08 18:23:17 +02:00
Kevin Ansfield
47692b1081 🐛 Fixed last paragraph not rendering on front-end when it's styled 
no issue
- the conditional for removal of trailing blank paragraphs was not sufficient to handle paragraphs where the first child element was not a text node such as when the content of the last paragraph is italic
- switched to a method that fully walks the DOM of the last paragraph node to extract its equivalent `.textContent` value for use in the "last para is blank?" check
 2019-04-08 16:25:20 +01:00
Kevin Ansfield
12e0366fc9 Version bump to 2.19.3 2019-04-04 14:58:48 +01:00
Kevin Ansfield
90f2a4ad7c Updated Ghost-Admin to 2.19.3 2019-04-04 14:58:48 +01:00
Kevin Ansfield
475e031542 Updated Casper to 2.9.8 2019-04-04 14:58:48 +01:00
Fabien O'Carroll
cebcf27b6b 🐛 Fixed 500 template error occurring in place of a 404 for missing pages/assets (#10660) 
no issue

- when the page is missing the context can be undefined, this defaults it to an empty array so that later `context.includes()` calls don't error
 2019-04-04 14:41:56 +01:00
Kevin Ansfield
36511f5a6d Fixed never ending "Building admin client" messages using grunt dev 
no issue
- ember-cli stopped outputting the "Build successful" text that we were looking for as an indication of completion
 2019-04-04 09:48:19 +01:00
Fabien O'Carroll
40d74ec3e0 Updated theme middleware tests 
no-issue

This allows the tests to not inspect the "internals" of the module, and
deal with the middleware array it exports.

- Removes two layers of indentation for readablity
- Adds executeMiddleware helper
- Reuses the global requires, rather than making new globals for stubs
 2019-04-04 10:44:43 +02:00
Fabien O'Carroll
35725f9537 Added members data to local template options 
no-issue

- Splits updateTemplateData into three functions with clear naming
- Adds req.member to local template options, to be used as {{@member}}
 2019-04-04 10:44:43 +02:00
Fabien O'Carroll
b38fb32c3f Refactored theme middleware module 
no-issue

- Replaces var -> const
- Removed use of object to hold functions
 2019-04-04 10:44:43 +02:00
Fabien O'Carroll
d0c1853797 Used getter instead of looking up internal property 
no-issue

Since express-hbs@1.10 we have a method to get the template options,
which should be used rather than reading internal "private" properties
 2019-04-04 10:44:43 +02:00
Fabien O'Carroll
c461c66b38 Added support for local template options 
no-issue

This bumps express-hbs to 1.1.0 which includes the change for local
template options.

https://github.com/barc/express-hbs/releases/tag/v1.1.0
 2019-04-03 11:31:20 +02:00
Hannah Wolfe
6f677a5b2f
Added config.development.json 
- Allow for easy access to alpha features whilst working on master
- Should never appear in any released version of Ghost
 2019-04-03 11:10:41 +01:00
Nazar Gargol
b7224ef1b0 Fixed regression test 
no issue

- html to plaintext was broken with c219446f85 . Ghost's API supports html intpu format only for version above v8
 2019-04-03 10:58:36 +08:00
Kevin Ansfield
dd619789cb Version bump to 2.19.2 2019-04-02 10:02:14 +01:00
Kevin Ansfield
bd3f2f98af Updated Ghost-Admin to 2.19.2 2019-04-02 10:02:14 +01:00
Kevin Ansfield
421da1ac82 Updated Casper to 2.9.7 2019-04-02 10:02:14 +01:00
Vikas Potluri
bd77c1e2e0 Migrated body_class, content and date helpers to ES6 (#10644) 
refs #9589 

* updated body_class helper to use newer code standards
* updated content helper to use newer code standards
* updated date helper to use newer code standards
 2019-04-02 08:36:13 +02:00
Nazar Gargol
cea6b6c837 Improved grunt express/casper watchers 
closes #9718

- fs.fileWatch that is used internally by 'gase' in 'grunt-contrib-watch', is having 100ms pooling default (07828a6845/lib/gaze.js (L36)). This is causing hight CPU usage for large amount of files.
- As suggested in https://github.com/gruntjs/grunt-contrib-watch#why-is-the-watch-devouring-all-my-memorycpu the watch interval was set to higher 500ms because the recommended default of 5s (https://github.com/gruntjs/grunt-contrib-watch/issues/145#issuecomment-20526067) was visible in the development flow
 2019-04-02 14:16:26 +08:00
Nazar Gargol
7d6436f9bf Bumped gscan version to 2.4.0 
no issue

- Updated theme fixtures to be in line with new deprecation rules
for {{lang}} and {{@blog.*}} helpers introduced with https://github.com/TryGhost/gscan/pull/180
 2019-04-02 13:47:59 +08:00
Nazar Gargol
a2d8c07c96 Fixed regression tests 
no issue

- Tests were broken with b9eaf27e56
 2019-04-02 11:23:46 +08:00
John O'Nolan
99983fa2e2
Update to new Twitter URL 2019-04-01 23:36:43 +02:00
Nazar Gargol
b9eaf27e56 🐛 Fixed admin error page on startup 
closes #10616

- The check should be on empty object because that's the default state of expresses 'engines' property - 3ed5090ca9/lib/application.js (L59)
- The bug was introduced with 5e963935f9 (diff-04cc23b216e11161ab7267d69f13d004R142)
 2019-04-01 15:06:00 +08:00
Nazar Gargol
0d89acd910 🐛 Fixed redirects to external URL 
closes #10623

- The ability to redirect to external URLs was broken with 7e211a307c
- Added test coverage for external URL case
 2019-04-01 12:33:29 +08:00
Kevin Ansfield
a532e35dc4 Version bump to 2.19.1 2019-03-27 17:26:57 +00:00
Kevin Ansfield
c95141740f Updated Ghost-Admin to 2.19.1 2019-03-27 17:26:57 +00:00