Hannah Wolfe
b80b90229f
Added consistent linting pattern to all packages
...
refs: https://github.com/TryGhost/Toolbox/issues/188
- some of our older packages used a pattern for linting which missed using test config for linting tests
- we need this to be consistent so that we can add more eslint rules for testing
- two packages also didn't use the lib pattern, which made the lint pattern error - so this was fixed as well
2023-06-13 10:43:29 +01:00
Fabien "egg" O'Carroll
104f84f252
Added eslint rule for file naming convention
...
As discussed with the product team we want to enforce kebab-case file names for
all files, with the exception of files which export a single class, in which
case they should be PascalCase and reflect the class which they export.
This will help find classes faster, and should push better naming for them too.
Some files and packages have been excluded from this linting, specifically when
a library or framework depends on the naming of a file for the functionality
e.g. Ember, knex-migrator, adapter-manager
2023-05-09 12:34:34 -04:00
renovate[bot]
83373e1751
Update Test & linting packages
2023-04-05 15:16:08 +02:00
renovate[bot]
2223db5379
Update Test & linting packages
2023-03-13 02:36:20 +00:00
Daniel Lockyer
6b1966ad9b
Updated sinon
dependency
...
- this is being done manually instead of merging the Renovate PR because
the PR bundles another bump which doesn't pass yet
2023-03-02 12:43:42 +01:00
Daniel Lockyer
2d1f9fff0c
Updated @tryghost/errors
dependency
...
- there's a weird situation when we have mixed versions of the
dependency because different libraries try to compare instances
- this brings the usage up to 1.2.21 so we can fix the build for now
2023-02-22 11:32:11 +01:00
renovate[bot]
cf7ecb492c
Update dependency c8 to v7.13.0
2023-02-16 22:15:50 +00:00
Daniel Lockyer
08b786af3b
Bumped TryGhost-owned dependencies and lockfile
...
- this was all getting terribly behind so I've done several things:
- majority of `@tryghost/*` except Lexical packages
- gscan + knex-migrator to remove old `@tryghost/errors` usage
- bumped lockfile
2023-01-02 20:55:22 +01:00
Daniel Lockyer
6f4e663d74
Updated @tryghost dependencies ( #16005 )
...
- also includes `knex-migrator` with a simple `sqlite3` bump
2022-12-14 11:18:55 +07:00
renovate[bot]
13abcf6c9d
Update dependency mocha to v10.2.0
2022-12-12 13:20:22 +00:00
renovate[bot]
8fa9f1e7e6
Update Test & linting packages
2022-11-07 20:39:48 +00:00
renovate[bot]
e9587e02d0
Update dependency mocha to v10.1.0
2022-10-17 08:41:28 +00:00
renovate[bot]
6fc497743d
Updated @tryghost dependencies ( #15479 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-10-12 10:16:05 +07:00
renovate[bot]
82441e943d
Update dependency express to v4.18.2
2022-10-10 10:29:34 +07:00
renovate[bot]
2c2ee81adb
Update Test & linting packages
2022-10-05 00:36:08 +00:00
renovate[bot]
9eb3c84a23
Updated @tryghost dependencies ( #15434 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-09-27 08:31:35 +07:00
renovate[bot]
225765241c
Updated @tryghost dependencies ( #15404 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-09-19 12:09:33 +01:00
Daniel Lockyer
54aa9f016b
Fixed full Admin test suite running during unit tests
...
- because of how the npm scripts were set up, we were running the full
Admin integration tests during the unit tests phase of CI
- this commit renames the majority of `test` to `test:unit` in the
package.json files, and aliases `test` to `test:unit`
- special packages like Admin have no-op'd `test:unit` scripts so we
don't end up running its tests
2022-08-15 15:34:52 +02:00
Simon Backx
82a3133ace
Added replies/likes count and limited replies to comments ( #15206 )
...
refs https://github.com/TryGhost/Team/issues/1723
- Added count.replies to comments
- Added replies endpoint
- Limited returned replies to 3.
- Replaced likes_count with count.likes in comments
- Instead of fetching all the likes of a comment to determine the total count, we'll now use count.likes
- Instead of fetching all the likes of a comment to determine whether a member liked a comment, we'll now use count.liked (which returns the amount of likes of the current member, being 0 or 1). This is mapped to `liked` to make it more natural to work with.
The `members.test.snap` file changed because we no longer include `liked: false` if we didn't fetch the liked relation. And in the comments events of the activity feed the liked property is therefore removed.
These changes requires an update to the `bookshelf-include-count` plugin:
- Updated to also work for nested relations
- This moves the count queries from the `bookshelf-include-count` plugin to the `countRelations` method of each model.
- Updated to keep the counts after saving a model (crud.edit didn't return the counts before)
2022-08-10 16:12:35 +02:00
Daniel Lockyer
6dde5e40e3
Updated Eslint ECMAScript compatibility to 2022
...
refs https://github.com/TryGhost/Toolbox/issues/345
- this commit bumps `eslint-plugin-ghost`, which bumps compatiblity to
2022
- this also removes a lot of the manually-added
`parserOptions.ecmaVersion` that we had in imported packages, in favor
of the value set in `eslint-plugin-ghost`
2022-08-09 15:51:40 +02:00
Daniel Lockyer
713a81455d
Deleted types/
folders
...
- these should no longer be needed because the cross-linking of packages
makes jsdoc types Just Work ™️
2022-08-04 19:42:22 +02:00
Daniel Lockyer
73bd9a8e1a
Deleted typescript config files
...
- these aren't needed any more because the packages are in the same repo
as Ghost, so jsdocs + types should Just Work ™️
2022-08-03 12:49:32 +02:00
renovate[bot]
679634342a
Pinned dependencies ( #15100 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-07-26 16:06:00 +02:00
Daniel Lockyer
08abfcafd1
Remove linting as posttest step
...
- linting is handled separately (in CI and locally, as it's a git
pre-push hook) so we shouldn't also be running it after tests
2022-07-26 15:26:21 +02:00
Daniel Lockyer
0a5f600dfe
Tidied up package README and LICENSE files
...
- we shouldn't need individual LICENSE files because these packages
won't be published, so the top-level one applies
- also cleaned up README files to remove mentions of Lerna monorepos and
install instructions
2022-07-26 15:22:10 +02:00
Daniel Lockyer
255eb0726b
Cleaned up package metadata
...
refs https://github.com/TryGhost/Toolbox/issues/354
- set packages to `private: true`
- removed repository link - these packages won't be published so this
link won't be seen anywhere
- removed `publishConfig`
2022-07-26 15:08:05 +02:00
Daniel Lockyer
5fc7ba59d3
Reset package versions back to 0.0.0
...
refs https://github.com/TryGhost/Toolbox/issues/354
- these packages won't be published from now on, so setting the versions
back to 0.0.0 keeps them clean
2022-07-26 14:57:43 +02:00
Naz
d5e38e6fc7
Published new versions
...
- @tryghost/adapter-manager@0.2.33
- @tryghost/api-version-compatibility-service@0.4.4
- @tryghost/bootstrap-socket@0.2.22
- @tryghost/config-url-helpers@1.0.2
- @tryghost/constants@1.0.7
- @tryghost/database-info@0.3.8
- @tryghost/email-content-generator@0.1.4
- @tryghost/image-transform@1.2.1
- @tryghost/job-manager@0.9.0
- @tryghost/limit-service@1.2.2
- @tryghost/minifier@0.1.17
- @tryghost/moleculer-service-from-class@0.2.28
- @tryghost/mw-api-version-mismatch@0.2.3
- @tryghost/mw-error-handler@1.0.5
- @tryghost/mw-session-from-token@0.1.34
- @tryghost/mw-update-user-last-seen@0.1.8
- @tryghost/package-json@1.0.23
- @tryghost/pretty-cli@1.2.29
- @tryghost/promise@0.1.20
- @tryghost/release-utils@0.8.1
- @tryghost/security@0.3.3
- @tryghost/session-service@0.1.44
- @tryghost/settings-path-manager@0.1.9
- @tryghost/version-notifications-data-service@0.2.2
- @tryghost/vhost-middleware@1.0.28
- @tryghost/zip@1.1.27
2022-07-22 16:46:56 +01:00
renovate[bot]
11d0ab9605
Update dependency c8 to v7.12.0
2022-07-19 18:33:27 +00:00
Daniel Lockyer
d8af7189e7
Published new versions
...
- @tryghost/adapter-manager@0.2.32
- @tryghost/api-version-compatibility-service@0.4.2
- @tryghost/bootstrap-socket@0.2.21
- @tryghost/config-url-helpers@1.0.1
- @tryghost/constants@1.0.6
- @tryghost/database-info@0.3.6
- @tryghost/email-content-generator@0.1.3
- @tryghost/image-transform@1.0.33
- @tryghost/job-manager@0.8.25
- @tryghost/limit-service@1.2.1
- @tryghost/minifier@0.1.16
- @tryghost/moleculer-service-from-class@0.2.27
- @tryghost/mw-api-version-mismatch@0.2.2
- @tryghost/mw-error-handler@1.0.2
- @tryghost/mw-session-from-token@0.1.33
- @tryghost/mw-update-user-last-seen@0.1.7
- @tryghost/package-json@1.0.22
- @tryghost/pretty-cli@1.2.28
- @tryghost/promise@0.1.19
- @tryghost/release-utils@0.8.0
- @tryghost/security@0.3.2
- @tryghost/session-service@0.1.43
- @tryghost/settings-path-manager@0.1.8
- @tryghost/version-notifications-data-service@0.2.1
- @tryghost/vhost-middleware@1.0.26
- @tryghost/zip@1.1.26
2022-05-24 13:06:28 +02:00
Renovate Bot
74ff5d48de
Update dependency c8 to v7.11.3
2022-05-16 04:56:38 +00:00
Naz
c5b8d073d7
Published new versions
...
- @tryghost/adapter-manager@0.2.31
- @tryghost/api-version-compatibility-service@0.3.0
- @tryghost/bootstrap-socket@0.2.20
- @tryghost/config-url-helpers@0.1.8
- @tryghost/constants@1.0.5
- @tryghost/database-info@0.3.5
- @tryghost/email-content-generator@0.1.2
- @tryghost/image-transform@1.0.32
- @tryghost/job-manager@0.8.24
- @tryghost/limit-service@1.1.3
- @tryghost/minifier@0.1.15
- @tryghost/moleculer-service-from-class@0.2.26
- @tryghost/mw-api-version-mismatch@0.1.4
- @tryghost/mw-error-handler@1.0.1
- @tryghost/mw-session-from-token@0.1.32
- @tryghost/mw-update-user-last-seen@0.1.6
- @tryghost/package-json@1.0.21
- @tryghost/pretty-cli@1.2.27
- @tryghost/promise@0.1.18
- @tryghost/release-utils@0.7.15
- @tryghost/security@0.3.1
- @tryghost/session-service@0.1.42
- @tryghost/settings-path-manager@0.1.7
- @tryghost/update-check-service@0.3.4
- @tryghost/version-notifications-data-service@0.1.2
- @tryghost/zip@1.1.25
2022-05-09 18:25:48 +08:00
Renovate Bot
82b83743a7
Update dependency sinon to v14
2022-05-09 00:14:50 +00:00
Naz
e5d097fbae
Published new versions
...
- @tryghost/adapter-manager@0.2.30
- @tryghost/api-version-compatibility-service@0.1.2
- @tryghost/bootstrap-socket@0.2.19
- @tryghost/config-url-helpers@0.1.7
- @tryghost/constants@1.0.4
- @tryghost/database-info@0.3.4
- @tryghost/email-content-generator@0.1.0
- @tryghost/image-transform@1.0.31
- @tryghost/job-manager@0.8.23
- @tryghost/limit-service@1.1.1
- @tryghost/minifier@0.1.14
- @tryghost/moleculer-service-from-class@0.2.25
- @tryghost/mw-api-version-mismatch@0.1.2
- @tryghost/mw-error-handler@0.2.3
- @tryghost/mw-session-from-token@0.1.31
- @tryghost/mw-update-user-last-seen@0.1.5
- @tryghost/package-json@1.0.20
- @tryghost/pretty-cli@1.2.26
- @tryghost/promise@0.1.17
- @tryghost/release-utils@0.7.14
- @tryghost/security@0.2.17
- @tryghost/session-service@0.1.41
- @tryghost/settings-path-manager@0.1.6
- @tryghost/update-check-service@0.3.3
- @tryghost/version-notifications-data-service@0.1.1
- @tryghost/vhost-middleware@1.0.25
- @tryghost/zip@1.1.24
2022-05-04 17:21:51 +08:00
Renovate Bot
6f93c82c5a
Update Test & linting packages
2022-05-02 14:01:35 +00:00
Renovate Bot
9589755925
Update Test & linting packages
2022-05-02 13:58:34 +00:00
Renovate Bot
1ed9d1ef34
Update dependency express to v4.18.1
2022-04-29 20:53:08 +00:00
Fabien "egg" O'Carroll
918db79aa8
Published new versions
...
- @tryghost/limit-service@1.1.0
- @tryghost/mw-error-handler@0.2.2
- @tryghost/mw-session-from-token@0.1.30
- @tryghost/session-service@0.1.40
- @tryghost/vhost-middleware@1.0.24
2022-04-27 11:24:20 +01:00
Renovate Bot
70c6263ea1
Update dependency express to v4.18.0
2022-04-25 20:53:02 +00:00
Naz
014fafbafb
Published new versions
...
- @tryghost/adapter-manager@0.2.29
- @tryghost/api-version-compatibility-service@0.1.0
- @tryghost/bootstrap-socket@0.2.18
- @tryghost/config-url-helpers@0.1.6
- @tryghost/constants@1.0.3
- @tryghost/database-info@0.3.2
- @tryghost/image-transform@1.0.30
- @tryghost/job-manager@0.8.22
- @tryghost/limit-service@1.0.11
- @tryghost/minifier@0.1.13
- @tryghost/moleculer-service-from-class@0.2.24
- @tryghost/mw-api-version-mismatch@0.1.0
- @tryghost/mw-error-handler@0.2.1
- @tryghost/mw-session-from-token@0.1.29
- @tryghost/mw-update-user-last-seen@0.1.4
- @tryghost/package-json@1.0.19
- @tryghost/pretty-cli@1.2.25
- @tryghost/promise@0.1.16
- @tryghost/release-utils@0.7.13
- @tryghost/security@0.2.16
- @tryghost/session-service@0.1.39
- @tryghost/settings-path-manager@0.1.5
- @tryghost/vhost-middleware@1.0.23
- @tryghost/zip@1.1.23
2022-04-21 20:58:17 +08:00
Renovate Bot
430608c9c3
Update dependency c8 to v7.11.2
2022-04-20 18:23:57 +00:00
Daniel Lockyer
3324ffc788
Published new versions
...
- @tryghost/adapter-manager@0.2.28
- @tryghost/bootstrap-socket@0.2.17
- @tryghost/config-url-helpers@0.1.5
- @tryghost/constants@1.0.2
- @tryghost/database-info@0.2.0
- @tryghost/image-transform@1.0.28
- @tryghost/job-manager@0.8.20
- @tryghost/limit-service@1.0.10
- @tryghost/minifier@0.1.11
- @tryghost/moleculer-service-from-class@0.2.23
- @tryghost/mw-error-handler@0.1.3
- @tryghost/mw-session-from-token@0.1.28
- @tryghost/mw-update-user-last-seen@0.1.3
- @tryghost/package-json@1.0.16
- @tryghost/pretty-cli@1.2.24
- @tryghost/promise@0.1.15
- @tryghost/release-utils@0.7.12
- @tryghost/security@0.2.15
- @tryghost/session-service@0.1.38
- @tryghost/settings-path-manager@0.1.4
- @tryghost/vhost-middleware@1.0.22
- @tryghost/zip@1.1.20
2022-03-01 08:40:52 +01:00
Daniel Lockyer
3259994e4f
Added --all
flag to c8 commands
...
refs https://github.com/TryGhost/Toolbox/issues/203
- without `--all`, c8 will ignore files that aren't covered in tests, so
they won't pull the test coverage down
- this means we have artificially high coverage scores
- this commit adds `--all` where previously missing
2022-02-21 12:50:26 +01:00
Renovate Bot
b7af869669
Update dependency express to v4.17.3
2022-02-17 03:48:16 +00:00
Daniel Lockyer
19d2411f2b
Published new versions
...
- @tryghost/adapter-manager@0.2.27
- @tryghost/bootstrap-socket@0.2.16
- @tryghost/config-url-helpers@0.1.4
- @tryghost/constants@1.0.1
- @tryghost/database-info@0.1.0
- @tryghost/errors@1.2.1
- @tryghost/image-transform@1.0.27
- @tryghost/job-manager@0.8.18
- @tryghost/limit-service@1.0.9
- @tryghost/minifier@0.1.10
- @tryghost/moleculer-service-from-class@0.2.22
- @tryghost/mw-error-handler@0.1.2
- @tryghost/mw-session-from-token@0.1.27
- @tryghost/mw-update-user-last-seen@0.1.2
- @tryghost/package-json@1.0.15
- @tryghost/pretty-cli@1.2.23
- @tryghost/promise@0.1.14
- @tryghost/release-utils@0.7.10
- @tryghost/security@0.2.14
- @tryghost/session-service@0.1.37
- @tryghost/settings-path-manager@0.1.3
- @tryghost/vhost-middleware@1.0.20
- @tryghost/zip@1.1.19
2022-01-18 09:08:09 +00:00
John O'Nolan
279ce66e71
2022
2022-01-06 09:52:35 +00:00
Renovate Bot
4c288fa50e
Update dependency c8 to v7.11.0
2021-12-30 16:28:02 +00:00
Renovate Bot
86d5d4b868
Update dependency express to v4.17.2
2021-12-17 05:58:56 +00:00
Sam Lord
b014df7b21
Published new versions
...
- @tryghost/adapter-manager@0.2.26
- @tryghost/errors@1.2.0
- @tryghost/image-transform@1.0.26
- @tryghost/limit-service@1.0.8
- @tryghost/minifier@0.1.9
- @tryghost/mw-error-handler@0.1.1
- @tryghost/package-json@1.0.14
- @tryghost/release-utils@0.7.9
- @tryghost/session-service@0.1.36
2021-12-14 14:24:31 +00:00
Sam Lord
bdcd205791
Published new versions
...
- @tryghost/adapter-manager@0.2.25
- @tryghost/errors@1.1.1
- @tryghost/image-transform@1.0.25
- @tryghost/limit-service@1.0.7
- @tryghost/minifier@0.1.8
- @tryghost/package-json@1.0.13
- @tryghost/release-utils@0.7.8
- @tryghost/session-service@0.1.35
2021-12-06 16:53:49 +00:00