TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-23 02:41:50 +03:00
Code Issues Projects Releases Wiki Activity
8,370 Commits 250 Branches 1,686 Tags 392 MiB
99e2db76dc
Commit Graph

559 Commits

Author SHA1 Message Date
Kevin Ansfield
99e2db76dc 🐛 Fixed Spotify and Soundcloud embeds having overly long containers in editor 
closes https://github.com/TryGhost/Team/issues/871

- when determining the size of the iframe containing a nested iframe in the embed card we were incorrectly treating a `100%` width attribute as a `100px` attribute and ending up with a completely incorrect ratio calculation
- added a conditional to ignore %-width attributes when calculating a ratio for a nested iframe
- if we have a nested iframe with a %-width but a fixed height, use that fixed height for the outer container iframe
 2022-01-04 10:00:21 +00:00
Thibaut Patel
5056401c13 Renamed the header styles 
refs https://github.com/TryGhost/Team/issues/1253

- The naming is easier to understand for theme developers
 2021-12-16 18:22:08 +01:00
Peter Zimon
b6da19df65 Updated header card placeholders 2021-12-16 16:11:50 +01:00
James Morris
dcb5d2ad0a Fixed a merge with the header card settings 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-16 14:39:50 +00:00
Thibaut Patel
05af5cdcd4 Removed width and alignment configuration from the header card 
refs https://github.com/TryGhost/Team/issues/1253

- We're simplifying the header card from a design point of view to ease integration with themes
 2021-12-16 15:10:57 +01:00
Peter Zimon
c4c728d7a1 Refined header image styles 2021-12-16 12:59:03 +01:00
Peter Zimon
c4b4a6b2a4 Put back header style options 2021-12-16 12:26:15 +01:00
Peter Zimon
9afb0c7a94 Updated style picker for header 2021-12-16 12:25:01 +01:00
Thibaut Patel
1e16b92f52 Updated the header card file selector 
refs https://github.com/TryGhost/Team/issues/1253

- Selecting the `image` style opens the file selector right away
- Avoids an extra click to the user
- Moved `GhFileInput` so that it's always rendered, which enables triggering it right when selecting the `image` style
 2021-12-16 11:09:14 +01:00
Sanne de Vries
21a1b3a1aa 🐛 Fixed audio file duration missing digit in editor 
Closes https://github.com/TryGhost/Ghost/issues/13894
 2021-12-16 09:17:45 +01:00
Naz
575623f5be Added support for additional wav MIME types 
refs f882ebc58e
refs https://github.com/TryGhost/Toolbox/issues/95

- The `audio/x-wav`, `audio/wav`, and `audio/wave` are also commonly used MIME types for the .wav files.
 2021-12-16 11:11:43 +04:00
James Morris
47e77ddcdc Little tweaks for header settings panel and added add icon 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 19:09:17 +00:00
djordje vlaisavljevic
ffc22f520a Updated before/after card editor template 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 20:06:00 +01:00
djordje vlaisavljevic
2a19d3bb74 Updated before/after card editor template 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 20:03:03 +01:00
Fabien egg O'Carroll
ee410a08c1 Updated slider for before/after to match frontend 
refs https://github.com/TryGhost/Team/issues/1249

Adds a new element to use as the slider handle to match how we're doing
it in the frontend
 2021-12-15 20:27:39 +02:00
Thibaut Patel
6d8fc32d77 Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- added a default `cardWidth`
 2021-12-15 18:28:41 +01:00
Thibaut Patel
1db6e175fd Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- removed the accent class in the edit mode
 2021-12-15 18:26:47 +01:00
Thibaut Patel
1194a553e8 Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- added the card width back (only regular or full options)
- removed the accent class from the button
- fixed a bug happening when the subheader was empty
 2021-12-15 18:25:05 +01:00
Peter Zimon
4f005f0ef5 Updated file card Koenig styles 2021-12-15 17:45:04 +01:00
djordje vlaisavljevic
ac33996c08 Updated editor styles for before/after card 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 11:10:05 +01:00
Fabien egg O'Carroll
cb24aa1914 Added replace image functionality 
refs https://github.com/TryGhost/Team/issues/1249

This can resuse the image selection as after a successful upload the
image is replaced.
 2021-12-15 12:06:46 +02:00
Thibaut Patel
e1bbc63bb3 Updated header card class names 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 10:02:17 +01:00
Fabien egg O'Carroll
804da37926 Removed requirement for matchign aspect ratio 
refs https://github.com/TryGhost/Team/issues/1249

Based on design feedback so that users are able to use the card with
less friciton.
 2021-12-15 10:35:38 +02:00
djordje vlaisavljevic
1d19f74ba8 Updated editor styles for before/after card 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 09:32:09 +01:00
Sanne de Vries
b640a023f7 Refined video card in editor 
Refs https://github.com/TryGhost/Team/issues/1229

- Fixed glitch on load
- Fixed error state
- Hid custom thumbnail when video is looped
 2021-12-14 19:49:29 +01:00
Peter Zimon
526c92bad7 Refined file Koenig styles 2021-12-14 17:55:27 +01:00
Peter Zimon
09b221543f Updated file upload Koenig styles 2021-12-14 17:41:41 +01:00
Fabien egg O'Carroll
1a772b13c1 Removed option & logic for setting orientation 
refs https://github.com/TryGhost/Team/issues/1249

Based on design feedback from Djordje & Zimo.
 2021-12-14 18:39:28 +02:00
Thibaut Patel
3742502f2d Updated the header card based 
refs https://github.com/TryGhost/Team/issues/1253

- follows the latest design
 2021-12-14 16:00:59 +01:00
Fabien egg O'Carroll
7d7d856e77 Removed edit option from toolbar 
https://github.com/TryGhost/Team/issues/1249

We have no floating settings now so we can remove the menu item and
display the toolbar always when the card is selected
 2021-12-14 16:40:51 +02:00
Fabien egg O'Carroll
1338ddd12b Removed usage of MutationObserver 
refs https://github.com/TryGhost/Team/issues/1249

We now want to update the element which we are observing, which means we
end up in a loop. Instead we can listen to resize events and manually
update the dimensions when images are changed.
 2021-12-14 16:40:51 +02:00
Fabien egg O'Carroll
d3ee36e45d Moved image upload and slider settings into card 
refs https://github.com/TryGhost/Team/issues/1249

Based on design wirefames
 2021-12-14 16:40:51 +02:00
Fabien egg O'Carroll
993fdf9a10 Moved layout and orientation settings to toolbar 
refs https://github.com/TryGhost/Team/issues/1249

Based on the design wireframes we're not going to be using a floating
panel for settings, this moves the functionality into the toolbar
 2021-12-14 16:40:51 +02:00
Fabien egg O'Carroll
d18e6006f9 Removed unused wordCount 
refs https://github.com/TryGhost/Team/issues/1249

This isn't used anywhere at the moment.
 2021-12-14 16:40:46 +02:00
Rishabh
324e6e95d0 Added duration data in video card 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 16:42:56 +05:30
Thibaut Patel
06a83f81b7 Updated the header card width selector 
refs https://github.com/TryGhost/Team/issues/1253

- Follows the same pattern as the video card
 2021-12-14 12:02:05 +01:00
Sanne de Vries
69aa98f9ca Updated video card and media player classes 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 11:49:33 +01:00
Sanne de Vries
a011ee2d97 Updated video card settings panel 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-14 09:37:45 +01:00
Thibaut Patel
f8caa3adce Added a first pass of the header card 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-13 19:31:23 +01:00
Sanne de Vries
6df5708c7f Refined audio and bookmark cards in editor 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-13 19:09:00 +01:00
Rishabh
c9c602f839 Fixed settings panel behavior for video card thumbnail replace 
refs https://github.com/TryGhost/Team/issues/1229
 2021-12-13 21:46:09 +05:30
Sanne de Vries
06cb582fc0 Refined audio cards in editor 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-13 16:18:32 +01:00
Fabien egg O'Carroll
12582c6cf4 Added initial Before/After card UI 
refs https://github.com/TryGhost/Team/issues/1249

This adds a WIP for the Before/After card UI - behind an alpha flag.
It's completely missing design input and is intented to serve as a base
to work from.
 2021-12-13 15:57:29 +02:00
Sanne de Vries
f788cd6dfa Removed unnecessary hidden audio player buttons 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-13 14:09:39 +01:00
Sanne de Vries
828786212c Fixed audio card error state 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-13 12:36:38 +01:00
Thibaut Patel
a879beb09d Hid the product card button fields when button is disabled 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-13 11:48:21 +01:00
Sanne de Vries
26265b6a11 Updated video card in editor 
Refs https://github.com/TryGhost/Team/issues/1229
 2021-12-13 11:43:11 +01:00
Rishabh
48e64a47be Updated thumbnail replace for audio card with thumbnail delete option 
refs https://github.com/TryGhost/Team/issues/1230

- allowing users to delete the thumbnail and upload another is a better flow as it allows removing a thumbnail as well if not needed
 2021-12-13 16:10:29 +05:30
Rishabh
c3cb7dde47 Updated card edit flow for audio and file cards 
refs https://github.com/TryGhost/Team/issues/1230

- Updated the audio and file card to follow - 1st click → select, 2nd click → edit pattern, which is consistent with other cards
 2021-12-13 15:58:25 +05:30
Kevin Ansfield
59def266de Fixed video card aspect ration change when uploading custom thumbnail 
refs https://github.com/TryGhost/Team/issues/1229

- changed the video card image so it uses an aspect-ratio box set to the aspect ratio of the video, with the image using `object-fit: cover` to match the background image behavior in the front-end
 2021-12-10 19:48:28 +00:00