Commit Graph

10083 Commits

Author SHA1 Message Date
Hannah Wolfe
9a2719ac4f Decoupled routing service and theme service
- This is a fairly temporary state
- It at least removes the themeService require from inside the routingService
- Requires us to pass the routingService the desired API Version...
- We're working towards having the entire frontend respect the theme API version by having it passed around everywhere
2019-11-06 15:20:13 +07:00
Hannah Wolfe
ca61e245e8 Updated syntax in labs service
- use consistent, simpler syntax
2019-11-06 14:53:53 +07:00
Hannah Wolfe
7a36200e24 🐛 Ensure deprecated labs flags are unset
fixes #11343

- solves the case where themes depends on old labs flags that are now always false, but the DB still has the feature set to true
- add concept of deprecated labs flags to the labs service
- make sure that the labs service gets used in our theme middleware
- added tests and other small fixes
2019-11-06 14:42:39 +07:00
Hannah Wolfe
27dd442059 Added extra handling for test port conflict errors
- If you use ghost cli, you may have extra ghost instances running on 2369
- Add extra handling to make this case super clear next time it happens to someone (probably me)
2019-11-06 12:48:58 +07:00
Hannah Wolfe
814bb7da55 Fix silly issues with post class 2019-11-06 11:02:50 +07:00
Hannah Wolfe
6315223589 Node v12 is now LTS and supported
- no more allowed failures
- shouldn't need ignore-engines flag anymore
2019-11-06 09:39:56 +07:00
Daniel Lockyer
b91f3071be Deferred loading metascraper (#11337)
no issue

- reduces Ghost boot time from 1.47s to 1.33s on my machine.
2019-11-06 08:31:11 +07:00
Hannah Wolfe
1cdc181c54 Added no-image class to content w/o feature_image
no issue

- Most of the offical Ghost themes have been doing this manually
- So we'll just do it by default:
2019-11-05 18:02:23 +07:00
Hannah Wolfe
72679aefb9 Updated inconistent frontend debug statements
- Fixed debug statements had wrong/inconsistent debug statement path after refactor
2019-11-05 15:06:15 +07:00
Renovate Bot
f78996d063 Update dependency sharp to v0.23.2 2019-11-04 14:29:45 +00:00
Renovate Bot
afc68be5fc Update dependency oembed-parser to v1.3.6 2019-11-04 13:31:14 +00:00
Renovate Bot
783ab24735 Update dependency metascraper-title to v5.7.17 2019-11-04 12:30:53 +00:00
Renovate Bot
ea0833c1fc Update dependency metascraper-logo-favicon to v5.7.17 2019-11-04 11:29:20 +00:00
Renovate Bot
a62f9be0fb Update dependency metascraper-url to v5.7.17 2019-11-04 10:30:46 +00:00
Renovate Bot
fc23b3418e Update dependency metascraper-publisher to v5.7.17 2019-11-04 09:30:15 +00:00
Renovate Bot
07915bcf85 Update dependency metascraper-image to v5.7.17 2019-11-04 08:31:27 +00:00
Renovate Bot
d7bd355159 Update dependency metascraper-logo to v5.7.17 2019-11-04 07:29:53 +00:00
Renovate Bot
3714a66ed1 Update dependency metascraper-author to v5.7.17 2019-11-04 06:28:31 +00:00
Renovate Bot
4817679bc4 Update dependency metascraper-description to v5.7.17 2019-11-04 05:28:47 +00:00
Renovate Bot
033f4ecd76 Update dependency metascraper to v5.7.17 2019-11-04 04:30:21 +00:00
Renovate Bot
f29b734feb Update dependency gscan to v3.1.1 2019-11-04 03:32:02 +00:00
Renovate Bot
708cf6ed02 Update dependency @tryghost/members-ssr to v0.7.2 2019-11-04 02:30:56 +00:00
Renovate Bot
28d3818b97 Update dependency @tryghost/helpers to v1.1.18 2019-11-04 01:28:58 +00:00
Kevin Ansfield
6b420d0cbd Added member.edited webhook
no issue

- member model emits a `member.edited` event on update
- webhooks service listens for `member.edited` event and will trigger any registered hooks
2019-10-31 14:34:50 +00:00
Kevin Ansfield
a339a838b3
Removed /api/v2/members/ endpoints (#11308)
no issue

- this was a hangover from earlier members betas
- members is only available on `v3` and `canary` APIs
2019-10-31 11:11:46 +00:00
Naz Gargol
0c3b90283a
Renamed members to post-gating for better context (#11309)
no issue

- Using members.js naming for the file was a bad choice and lead to some false signals when doing a cleanup.  `post-gating` is more explicit and to the point of what the module is responsible for
2019-10-31 10:33:37 +01:00
Kevin Ansfield
1fd7014c45 Fixed member.deleted webhook having an empty payload
no issue

- the members output serializer was passing model objects through on `frame.response` but the webhooks serializer doesn't know how to deal with those
- adjusting the output serializer to use a mapper as per the other serializers means that POJOs are being passed through which allows the webhook serializer to correctly pick out the changed attributes
2019-10-31 15:19:45 +07:00
Casper Bøgeskov Hansen
638b4fc2f2 Fixed post preview access flag in 3.0 (#11275)
no-issue

The access flag was not being set in the preview controller which was causing 3.0 Member themes to incorrectly hide the content
2019-10-31 13:58:47 +07:00
Kevin Ansfield
2dc6f30f11 🐛 Fixed internal error for RSS feed when a post has no content
no issue

- initial report https://forum.ghost.org/t/rss-feed-stopped-working/9874
- `htmlRelativeToAbsolute` will return `null` if `null` is passed into it but `cheerio.load(null)` will throw a "Cannot read property 'parent' of null" error so we need to ensure we at least load an empty string
2019-10-30 17:46:17 +00:00
renovate[bot]
cfb66ac161 Update dependency oembed-parser to v1.3.5 (#11124) 2019-10-30 17:16:38 +01:00
renovate[bot]
da37e3ec61 Update dependency express-session to v1.17.0 (#11238) 2019-10-30 16:41:39 +01:00
renovate[bot]
4009911da2 Update dependency grunt-contrib-compress to v1.6.0 (#11293) 2019-10-30 16:38:32 +01:00
Kevin Ansfield
f153f174d0 Version bump to 3.0.2 2019-10-30 11:08:00 +00:00
Kevin Ansfield
bddbdd2429 Updated Ghost-Admin to 3.0.2 2019-10-30 11:08:00 +00:00
Kevin Ansfield
c65ded66fa Updated Casper to 3.0.2 2019-10-30 11:07:59 +00:00
Kevin Ansfield
314958cbf1 Updated dependency @tryghost/url-utils to v0.6.13
no issue

- includes fix for cloudflare `<stream>` embeds breaking after having their URLs transformed
2019-10-30 10:56:48 +00:00
Fabien O'Carroll
804afca51f Installed @tryghost/members-api@0.8.3
no-issue

This improves logging for webhook signature validation
2019-10-30 17:24:04 +07:00
Kevin Ansfield
b5571bf5c6 Version bump to 3.0.1 2019-10-29 14:20:09 +00:00
Kevin Ansfield
a95bb6c5fd Updated Ghost-Admin to 3.0.1 2019-10-29 14:20:09 +00:00
Kevin Ansfield
f7f0f1a8cd Updated Casper to 3.0.1 2019-10-29 14:20:09 +00:00
Kevin Ansfield
37e4fd9521 Revert "Update dependency @tryghost/url-utils to v0.6.11"
This reverts commit 37e8951fe9.

- the sub-dependency bump of `moment-timezone` caused another occurrence of https://github.com/tryghost/Ghost/issues/10870

# Conflicts:
#	package.json
2019-10-29 14:13:24 +00:00
Naz Gargol
9b347d6d95 🐛 Fixed 3.0 migration on SQLite with many posts (#11302)
refs https://github.com/TryGhost/Ghost/pull/11270

- Fixed 3.0/11-update-posts-html migration which failed in scenario when more than 999 posts with posts_meta relation were present
- The issue was originally spotted here: https://github.com/TryGhost/Ghost/pull/11270#issuecomment-546248308
- The main problem is in the `SELECT` statement which is generated for `findAll` method in Bookshelf which creates `WHERE IN(post_ids_here)` statement with all posts in the database
- Using knex directly as that's a preferred way to write migrations (does not depend on the model layer)
2019-10-29 12:16:47 +00:00
renovate[bot]
640c4a82f1 Update dependency gscan to v3.1.0 (#11294) 2019-10-29 10:00:24 +00:00
renovate[bot]
4023772d12 Update dependency express-hbs to v2.2.0 (#11292) 2019-10-29 10:00:05 +00:00
Kevin Ansfield
c2cdfef9e2
💡 Removed list of reserved slugs (#11301)
no issue

- reserved slugs get in the way of creating pages such as `/signin/` which do not currently exist and are useful for members
- the reserved slugs concept is a little meaningless because if there are any route clashes then our own routes should always win out over a post slug
2019-10-29 09:49:47 +00:00
Rishabh Garg
d370a4e840
🐛 Fixed members export limiting to 15 members only (#11299)
refs https://github.com/TryGhost/Ghost/issues/11298

The members export admin API by default paginates the result and only returns upto 15 members. This allows passing `limit` param to the API and allows passing `limit=all` to fetch all members in result.
2019-10-29 10:20:32 +05:30
Renovate Bot
2cf3b4f2f1 Update dependency metascraper-title to v5.7.14 2019-10-28 16:44:50 +00:00
Renovate Bot
661d0d784f Update dependency metascraper-url to v5.7.14 2019-10-28 15:37:39 +00:00
Renovate Bot
ab5662e4b3 Update dependency metascraper-logo-favicon to v5.7.14 2019-10-28 14:37:14 +00:00
Naz Gargol
99c6351feb
🐛 Fixed 3.0 migration for SQLite (#11270)
closes #11263

- Fixed `3.0/05-populate-posts-meta-table.js` migration failure when having >999 posts with metadata in the database
- The issue here is with hitting SQLite's internal SQLITE_LIMIT_VARIABLE_NUMBER limit when updating with a large amount of posts having metadata fields set (ref.: https://sqlite.org/limits.html#max_variable_number)
- Transforming migration to iterative method avoided inserting lots of records at once
2019-10-28 14:21:21 +01:00