TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 05:37:34 +03:00
Code Issues Projects Releases Wiki Activity
35,601 Commits 235 Branches 1,678 Tags 380 MiB
9a5c13309e
Commit Graph

35601 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sanne de Vries
4a6a61b29b
Added feature flag for page improvements (#17176) 
No ref
 2023-07-03 09:24:57 +02:00
Jono M
3811999be7
Improved AdminX theme installation flow (#17175) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-07-03 17:59:31 +12:00
Ghost CI
8b164b8dbf v5.53.3 2023-06-30 15:02:52 +00:00
Daniel Lockyer
956fb7d4a4
Updated lockfile 2023-06-29 15:52:35 +02:00
Simon Backx
8b610d46b1
Cleaned up batch email utils (#17165) 
no issue
 2023-06-29 15:29:16 +02:00
Simon Backx
c90424542e
🐛 Fixed signup card in post plaintext and email preheader (#17163) 
fixes https://github.com/TryGhost/Team/issues/3542

The signup card text was included in the post plaintext/excerpt and
email preheader
 2023-06-29 14:45:30 +02:00
Simon Backx
e6dbc0bc4c
🐛 Fixed repeating text in plaintext version of emails (#17162) 
fixes https://github.com/TryGhost/Team/issues/3541

The email preheader, which is only present in the html version of an
email, is also included in the plaintext version of all emails. This
results in all text being duplicated twice in plaintext emails.
 2023-06-29 12:47:17 +02:00
Simon Backx
c41694f5e6
Added E2E Koenig Lexical card tests for paragraphs and signup card (#17159) 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1687987311455289
 2023-06-29 11:10:56 +02:00
Ghost CI
a85d455d1b Merged v5.53.2 into main 2023-06-29 08:53:43 +00:00
Ghost CI
1e9844e781 v5.53.2 2023-06-29 08:53:41 +00:00
Michael Barrett
576fba0568
🐛 Fixed members-only content incorrectly showing in plaintext email (#17137) 
fixes https://github.com/TryGhost/Ghost/issues/16131

Members only content was incorrectly being shown in a plaintext email
due to the email `preheader` using the post model `plaintext` field
directly (which contained the members-only content). This changes this
behaviour so that the post html content is utilised for the `preheader`
but has all members-only content (post-preview content + segmented
content) removed
 2023-06-29 09:40:04 +01:00
Ronald Langeveld
04970b4995 🐛 Fixed email breaking when signup card is added 
ref https://ghost.slack.com/archives/C04TMVA1D7A/p1687987311455289
 2023-06-29 10:34:39 +02:00
Ronald Langeveld
08e1bcd50c Bumped Koenig packages 
no issue
 2023-06-29 10:11:20 +02:00
renovate[bot]
aa8cbb9fa3 Update dependency typescript to v5.1.6 2023-06-29 08:24:30 +02:00
Jono M
c03d3ff384
Factored out theme installed modal (#17158) 
refs https://github.com/TryGhost/Team/issues/3349

Will be reused in future changes, just doing a quick refactor first to
prevent conflicts
 2023-06-29 18:14:53 +12:00
Fabien "egg" O'Carroll
d4027a4797 Added BookshelfCollectionsRepository 
This implements the CollectionRepository interface and can be swapped out with
the existing repository to persist collections to the database.
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
724c95cd92 Added bookshelf model for collections 
We setup the relations and NQL expansions/replacements here rather than in the
repository, we want to keep all the bookshelf code together in one place.
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
16db3bbf17 Removed deletable property in favour of protected slugs 
We couldn't decide on the best way to encode this in the database.
e.g. deletable: true? or type: internal? but type conflicts with the
storage of manual/automatic.

For now we can use this, and add something in future if we're finding problems
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
cf83d169db Added use of a slug generator to offload calculation of slugs 
When we end up wiring this to the database, this generator will also ensure
uniqueness by appending/incrementing a number on the end of the slug. Long term
it would be good to offload this to a shared slug service, this could also
ensure that slugs are unique globally or between multiple tables, if desired
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
0a3e36cd62 Ensured uniqueness of slug in collections 
We require that slugs are unique as slugs can/are used for routing purposes and
act as an identifier for a resource. As this is a core business rule, we want
to encode it in the entity so that it can be unit tested, and be enforced
regardless of underlying persistence layer
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
d29f512823 Required titles for collections 
We don't want to allow collections to be created without a title, and we need
to encoe that business rule in the entity.
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
0cfa236570 Fixed visibility of internal _posts member 
The _posts member is supposed to be an iternal property to store the data used
by the `posts` getter/setter
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
633cecdf75 Fixed createCollection not waiting for save 
This can cause race conditions when writing e2e tests in the case of to the API
responding before persisting the data
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
283cae9a59 Fixed "Full Offline Dev" launch config 
Each flag needs to be a separate entry in the args array.
 2023-06-29 01:40:05 +01:00
Fabien "egg" O'Carroll
9771e1f5c1 Renamed collections service wrapper to service.js 
This follows our existing patterns and protects us from th eslint max line rule
when wiring up dependencies. The rule is designed to keep logic out of glue
code, and this file won't have logic, just lots of deps.
 2023-06-29 01:40:05 +01:00
Sodbileg Gansukh
d0bea0d607 Released Announcement-Bar v1.1.7 2023-06-29 08:35:07 +08:00
Sodbileg Gansukh
e8e2077548 Added box-sizing to the announcement bar 
no issues

- it overrides the default content-box behavior and prevents the bar becoming taller than it should be
 2023-06-29 08:33:39 +08:00
renovate[bot]
98a8727538 Update peter-evans/create-or-update-comment digest to be902ae 2023-06-28 16:23:45 +02:00
Eric S. Londres
47b76925a0 Update README.md 2023-06-28 16:23:34 +02:00
renovate[bot]
58b54333a5 Update dependency typescript to v5.1.5 2023-06-28 16:21:27 +02:00
renovate[bot]
a04a4293cb Update dependency vite-plugin-css-injected-by-js to v3.1.2 2023-06-28 16:21:00 +02:00
Michael Barrett
636c916715
Fixed leaking pivot fields (#17142) 
fixes https://github.com/TryGhost/Team/issues/2657

The `omitPivot` option does not have an affect on a models
`_previousAttributes`. When we serialise a model and want to retrieve
the previous attributes we need to ensure we manually remove the pivot
fields

See
7704fbc5e8/lib/base/model.js (L512)
 2023-06-28 13:16:50 +01:00
Simon Backx
5c843545d8 Added comments-ui editor E2E tests 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-28 13:08:35 +02:00
Jono M
9c2553a06a
Updated theme upload modal to show gscan errors (#17148) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-06-28 19:54:21 +12:00
Jono M
768511c7cc
Added tests for more areas of AdminX settings (themes, design, multiselect) (#17134) 
refs https://github.com/TryGhost/Team/issues/3349

Tidies up the remaining major pieces which were not covered by tests.
Extends the existing test patterns, although the API mocks are getting a
bit unmanageable.
 2023-06-28 14:59:05 +12:00
Daniel Lockyer
12deff4a16 Fixed performance issue when checking theme name 
refs 1374e3f70c

- see referenced commit for the explanation
- this bumps GScan to bring in that fix
 2023-06-27 17:04:34 +02:00
renovate[bot]
5bcbb2de41 Update storybook monorepo to v7.0.24 2023-06-27 16:56:47 +02:00
Simon Backx
e6fe60ed37 Added E2E test for colorScheme in comments-ui 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-27 16:28:53 +02:00
Simon Backx
23fc00ae60 Added E2E tests for comments-ui accent color option 
refs https://github.com/TryGhost/Team/issues/3504

This also fixes an issue where the signup button would become transparent when the accent color option was not set
 2023-06-27 16:28:53 +02:00
Simon Backx
81970fbe01 Added E2E test for avatarSaturation on comments-ui 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-27 16:28:53 +02:00
Simon Backx
331533d724
Migrated Comments-UI to TypeScript (#17129) 
refs https://github.com/TryGhost/Team/issues/3504

This migrates comments-ui to TypeScript. Only `App.js` is left to
migrate, but since this isn't using hooks yet, it will need a bigger
rewrite so this will need to happen in a separate PR.
 2023-06-27 14:51:37 +02:00
Daniel Lockyer
549e608b27
Released Portal v2.33.4 2023-06-27 09:26:05 +02:00
Daniel Lockyer
6cbfeb232e
Fixed mismatched brackets in French and Uzbek translations 
refs https://github.com/TryGhost/Toolbox/issues/603

- these were found by a newly added test and would have resulted in the
  variable strings being left in the final result
 2023-06-27 09:03:51 +02:00
Daniel Lockyer
a8801be82a
Added test to check for mismatched brackets in translations 
refs https://github.com/TryGhost/Toolbox/issues/603

- this will loop over all locales and translations files to check for
  a mismatched bracket count
 2023-06-27 09:01:25 +02:00
Daniel Lockyer
bebf85f84a
Released Portal v2.33.3 2023-06-27 08:22:48 +02:00
Naz
9767e1f591 Fixed PostEditedEvent data mapping 
refs https://github.com/TryGhost/Team/issues/3169

- The "current" part of the payload should always have the "id" included to make the data structure easier to use for the event consumer
 2023-06-27 12:52:10 +07:00
Naz
5dd6159ac6 Added handling for 'post.edited' Ghost model event 
refs https://github.com/TryGhost/Team/issues/3169

- Adds optomized collection update handling for when post.edited model event is emitted.
 2023-06-27 12:52:10 +07:00
Naz
a8e5cbcc3d Extracted post matching to filter to separate method 
refs https://github.com/TryGhost/Team/issues/3169

- This method is also useful for external services when checking if collection needs any updates or not.
 2023-06-27 12:52:10 +07:00
Naz
bb13845773 Added future perf oprimization note 
refs 1bc2a604c3 (r1239780571)
 2023-06-27 12:52:10 +07:00
Naz
cf48d4ef5c Removed ability to change collection type after creation 
refs https://github.com/TryGhost/Team/issues/3169

- Being able to change the collection type comes with extra complications we don't wan to support just yet. This came up as a part of the PR review here - 1bc2a604c3 (r1239783573).
 2023-06-27 12:52:10 +07:00