6 Commits

Author	SHA1	Message	Date
Nazar Gargol	12c8b63a4a	Added more specific error handling when adding duplicate labels ... no issue - Similarly to other additive api methods (e.g. members.add) returned more specific ValidationError with contex filled in with the reason why adding did not succed. - This change is needed for more graceful label handling when adding new members through import	2020-06-05 00:23:10 +12:00
Nazar Gargol	59c773fb04	Removed cache invalidation header when adding label through Amdin API ... no issue - Adding labels doesn't cause any content to invalidate, similarly to adding members. Unlike it's caunterpart - tags, there is no dependent "frontend" content that would become invalid	2020-06-04 23:44:19 +12:00
Vikas Potluri	4ac88dce10	Refactored common lib import to use destructuring (#11835) ... * refactored `core/frontend/apps` to destructure common imports * refactored `core/frontend/services/{apps, redirects, routing}` to destructure common imports * refactored `core/frontend/services/settings` to destructure common imports * refactored remaining `core/frontend/services` to destructure common imports * refactored `core/server/adapters` to destructure common imports * refactored `core/server/data/{db, exporter, schema, validation}` to destructure common imports * refactored `core/server/data/importer` to destructure common imports * refactored `core/server/models/{base, plugins, relations}` to destructure common imports * refactored remaining `core/server/models` to destructure common imports * refactored `core/server/api/canary/utils/serializers/output` to destructure common imports * refactored remaining `core/server/api/canary/utils` to destructure common imports * refactored remaining `core/server/api/canary` to destructure common imports * refactored `core/server/api/shared` to destructure common imports * refactored `core/server/api/v2/utils` to destructure common imports * refactored remaining `core/server/api/v2` to destructure common imports * refactored `core/frontend/meta` to destructure common imports * fixed some tests referencing `common.errors` instead of `@tryghost/errors` - Not all of them need to be updated; only updating the ones that are causing failures * fixed errors import being shadowed by local scope	2020-05-22 19:22:20 +01:00
Daniel Lockyer	a769bbe86c	Fixed 500 error when deleting items that don't exist ... fixes #11723 - when deleting an invite/label/tag/webhook that doesn't exist, Ghost would throw a 500 error - this commit catches the NotFoundError - also rejects from model if nothing was found - spotted in Sentry	2020-04-13 16:13:33 +01:00
Daniel Lockyer	13e1ecae27	Replaced use of Bluebird return method from knex code ... no issue - Knex removed their use of several Bluebird methods, including `return` - our code used `return`, but mostly to return null after a destroy action - these uses have been replaced with `.then(() => null)` in order to continue returning null and to avoid breaking anything	2020-04-07 10:49:12 +01:00
Rishabh Garg	001db05075	✨Added labels for Members (#11538) ... no issue * Updated sendEmailWithMagicLink syntax * Updated label name selection from theme * Updated migration version for labels * Added labels to export/import of members * Added member labels sanitization for case-insensitive duplicates * Fixed tests * Fixed label serialization bug on import * Bumped @tryghost/members-api to 0.15.0 * Fixed lint * Cleanup	2020-02-14 15:03:10 +05:30