Commit Graph

1792 Commits

Author SHA1 Message Date
Hannah Wolfe
a196d81778 Fixing overzealous trailing-slashes
refs #4989

- Don't add a trailing a slash if the url is a file or anchor
2015-03-07 21:09:50 +00:00
John O'Nolan
4d5c63e4df Merge pull request #4948 from PaulAdamDavis/simpler-icon-code
Improve icon handling code
2015-03-07 20:16:06 +02:00
John O'Nolan
409e97772c Merge pull request #4976 from PaulAdamDavis/fix-blog-logo-svg
Remove button wrapping blog logo image
2015-03-07 20:15:53 +02:00
Hannah Wolfe
4fdc730913 More serverside notificaiton HTML fixes
refs #4964, #4969
2015-03-03 19:57:27 +00:00
Paul Adam Davis
153995ff3b Remove button wrapping blog logo image
Closes #4959

An SVG (without width & height attributes) inside a button won't display as it should. There seems to be no fix other than apply a minimum width & height. That doesn't feel right, so I've opted for this.

- Remove the `<button>` wrapping `<img>` elements
- Add `cursor: pointer;` to those images (now they don't get one, not being inside a `<button>`
- Remove the `#blog-logo/cover` IDs and `for` attributes. They only apply focus on text inputs anyway.
2015-03-02 14:53:03 +00:00
Hannah Wolfe
cecb07f6e2 Display serverside HTML notifications correctly
refs #4964

- persistent notifcations from the server contain HTML and should be marked HTML safe
2015-02-28 17:41:38 +00:00
Matt Enlow
a6f0264bf1 Merge pull request #4965 from ErisDS/validate-image-url
Validate urls in modal
2015-02-28 09:49:15 -07:00
Hannah Wolfe
c3574c6130 Validate urls in modal
- Urls added via a model are stored in the DB and need to be validated

Credits: Abdel Adim Oisif
2015-02-28 16:24:34 +00:00
Hannah Wolfe
2070f47fe9 Mark html notifications as html-safe, else escape
no issue

- Use the double-tash escaping output for notification messages
- Mark known and trusted html notifications as html-safe

Credits: Abdel Adim Oisif
2015-02-28 16:22:38 +00:00
Matt Enlow
caec7f990e Merge pull request #4950 from ErisDS/nav-flag-remove
Remove navigation config flag
2015-02-26 07:50:23 -07:00
Jason Williams
a25d483da5 Simplify navigation item reordering 2015-02-25 17:26:25 +00:00
Hannah Wolfe
95f6b6f549 Remove navigation config flag
ref #4535

- don't need this any more :)
2015-02-25 15:15:55 +00:00
Paul Adam Davis
09b2609e10 Improve icon handling code
Closes #4878

This changes nothing except DRYness of code. Its output is exactly the
same.

- Moves all icon variables into a map
- Add getter function to extract variables from the map
2015-02-25 00:21:56 +00:00
Matt Enlow
6f4ec2f21c Don't save if nav items have empty labels
Closes #4942, Closes #4944
- Also adds the `order` prop to the lastItem on save, so it doesn't jump about
2015-02-24 11:50:07 -07:00
Matt Enlow
c30ed85c80 Fix navigation deletion
Closes #4928
2015-02-23 17:02:48 -07:00
Hannah Wolfe
f8e936150f Merge pull request #4934 from PaulAdamDavis/fix-nav-order-metadata
Add `order` property when parsing Navigation JSON
2015-02-23 23:39:06 +00:00
Paul Adam Davis
337ff59888 Add order property when parsing Navigation JSON
Closes #4927

- Add `order` property when parsing Navigation JSON
- Fixes CSS issue where the placeholder nav item drag handle was still visible
2015-02-21 14:07:13 +00:00
Hannah Wolfe
5740834d69 Merge pull request #4935 from PaulAdamDavis/input-error-style
Add `error` class styles for inputs
2015-02-20 16:17:28 +00:00
Sebastian Gierlinger
d6c8bc6549 Merge pull request #4923 from ErisDS/nav-trailing-slash
Ensure internal nav items have a trailing slash
2015-02-18 20:40:22 +01:00
Hannah Wolfe
dcee7ed234 Merge pull request #4930 from jaswilli/issue-4871
Run listener callbacks in Ember run-loops
2015-02-18 19:19:01 +00:00
Sebastian Gierlinger
7fb7a0de09 Merge pull request #4914 from ErisDS/nav-ux-fix
Use placeholder only for last item
2015-02-18 19:55:09 +01:00
Jason Williams
af87641bae Run listener callbacks in Ember run-loops
Closes #4871
2015-02-18 17:11:02 +00:00
Paul Adam Davis
5ddd9e3463 Add error class styles for inputs
No issue

Adds a red border to inputs when a `error` class is applied

Also DRY's up the URL input a tad.
2015-02-18 11:34:52 +00:00
John O'Nolan
2c8cd445b8 Merge pull request #4870 from PaulAdamDavis/notifications-bug
Move bottom notifications outlet outside of <main>
2015-02-17 21:22:12 +02:00
Hannah Wolfe
d35291259b Ensure internal nav items have a trailing slash
refs #4535

- all internal urls in ghost have a trailing slash, missing it out will cause nav-current to not work
2015-02-16 19:08:41 +00:00
Hannah Wolfe
e2fc4771c1 Use placeholder only for last item
refs #4535

- as discussed in the meeting on 1st February ;)
- changed the fake-placeholder to only operate on the last item, this way it feels right, I think
2015-02-13 23:27:22 +00:00
Matt Enlow
920c80e908 Merge pull request #4858 from PaulAdamDavis/nav-drag-order
Drag & Drop Navigation Reordering
2015-02-13 11:26:34 -07:00
Matt Enlow
d3d2f9a1ae Merge pull request #4910 from 1pete/disable-reset-pw-btn
Set reset-password button disabled while submitting form
2015-02-12 19:51:49 -07:00
Jason Williams
691f22596e Adjust reauth modal to handle removal of proxying
Closes #4907.
- The modal signin no longer inherits from the signin page
  controller to simplify the interaction with simple-auth.
2015-02-13 01:40:13 +00:00
1Pete
fd2ac648fa set reset-password button disabled while submitting form 2015-02-13 06:16:18 +07:00
Paul Adam Davis
97506a53f6 Drag & Drop Navigation Reordering
Closes #4540

- Implements drag & drop to reorder navigation items
- Adds a `sort` property to navigation items
- Adds a tiny library to enable touch events for drag & drop. It hooks onto jQuery UI.
- Sort nav items before being saved
- Adds `settings-view-navigation` to route for body class
2015-02-12 17:02:46 +00:00
Jason Williams
5ea14118c8 Update Ember to 1.10.0
No issue.
- Ember@1.10.0
- Update grunt-ember-templates to version that supports HTMLBars.
- Update Gruntfile.js to compile templates with HTMLBars.
- Convert Handlebars code to its HTMLBars equivalent.
2015-02-09 16:20:16 +00:00
John O'Nolan
5d7e297923 Merge pull request #4793 from PaulAdamDavis/url-upload-styles
Update Image URL Input Styles
2015-02-04 09:02:33 -04:00
John O'Nolan
bfe546ad5b Merge pull request #4864 from PaulAdamDavis/user-image-styles
Update user image styles
2015-02-04 09:02:20 -04:00
Hannah Wolfe
89f0b42cda Merge pull request #4880 from jaswilli/client-model-tests
Add tests for admin client models
2015-02-02 19:03:40 +00:00
Jason Williams
8b0505070d Merge pull request #4877 from harryhope/master
Ignore non-words in word counter
2015-02-02 10:52:04 -06:00
Jason Williams
b18878fd7e Add tests for admin client models 2015-02-01 21:41:55 +00:00
Harry Hope
6e2765da70 ignore non-words in word counter 2015-02-01 01:22:20 -05:00
Jason Williams
9d8a68332c Fix regression in re-setting slug on untitled post
Refs #4748
2015-02-01 05:17:24 +00:00
Jason Williams
8f5120150c Do not add autofocus attribute unless set to focus
No Issue
- Don't add the "autofocus" attribute to the input element unless
  the "focus" property is set to true.
2015-01-30 22:29:34 +00:00
Hannah Wolfe
d98c6fdad2 Merge pull request #4865 from PaulAdamDavis/user-settings-no-name-bug
Fix layout error when there's no user name
2015-01-30 20:16:04 +00:00
Paul Adam Davis
44911304d5 Move bottom notifications outlet outside of <main>
Closes #4379

- Moves the bottom notification outlet _outside_ the `<main>` element which allows notifications to show above the nav bar
- Removes (the now unnecessary) code which counter-positioned the bottom notifications when a Settings Menu was opened.

The way these notifications look or are positioned at various viewport sizes **has not changed**.
2015-01-30 16:01:13 +00:00
Jason Williams
5553f4f6fe Simplify url preview component, add test
No Issue
- Rework the preview URL component so its implementation is
  simpler.
- Add test for gh-url-preview component.
- ember-mocha@0.3.0.
- Remove unused jshint options.
2015-01-29 17:13:02 +00:00
Paul Adam Davis
e3edcff41b Update user image styles
Related to #4844

The newly added user image in the content list uses a CSS property to
crop `img` tags, but it's not supported in IE or Firefox. This issue
corrects that by chancing them to be background images which can be
cropped cross-browser.

It also adjusts the nav bar user image (previously an `img` tag) which
would squash a non-square image.

Also removes the border around the settings/users/ user images, to be
consistent with the rest of the UI.
2015-01-29 11:34:14 +00:00
Paul Adam Davis
c9f998099b Fix layout error when there's no user name
No issue

- Adds a clearfix to the user settings header to prevent a broken
layout when there's no name.
2015-01-28 16:43:55 +00:00
Jason Williams
97e70f22b0 Add new navigation item on enter key
No Issue
- Fix regression in add item on enter behavior.
2015-01-27 23:14:45 +00:00
Jason Williams
e4c67f1502 Set 'value' property before a dependent CP is used
No issue.
- Make sure value property has been set before computed
  property isRelative is referenced.
2015-01-27 22:23:10 +00:00
John O'Nolan
42b0f3ebed Merge pull request #4844 from PaulAdamDavis/content-list-style
Update content list styles
2015-01-27 13:03:24 -05:00
Hannah Wolfe
63fe50d997 Merge pull request #4842 from chilts/add-slash-to-tag-editor-tag-url
Make preview URLs include trailing slash when slug is given
2015-01-27 17:45:01 +00:00
Matt Enlow
77d28758be Merge pull request #4855 from jaswilli/serializer-cleanup
Update Ember-Data, remove unneeded code
2015-01-26 12:05:50 -07:00