- After some trying things out, just removed that now
- There should be no more bottom spacing apart from what's in the iFrame now
refs https://github.com/TryGhost/Team/issues/1747
- There were left over paddings that were present with old design
- Stripping back the paddings to have better placement in more themes without adjustment
refs https://github.com/TryGhost/Team/issues/1747
- This changes the behaviour of the Avatar component to show the icon properly
- This removes a parameter from the Avatar component
refs https://github.com/TryGhost/Team/issues/1746
- This replaces the A that showed which was a bit confusing
- Icon may still change but it feels better than what was there before
- Added new parameter for Avatar component for Blank and Anonymous
refs https://github.com/TryGhost/Team/issues/1746
- Removed only showing bio in modal, now showing both always
- Changed how the modal is called with parameters to focus on bio if clicked
refs https://github.com/TryGhost/Team/issues/1716
- This adds in the bio UI into the modal
- Adds in a simple button for bio under the name in textbox
- Still needs wiring up as it data doesn't save and update yet
refs https://github.com/TryGhost/Team/issues/1716
fixes https://github.com/TryGhost/Team/issues/1725
- ESC to close/blur forms
- CMD + ESC to submit forms
- C to focus and scroll to main comment form
- ESC to close any modals (context menus or dialogs)
- keydown events are passed down from iframes to the main window to prevent having to listen on all iframes + window every time we need these events.
fixes https://github.com/TryGhost/Team/issues/1729
refs https://github.com/TryGhost/Team/issues/1730
Please note that it only works on initial page load for now. Browsers have custom implementations for handling URL hashes/fragments that mess with the scroll position if you reload a page.
We need a special JS based handling of the URL fragment/hash because:
- We should only scroll after the comments have loaded, else we risk landing on a higher position on the page due to content height changes.
- The DIV we scroll to (#ghost-comments-root) is inserted via JS, making it more difficult to scroll to it without JS.
- We cannot wrap the `<script>` tag that loads the comments with a different DIV that has an id where we can scroll to. This would break themes and would make it harder to work with existing CSS grids (tried this first). And we still have the first issue too if we use this.
refs https://github.com/TryGhost/Team/issues/1695
We should allow for an empty string to be passed in as the title,
which means a boolean coercion check is not appropriate, we should
check for null which in this case means to use the default title
no issue
- typography and spacing was a bit off in the signup / upgrade CTA boxes
- the line style was inconsistent with the rest of the comments design
- button sizes and spacings needed also a bit of refinement
no issue
- applied typography changes to bio and date line as they were too strong
- padding and positioning of the comment input form was a bit misaligned
- Before it was static, with an X, but now using the variable available
- Do note, this doesn't seem to be showing the right number
refs https://github.com/TryGhost/Team/issues/1695
