Commit Graph

10203 Commits

Author SHA1 Message Date
Kevin Ansfield
a523fedccb Fixed errors thrown from blank twitter/facebook URL fields
no issue

- reset logic was incorrect meaning that if you focused a twitter/facebook URL field then moved to a different field without inputting anything an error would be thrown from trying to use `.match()` on `null`
2022-10-04 10:09:36 +01:00
Sanne de Vries
0124c2f28a Updated member activity page with new breadcrumb styles
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Filtering on specific member activity now uses new breadcrumb pattern
- Fixed double scrollbar issue on member activity and history page
2022-10-04 13:51:01 +07:00
Sanne de Vries
2c498ab193 Updated breadcrumb and title style across admin
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Separating out the breadcrumbs and the title makes it easier to navigate back on multiple levels for nested pages.
- Avoids very long titles, as it doesn't include breadcrumbs anymore
2022-10-04 12:35:29 +07:00
Rishabh
09fbe19a31 Fixed anchor chart load for site without paid tiers
refs https://github.com/TryGhost/Team/issues/2019

- the anchor chart keeps showing the loading spinner for a site that has no paid tiers and the source attribution flag switched on.
- this was because it tries to load the the MRR chart by default, which doesn't has any data when paid tiers are disabled.
- updated the chart to use `total members` data when paid tiers is disabled
2022-10-04 10:34:44 +05:30
Ronald Langeveld
226794e201
🐛 Fixed broken close buttons on modals (#15514)
* 🐛 Fixed broken `close` button on modals
no issue

Some modals' close elements containing `{{on "click" @close}}` and `href=""` would not take the 'on cl
ick' function into account, meaning the whole page would get redirected to "/" (back to the root of the dashboard) instead of just closing the modal.
2022-10-04 06:33:49 +04:00
renovate[bot]
8751245fa5 Update sentry-javascript monorepo to v7.14.1 2022-10-04 08:07:37 +07:00
Kevin Ansfield
cd9a50841e Fixed tests
refs 85cce39af7

- removed out of date transfer owner modal integration test
- fixed missing `?` in optional chaining in `<GhImageUploader>` error handling
2022-10-03 22:05:02 +01:00
Kevin Ansfield
bdc5984cdc Fixed linter error
refs 85cce39af7
2022-10-03 21:20:37 +01:00
Kevin Ansfield
85cce39af7 Refactored staff user modals
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
- cleaned up the `upload-image` modal which had multiple areas of code that were no longer being used
- disabled `no-duplicate-landmark-elements` template lint rule as it's buggy and mostly gives false positives
2022-10-03 21:15:34 +01:00
Kevin Ansfield
74d66ca9be Renamed incorrect test selectors on limit modals
no issue

- selectors hadn't been updated when copy/pasting modal contents
2022-10-03 21:15:34 +01:00
Stephen Sauceda
eb585f9c02
🐛 Fixed active state bug in sidebar nav (#15511)
closes: https://github.com/TryGhost/Ghost/issues/15506

- The sidebar items that don't open the editor were missing some relative current-when attributes so the nested views weren't considered "active".
2022-10-03 19:49:21 +01:00
Djordje Vlaisavljevic
02369ee852 Switched the dash character
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 17:29:07 +02:00
Kevin Ansfield
353cad7ed2 Fixed mirage members route permissions checks
refs 568e4183e3
refs 258f56ded9

- when in test environment add a `X-Test-User` header to API requests that allows the mirage endpoints to check the logged in user without having to cross boundaries into the application or test contexts
2022-10-03 14:59:16 +01:00
Rishabh
01249926d5 Refined attribution data on member details page
refs https://github.com/TryGhost/Team/issues/1986

- hides referrer source on member details page if its `Created manually` as its not useful
2022-10-03 18:58:48 +05:30
Djordje Vlaisavljevic
c48df76d9b Updated formatting of the signup info
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 14:25:32 +02:00
Djordje Vlaisavljevic
f351064726 Commented out the Learn more link
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 14:20:03 +02:00
Kevin Ansfield
568e4183e3 Disabled mirage member routes permission checks
refs 258f56ded9

- `@ember/test-helpers` is not included outside of test builds but we load mirage in development too so this was causing import errors that completely broke the app in development
- commented out the checks for now to get development working again whilst we look for alternatives to `getContext()`
2022-10-03 13:13:37 +01:00
Kevin Ansfield
258f56ded9
Added regression test for publishing as editor when over member limit (#15518)
closes https://github.com/TryGhost/Team/issues/2010
refs a67cb265fc

- wrapped all members endpoints in a permission check that returns a 403 response if the logged in member is not an admin
- added a publish-flow acceptance test that goes through the flow as an Editor user that fails if the stats endpoint is hit and throws a permissions error
- removed some unnecessary waits in members acceptance test that were added for earlier versions of Ember
2022-10-03 12:05:58 +01:00
Kevin Ansfield
485b793ee3 Deleted test for component that doesn't exist
no issue

- looks like the test file was left over from development
2022-10-03 11:26:00 +01:00
Djordje Vlaisavljevic
7fea370faf Fixed all sources modal gradient in dark mode
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 12:24:54 +02:00
Djordje Vlaisavljevic
ee40c92758 Updated cursor for disabled dropdown
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 11:42:50 +02:00
Rishabh
e57502e02f Handled empty attribution section on member detail page
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if there is no source and page/post attribution
2022-10-03 14:58:14 +05:30
Rishabh
6dc5f7ebb0 Added empty state mock option for attribution data
- allows mimicking empty state on dashboard for attribution data
2022-10-03 14:56:37 +05:30
Daniel Lockyer
44f6840a26
Merged v5.17.1 into main
v5.17.1
2022-10-03 15:42:30 +07:00
Ghost CI
f1dad0519c v5.17.1 2022-10-03 09:41:39 +01:00
Peter Zimon
349ef4926c Update engagement copy in Post Analytics
closes https://github.com/TryGhost/Team/issues/2016

- the absolute value and percentage for Opened and Clicked metrics in the engagement section of the post analytics page were inconsistent
2022-10-03 08:42:19 +02:00
Ghost CI
a7556ad9ea v5.17.0 2022-09-30 16:00:36 +01:00
Rishabh
30efab8401 Fixed lint 2022-09-30 09:38:15 +05:30
Rishabh
579ca615f9 Refined member attribution wording 2022-09-30 01:27:26 +05:30
Djordje Vlaisavljevic
198e43daec Updated disabled state
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 20:49:53 +02:00
Djordje Vlaisavljevic
fb2f0b3d3b Updated the all sources modal grid
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 20:33:00 +02:00
Rishabh
fa2292806a Refined all sources list on dashboard
refs https://github.com/orgs/TryGhost/projects/77

- shows single selected column on the all referrer sources list in dashboard
2022-09-29 23:47:43 +05:30
Rishabh
5eae093b3c Cleaned up attribution widget on analytics page
- updates attribution widget on analytics page to work same as dashboard with data
2022-09-29 23:33:17 +05:30
Djordje Vlaisavljevic
40c66dae6a Made the attribution widget show if you don't have paid tiers
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 19:37:09 +02:00
James Morris
8a6f082b14 Moving opened stats in row over if there are no clickes in post rows
- When there are no clicks, we are moving over the opened stats in it's place
- There shouldn't be too many times these mix so design should be ok

refs https://github.com/TryGhost/Team/issues/2000
2022-09-29 18:01:01 +01:00
James Morris
fd977479ee Tweaked up the analytics resources sections
refs https://github.com/TryGhost/Team/issues/1987
2022-09-29 17:38:50 +01:00
Simon Backx
648811690a Added email click tracking
no issue

Bumped flag to GA.
2022-09-29 18:14:15 +02:00
Simon Backx
58cabc68ec Fixed analytics button not working
no issue
2022-09-29 17:43:06 +02:00
James Morris
c44e7d1536 Improving the newsletter clicks table in post analytics
refs https://github.com/TryGhost/Team/issues/1984
2022-09-29 16:15:27 +01:00
Djordje Vlaisavljevic
aea7820487 Renamed files
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 16:45:56 +02:00
Simon Backx
0cd0fc838d
Added email track clicks column and cleaned up frontend checks (#15501)
fixes https://github.com/TryGhost/Team/issues/2008

- New column that stores email click tracking at the time it was created
- Improved frontend side checks for when to show analytics
2022-09-29 16:42:45 +02:00
Djordje Vlaisavljevic
22a75ba144 Updated dashboard mocks
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 16:23:50 +02:00
Djordje Vlaisavljevic
d2d34b1418 Updated all sources modal width
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 16:23:01 +02:00
Djordje Vlaisavljevic
d811bd512f Fixed modal footer
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 16:20:21 +02:00
Djordje Vlaisavljevic
9fa48613de Updated hover state for the anchor dropdown
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 16:14:58 +02:00
James Morris
9e51ba0c31 Removed the button labels from the post rows
refs https://github.com/TryGhost/Team/issues/1965
2022-09-29 15:07:37 +01:00
Djordje Vlaisavljevic
3fe51c8e9a Set max height for All sources modal
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 15:59:12 +02:00
James Morris
a9308e6394 Adding in new code to bring source attribution more in line
refs https://github.com/TryGhost/Team/issues/2001
2022-09-29 14:52:36 +01:00
Simon Backx
1a5ff8d53d
Added back button from editor to analytics (#15493)
fixes https://github.com/TryGhost/Team/issues/1992

When you edit a post via the editor, the back button on the top of the editor should go back to the analytics page and the status at the top should be removed.
2022-09-29 14:34:01 +02:00
Simon Backx
0c20950512 Cleaned up indentation in links-table.hbs 2022-09-29 13:05:55 +02:00