TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 21:40:39 +03:00
Code Issues Projects Releases Wiki Activity
610 Commits 237 Branches 1,680 Tags 386 MiB
a61bf71a16
Commit Graph

608 Commits

Author SHA1 Message Date
Naz
a61bf71a16 Added missing "should" imports 
no issue
 2021-10-26 15:50:43 +04:00
Naz
f6fbfe712a Added custom formatter to uploads limit 
refs https://linear.app/tryghost/issue/CORE-121/create-a-video-storage-adapter

 - Provides readable bytes -> megabytes conversion for filesize limit
 2021-10-26 15:49:59 +04:00
Naz
4172f993d4 Added custom formatter functionality to MaxLimit 
refs https://linear.app/tryghost/issue/CORE-121/create-a-video-storage-adapter

 - Some variables (like file size) would be hard to comprehend with the default formatting. Instead allowed MaxLimit to be configured with a custom formatter
 2021-10-26 15:49:26 +04:00
Naz
945e7ab520 Added "uploads" limit type 
refs https://linear.app/tryghost/issue/CORE-121/create-a-video-storage-adapter

 - The limit is here to accomodate file size checks
 - An example configuration is in the README
 2021-10-26 15:46:36 +04:00
Naz
91a2e54484 Added ability to pass in "currentCount" for limited resource 
refs https://linear.app/tryghost/issue/CORE-121/create-a-video-storage-adapter

- When checking limits for a nondb-resource type (like file size) there is no way to "currentCountQuery", so the value has to be passed in directly into the limit to evaluate against configured "max" limit
 2021-10-26 15:42:10 +04:00
Naz
9c695a363c Improved JSDocs in limit package 
no issue

- There were a few errors and little inconsistencies that needed a cleanup
 2021-10-26 11:23:42 +04:00
Naz
aef6c19933 Fixed uses ov currentCountQuery 
no issue

- The currentCountQuery method takes in  no parameters!
 2021-10-26 11:15:15 +04:00
Naz
d6d88d4f70 Improved JSDocs in limit package 
no issue

- There were a few errors and little inconsistencies that needed a cleanup
 2021-10-26 11:11:59 +04:00
Naz
3c6bb95234 Fixed typos 2021-10-26 10:52:09 +04:00
Naz
10e9c30b15 Added JSDoc with types to the Limit base constructor 
no issue

- Improved type checking a little
 2021-10-26 10:51:25 +04:00
Naz
bd4204dbc5 Fixed returned value type 
no issue

- The return type was incorrectly declared thworing error during type checking
 2021-10-26 10:48:27 +04:00
Naz
c8d840c211 Improved test coverage for limit-service module 
no issue

- The aim is to achieve 100% unit test coverage for servies and small modules. This change covers few more bases brining limit-service's module coverage from 80% to 94%.
 2021-10-25 18:18:04 +04:00
Naz
8520c8a746 Published new versions 
- @tryghost/adapter-manager@0.2.18
 - @tryghost/bootstrap-socket@0.2.13
 - @tryghost/config-url-helpers@0.1.3
 - @tryghost/constants@0.1.12
 - @tryghost/errors@0.2.17
 - @tryghost/image-transform@1.0.17
 - @tryghost/job-manager@0.8.11
 - @tryghost/limit-service@0.6.5
 - @tryghost/moleculer-service-from-class@0.2.21
 - @tryghost/mw-session-from-token@0.1.26
 - @tryghost/package-json@1.0.6
 - @tryghost/pretty-cli@1.2.22
 - @tryghost/promise@0.1.13
 - @tryghost/release-utils@0.7.1
 - @tryghost/security@0.2.13
 - @tryghost/session-service@0.1.28
 - @tryghost/settings-path-manager@0.1.2
 - @tryghost/vhost-middleware@1.0.19
 - @tryghost/zip@1.1.18
 2021-10-22 16:01:20 +04:00
Naz
a986da8aa8 Added images and media prefixes 
refs https://linear.app/tryghost/issue/CORE-121/create-a-video-storage-adapter

- These paths are a bit painful to discover in URL utils and don't really have to live there. They should be used instead of the onse in @tryghost/url-utils
- the STATIC_IMAGES_URL_PREFIX comes form ef9ab5bd9e/packages/url-utils/lib/index.js (L37)
- the STATIC_MEDIA_URL_PREFIX is a new concept introduced for experimental "video" file support
 2021-10-22 15:59:10 +04:00
Daniel Lockyer
81f566b44a Added codecov.io coverage uploader to CI 
refs linear.app/tryghost/issue/CORE-74/improve-the-test-situation

- this commit adds the codecov GitHub Action into CI so we can upload
  coverage reports
- the coverage files need to be in XML for them to work with
  codecov, so this commit also adds cobertura (XML) as a reporter
 2021-10-20 11:56:20 +02:00
Renovate Bot
ebe62e27c1 Update dependency mocha to v9.1.3 2021-10-15 08:26:58 +00:00
Renovate Bot
dee321eebc Update dependency c8 to v7.10.0 2021-10-06 23:39:01 +00:00
Renovate Bot
5ac4596a30 Update dependency date-fns to v2.25.0 2021-10-05 09:01:07 +00:00
Daniel Lockyer
fd94548b1e Published new versions 
- @tryghost/adapter-manager@0.2.17
 - @tryghost/bootstrap-socket@0.2.12
 - @tryghost/constants@0.1.11
 - @tryghost/errors@0.2.16
 - @tryghost/image-transform@1.0.16
 - @tryghost/job-manager@0.8.10
 - @tryghost/limit-service@0.6.4
 - @tryghost/moleculer-service-from-class@0.2.20
 - @tryghost/mw-session-from-token@0.1.25
 - @tryghost/package-json@1.0.5
 - @tryghost/pretty-cli@1.2.21
 - @tryghost/promise@0.1.12
 - @tryghost/release-utils@0.7.0
 - @tryghost/security@0.2.12
 - @tryghost/session-service@0.1.27
 - @tryghost/vhost-middleware@1.0.18
 - @tryghost/zip@1.1.17
 2021-10-01 16:57:18 +01:00
Daniel Lockyer
e1887f2df4 Exposed getFinalChangelog helper 
no issue

- this is needed so I can generate the release changelog for the Slack
  notifications in action-ghost-release
 2021-10-01 16:53:40 +01:00
Daniel Lockyer
d1c58466b5 Updated repository links 
no issue

- this repo changes from `master` to `main` a while back, but the
  repository links needed updating too
 2021-10-01 14:34:06 +01:00
Daniel Lockyer
669ef01d1b Moved @tryghost/tpl to Framework repo 
refs 3cc8da4a7c

- the package has been moved into the framework repo in the referenced
  commit, so the files can be deleted here
 2021-10-01 14:28:07 +01:00
Naz
20aad599fd Published new versions 
- @tryghost/settings-path-manager@0.1.1
 2021-09-30 20:15:02 +02:00
Naz
98f4f90b19 Added getBackupFilePath to settings-path-manager module 
refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings

- getBackupFilePath is yet another utility function tha's used often with Ghost config files like so:
- ca149f2c0e/core/server/services/redirects/settings.js (L147-L151)
- ca149f2c0e/core/server/services/route-settings/route-settings.js (L42-L45)
 2021-09-30 20:14:21 +02:00
Naz
8f4c4f66b5 Published new versions 
- @tryghost/adapter-manager@0.2.16
 - @tryghost/bootstrap-socket@0.2.11
 - @tryghost/config-url-helpers@0.1.2
 - @tryghost/constants@0.1.10
 - @tryghost/errors@0.2.15
 - @tryghost/image-transform@1.0.15
 - @tryghost/job-manager@0.8.9
 - @tryghost/limit-service@0.6.3
 - @tryghost/moleculer-service-from-class@0.2.19
 - @tryghost/mw-session-from-token@0.1.24
 - @tryghost/package-json@1.0.4
 - @tryghost/pretty-cli@1.2.20
 - @tryghost/promise@0.1.11
 - @tryghost/release-utils@0.6.17
 - @tryghost/security@0.2.11
 - @tryghost/session-service@0.1.26
 - @tryghost/settings-path-manager@0.1.0
 - @tryghost/tpl@0.1.5
 - @tryghost/vhost-middleware@1.0.17
 - @tryghost/zip@1.1.16
 2021-09-30 19:23:46 +02:00
Naz
a2a2a7c7be Added settings-path-manager module 
refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings

- The module is a tiny path resolver for settings used in Ghost. A first obvious place it's used is for routes.yaml settings files. With a little bit of tweaking it should also be adopted by redirects services
 2021-09-30 19:22:09 +02:00
Hannah Wolfe
c886738bbc Added README.md and one extra test 
- Try to make sure it's clear how to make interpolation work when working with handlebars helpers
 2021-09-30 16:17:56 +01:00
Renovate Bot
c9b4504bab Update dependency @sinonjs/fake-timers to v8.0.1 2021-09-27 14:36:36 +00:00
Renovate Bot
81bb6465fb Update dependency mocha to v9.1.2 2021-09-27 01:04:25 +00:00
Renovate Bot
4a1da452e9 Update Test & linting packages 2021-09-22 14:29:23 +00:00
Naz
b428648665 Published new versions 
- @tryghost/adapter-manager@0.2.15
 - @tryghost/bootstrap-socket@0.2.10
 - @tryghost/config-url-helpers@0.1.1
 - @tryghost/constants@0.1.9
 - @tryghost/errors@0.2.14
 - @tryghost/image-transform@1.0.14
 - @tryghost/job-manager@0.8.8
 - @tryghost/limit-service@0.6.2
 - @tryghost/moleculer-service-from-class@0.2.18
 - @tryghost/mw-session-from-token@0.1.23
 - @tryghost/package-json@1.0.3
 - @tryghost/pretty-cli@1.2.19
 - @tryghost/promise@0.1.10
 - @tryghost/release-utils@0.6.16
 - @tryghost/security@0.2.10
 - @tryghost/session-service@0.1.25
 - @tryghost/tpl@0.1.4
 - @tryghost/vhost-middleware@1.0.16
 - @tryghost/zip@1.1.15
 2021-09-22 11:59:35 +02:00
Naz
ceb2b7e5ea Moved error messages to "messages" hash 
refs https://linear.app/tryghost/issue/CORE-49/fix-errors-in-utils-repo-limit-service

- As I've touched these files did a little refactor and changed where the error messages are stored to keep it up with our lates coding standard - having "messages" hash defined in the module storing all messages that have pottential for i18y in the future.
 2021-09-22 11:57:49 +02:00
Naz
ee43133dd9 Fixed error initialization syntax 
refs https://linear.app/tryghost/issue/CORE-9/remove-eslint-warnings

- Used an incorrect string parameter constructor for ghost errors previously. The errors should be initialized with an object containing a "message" property
 2021-09-22 11:51:37 +02:00
Naz
4b70c7e0c0 Removed use of native JS Error objects 
closes https://linear.app/tryghost/issue/CORE-55/fix-errors-in-utils-repo-job-manager

- The latest ESLint rules forbid use of native JS errors, updated the codebase before bumping the ESLint version
 2021-09-22 11:50:21 +02:00
Naz
be6c8ea390 Removed use of native JS Error objects 
closes https://linear.app/tryghost/issue/CORE-54/fix-errors-in-utils-repo-release-utils

- The latest ESLint rules forbid use of native JS errors, updated the codebase before bumping the ESLint version
 2021-09-22 11:49:02 +02:00
Naz
2b82d2afce Removed use of native JS Error objects 
refs https://linear.app/tryghost/issue/CORE-49/fix-errors-in-utils-repo-limit-service

- The latest ESLint rules forbid use of native JS errors, updated the codebase before bumping the ESLint version
 2021-09-22 11:32:02 +02:00
Renovate Bot
a28a2a23a5 Update dependency date-fns to v2.24.0 2021-09-17 07:39:17 +00:00
Renovate Bot
ced3a5251c Update dependency @sinonjs/fake-timers to v8 2021-09-15 11:49:45 +00:00
Renovate Bot
ff5ee78825 Update dependency c8 to v7.9.0 2021-09-10 04:03:35 +00:00
Renovate Bot
65760e061e Update dependency sharp to ^0.29.0 2021-08-23 09:13:58 +02:00
Renovate Bot
daab0d1f5d Update dependency supertest to v6.1.6 2021-08-17 22:28:32 +00:00
Renovate Bot
92a531cb9c Update dependency supertest to v6.1.5 2021-08-11 17:38:29 +00:00
Renovate Bot
2b7e2676eb Update dependency c8 to v7.8.0 2021-07-28 17:56:14 +00:00
Renovate Bot
798f7d1421 Update dependency date-fns to v2.23.0 2021-07-23 07:26:46 +00:00
Renovate Bot
0ad9fcf8dd Update dependency supertest to v6.1.4 2021-07-21 05:00:25 +00:00
Daniel Lockyer
1d6b8c1875 Stopped type declaration files from being generated 
refs https://github.com/TryGhost/Team/issues/870

- currently, a handful of packages in this repo generate type
  declarations when building
- we're aiming to go more in the direction of better inline jsdoc, and
  we want to clean up all generated files and use of external types
- this commit removes the `typescript` dependency, removes the pretest
  commands that run the builds, and cleans up anywhere where we
  configure types
 2021-07-14 11:51:14 +01:00
Daniel Lockyer
f918398779 Added c8 test coverage to all packages 
refs https://github.com/TryGhost/Team/issues/870

- using `c8` allows us to see test coverage for all packages in the repo
- this commit adds `c8` as a dev dependency and prepends the `mocha`
  command with `c8` so it runs on all tests
 2021-07-14 11:26:06 +01:00
Renovate Bot
9979768591 Update dependency @types/mocha to v8.2.3 2021-07-07 01:36:51 +00:00
Renovate Bot
950689fb35 Update dependency @types/express to v4.17.13 2021-07-06 21:26:50 +00:00
Renovate Bot
b56dc030ea Update dependency typescript to v4.3.5 2021-07-01 01:11:31 +00:00