Commit Graph

6305 Commits

Author SHA1 Message Date
Kevin Ansfield
a3b2f2072a 🐛 Fixed clipped tooltips in member activity feed after showing all
no issue

- liquid-fire containers (inserted by `{{#liquid-if}}`) have `overflow: hidden` applied which means the absolutely positioned tooltips that leave the container are clipped or in some cases not visible at all
- adding `class="show-overflow"` to `{{#liquid-if}}` adds the class to the top-level `.liquid-container` element allowing us to alter the behaviour slightly in CSS by making use of the `.liquid-animating` class that is added whilst the animation is in progress. By only applying `overflow: hidden` whilst animating we can keep the reveal whilst eliminating the clipping when the animation finishes
  - does not work in all cases and can introduce jankiness in others where the visible overflow causes positioning changes
2020-12-11 11:04:18 +00:00
Sanne de Vries
77e24d4d25 Fixed test failure for post time format 2020-12-11 10:03:29 +01:00
Sanne de Vries
20d0ef2fe7 Changed tooltip on hovering schedule state in post list from uppercase to capitalised 2020-12-11 09:49:07 +01:00
Sanne de Vries
c53363586c Fixed date alignment in activity feed on mobile 2020-12-11 09:41:10 +01:00
Daniel Lockyer
2b6158a822 v3.40.0 2020-12-10 15:49:34 +00:00
Kevin Ansfield
ca956981c3 Fixed open rate appearing twice in posts ordering dropdown
no issue

- sometimes the controller's init method can be triggered twice so a guard was added to ensure we're not re-adding the same option
2020-12-10 15:14:13 +00:00
Sanne de Vries
e4c4237365 Fixed overflow issue for ID and email in member Stripe info 2020-12-10 15:33:12 +01:00
Sanne de Vries
57dc3ca115 Changed icon color for received emails in member feed 2020-12-10 15:06:45 +01:00
Kevin Ansfield
c84282d5da Added member activity feed icon color classes
no issue

- use green for normal activities and red for failed/undesireable activities
2020-12-10 14:01:11 +00:00
Renovate Bot
6475260522 Update dependency @tryghost/helpers to v1.1.35 2020-12-10 11:59:02 +00:00
Renovate Bot
b2ff80e334 Update dependency @tryghost/timezone-data to v0.2.33 2020-12-10 11:58:39 +00:00
Sanne de Vries
2453f6afbd Added activity feed to member details screen (#1796)
closes https://github.com/TryGhost/Ghost/issues/12461

Design changes:
- added activity feed to member details page
- rearranged Stripe info to display on the right
- added toggle buttons for Stripe subscription and customer info
- added box to display activity feed for received and opened emails

Functionality changes:
- added `queryRecord()` to member adapter so `queryRecord('member', {id: x})` will hit `/members/:id/?query` instead of `/members/?id=x&query`
- updated member route to query member with `?include=email_recipients`
- added `EmailRecipient` model for access to event timestamps and email relationship setup
- added `<GhMemberActivityFeed>` component that accepts an `EmailRecipient` array and converts that into an activity list
- added support for `@model=emailInstance` to the email preview modal
- fixed a timing issue with email preview that could result in it showing blank content until the mobile/desktop toggle is used
- fixed sometimes blank member location

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-12-10 11:38:38 +00:00
Peter Zimon
be0ad730e0 Copy fix for member import errors
no refs.
- removed full stops from member import error messages
2020-12-10 12:15:07 +01:00
Rishabh Garg
69782e7aca Updated UI for empty member import (#1801)
no issue

- Disabled import button if mapping screen has 0 members to be imported
- Updated UI logic for no-member upload case
- Used bullet list for email summary
2020-12-10 16:33:56 +05:30
Kevin Ansfield
65129a0d9f Fixed missing email received/opened count when creating new member
no issue

- adds default value of 0 for `member.{email_count,opened_email_count}` to match server-side behaviour and allow consistency in the UI
2020-12-10 10:15:42 +00:00
Rish
23a71113ed Updated Lock file
no refs
2020-12-10 13:34:24 +05:30
Rishabh Garg
f068e40723 Added new members CSV importer (#1797)
no refs
depends on https://github.com/TryGhost/Ghost/pull/12472

The members CSV importer gets an overhaul and works with new importer module in members service, performing the import in a background job when the import will take too long to complete in a reasonable time and send an email with data on completion. Also includes updated CSV mapping UI and error handling to allow easier import from different type of exports.

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
Co-authored-by: Peter Zimon <zimo@ghost.org>
2020-12-10 01:02:31 +05:30
Sanne de Vries
4b51ae8705 Fixed responsive layout for members list 2020-12-09 19:10:12 +01:00
Sanne de Vries
3adcf2b5d8 Fixed font color bug for email on member details page 2020-12-09 17:23:25 +01:00
renovate[bot]
117a46c5e5 Update dependency autoprefixer to v10.1.0 (#1793)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-12-09 13:27:04 +00:00
renovate[bot]
54d79e5a14 Update dependency ember-concurrency-decorators to v2.0.2 (#1792)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-12-09 13:26:50 +00:00
renovate[bot]
a19dd9614f Update dependency ember-composable-helpers to v4.4.1 (#1791)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-12-09 13:26:37 +00:00
Sanne de Vries
ecfb77b980 Added email stats overview to member details page (#1795)
refs https://github.com/TryGhost/Ghost/issues/12461

- Added "Emails received", "Emails opened", and "Avg. open rate" to member details
- Adjusted visual display of avatar, name and email. Made email a mailto link
- Rearranged Name and Email fields to reduce height
- Changed height of the notes textarea

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-12-09 13:26:00 +00:00
Sanne de Vries
ffe0f84700 Added open-rate column and ordering to the members list (#1790)
closes https://github.com/TryGhost/Ghost/issues/12421

- added `emailOpenRate` property to member model
- added open-rate column to the members list
  - hidden when email analytics is disabled
- added `{{feature "flag"}}` helper so feature flags can be checked in templates without injecting the feature service into the backing class
- added `order` query param to the members controller/route and wired it into the data fetching routine
- added order dropdown to the filter bar with "Newest" (default) and "Open rate" as the two options
  - whole dropdown is hidden if email analytics is disabled

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-12-08 19:23:57 +00:00
Daniel Lockyer
a6ceeb634f Merged 3.39.3 into master
v3.39.3

* tag '3.39.3':
  v3.39.3
  🐛 Fixed email design settings not opening
2020-12-08 09:41:15 +00:00
Daniel Lockyer
16614d2aae v3.39.3 2020-12-08 09:37:00 +00:00
Rish
a48cb89e53 🐛 Fixed email design settings not opening
closes https://github.com/TryGhost/Ghost/issues/12459

- Email design settings don't open in some cases when footer html is set as null, specifically on import
- Patches html cleanup to use empty string in case of null footer value
2020-12-08 09:35:05 +00:00
Rish
439b877744 🐛 Fixed email design settings not opening
closes https://github.com/TryGhost/Ghost/issues/12459

- Email design settings don't open in some cases when footer html is set as null, specifically on import
- Patches html cleanup to use empty string in case of null footer value
2020-12-08 15:01:38 +05:30
Daniel Lockyer
47f3855d4d Merged 3.39.2 into master
v3.39.2

* tag '3.39.2':
  v3.39.2
2020-12-07 11:17:06 +00:00
Daniel Lockyer
31ccbe44e4 v3.39.2 2020-12-07 11:14:53 +00:00
Daniel Lockyer
a454bb5d99 Merged 3.39.1 into master
v3.39.1

* tag '3.39.1':
  v3.39.1
  Fixed email cards missing an edit icon in the toolbar
  Fixed copy for open-tracking settings
2020-12-07 09:22:09 +00:00
Daniel Lockyer
1fab8db87b v3.39.1 2020-12-07 09:20:05 +00:00
Kevin Ansfield
6b3cb59aff Fixed email cards missing an edit icon in the toolbar
no issue

- email cards a block cards so have a distinct edit mode, that type of card should always have an edit icon in the toolbar for consistency and ease of use when the double-click or cmd+enter shortcuts aren't known
2020-12-07 09:09:30 +00:00
Sanne de Vries
dbfe2f493a Fixed copy for open-tracking settings 2020-12-07 09:09:18 +00:00
Renovate Bot
c6f9bdf986 Update dependency eslint to v7.15.0 2020-12-07 00:06:47 +00:00
Kevin Ansfield
84aaa5224c Moved email open rate ordering behind analytics flag
refs https://github.com/TryGhost/Ghost/issues/12420

- email analytics can be disabled, when that's the case it doesn't make sense to allow posts to be sorted by open rate
2020-12-04 14:08:48 +00:00
Kevin Ansfield
439ba03053 Added open rate order option to posts list
closes https://github.com/TryGhost/Ghost/issues/12420

- adds "Open rate" to the available ordering options in the posts list order dropdown
- amends pages controller to have it's own order list because pages can't be ordered by open rate
2020-12-04 10:30:03 +00:00
renovate[bot]
817e327032 Lock file maintenance (#1787)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-12-04 09:03:35 +00:00
renovate[bot]
1fb9d12126 Update dependency ember-auto-import to v1.8.0 (#1789)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-12-04 08:42:12 +00:00
Kevin Ansfield
d5d0eafb47 Fixed email cards missing an edit icon in the toolbar
no issue

- email cards a block cards so have a distinct edit mode, that type of card should always have an edit icon in the toolbar for consistency and ease of use when the double-click or cmd+enter shortcuts aren't known
2020-12-03 10:26:28 +00:00
Sanne de Vries
70b34432c8 Fixed copy for open-tracking settings 2020-12-02 21:31:11 +01:00
Daniel Lockyer
af75bc320d v3.39.0 2020-12-02 15:11:32 +00:00
Peter Zimon
b616a839a9 Email settings preview refinements (#1788)
- fixed sizes for email preview area
- replaced static values with dynamic ones
- replaced radio button with font selector
- fixed footer textarea styles
- refined styles
- refined copy
2020-12-02 13:12:41 +01:00
Kevin Ansfield
ca97f84cad Added emailAnalytics feature flag
no issue

- email analytics feature has a potential to be resource-intensive so it may be switched off via config, when this is the case we don't want to show stats in the admin that are out of date or won't be added/updated
- fixed page link titles saying "Edit this post" instead of "Edit this page"
2020-12-02 11:47:34 +00:00
Kukhyeon Heo
8e219f35c9 🐛 Fixed infinite spinner when admin login attempt fails (#1755)
closes TryGhost/Ghost#12189

- This bug happened because authenticate function always returned success(true) even when it is failed.
2020-12-01 14:32:59 +00:00
Kevin Ansfield
c0da576e41 Lock file maintenance 2020-11-30 11:21:39 +00:00
renovate[bot]
bfc23a7505 Update dependency autoprefixer to v10.0.4 (#1785)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-11-30 11:16:18 +00:00
renovate[bot]
4e7d629f55 Update dependency ember-composable-helpers to v4.4.0 (#1786)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-11-30 11:15:57 +00:00
Sanne de Vries
8467bf025b Changed font styling for email stats in posts list 2020-11-30 10:14:27 +01:00
Sanne de Vries
a2a98b575f Added email open rate to posts list in admin (#1772)
no issue

- added "Sends" and "Opens" columns to the posts list to see newsletter performance at a glance
- "Sends" will show the type of members sent to (free, paid, all) as a tooltip
- "Opens" shows open rate by default and total opens on hover
2020-11-26 17:19:05 +00:00