Commit Graph

16563 Commits

Author SHA1 Message Date
Aileen Booker
8d290c4560
Milestone emails templates and sending implementation (#16318)
refs
https://www.notion.so/ghost/Marketing-Milestone-email-campaigns-1d2c9dee3cfa4029863edb16092ad5c4?pvs=4

- Added email template for milestones with using a configuration file
for different member milestone values, as we're sending different
content for each one
- Implement sending the email to users who have
`milestone-notifications` enabled, currently still behind a flag

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2023-03-21 13:39:40 +00:00
renovate[bot]
be96c9d5d0
Update dependency i18next to v22.4.13 2023-03-21 10:46:44 +00:00
Sanne de Vries
792bfdb498 Added UI for subscription box in newsletters
Refs https://github.com/TryGhost/Team/issues/2738

- Added preview to email newsletter settings
- Added subscription box UI to email template
2023-03-21 11:40:04 +01:00
Rishabh
b8d79a850b Updated email subject copy for new mentions
refs https://github.com/TryGhost/Team/issues/2754

Updates email copy to be more descriptive and also avoid stacking in inbox.
2023-03-21 16:09:21 +05:30
Rishabh
0b7e09c986 Updated fallback for storing source site title
refs https://github.com/TryGhost/Team/issues/2754

Previously, we didn't have any backup for storing source site title and it could have stored as empty if missing. This change ensures the source site title is stored as site host instead as fallback if not present.
2023-03-21 16:09:21 +05:30
Rishabh
61a206c9eb Updated copy for mentions on Admin staff settings
refs https://github.com/TryGhost/Team/issues/2754
2023-03-21 16:09:21 +05:30
Rishabh
63edac090b Fixed incorrect usage of mentions report timestamp
refs https://github.com/TryGhost/Team/issues/2754

The name of the setting used for storing last timestamp of mentions report is `last_mentions_report_email_timestamp`, but in the code we incorrectly camel-cased it which meant we were not reading from and writing to the correct setting, and ended up sending a mentions report every few hours every time the job ran.
2023-03-21 16:09:21 +05:30
Simon Backx
a016f53b7e Added resolveMx stub to all E2E tests
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1679391135060629
refs 1b0adcf4ab

The same issue when sending emails from E2E tests, where the tests timeout when resolving mx records for invalid domains.
2023-03-21 11:25:06 +01:00
Sodbileg Gansukh
9239fe497f Adjusted typography and spacing of the Stripe connect modal
refs https://github.com/TryGhost/Team/issues/2749
2023-03-21 17:48:37 +08:00
Simon Backx
db589b1ad4 Fixed random unit test failure for revue importer
refs https://github.com/TryGhost/Ghost/actions/runs/4477418718/jobs/7868921949

This test used the current time, and this resulted in a `AssertionError [ERR_ASSERTION]: '2023-03-21T09:28:29.837Z' == '2023-03-21T09:28:29.838Z'` in rare situations.
2023-03-21 10:46:13 +01:00
Simon Backx
0cc3164b25
Added export button to posts page with placeholder endpoint (#16456)
fixes https://github.com/TryGhost/Team/issues/2780 
refs https://github.com/TryGhost/Team/issues/2781

Adds an export button to the posts page in admin (behind feature flag). It downloads a
placeholder CSV via a real endpoint (`/posts/export`).
2023-03-21 10:24:56 +01:00
Daniel Lockyer
2096773310
Added missing @tryghost/posts-service dependency
- this is needed so we can link between packages in the monorepo when
  the packages are bundled
2023-03-21 08:24:25 +01:00
renovate[bot]
48e486509c Update dependency vite to v4.2.1 2023-03-21 07:36:34 +01:00
renovate[bot]
41e956fd55 Update vitest monorepo to v0.29.7 2023-03-21 07:36:13 +01:00
renovate[bot]
1f2df81ed1 Update sentry-javascript monorepo to v7.44.1 2023-03-21 07:35:45 +01:00
renovate[bot]
e1fa8560d5 Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
Simon Backx
a5dff4207e Moved posts service to its own package
fixes https://github.com/TryGhost/Team/issues/2778

It is easier to add extra classes using the latest patterns if it has its own package.
2023-03-20 16:06:42 +01:00
Elena Baidakova
aca8c5805c Improved members-actions e2e browser test
refs TryGhost/Team#2667
- Added notification check before checking that user successfully unsubscribed from all newsletters. It helps to make the test more stable
2023-03-20 18:48:35 +04:00
Simon Backx
07ec33fb3a
Added latest posts to email template (#16448)
refs https://github.com/TryGhost/Team/issues/2769

Needs some extra styling and design, this is only a minimal version
behind the feature flag.
2023-03-20 14:30:42 +01:00
Simon Backx
6d8388c5bb Fixed migration version for show latest posts
no issue

The migration was added to 5.39, but this was not correct. It should have been added to 5.40. This commit fixes moves the migration to the right folder. Running the migration twice locally will skip it because it detects the table is already correct.
2023-03-20 14:18:30 +01:00
Simon Backx
f2860e745c Added placeholder latest posts to newsletter preview
refs https://github.com/TryGhost/Team/issues/2768

Added a placeholder to be replaced with some better design and styling.
2023-03-20 11:30:16 +01:00
Simon Backx
f38d799ae2 Wired up showLatestPosts in admin
fixes https://github.com/TryGhost/Team/issues/2766

Edit showLatestPosts column via admin.
2023-03-20 11:26:19 +01:00
Simon Backx
a513542b56
Added show_latest_posts column to newsletter table (#16402) 2023-03-20 11:10:49 +01:00
Sodbileg Gansukh
4aef61ce66 Fixed member list loading UI spacing
refs https://github.com/TryGhost/Team/issues/2743
2023-03-20 13:55:51 +08:00
renovate[bot]
827d2abf55 Update dependency @testing-library/react to v12.1.5 2023-03-17 23:38:13 +00:00
Sanne de Vries
1b0adcf4ab Fixed missing stub for DNS in GhostMailer Direct tests
- without this, Node will try and resolve the domain name but local DNS
  resolvers can take a while to timeout, which causes the tests to timeout
- `nodemailer-direct-transport` calls `dns.resolveMx`, so if we stub that
  function and return an empty array, we can avoid any real DNS lookups
2023-03-17 18:16:30 +01:00
Simon Backx
a6654b5e6c Updated GhostMailer Direct unit tests to async await style
no issue

Tests were timing out for some users, probably because not all errors are caught.
2023-03-17 17:34:01 +01:00
Ghost CI
7f1f6a7249 v5.39.0 2023-03-17 16:00:48 +00:00
Steve Larson
0a4d568f19 updated snapshot
no refs
-updated snapshot to pass tests
2023-03-17 10:57:50 -05:00
Peter Zimon
9d25c2a058 Fixed mobile size footer buttons in newsletters
refs. https://github.com/TryGhost/Team/issues/2740

- alignment of buttons in the footer of newsletter email template was off
2023-03-17 16:34:23 +01:00
Steve Larson
067b35de6b fixed member newsletter test
no refs
-fixed flaky test that seemed to have sync issues with fixture data and db
2023-03-17 10:27:09 -05:00
Rishabh
3d68cd4544 Fixed incorrect newsletter ref for internal links
refs TryGhost/Team#2755

Previous change for outbound tagging had incorrectly changed the internal links ref for newsletter to include domain. This change fixes it back to use newsletter name for internal links.
2023-03-17 20:55:52 +05:30
Simon Backx
92fc5bdf70 Fixed email service unit tests for duplicate email buttons 2023-03-17 16:09:50 +01:00
Simon Backx
b3c410a923 Reverted stats snapshot change 2023-03-17 16:06:00 +01:00
Simon Backx
c591f1f86a Updated email batch sending snapshots 2023-03-17 16:00:14 +01:00
Sanne de Vries
48a3159d3d Added mobile feedback buttons to email template
Refs https://github.com/TryGhost/Team/issues/2740
2023-03-17 15:58:14 +01:00
renovate[bot]
b7a7a54b43 Update dependency react-error-overlay to v6.0.11 2023-03-17 15:21:26 +01:00
Daniel Lockyer
b7a03ca765 🐛 Fixed mainEntityOfPage property within page metadata
fixes https://github.com/TryGhost/Ghost/issues/16367
refs https://github.com/schemaorg/schemaorg/discussions/3274

- after a discussion with the schemaorg maintainers, it looks like
  `mainEntityOfPage` should refer to the entity itself vs the parent
  entity
- this commit updates the code to use the entity URL and fixes the
  associated tests
2023-03-17 15:13:28 +01:00
Simon Backx
f67b38daf4 Fixed posts and email wrappers in worker threads
refs https://ghost.slack.com/archives/C02G9E68C/p1679055933852679

- The posts api is used in the update-check job. This also uses the email wrapper, which needs the email-service
- The email service is not initalized in the worker threads, this causes an error
- Adds a check, because this part is optional in worker threads
2023-03-17 14:10:33 +01:00
Simon Backx
9bdffdf89d Fixed body style dropdown overflow issue
no issue

When opening the 'body style' dropdown in the newsletter settings, the dropdown was not completely visible. The next 'liquid' tab covered the dropdown. This makes some adjustments to the overflow of the liquid containers and z-index of the buttons and containers to fix that.

It also removes overflow-y: auto from one of the containers because it cropped the shadow if the dropdown, while that container could never scroll (parent is scrollable).
2023-03-17 12:00:24 +01:00
Daniel Lockyer
3302f4125e
Added support to yarn dev for --search to launch Sodo-Search
refs https://github.com/TryGhost/Toolbox/issues/400

- this makes development more fluid by allowing developers to use the
  local Sodo-Search code
2023-03-17 11:51:42 +01:00
renovate[bot]
680e3bf270 Update sentry-javascript monorepo to v7.43.0 2023-03-17 11:40:12 +01:00
Daniel Lockyer
945bae34cc
Updated Sodo-Search dependencies
- these were the easy ones to bump, the rest require bigger changes or
  more investigation
2023-03-17 11:30:02 +01:00
Daniel Lockyer
d1392e3b8a
Deleted superfluous .editorconfig file
- this is not needed as we have one at the top-level
2023-03-17 11:30:02 +01:00
Daniel Lockyer
73c1438561
Updated Sodo-Search package.json
refs https://github.com/TryGhost/Toolbox/issues/400

- this brings it inline with Portal's, which is a similar project
2023-03-17 11:30:02 +01:00
Sanne de Vries
0d8d5a8119 Updated typography in email design preview
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-17 11:19:30 +01:00
Simon Backx
005b5f20fb Added E2E tests for comment CTA
fixes https://github.com/TryGhost/Team/issues/2727

Adds some E2E tests and snapshots for comment CTA in all possible situations.
2023-03-17 11:12:47 +01:00
Daniel Lockyer
ddc6d60927
Added missing yarn test:unit command to Sodo-Search
refs https://github.com/TryGhost/Toolbox/issues/400

- this is needed for CI tests
2023-03-17 10:48:25 +01:00
Daniel Lockyer
a18da88073
Added .yarnrc config to Sodo-Search
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows the git tag and commit to be correctly formed for new
  Sodo-Search releases
2023-03-17 10:41:47 +01:00
Daniel Lockyer
2c72f3c97b
Merged Sodo-Search gitignore with top-level one
refs https://github.com/TryGhost/Toolbox/issues/400

- we don't need multiple gitignores because it can produce weird
  behaviour with some tools
2023-03-17 10:34:21 +01:00
Daniel Lockyer
94201281e3
Updated lockfile 2023-03-17 10:32:28 +01:00
Daniel Lockyer
9cc202aae3
Imported code and history from Sodo-Search
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for a better dev experience by having the code in the
  monorepo
2023-03-17 10:31:20 +01:00
Simon Backx
6058b2db22 Removed ghost comments link test
no issue

Accidentally left when committing.
2023-03-17 10:28:47 +01:00
Simon Backx
298e3da745 Fixed comment CTA button link
refs https://github.com/TryGhost/Team/issues/2672

- Use #ghost-comments instead of #ghost-comments-root
- Fixed snapshots
2023-03-17 10:27:23 +01:00
Simon Backx
423337a048 Fixed snapshots 2023-03-17 10:24:21 +01:00
Sanne de Vries
6821750a3a Fixed spacing between post title and metadata in email template
Refs https://github.com/TryGhost/Team/issues/2740
2023-03-17 10:17:56 +01:00
Sanne de Vries
717ed114f4 Fixed center aligned post title in emails
Refs https://github.com/TryGhost/Team/issues/2740
2023-03-17 10:07:17 +01:00
Daniel Lockyer
3f3cf76c37 Updated react-scripts to v5
refs https://github.com/TryGhost/Toolbox/issues/400

- this fixes various build issues when it's moved into the Ghost
  monorepo
2023-03-17 09:52:12 +01:00
Chris Raible
0640b9c4aa
Modified outbound link tagger to use ?ref=domain instead of ?ref=siteTitle (#16431)
refs TryGhost/Team#2755

- Outbound link tagger will now append ?ref=example.com or ?ref=example.ghost.io instead of ?ref=siteTitle
2023-03-17 14:18:26 +05:30
Simon Backx
25f4974846 Added comment CTA in newsletters
fixes https://github.com/TryGhost/Team/issues/2672

- Moves the feature from behind the flag
- Also hides the comment CTA for email only posts

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
2023-03-17 09:38:55 +01:00
Simon Backx
86446e4c86 Added option to remove post title from newsletters
fixes https://github.com/TryGhost/Team/issues/2673

Adds a new option to hide the post title section from newsletters.

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
2023-03-17 09:38:55 +01:00
renovate[bot]
fb69af86e2
Update dependency i18next to v22.4.12 2023-03-17 07:22:44 +00:00
Chris Raible
8d4028bbb7
🐛 Fixed editor crashing with unknown cards in mobiledoc (#16430)
refs TryGhost/Team#2702

- adds a default handler for unknown cards: 
- logs a warning message to the console 
- removes the card from the mobiledoc
2023-03-16 16:06:56 -07:00
Naz
74a1ab4525
Fixed root zip media/files copying during import
refs https://github.com/TryGhost/Toolbox/issues/523

- During import process of content files the files from the root directory were also copied over. This is causing chaos in the root of content folder with files that only needed for data import. For example, the csv files needed for Revue import were also copied over by "file importer" even though those do not belong to any content.
- The approach of filtering on a "handler" level was taken over filtering in the import manager due to how our globing patterns work. See a previous commit with reverted previous fix for more context.
2023-03-16 22:48:57 +01:00
Naz
c487b12518 Reverted zip's root file copying fix
refs https://github.com/TryGhost/Toolbox/issues/523

- The reverted fix did not take into account the "original path" of the
files would be truncated. This path has to be full relative to the root
of the zip to later be used during importer url substitution logic.
- This reverts commit 831a76505c.
2023-03-16 21:52:24 +01:00
Daniel Lockyer
dda1d7cf26 Removed emojis from i18n strings
refs https://github.com/TryGhost/Ghost/issues/15502

- these aren't going to change across languages so we can exclude them
  from the strings to simplify things
2023-03-16 20:52:39 +01:00
Kevin Ansfield
6760bc1bb0
Added darkMode passthrough to lexical editor
closes https://github.com/TryGhost/Team/issues/2753

- dark mode styles are being added to our Lexical-based Koenig editor, this lets us test them inside of Admin
2023-03-16 18:55:44 +00:00
Sanne de Vries
d04b2e04d6 Updated copy from "Comments" to "Comment"
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-16 18:19:45 +01:00
Daniel Lockyer
dc0f021b99 Refactored i18n plaintext email translations to split on newline
refs https://github.com/TryGhost/Ghost/issues/15502

- this makes the translations files a lot nicer because they only
  contain one line per key
2023-03-16 17:25:22 +01:00
Rishabh Garg
ef538428c9
Fixed broken empty state in mentions admin url (#16419)
fixes https://github.com/TryGhost/Team/issues/2734

With WebMentions flag on, navigating to `/ghost/#/mentions` on Admin when there are no mentions gives a 400 error page instead of the intended empty state.
2023-03-16 21:19:56 +05:30
Steve Larson
7f223b56dd
fixed member newsletter test (#16425)
no ref
-fixed flaky test that seemed to have sync issues with fixture data and
db
2023-03-16 10:43:17 -05:00
renovate[bot]
a6f6b11ddf Update dependency vite to v4.2.0 2023-03-16 16:41:24 +01:00
renovate[bot]
f8730267ed Update dependency vitest to v0.29.3 2023-03-16 16:34:27 +01:00
Daniel Lockyer
327fef0ad8 Migrated Portal from CRA to Vite
refs https://github.com/TryGhost/Ghost/issues/15502

- this commit migrates Portal from CRA to Vite, as it brings the
  package more inline with the direction we're going in terms of tooling
  for builds
- the bulk of the changes here are just config related to get things
  working with Vite, and then cleaning up all the CRA boilerplate
2023-03-16 16:25:55 +01:00
Sanne de Vries
cdcb3dcd6f
Updated email template to include comment link in header and footer (#16423)
Refs https://github.com/TryGhost/Team/issues/2740

---------

Co-authored-by: Steve Larson <9larsons@gmail.com>
2023-03-16 16:10:53 +01:00
Daniel Lockyer
330e86944c Added example translation for emails within Ghost
refs https://github.com/TryGhost/Ghost/issues/15502

- this adds the i18n translation wrapper to the titles, plaintext
  versions and one HTML version of the member emails
2023-03-16 16:09:55 +01:00
Daniel Lockyer
9f5d4b4efe
Removed .only from Portal tests
- I'm not sure what this was doing here, nor why it hasn't caused
  problems for us
2023-03-16 16:00:19 +01:00
Elena Baidakova
60b3731199 Separated admin and portal tests to different projects
refs TryGhost/Team#2667
- Portal tests are much more stable when running in the separate DB from admin tests.
2023-03-16 18:35:09 +04:00
renovate[bot]
0ae2a79a77
Update dependency ember-template-lint to v5.7.1 2023-03-16 13:53:36 +00:00
Daniel Lockyer
21ea426794 Added i18n service to Ghost core
refs https://github.com/TryGhost/Ghost/issues/15502

- this adds the scaffolding for enabling i18n translations within Ghost
  core
- also adds `yarn translate:ghost` as an option to the `i18n` package
- the locale is currently hardcoded to `en` so we don't utilize the
  translations until we're ready
2023-03-16 14:50:50 +01:00
Daniel Lockyer
0273ba2066
Disabled i18next debug mode in development
- I didn't realise how annoying this would be so this commit disables it
2023-03-16 14:06:38 +01:00
Sodbileg Gansukh
2d7e5753d7 Fixed border color of the post analytics list in dark mode
closes https://github.com/TryGhost/Team/issues/2620
2023-03-16 19:55:14 +08:00
Sodbileg Gansukh
66b749ba90 Removed tabbed look from post analytics page with only one metric
refs https://github.com/TryGhost/Team/issues/2620
2023-03-16 19:51:04 +08:00
Daniel Lockyer
0479b1a848
Converted Portal utils to ESM syntax
- Portal is completely configured for ESM so we can utilize that here
  too and save on some tsserver warnings
2023-03-16 12:10:16 +01:00
Daniel Lockyer
e280925a8b
Switched Portal components to use explicit path imports
- `compilerOptions.baseUrl` is nice but it means we end up with two
  different styles of import paths for project files - relative and from
  `src/`
- to fix this, we're going to standardize on relative imports and remove
  the ability to import relative to the top-level project folder
- this removes the jsconfig line and fixes all existing imports
2023-03-16 12:10:03 +01:00
Sam Lord
d04b43aeee Added post-based attributions for members in data-generator
no issue
2023-03-16 10:17:14 +00:00
renovate[bot]
1c9327ce33 Update dependency webpack to v5.76.2 2023-03-16 01:03:03 +00:00
renovate[bot]
4bb673ba8a
Update Test & linting packages 2023-03-15 21:52:02 +00:00
Simon Backx
450e01d1c0 Added placeholder basic subscription details to email template
refs https://github.com/TryGhost/Team/issues/2736

The renewal date is still missing, and style and desin is only a placeholder.
2023-03-15 17:12:56 +01:00
Rishabh Garg
d98ffcff28 Updated last mentions report timestamp to use number
Co-authored-by: Simon Backx <simon@ghost.org>
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
266c70a8fd Added mentions-email-report service
This wires up the @tryghost/mentions-email-report service
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
7300130986 Added templates for mention report email 2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
3cf3f633aa Refactored staff-service
This moves the shared data between all templates into a method so that
it's calculated in a single place, as well as exposing separate render
methods for HTML and Text. We've also added some new custom helpers
for use in the handlebars templates
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
04efb6c177 Exposed MentionsAPI from mentions service
This is necessary so that we can use it as the IMentionReportGenerator
dependency for the mentions-email-report packages
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
018e2654c5 Added getAll method to BookshelfMentionRepository
This is necessary to support the getMentionReport method in MentionsAPI
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
0262083bb0 Added getMentionReport method to MentionsAPI
This will be used by the mentions-report-email package to generate the
data used for the report emails
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
c56b819748 Added @tryghost/mentions-email-report package
This package contains the business logic for the sending of mention
report emails, it could eventually be included in the webmentions
package I think, but has been kept separate for now in favour of
smaller packages.
2023-03-15 21:22:13 +05:30
Simon Backx
b8b0d1538e Added very basic subscription details in preview labs
refs https://github.com/TryGhost/Team/issues/2738
2023-03-15 15:07:26 +01:00
Kevin Ansfield
e2eba623dc
Added complex object URL transform support for lexical card datasets
refs https://github.com/TryGhost/Team/issues/2722

- bumped `@tryghost/url-utils` with additional lexical card dataset support
- see 2154b26dd2
2023-03-15 14:00:23 +00:00
Daniel Lockyer
7409f9524a
Added link to GitHub commit if prerelease version
refs https://ghost.slack.com/archives/C025584CA/p1678886661494989?thread_ts=1678886465.260379&cid=C025584CA

- if we're running a prerelease, our usual format is `<major>.<minor>.<patch>-pre.<commit hash>.<build>`
- if you wanna see what commit it was built on, you have to copy and
  paste the hash into a GitHub URL
- this provides an easier route to the commit by detecting if the
  version is our special format and links direct to GitHub if so
2023-03-15 14:47:45 +01:00