Commit Graph

15600 Commits

Author SHA1 Message Date
Sanne de Vries
edbc1a5839 Revert "Updated copy for email sending failure error message"
This reverts commit 3046e30802.
2023-01-06 19:24:32 +01:00
Sanne de Vries
3046e30802 Updated copy for email sending failure error message
No ref
2023-01-06 19:14:46 +01:00
renovate[bot]
608d4eb6d2 Update dependency knex to v2.4.0 2023-01-06 19:11:14 +01:00
Ghost CI
ab26c474f1 v5.28.0 2023-01-06 16:00:44 +00:00
Simon Backx
21835b0b03 🐛 Fixed duplicate member columns when filtering
refs https://ghost.slack.com/archives/CTH5NDJMS/p1672999077197199

When filtering on the same filter twice, columns were added twice. This change removes duplicate columns.
2023-01-06 16:04:22 +01:00
Simon Backx
26635f192f Added visible theme errors in admin
fixes https://github.com/TryGhost/Team/issues/2393
2023-01-06 15:51:34 +01:00
Simon Backx
3ddc85781c Fixed theme warnings not passed when installing theme
refs 6593c3e4a6

In development mode, we didn't pass the warnings when installing a theme. So the warnings were not visible with the fatal errors.
2023-01-06 15:26:54 +01:00
Simon Backx
f6e463ea43 Fixed missing awaits in publishing Playwright test
no issue
2023-01-06 14:18:54 +01:00
Rishabh
54b27f7d55 Fixed offers playwright test for redemption count
- updates check of redemption count using data test attributes to avoid unreliable member count check
2023-01-06 18:39:38 +05:30
Simon Backx
6593c3e4a6 🐛 Fixed warnings not visible when uploading theme with fatal errors
refs https://github.com/TryGhost/Team/issues/2393

Small bug if you upload a theme that has fatal errors, in development mode the warnings are not visible.
2023-01-06 13:54:09 +01:00
Simon Backx
7b3712a15b
Added visible theme errors in admin (#16081)
refs https://github.com/TryGhost/Team/issues/2393

- During boot and loading the active theme, we now cache the result of
the gscan validation. Cache configuration can happen in
`adapters.cache.gscan`
- We now also return non-fatal errors when activating or adding a theme.
- When the `themeErrorsNotification` feature flag is on, we fetch the
active theme (which includes the validation information) when loading
admin
- If the currently active theme has errors, we show an error
notification that can open the error modal
- Added a new endpoint: `/ghost/api/admin/themes/active/` that returns
the result of the last gscan validation of the active theme. If no cache
is available, it will run a new gscan validation.
- Added new permissions for the active action/endpoint (author, editor,
administrator)
2023-01-06 13:44:27 +01:00
Naz
a37bd19f74
ℹ️ Bumped gscan to 4.36.0
closes https://github.com/TryGhost/Toolbox/issues/497

- The classification of fatal/non-fatal errors has been updated to only be fatal when causing page renders with 5xx or 4xx responses.
- Some of the rules checking Ghost 5.x compatibility have been relaxed to only be "error" with the gscan version bump
- You can find more details on which exact rules were relaxed in the gscan's commit log - https://github.com/TryGhost/gscan/compare/v4.35.1...v4.36.0
2023-01-06 18:05:07 +07:00
Naz
3e209218d7
Made resource mismatch error more specific
refs https://github.com/TryGhost/Toolbox/issues/497

- During gscan fatal error downgrade to non-fatal some of the deprecated helpers were a bit vague to debug with no information on which exact "resource" was invalid
- Added resource name to the log for clarity. Should make life easier when debugging potential get helper misuses
2023-01-06 18:05:07 +07:00
Naz
8911af150a
Removed "code" property from global error variable
refs https://github.com/TryGhost/Toolbox/issues/406
refs b2a3e03ef3

- The "code" property in the global "error" variable (accessible via {{error.*}}) has been long deprecated - time to go, bye!
- When {{code}} or {{error.code}} helpers are used in the templates they will output an empty string from now on. Use {{statusCode}} instead!
2023-01-06 18:05:07 +07:00
renovate[bot]
f58a7725d6 Update dependency luxon to v2.5.2 2023-01-06 11:59:24 +01:00
renovate[bot]
1c64b8a8fc Update dependency html-validate to v7.12.1 2023-01-06 11:58:57 +01:00
Sam Lord
36e7e79eec Improved Playwright test, selector for redemption count
no issue

Selector for redemption count was not ideal - this makes it more specific & clear.
2023-01-06 10:56:19 +00:00
Rishabh
30c9dfd68d Fixed failing playwright test to remove member labels
- the test was using incorrect test state that was copied over from adding label test
- also adds guard for empty newsletters in member filters as in some cases it might not exist as found by test
2023-01-06 16:17:34 +05:30
Ronald Langeveld
e52f29231f Added Playwright test - remove labels from members
ref https://github.com/TryGhost/Team/issues/2371

- check that a fitered list of members can have a label removed from
  them at once.
2023-01-06 14:36:13 +08:00
Patrick McKenzie
559ca9d866
🐛 Stopped creating redundant Stripe Customers for Members
fixes https://github.com/TryGhost/Ghost/issues/16057

Briefly, Ghost created two Customer objects via the Stripe API when an
existing subscriber would upgrade to a paid subscription, one in an API
call to create the Customer and then a second as a side effect of an API
call to create a Checkout session for the user. The fix is passing the
reference to the Customer object to the API call to create the Checkout
session; Stripe will no longer redundantly create a Customer object in
this case.

This largely impacts the owner's experience of the Stripe Dashboard; it
will correct their new Customer count (going forward) and make searches
for users by name or email address return one responsive object which
has the actual subscription in it versus returning two and forcing them
to look in each to e.g. refund a transaction or similar.
2023-01-06 11:44:56 +07:00
renovate[bot]
78384dd9eb
Update dependency ember-template-lint to v5.3.1 2023-01-06 00:21:56 +00:00
Ghost CI
adbf6427ae v5.27.0 2023-01-05 16:22:40 +00:00
Simon Backx
d34f07f408 🐛 Fixed admin loading member counts for authors and editors
no issue

When using admin as a user with author or editor permissions, admin tried to load the member counts in order to display them in the menu. But authors and editors are not allowed to see the members. So the request returned a 403.

It is not necessary to load the member counts for authors and editors, so we can just skip the request.
2023-01-05 16:37:01 +01:00
Simon Backx
cf5c64f96b
🐛 Fixed batches can have an empty "to" field (#16064)
fixes https://github.com/TryGhost/Team/issues/2246

This solution adds some retries when fetching the recipients for a
batch. For an unknown reason the recipients can be empty (while they
aren't in the database). This should fix the issue for now until we find
more information about the root cause.
2023-01-05 15:29:03 +01:00
Peter Zimon
bfe1915924 Theme error list design refinements
refs. https://github.com/TryGhost/Team/issues/2393

- style for theme error list was outdated
2023-01-05 13:19:34 +01:00
Djordje Vlaisavljevic
5b8a44772b Fixed settings menu header and tags overlapping
no refs
2023-01-05 12:08:03 +00:00
Peter Zimon
84cdf0c46c Added static version of theme errors notification
refs. https://github.com/TryGhost/Team/issues/2393

- a labs flag had to be created so we avoid working in branches
- permanent notification toast was added to make theme errors more discoverable
- static modal was needed to hold theme error details
2023-01-05 11:38:17 +01:00
Fabien "egg" O'Carroll
953f3856a8 Handled EmailBounceEvent with 605 error code
When Mailgun fails to deliver an email to an address because the
address has already bounced before, it gives us a permanent fail event
with a 605 error code rather than a 5xx one. Because we want to
"backfill" our suppressions data with previously bounced email
addresses, we want to handle this specific error code.

We may update this logic in the future based on new information from
Mailgun with respect to their 6xx error codes and the
meanings/underlying cause of theme.

This also moves the tests which check for whether or not emails are
suppressed into their own fail so that we do not pollute the event
storage tests, and adds more tests cases.

We also fix a leaky sinon stub which we were not resetting in the email
event storage tests
2023-01-05 17:11:37 +07:00
Fabien "egg" O'Carroll
2d9114450c Fixed email_recipients fixtures for tests
The email_recipient fixtures were using duplicate and mismatched email addresses
rather than having them correctly map to the Members, which is required for testing
email suppressions.
2023-01-05 17:11:06 +07:00
Peter Zimon
74fd5d4b04 Portal settings design bugfixes
no refs.

- Stripe Connect footer in the Portal settings sidebar was covering settings on small screens
- the border for Stripe Connect box was not visible in dark mode
- the "Save and Close" button background was not visible in dark mode in Portal settings
2023-01-04 18:04:01 +01:00
renovate[bot]
218136060e Update sentry-javascript monorepo to v7.29.0 2023-01-04 17:23:05 +01:00
renovate[bot]
e291c18371
Update dependency ember-modifier to v4 (#15990)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-modifier](https://togithub.com/ember-modifier/ember-modifier) |
[`3.2.7` ->
`4.0.0`](https://renovatebot.com/diffs/npm/ember-modifier/3.2.7/4.0.0) |
[![age](https://badges.renovateapi.com/packages/npm/ember-modifier/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/ember-modifier/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/ember-modifier/4.0.0/compatibility-slim/3.2.7)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/ember-modifier/4.0.0/confidence-slim/3.2.7)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ember-modifier/ember-modifier</summary>

###
[`v4.0.0`](https://togithub.com/ember-modifier/ember-modifier/blob/HEAD/CHANGELOG.md#v400-2022-12-13)

[Compare
Source](https://togithub.com/ember-modifier/ember-modifier/compare/v3.2.7...v4.0.0)

##### 🚀 Enhancement

-
[#&#8203;498](https://togithub.com/ember-modifier/ember-modifier/pull/498)
Update signature of constructor for class-based modifiers
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))
-
[#&#8203;327](https://togithub.com/ember-modifier/ember-modifier/pull/327)
auto-publish unstable packages to NPM
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### 🐛 Bug Fix

-
[#&#8203;372](https://togithub.com/ember-modifier/ember-modifier/pull/372)
Include `blueprints` folder in published tarball
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### 📝 Documentation

-
[#&#8203;504](https://togithub.com/ember-modifier/ember-modifier/pull/504)
docs: Fix typo in TypeScript class based example
([@&#8203;HeroicEric](https://togithub.com/HeroicEric))

##### 🏠 Internal

-
[#&#8203;539](https://togithub.com/ember-modifier/ember-modifier/pull/539)
Sync with latest v2 addon and cli-typescript blueprints
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))
-
[#&#8203;328](https://togithub.com/ember-modifier/ember-modifier/pull/328)
run `npx ember-cli-update --to=4.3.0` to align with blueprint
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### Committers: 2

-   Eric Kelly ([@&#8203;HeroicEric](https://togithub.com/HeroicEric))
- Sergey Astapov
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-04 15:13:15 +00:00
Simon Backx
30853bc213 Added 100% test coverage to EmailEventProcessor
refs https://github.com/TryGhost/Team/issues/2339
2023-01-04 16:07:19 +01:00
Peter Zimon
9d924efe92 Updated Stripe Connect buttons
no refs.

- Stripe Connect in Portal was not discoverable enough
- we used the old Stripe Connect buttons everywhere
2023-01-04 15:29:56 +01:00
Simon Backx
c31bc58210 Added 100% test coverage to EmailController
refs https://github.com/TryGhost/Team/issues/2339
2023-01-04 15:22:49 +01:00
Simon Backx
913ad18b71
Added DomainEvents.allSettled utility method (#16075)
no issue

With the increased usage of DomainEvents, it gets harder to build
reliable tests without having to resort to timeouts. This utility method
allows us to wait for all events to be processed before continuing with
the test.

This change should speed up tests and make them more reliable.

It only adds extra code when running tests and shouldn't impact
production.
2023-01-04 14:30:35 +01:00
Simon Backx
e2e9a56583 Added 100% test coverage to EmailService class
refs https://github.com/TryGhost/Team/issues/2339

Tests the EmailService class of the email-service package.
2023-01-04 14:25:29 +01:00
Rishabh
45ab2586b0 Fixed free trial messaging shown for invite-only sites in portal
refs https://github.com/TryGhost/Team/issues/2361

- bumps portal with fix for free trial messaging shown on invite-only sites
2023-01-04 17:15:25 +05:30
Rishabh
09237b2c90 Released Portal v2.23.0 2023-01-04 17:13:24 +05:30
Rishabh
f5aa07a095 🐛 Removed free trial message shown on portal for invite only sites
closes https://github.com/TryGhost/Team/issues/2361

If a free trial tier existed on site and its set to 'Invite only' in membership settings, the free trial copy still showed on portal.

- removes free trial copy from portal if site is invite only
- adds playwright test to make sure free trial copy is not shown for invite only sites
2023-01-04 17:11:55 +05:30
Daniel Lockyer
017f3e1257 Lowered threshold for link-tracking coverage
- for some reason, Node 18 detects a lower coverage than the configured
  threshold so this fails
- I've temporarily lowered the threshold until we can investigate why
2023-01-04 11:27:39 +01:00
Daniel Lockyer
1af31bab1a ℹ️ Added support for Node 18
refs https://github.com/TryGhost/Toolbox/issues/488

- Node 18 is now LTS so we're adding support for it
- this adds Node 18.12.1 (the latest security release) to our supported
  ranges and CI
2023-01-04 11:27:39 +01:00
Daniel Lockyer
aa08fc72e7 Updated Koenig packages
refs https://github.com/TryGhost/Toolbox/issues/488

- these packages add support for Node 18 and drop support for Node 12
2023-01-04 11:27:39 +01:00
Fabien 'egg' O'Carroll
50e99e013c
Added migrations to drop and recreate the suppressions table (#16070)
There are currently two issues with the suppressions table:
  - We have some incorrect rows
  - We have missing UNIQUE constraints

We want to completely wipe the tables and start fresh, as well as make
sure that the UNIQUE constraints are added, so we drop the table
completely, and then re-add it, which should result in an empty
suppressions table with all expected constraints.

We've also renamed the `email_address` column to `email` to match our
`users` & `members` tables
2023-01-04 17:26:57 +07:00
Simon Backx
819d0d884c
Improved email verification required checks (#16060)
fixes https://github.com/TryGhost/Team/issues/2366
refs https://ghost.slack.com/archives/C02G9E68C/p1670232405014209

Probem described in issue.

In the old MEGA flow:
- The `email_verification_required` check is now repeated inside the job

In the new email service flow:
- The `email_verification_required` is now checked (didn't happen
before)
- When generating the email batch recipients, we only include members
that were created before the email was created. That way it is
impossible to avoid limit checks by inserting new members between
creating an email and sending an email.
- We don't need to repeat the check inside the job because of the above
changes

Improved handling of large imports:
- When checking `email_verification_required`, we now also check if the
import threshold is reached (a new method is introduced in
vertificationTrigger specifically for this usage). If it is, we start
the verification progress. This is required for long running imports
that only check the verification threshold at the very end.
- This change increases the concurrency of fastq to 3 (refs
https://ghost.slack.com/archives/C02G9E68C/p1670232405014209). So when
running a long import, it is now possible to send emails without having
to wait for the import. Above change makes sure it is not possible to
get around the verification limits.

Refactoring:
- Removed the need to use `updateVerificationTrigger` by making
thresholds getters instead of fixed variables.
- Improved awaiting of members import job in regression test
2023-01-04 11:22:12 +01:00
renovate[bot]
c9221525bc Update dependency gscan to v4.35.1 2023-01-04 11:13:01 +01:00
Fabien 'egg' O'Carroll
e78612bb66
Fixed MailgunEmailSuppressionList adding non-5xx failures to the list
The MailgunEmailSuppression list was incorrectly adding emails
to the suppression list for permanent failure events which have
an error code outside of the 5xx range.
2023-01-04 17:03:52 +07:00
Kevin Ansfield
ea9c8c03fe
Update dependency ember-template-lint to v5.3.0 (#16062)
refs https://github.com/TryGhost/Ghost/pull/15550

Pulled out of the rolled up node+ember-js+ember-template rollup linter update PR as it required fairly extensive changes.

- bumped package
- renamed `no-down-event-binding` to `no-pointer-down-event-binding`
- disabled `no-pointer-down-event-binding` rule
- disabled `no-triple-curlies` rule
- ran `yarn lint:hbs --fix`
- updated integration tests to match Octane syntax
- fixed various one-off errors
- updated .lint-todo
2023-01-04 09:39:32 +00:00
Simon Backx
789e2c96c0
🐛 Fixed SingleUseTokens being cleared on boot (#15999)
fixes https://github.com/TryGhost/Team/issues/1996

**Issue**
Our Magic links are valid for 24 hours. After first usage, the token
lives for a further 10 minutes, so that in the case of email servers or
clients that "visit" links, the token can still be used.

The implementation of the 10 minute window uses setTimeout, meaning if
the process is interrupted, the 10 minute window is ignored completely,
and the token will continue to live for the remainder of it's 24 hour
validity period. To prevent that, the tokens are cleared on boot at the
moment.

**Solution**

To remove the boot clearing logic, we need to make sure the tokens are
only valid for 10 minutes after first use even during restarts.

This commit adds 3 new fields to the SingleUseToken model:
- updated_at: for storing the last time the token was changed/used). Not
really used atm.
- first_used_at: for storing the first time the token was used
- used_count: for storing the number of times the token has been used

Using these fields:
- A token can only be used 3 times
- A token is only valid for 10 minutes after first use, even if the
server restarts in between
- A token is only valid for 24 hours after creation (not changed)

We now also delete expired tokens in a separate job instead of on boot /
in a timeout.
2023-01-04 09:49:39 +01:00
renovate[bot]
497491fbef
Update metascraper to v5.33.3 2023-01-04 01:46:54 +00:00
renovate[bot]
640b4accd6
Update dependency knex-migrator to v5.1.0 2023-01-03 22:35:38 +00:00
Paul Davis
8db947cd24
Trim generated post slug length in Revue importer (#16065)
refs: 5f90baf6fe

- Ghost has a character limit on post slugs of 191 characters,
- Sometimes, the slug that is generated from the title in Revue content is longer than this, causing the import to fail. 
- This PR trims that generated post slug to 190 characters.
2023-01-03 20:15:32 +00:00
renovate[bot]
1c9ad00d6d
Update dependency bookshelf-relations to v2.5.1 2023-01-03 19:09:30 +00:00
renovate[bot]
854c90f324 Update dependency fastq to v1.15.0 2023-01-03 19:06:34 +00:00
renovate[bot]
f6db0640a6
Update dependency @ember/test-helpers to v2.9.3 (#16011)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@ember/test-helpers](https://togithub.com/emberjs/ember-test-helpers)
| [`2.8.1` ->
`2.9.3`](https://renovatebot.com/diffs/npm/@ember%2ftest-helpers/2.8.1/2.9.3)
|
[![age](https://badges.renovateapi.com/packages/npm/@ember%2ftest-helpers/2.9.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@ember%2ftest-helpers/2.9.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@ember%2ftest-helpers/2.9.3/compatibility-slim/2.8.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@ember%2ftest-helpers/2.9.3/confidence-slim/2.8.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>emberjs/ember-test-helpers</summary>

###
[`v2.9.3`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.3):
Release 2.9.3

[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.2...v2.9.3)

##### 🐛 Bug Fix

-
[#&#8203;1305](https://togithub.com/emberjs/ember-test-helpers/pull/1305)
\[backport] Avoid unnecessary dependencies on `@glimmer` types
([@&#8203;dfreeman](https://togithub.com/dfreeman))

##### Committers: 1

-   Dan Freeman ([@&#8203;dfreeman](https://togithub.com/dfreeman))

###
[`v2.9.2`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.2):
Release 2.9.2

[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.1...v2.9.2)

##### 🐛 Bug Fix

-
[#&#8203;1302](https://togithub.com/emberjs/ember-test-helpers/pull/1302)
\[backport] Remove the index signature from `TestContext`
([@&#8203;chriskrycho](https://togithub.com/chriskrycho))
- Backporting
[#&#8203;1301](https://togithub.com/emberjs/ember-test-helpers/pull/1301)
Remove the index signature from `TestContext`
([@&#8203;dfreeman](https://togithub.com/dfreeman))
-
[#&#8203;1303](https://togithub.com/emberjs/ember-test-helpers/pull/1303)
`TestContext.resumeTest()` returns `void`, not `Promise<void>`
([@&#8203;chriskrycho](https://togithub.com/chriskrycho))

##### Committers: 1

- Chris Krycho ([@&#8203;chriskrycho](https://togithub.com/chriskrycho))
-   Dan Freeman ([@&#8203;dfreeman](https://togithub.com/dfreeman))

###
[`v2.9.1`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v291-2022-12-16)

[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.0...v2.9.1)

***Note:** these were all back-ported from master since they could go
out on 2.9. This will be the last 2.9 release unless there are critical
bug fixes here!*

##### 🐛 Bug Fix

- Let ESLint have its way about docstring location
([`a8fac83`](https://togithub.com/emberjs/ember-test-helpers/commit/a8fac83))
- DOC: API: add render helper examples
([`f476a20`](https://togithub.com/emberjs/ember-test-helpers/commit/f476a20))
- Tweak TS style for indexing multiple types (for getElement)
([`f01ad9f`](https://togithub.com/emberjs/ember-test-helpers/commit/f01ad9f))
- Use export type for RenderingTestContext
([`2dc5077`](https://togithub.com/emberjs/ember-test-helpers/commit/2dc5077))
- Tweak TS style for indexing multiple types
([`3214483`](https://togithub.com/emberjs/ember-test-helpers/commit/3214483))
- Address PR feedback
([`5e87a54`](https://togithub.com/emberjs/ember-test-helpers/commit/5e87a54))
- DOC: API: add DOM query helper examples
([`83b7f5f`](https://togithub.com/emberjs/ember-test-helpers/commit/83b7f5f))
- Export type for Target
([`335019d`](https://togithub.com/emberjs/ember-test-helpers/commit/335019d))
- Upgrade expect-type and fix issues the new version reveals
([`bae5e33`](https://togithub.com/emberjs/ember-test-helpers/commit/bae5e33))
- Correctly handle special char keyCodes with Shift
([`d537923`](https://togithub.com/emberjs/ember-test-helpers/commit/d537923))
- Add tab type test
([`64f40d5`](https://togithub.com/emberjs/ember-test-helpers/commit/64f40d5))
- Generate documentation
([`939f29f`](https://togithub.com/emberjs/ember-test-helpers/commit/939f29f))
- Ensure types reflect optional-ness of tab options
([`95285cc`](https://togithub.com/emberjs/ember-test-helpers/commit/95285cc))
- Fix typesVersions config again
([`53fa899`](https://togithub.com/emberjs/ember-test-helpers/commit/53fa899))
- Clean up public-types after pack
([`b9dcbca`](https://togithub.com/emberjs/ember-test-helpers/commit/b9dcbca))

###
[`v2.9.0`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v290-2022-12-14)

[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.8.1...v2.9.0)

##### 🚀 Enhancement

-
[#&#8203;1269](https://togithub.com/emberjs/ember-test-helpers/pull/1269)
Re-export hasEmberVersion (and its type) from
[@&#8203;ember/test-helpers](https://togithub.com/ember/test-helpers)
([@&#8203;gitKrystan](https://togithub.com/gitKrystan))
-
[#&#8203;1278](https://togithub.com/emberjs/ember-test-helpers/pull/1278)
perf: Remove excessive destroy call
([@&#8203;runspired](https://togithub.com/runspired))
-
[#&#8203;1234](https://togithub.com/emberjs/ember-test-helpers/pull/1234)
Introduce public TypeScript support
([@&#8203;chriskrycho](https://togithub.com/chriskrycho))

##### 🐛 Bug Fix

-
[#&#8203;1277](https://togithub.com/emberjs/ember-test-helpers/pull/1277)
Actually publish .d.ts
([@&#8203;gitKrystan](https://togithub.com/gitKrystan))
-
[#&#8203;1270](https://togithub.com/emberjs/ember-test-helpers/pull/1270)
Fix typesVersions path
([@&#8203;gitKrystan](https://togithub.com/gitKrystan))
-
[#&#8203;1233](https://togithub.com/emberjs/ember-test-helpers/pull/1233)
Add more keyCode mappings ([@&#8203;CvX](https://togithub.com/CvX))

##### 📝 Documentation

-
[#&#8203;1259](https://togithub.com/emberjs/ember-test-helpers/pull/1259)
DOCS: API: publish docs for tab
([@&#8203;geneukum](https://togithub.com/geneukum))

##### Committers: 5

- Chris Krycho ([@&#8203;chriskrycho](https://togithub.com/chriskrycho))
-   Chris Thoburn ([@&#8203;runspired](https://togithub.com/runspired))
-   Geordan Neukum ([@&#8203;geneukum](https://togithub.com/geneukum))
-   Jarek Radosz ([@&#8203;CvX](https://togithub.com/CvX))
- Krystan HuffMenne
([@&#8203;gitKrystan](https://togithub.com/gitKrystan))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 18:04:35 +00:00
Kevin Ansfield
0b80a7f9eb
Fixed new tier creation browser tests (#16066)
refs https://github.com/TryGhost/Ghost/pull/16013

- ordering of tiers changed so newly added tiers are no longer always at the end of the list in Admin
2023-01-03 17:59:33 +00:00
Daniel Lockyer
99c775be23
ℹ️ Bumped minimum Node version to 14.18.0
refs https://github.com/TryGhost/Toolbox/issues/488

- this is needed so we can bump some dependencies
- given how old these versions are, users should probably update past
  this anyway
2023-01-03 18:54:39 +01:00
renovate[bot]
9e4b882889 Update dependency @sinonjs/fake-timers to v10.0.2 2023-01-03 18:47:15 +01:00
renovate[bot]
dcf8c55e9c Update dependency @types/nodemailer to v6.4.7 2023-01-03 18:46:57 +01:00
renovate[bot]
470cdbb681 Update dependency html-validate to v7.12.0 2023-01-03 18:46:27 +01:00
renovate[bot]
55b73b9049 Update dependency @playwright/test to v1.29.1 2023-01-03 18:46:13 +01:00
renovate[bot]
cd1cdd869f
Update dependency ember-in-viewport to v4.1.0 (#15795)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-in-viewport](https://togithub.com/dockyard/ember-in-viewport) |
[`4.0.2` ->
`4.1.0`](https://renovatebot.com/diffs/npm/ember-in-viewport/4.0.2/4.1.0)
|
[![age](https://badges.renovateapi.com/packages/npm/ember-in-viewport/4.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/ember-in-viewport/4.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/ember-in-viewport/4.1.0/compatibility-slim/4.0.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/ember-in-viewport/4.1.0/confidence-slim/4.0.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dockyard/ember-in-viewport</summary>

###
[`v4.1.0`](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0)

[Compare
Source](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:51 +00:00
renovate[bot]
6f6f816077
Update dependency ember-css-transitions to v4.3.2 (#15846)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[ember-css-transitions](https://miguelcobain.github.io/ember-css-transitions)
([source](https://togithub.com/miguelcobain/ember-css-transitions)) |
[`4.2.0` ->
`4.3.2`](https://renovatebot.com/diffs/npm/ember-css-transitions/4.2.0/4.3.2)
|
[![age](https://badges.renovateapi.com/packages/npm/ember-css-transitions/4.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/ember-css-transitions/4.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/ember-css-transitions/4.3.2/compatibility-slim/4.2.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/ember-css-transitions/4.3.2/confidence-slim/4.2.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>miguelcobain/ember-css-transitions</summary>

###
[`v4.3.2`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v432-2022-11-18)

[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.1...v4.3.2)

##### 🐛 Bug Fix

-
[#&#8203;117](https://togithub.com/miguelcobain/ember-css-transitions/pull/117)
Handle no ownConfig scenario (for real)
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### Committers: 1

- Sergey Astapov
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

###
[`v4.3.1`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v431-2022-11-18)

[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.0...v4.3.1)

##### 🐛 Bug Fix

-
[#&#8203;116](https://togithub.com/miguelcobain/ember-css-transitions/pull/116)
Handle no ownConfig scenario
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### Committers: 1

- Sergey Astapov
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

###
[`v4.3.0`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v430-2022-11-18)

[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.2.0...v4.3.0)

##### 🚀 Enhancement

-
[#&#8203;113](https://togithub.com/miguelcobain/ember-css-transitions/pull/113)
Add opt-in integration with
[@&#8203;ember/test-waiters](https://togithub.com/ember/test-waiters)
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))
-
[#&#8203;109](https://togithub.com/miguelcobain/ember-css-transitions/pull/109)
Update glint import path to template-registry
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### 📝 Documentation

-
[#&#8203;115](https://togithub.com/miguelcobain/ember-css-transitions/pull/115)
Add Glint support page to docs
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### 🏠 Internal

-
[#&#8203;114](https://togithub.com/miguelcobain/ember-css-transitions/pull/114)
Fix flaky tests
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))
-
[#&#8203;112](https://togithub.com/miguelcobain/ember-css-transitions/pull/112)
Rename addon folder to ember-css-transitions
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))
-
[#&#8203;111](https://togithub.com/miguelcobain/ember-css-transitions/pull/111)
update v2 addon setup
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

##### Committers: 1

- Sergey Astapov
([@&#8203;SergeAstapov](https://togithub.com/SergeAstapov))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi40IiwidXBkYXRlZEluVmVyIjoiMzQuMjYuNCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:23 +00:00
renovate[bot]
5ff142bd49
Update dependency liquid-wormhole to v3 (#16003)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [liquid-wormhole](https://togithub.com/pzuraq/liquid-wormhole) |
[`2.1.5` ->
`3.0.0`](https://renovatebot.com/diffs/npm/liquid-wormhole/2.1.5/3.0.0)
|
[![age](https://badges.renovateapi.com/packages/npm/liquid-wormhole/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/liquid-wormhole/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/liquid-wormhole/3.0.0/compatibility-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/liquid-wormhole/3.0.0/confidence-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pzuraq/liquid-wormhole</summary>

###
[`v3.0.0`](https://togithub.com/pzuraq/liquid-wormhole/blob/HEAD/CHANGELOG.md#v300-2022-12-13)

[Compare
Source](https://togithub.com/pzuraq/liquid-wormhole/compare/v2.1.5...v3.0.0)

##### 💥 Breaking Change

- [#&#8203;75](https://togithub.com/pzuraq/liquid-wormhole/pull/75)
Ember >= 3.24, node >= 14
([@&#8203;rwwagner90](https://togithub.com/rwwagner90))
- [#&#8203;72](https://togithub.com/pzuraq/liquid-wormhole/pull/72)
Update liquid-fire, remove getowner polyfill
([@&#8203;rwwagner90](https://togithub.com/rwwagner90))
- [#&#8203;67](https://togithub.com/pzuraq/liquid-wormhole/pull/67) ci:
drop support for node 4.x and node 6.x
([@&#8203;alexdiliberto](https://togithub.com/alexdiliberto))

##### 🚀 Enhancement

- [#&#8203;74](https://togithub.com/pzuraq/liquid-wormhole/pull/74) Add
Embroider support
([@&#8203;rwwagner90](https://togithub.com/rwwagner90))
- [#&#8203;73](https://togithub.com/pzuraq/liquid-wormhole/pull/73)
Various Ember updates
([@&#8203;rwwagner90](https://togithub.com/rwwagner90))

##### Committers: 2

- Alex DiLiberto
([@&#8203;alexdiliberto](https://togithub.com/alexdiliberto))
- Robert Wagner ([@&#8203;rwwagner90](https://togithub.com/rwwagner90))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:21:58 +00:00
Simon Backx
803bb18b8d Improved unit test coverage for the output mappers
no issue

Increases the unit test coverage to a bit above 60% to increase margin
2023-01-03 15:58:31 +01:00
renovate[bot]
fe454d8a33
Update dependency @babel/plugin-proposal-decorators to v7.20.7 (#16043)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@babel/plugin-proposal-decorators](https://babel.dev/docs/en/next/babel-plugin-proposal-decorators)
([source](https://togithub.com/babel/babel)) | [`7.20.5` ->
`7.20.7`](https://renovatebot.com/diffs/npm/@babel%2fplugin-proposal-decorators/7.20.5/7.20.7)
|
[![age](https://badges.renovateapi.com/packages/npm/@babel%2fplugin-proposal-decorators/7.20.7/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@babel%2fplugin-proposal-decorators/7.20.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@babel%2fplugin-proposal-decorators/7.20.7/compatibility-slim/7.20.5)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@babel%2fplugin-proposal-decorators/7.20.7/confidence-slim/7.20.5)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>babel/babel</summary>

###
[`v7.20.7`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7207-2022-12-22)

[Compare
Source](https://togithub.com/babel/babel/compare/v7.20.5...v7.20.7)

##### 👓 Spec Compliance

- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#&#8203;15223](https://togithub.com/babel/babel/pull/15223) fix:
Deleting super property should throw
([@&#8203;SuperSodaSea](https://togithub.com/SuperSodaSea))
- `babel-helpers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`, `babel-plugin-transform-object-super`
- [#&#8203;15241](https://togithub.com/babel/babel/pull/15241) fix:
Throw correct error types from sed ant class TDZ helpers
([@&#8203;SuperSodaSea](https://togithub.com/SuperSodaSea))

##### 🐛 Bug Fix

-   `babel-parser`, `babel-plugin-transform-typescript`
- [#&#8203;15209](https://togithub.com/babel/babel/pull/15209) fix:
Support auto accessors with TypeScript annotations
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))
-   `babel-traverse`
- [#&#8203;15287](https://togithub.com/babel/babel/pull/15287) Fix
`.parentPath` after rename in `SwitchCase`
([@&#8203;nicolo-ribaudo](https://togithub.com/nicolo-ribaudo))
-   `babel-plugin-transform-typescript`, `babel-traverse`
- [#&#8203;15284](https://togithub.com/babel/babel/pull/15284) fix: Ts
import type and func with duplicate name
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))
-   `babel-plugin-transform-block-scoping`
- [#&#8203;15278](https://togithub.com/babel/babel/pull/15278) Fix tdz
analysis for reassigned captured for bindings
([@&#8203;nicolo-ribaudo](https://togithub.com/nicolo-ribaudo))
- `babel-plugin-proposal-async-generator-functions`, `babel-preset-env`
- [#&#8203;15235](https://togithub.com/babel/babel/pull/15235) fix:
Transform `for await` with shadowed variables
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))
-   `babel-generator`, `babel-plugin-proposal-optional-chaining`
- [#&#8203;15258](https://togithub.com/babel/babel/pull/15258) fix:
Correctly generate `(a ?? b) as T`
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))
-   `babel-plugin-transform-react-jsx`, `babel-types`
- [#&#8203;15233](https://togithub.com/babel/babel/pull/15233) fix: Emit
correct sourcemap ranges for `JSXText`
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))
- `babel-core`, `babel-helpers`,
`babel-plugin-transform-computed-properties`, `babel-runtime-corejs2`,
`babel-runtime-corejs3`, `babel-runtime`
- [#&#8203;15232](https://togithub.com/babel/babel/pull/15232) fix:
Computed properties should keep original definition order
([@&#8203;SuperSodaSea](https://togithub.com/SuperSodaSea))
- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#&#8203;15223](https://togithub.com/babel/babel/pull/15223) fix:
Deleting super property should throw
([@&#8203;SuperSodaSea](https://togithub.com/SuperSodaSea))
-   `babel-generator`
- [#&#8203;15216](https://togithub.com/babel/babel/pull/15216) fix:
Print newlines for leading Comments of `TSEnumMember`
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))

##### 💅 Polish

-   `babel-plugin-transform-block-scoping`, `babel-traverse`
- [#&#8203;15275](https://togithub.com/babel/babel/pull/15275) Improve
relative execution tracking in fn exprs
([@&#8203;nicolo-ribaudo](https://togithub.com/nicolo-ribaudo))

##### 🏠 Internal

- `babel-helper-define-map`, `babel-plugin-transform-property-mutators`
- [#&#8203;15274](https://togithub.com/babel/babel/pull/15274) Inline &
simplify `@babel/helper-define-map`
([@&#8203;nicolo-ribaudo](https://togithub.com/nicolo-ribaudo))
- `babel-core`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-block-scoping`,
`babel-plugin-transform-classes`,
`babel-plugin-transform-destructuring`,
`babel-plugin-transform-parameters`,
`babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`,
`babel-preset-env`, `babel-traverse`
- [#&#8203;15200](https://togithub.com/babel/babel/pull/15200) Rewrite
`transform-block-scoping` plugin
([@&#8203;nicolo-ribaudo](https://togithub.com/nicolo-ribaudo))

##### 🏃‍♀️ Performance

-   `babel-helper-compilation-targets`
- [#&#8203;15228](https://togithub.com/babel/babel/pull/15228) perf:
Speed up `getTargets`
([@&#8203;liuxingbaoyu](https://togithub.com/liuxingbaoyu))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:45:34 +00:00
renovate[bot]
e264616808
Update dependency ember-resolver to v8.1.0 (#16035)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-resolver](https://togithub.com/ember-cli/ember-resolver) |
[`8.0.3` ->
`8.1.0`](https://renovatebot.com/diffs/npm/ember-resolver/8.0.3/8.1.0) |
[![age](https://badges.renovateapi.com/packages/npm/ember-resolver/8.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/ember-resolver/8.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/ember-resolver/8.1.0/compatibility-slim/8.0.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/ember-resolver/8.1.0/confidence-slim/8.0.3)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ember-cli/ember-resolver</summary>

###
[`v8.1.0`](https://togithub.com/ember-cli/ember-resolver/blob/HEAD/CHANGELOG.md#v810-2022-12-20)

[Compare
Source](https://togithub.com/ember-cli/ember-resolver/compare/v8.0.3...v8.1.0)

Back-ports built-in TypeScript support from 9.0.0 (see below) to
decouple that from the Ember 4.x upgrade.

##### 🚀 Enhancement

- [#&#8203;839](https://togithub.com/ember-cli/ember-resolver/pull/839)
Backport types to 8.x
([@&#8203;chriskrycho](https://togithub.com/chriskrycho))

##### Committers: 1

- Chris Krycho ([@&#8203;chriskrycho](https://togithub.com/chriskrycho))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:38 +00:00
renovate[bot]
9955cdc3ba
Update dependency testem to v3.10.1 (#16034)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [testem](https://togithub.com/testem/testem) | [`3.10.0` ->
`3.10.1`](https://renovatebot.com/diffs/npm/testem/3.10.0/3.10.1) |
[![age](https://badges.renovateapi.com/packages/npm/testem/3.10.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/testem/3.10.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/testem/3.10.1/compatibility-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/testem/3.10.1/confidence-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>testem/testem</summary>

### [`v3.10.1`](https://togithub.com/testem/testem/releases/tag/v3.10.1)

[Compare
Source](https://togithub.com/testem/testem/compare/v3.10.0...v3.10.1)

#### What's Changed

- build(deps): bump socket.io from 4.5.3 to 4.5.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/testem/testem/pull/1609](https://togithub.com/testem/testem/pull/1609)
- build(deps-dev): bump sinon from 14.0.2 to 15.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/testem/testem/pull/1611](https://togithub.com/testem/testem/pull/1611)
- build(deps-dev): bump socket.io-client from 4.5.3 to 4.5.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/testem/testem/pull/1610](https://togithub.com/testem/testem/pull/1610)
- build(deps-dev): bump eslint from 8.28.0 to 8.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/testem/testem/pull/1616](https://togithub.com/testem/testem/pull/1616)
- build(deps-dev): bump sinon from 15.0.0 to 15.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/testem/testem/pull/1617](https://togithub.com/testem/testem/pull/1617)
- Scope testem assets with a prefix by
[@&#8203;stepankuzmin](https://togithub.com/stepankuzmin) in
[https://github.com/testem/testem/pull/1615](https://togithub.com/testem/testem/pull/1615)

#### New Contributors

- [@&#8203;stepankuzmin](https://togithub.com/stepankuzmin) made their
first contribution in
[https://github.com/testem/testem/pull/1615](https://togithub.com/testem/testem/pull/1615)

**Full Changelog**:
https://github.com/testem/testem/compare/v3.10.0...v3.10.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4wIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:07 +00:00
renovate[bot]
bde3dc8087
Update dependency ember-basic-dropdown to v6.0.2 (#15809)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-basic-dropdown](http://ember-basic-dropdown.com)
([source](https://togithub.com/cibernox/ember-basic-dropdown)) |
[`6.0.1` ->
`6.0.2`](https://renovatebot.com/diffs/npm/ember-basic-dropdown/6.0.1/6.0.2)
|
[![age](https://badges.renovateapi.com/packages/npm/ember-basic-dropdown/6.0.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/ember-basic-dropdown/6.0.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/ember-basic-dropdown/6.0.2/compatibility-slim/6.0.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/ember-basic-dropdown/6.0.2/confidence-slim/6.0.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>cibernox/ember-basic-dropdown</summary>

###
[`v6.0.2`](https://togithub.com/cibernox/ember-basic-dropdown/blob/HEAD/CHANGELOG.md#&#8203;602)

[Compare
Source](https://togithub.com/cibernox/ember-basic-dropdown/compare/v6.0.1...d6395e07adfa13037617fd2b051623d2f9bfde58)

- Relax dependency on ember-style-modifier so version 1.0 is also
allowed

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMS42IiwidXBkYXRlZEluVmVyIjoiMzQuMjEuNiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:39:21 +00:00
renovate[bot]
be31f8e9fe
Update dependency @embroider/macros to v1.10.0 (#15874)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@embroider/macros](https://togithub.com/embroider-build/embroider) |
[`1.9.0` ->
`1.10.0`](https://renovatebot.com/diffs/npm/@embroider%2fmacros/1.9.0/1.10.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@embroider%2fmacros/1.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@embroider%2fmacros/1.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@embroider%2fmacros/1.10.0/compatibility-slim/1.9.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@embroider%2fmacros/1.10.0/confidence-slim/1.9.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>embroider-build/embroider</summary>

###
[`v1.10.0`](https://togithub.com/embroider-build/embroider/blob/HEAD/CHANGELOG.md#embroidermacros-190---1100)

- BUGFIX: template macros could have pre-moved appRoot in their
packageCache
- ENHANCEMENT: expose simplified transforms API for use with
babel-plugin-ember-template-compilation

Previously, we used MacrosConfig.astTransforms() which gave you
transforms in
the reverse order they were expected to run, for compatibility with the
wacky
ordering in class ember-cli-htmlbars. Now we also offer
`MacrosConfig.transforms()` which provides them in a format compatible
directly with babel-plugin-ember-template-compilation 2.0, which uses
the more natural order and which supports
plugins-as-strings-to-be-loaded in addition to just plain functions.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:38:47 +00:00
renovate[bot]
435d5da3ff Update sentry-javascript monorepo to v7.28.1 2023-01-03 14:27:06 +01:00
Kevin Ansfield
581f0b34b4
🐛 Fixed missing validation of offer amounts in the admin panel (#16022)
closes https://github.com/TryGhost/Team/issues/2380

- improved offer validation for `amount` field to cover all type/amount cases
- added validate-on-blur to the amount field to match our standard validation behaviour
- added re-validation of the amount field when the type is changed and the amount gets reset
- removed the internal parsing of a decimal trial days entry to an integer so the field value matches what is set internally and we let the user know that partial trial days are not supported

Non-user-facing refactors:
- renamed `_saveOfferProperty` to `_updateOfferProperty` to better reflect what it does
- fixed missing indentation for conditional blocks in the offer template
2023-01-03 09:23:11 +00:00
Elena Baidakova
235446b034
🐛 Fixed tiers order by monthly_price (#16013)
refs TryGhost/Team#2273
- According to documentation (https://ghost.org/docs/content-api/#order)
tiers should be ordered from lowest to highest monthly price.
2023-01-03 12:59:18 +04:00
Simon Backx
211de82a8d
Fixed random test failure due to member newsletter ordering (#16024)
fixes https://github.com/TryGhost/Team/issues/2365

The newsletters relation of a member was not sorted. This is fixed now,
so we have consistent results in the test snapshots.
2023-01-03 09:43:41 +01:00
renovate[bot]
c0b700147e Update dependency eslint to v8.31.0 2023-01-03 07:22:01 +00:00
renovate[bot]
af91df561c Update metascraper to v5.32.4 2023-01-03 04:07:06 +00:00
renovate[bot]
694e02d7ba Update dependency sanitize-html to v2.8.1 2023-01-03 00:17:13 +00:00
Daniel Lockyer
4867b7fb3d
Updated @tryghost/logging resolutions
refs 08b786af3b

- we recently bumped the packages but I forgot to update the resolutions
  to pin Ghost to a specific version of the package
2023-01-02 21:01:45 +01:00
Daniel Lockyer
08b786af3b Bumped TryGhost-owned dependencies and lockfile
- this was all getting terribly behind so I've done several things:
  - majority of `@tryghost/*` except Lexical packages
  - gscan + knex-migrator to remove old `@tryghost/errors` usage
  - bumped lockfile
2023-01-02 20:55:22 +01:00
Sam Lord
994e546787 Prevented posts meta table from breaking data generator script
refs: https://github.com/TryGhost/Toolbox/issues/453
2023-01-02 16:45:45 +00:00
Simon Backx
f568b35f26 Fixed 2023 snapshot tests
no issue

Updated the snapshot files for the email preview test snapshots that contain 2023 in the email footer.
2023-01-02 11:18:07 +01:00
Ghost CI
65252c361a v5.26.4 2022-12-30 16:00:45 +00:00
Ghost CI
85db1838d9 v5.26.3 2022-12-23 16:01:11 +00:00
Ghost CI
42f5743e86 v5.26.2 2022-12-20 12:15:51 +00:00
Hannah Wolfe
1b5aa390f1
🐛 Fixed meta is missing error with revue imports (#16033)
refs:
5f90baf6fe

- The check for hasIssuesCSV didn't normalize the filename first,
meaning the importer is super sensitive to zip structure
- This allows for zips that contain a directory, so that it will still
be processed as a revue import, not a Ghost import
2022-12-20 11:56:07 +00:00
Ghost CI
1f5a752b71 v5.26.1 2022-12-16 16:01:00 +00:00
Ghost CI
26be3b9ccd v5.26.0 2022-12-16 12:49:22 +00:00
Ghost CI
571874d2cc 🎨 Updated Casper to v5.4.4 2022-12-16 12:49:21 +00:00
Rishabh Garg
2eac41b1f4
🐛 Fixed invalid email getting saved for members (#16021)
refs https://github.com/TryGhost/Team/issues/2235

We found some cases which can cause a site to have member emails that have invalid characters like `member@example.com�`. This happened due to the `validator` version used by Ghost not able to catch some specific cases as invalid email, allowing members to be created with them either via Admin or Importer or direct signup. Portal UI already blocked these email as invalid. This change:

- updates `@tryghost/validator` to include a latest version of email validator that catches these invalid cases
- doesn't allow member creation with invalid email like above
- doesn't allow existing member emails to be edited to invalid
2022-12-16 16:47:52 +05:30
Simon Backx
6a266be239
🐛 Fixed archived offers return button not working (#16023)
fixes https://github.com/TryGhost/Team/issues/2374

When clicking 'Show active offers' in the archived offers view, it would
always return to an empty offers list, even when there are active
offers.
2022-12-16 11:32:05 +01:00
renovate[bot]
9ec6a7320a
Update dependency sinon to v15.0.1 2022-12-15 21:03:48 +00:00
Kevin Ansfield
4a6a2f8ded Added missing @tryghost/importer-revue
no issue

- publishing Ghost wasn't correctly bundling the required package due to a missing dependency in package.json
2022-12-15 21:00:43 +00:00
Hannah Wolfe
3ee0b813b6
Updated to use proper members importer for Revue (#16018)
refs:
5f90baf6fe

- The OG implementation of importing revue subscribers was very naive
- This sures it up to use our proper member importer, which makes sure
everything works perfectly:
  - adds an import label
  - ensures members are subscribed to newsletters

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2022-12-15 20:29:08 +00:00
Paul Davis
ecd2083745
Handle blockquotes & empty paragraphs (#16019)
refs: 5f90baf6fe

- Blockquotes without any wrapping tag get converted to Mobiledoc weirdly. Wrapping them in `<p>` tags helps solve that
- Also removes empty paragraph tags which cause unwanted large blank spaces in content
- Remove internal #revue from Revue content
2022-12-15 19:28:48 +00:00
Hannah Wolfe
5f90baf6fe
Added Revue Importer (#16012)
refs: https://www.getrevue.co/app/offboard

- Revue is stopping all paid subscriptions on 20th Dec, and shutting down on Jan 18th.
- This update allows Ghost to accept and handle the zip file Revue are providing as an export in Labs > Importer
- It will import posts (as best as we can with the data provided) and subscribers as free members
- At present it doesn't import paid subscribers, as we don't have that info, but you can disconnect Revue from your Stripe account to prevent all your subscriptions being cancelled & there's the option this can be fixed later
- There will be further updates to polish up this tooling - this is just a first pass to try to get something in people's hands

Co-authored-by: Paul Davis <PaulAdamDavis@users.noreply.github.com>
2022-12-15 17:22:54 +00:00
Simon Backx
0825a2d7f4
🐛 Fixed importing existing member resetting newsletters (#16017)
fixes https://github.com/TryGhost/Team/issues/2386

**Issue:**
- When trying to import a member that already exists, and has
'subscribed' set to 'true' in the CSV, the newsletters the member is
subscribed to are reset to the default newsletters.
- When ediging a member with the API and setting `subscribed` to true,
the same happens.

**Cause:**
A faulty check for the `status` property of a newsletter.

Fixed and added a new E2E test.
2022-12-15 17:45:11 +01:00
Hannah Wolfe
5fad27a3c0
Added html -> mobiledoc conversion to the importer (#16016)
- Now that the importer runs in a job, it seems sensble that we should
do this
- If posts are imported with HTML set, but not mobiledoc, we now convert html -> mobiledoc
- Note: This also converts the mobiledoc -> html so _may_ be lossy
- Without this, imports that only have HTML, not mobiledoc, would have
resulted in empty posts, so lossy > empty
2022-12-15 16:10:36 +00:00
Sodbileg Gansukh
74cb362f87
Added theme docs link to the design settings (#16014)
no refs

- this adds a theme documentation link to the design settings footer if there's an URL set in the package.json of the theme. An example of the package.json property: "docs": "https://example.com"
2022-12-15 20:06:08 +08:00
Ronald Langeveld
ce53c76fdf
Added newsletter subscription filtering to members (#16006)
closes https://github.com/TryGhost/Team/issues/2012

- Members can now be filtered based on the newsletters they are
subscribed to.
- Defaults to the existing newsletter filtering if user does not have
more than 1 newsletter.
2022-12-15 16:06:47 +07:00
Ghost CI
64e44444c1 v5.25.5 2022-12-14 17:21:38 +00:00