Commit Graph

3370 Commits

Author SHA1 Message Date
Kevin Ansfield
ad358375b8 🐛 fix enter key not working in text inputs/areas (#771)
closes https://github.com/TryGhost/Ghost/issues/8588, closes https://github.com/TryGhost/Ghost/issues/8639
- check that we have an action assigned to keyEvent codes before attempting to prevent the default behaviour
- no tests because browsers don't trigger form submissions in response to JS key events as a security measure
2017-07-10 19:09:11 +07:00
Kevin Ansfield
1d3a9a692d 🎨 fix non-square icon sizes (#778)
closes https://github.com/TryGhost/Ghost/issues/8665

- updates width/height for non-square icons to match the desired dimensions (width+height have to be specified for IE11)

Changes introduced in #724 failed to take into account a few of our icons are not square (notably the `arrow-*-small.svg` icons) resulting in some icons appearing too small.
2017-07-10 13:54:24 +02:00
Kevin Ansfield
625cc3fe92 🎨 fix case inconsistency in team labels (#774)
closes https://github.com/TryGhost/Ghost/issues/8661
2017-07-10 13:36:11 +02:00
Kevin Ansfield
d37f68adcb 🐛 fix autosave+transition on title blur with empty title (#767)
refs TryGhost/Ghost#8525
- fix `saveTitle` action
	- don't abort title save when we have an empty title
	- force a "dirty" state so that the save actually happens
- add acceptance test for title blur behaviour
- extract multiple instances `"(Untitled)"` into a const
2017-07-10 18:33:05 +07:00
John O'Nolan
9738ecc9dd Minor style fixes 2017-07-10 11:20:56 +01:00
Kevin Ansfield
0853b57244 🐛 prevent session sync issues with multiple tabs/refreshes (#772)
refs https://github.com/TryGhost/Ghost/issues/8616

- only refresh tokens on boot if we last refreshed more than 24hrs ago - this should prevent rapidly changing access/refresh tokens when opening new admin tabs or refreshing whilst other tabs are open
- fix token refresh test which was testing it's own behaviour instead of the applications 🙈

This may not be the full solution to the session issues but it closes one potential culprit and should at least reduce token churn which can only help track down the real cause.
2017-07-10 12:18:19 +02:00
Katharina Irrgang
034f74a560 Merge pull request #773 from kevinansfield/soo-many-tags
🚀 supercharge tags performance
2017-07-09 14:31:06 +02:00
Kevin Ansfield
d65666f90b 🚀 supercharge tags performance
closes https://github.com/TryGhost/Ghost/issues/8540
- use `{{vertical-collection}}` in the tags dropdown filter list, opening the dropdown is now virtually instant as it's not attempting to immediately render components for every tag in the list
- remove pagination/infinite scroll from tags screen
- load all tags when accessing the tags screen
  - will pause to show spinner if no tags have previously been loaded
  - if tags exist in the ember data store, show the list immediately and load/update list in the background
- use `{{vertical-collection}}` to render enough tags to fill the scrollable area with a small buffer and use occlusion and element re-use to swap tags in whilst scrolling (suuuuper fast no matter number of tags loaded)
- scroll tags into view when they are selected (keyboard nav now makes a lot more sense)
- tested with 875 tags and 2x/5x CPU throttling with no major slowdowns 🎉
2017-07-07 17:53:08 +01:00
Kevin Ansfield
8965db6bdb 🔥 remove content screen keyboard shortcuts
closes https://github.com/TryGhost/Ghost/issues/8662
- removes `k`, `j`, `up`, `down` shortcuts for changing the active post (these were already mostly unusable in 1.0) and the associated `enter` and `ctrl/cmd+backspace` commands for opening and triggering the delete modal respectively
- removes the `c` shortcut for opening the new post screen
2017-07-07 10:37:24 +01:00
Kevin Ansfield
d2a1835f5a 🎨 fix editor header not covering scrolled content (#769)
no issue
- background color of the editor header at smaller screen sizes had been removed resulting in the editor content showing through when scrolling, this adds the explicit bg color back for both normal and dark mode
2017-07-06 17:23:14 +07:00
Kevin Ansfield
036ab413d3 🐛 fix display/message bugs in re-auth modal (#770)
closes https://github.com/TryGhost/Ghost/issues/8656
- prevents button stretching from flexbox and adds margin between input and button
- use the `context` attribute returned from the server instead of the `message` so the error is now `Your password is incorrect.` instead of `You are not authorised to make this request.`
- return truthy/falsy values from the auth tasks so that the save-state button shows the correct state
2017-07-06 17:18:19 +07:00
Fixer
fc706d1c02 Additional check of privacy.useGravatar for gh-profile-image component (#761)
closes TryGhost/Ghost#8612

* Additional check of privacy.useGravatar for gh-profile-image component
- added a check for privacy.useGravatar flag
- checked: tests are OK

* fix other issues in gh-profile-image
- we had CPs with side-effects 🤢
  - replace CP with basic properties that can be set within the component
  - use `didReceiveAttrs` and `ember-concurrency` to debounce changes to the email property and make the functionality easier to reason about
- fix the broken fade-in animation when the avatar changes
- fix tests - `.to.be.blank` was always returning true, replaced with `to.be.empty` which caused the tests to fail properly then replaced them with the expectations for the actual values
2017-07-06 16:33:15 +07:00
Aileen Nowak
26ae3fa69d 🐛 fix sticky save notifications (#762)
closes TryGhost/Ghost#8610

There's an issue in CSSnano, which we're using in production mode to minify our CSS that caused animation frames to not work properly anymore.
See: https://github.com/ben-eb/gulp-cssnano/issues/33#issuecomment-210518957

Adding the recommended options fixed this issue.
2017-07-04 11:20:25 +01:00
Patrick Kim
1d15386960 🐛 fix broken image upload button (#766)
closes https://github.com/TryGhost/Ghost/issues/8637
- add a default object to `_openImageFileDialog` args so that destructuring with default params works when not passed a value
2017-07-04 11:11:54 +01:00
Aileen Nowak
0b238e6463 💄 Consistent layout for about page (#763)
closes TryGhost/Ghost#8623

Uses the same classes as the other pages for more consistency and sexiness. Also updated the links to slack and contributers to be correct.
2017-07-04 11:41:38 +02:00
Aileen Nowak
92253cfb35 💅🏼 Set width of searchinput to 100% (#764)
closes TryGhost/Ghost#8630

Add `width: calc(100% - 8px)` (substract 8px to keep a bit of a padding to the icon) to `.ember-power-select-search input` class so the input field is full width.
2017-06-29 09:54:55 +02:00
kirrg001
42128ace8c Version bump to 1.0.0-beta.2 2017-06-23 09:58:44 +02:00
Aileen Nowak
067a90a733 🐛 Add conditional to fix post scheduling (#760)
refs TryGhost/Ghost#8603

With 69b82b9207 we introduced a bug, that caused the Ghost Admin to crash when scheduling a blog post. Adding a check in the conditional prevents it from crashing and fixes the functionality.
2017-06-23 07:13:54 +02:00
Hannah Wolfe
a07e6ebe8d Minimal client extensions (#759)
no issue

- Add minimal extensibility to Ghost Admin

- Adds 3 sections of semi-flexible customisation to Ghost Admin
- Options:
   - Menu: a list of links with icons and text and hrefs, also has a title
   - Dropdown: another list of links
   - Script: a custom container and a script file

- All of this can be provided via the blog config
- Also adds 2 extra icons for use with these menus

- 🎨 Improve extensibility
2017-06-22 20:37:04 +02:00
Aileen Nowak
7eb60b0086 💅🏼 Imprve theme activation error messages (#756)
refs TryGhost/Ghost#8530

This PR takes care that the modals for theme activation gets the same treatment as theme upload modal:
- differentiate between normal and fatal errors
- list headings for each error type (fatal, normal or warning)
- update test
2017-06-22 19:19:01 +02:00
David Wolfe
fa391217b9 Disable simpleMDE image shortcut (#758)
no issue

- disables simpleMDE image shortcut when using cmd+alt+i
2017-06-22 17:36:40 +02:00
Kevin Ansfield
ebc8cc8ed2 ctrl/cmd-shift-i triggers image file dialog (#750)
closes https://github.com/TryGhost/Ghost/issues/8523
- use shortcuts mixin to register `cmd-shift-i` shortcut in
`gh-markdown-editor` that triggers the image insertion dialog
- joins multiple uploaded images with new lines instead of a space for
easier editing post-upload
- add `captureSelection` option to `_openImageFileDialog` so that
insertion shortcut triggered when editor doesn't have focus doesn't
insert at the last focused char position
- if image insertion happens with no cursor position add two newlines
before the inserted image markdown for easier editing (previously it
would be inserted immediately after the last char in the post)
- removes unused `editor-shortcuts.js` file
2017-06-22 13:02:38 +01:00
Kevin Ansfield
698a446b0a 🐛 fix title not updating after import (#749)
closes https://github.com/TryGhost/Ghost/issues/8508
- manually set `config.blogTitle` when reloading settings after a
successful import
2017-06-22 11:51:38 +01:00
Hannah Wolfe
808fd492de 💄 🐷 Remove word "static" from PSM
refs #4374

- see if taking this word away + the throbber makes it clearer
2017-06-22 11:35:52 +01:00
Aileen Nowak
533ad231f7 💅🏼 Reduce meta description word count font-size (#757)
closes TryGhost/Ghost#8552

Reduce the `font-size` per `0.5rem` so it'll fit within the `700px` `max-width` of the parent container even with three numbers in word count.
2017-06-22 11:53:24 +02:00
John O'Nolan
7295bb942d Really fix selected text colour this time
Cause apparently I wasn't fucking specific enough the first time
2017-06-21 15:56:44 +01:00
John O'Nolan
9296db0ae8 👀 bugfix editor text selection colour 2017-06-21 13:39:35 +01:00
John O'Nolan
32f419e87c Visually stimulating cursor 💅🏼 2017-06-21 13:05:14 +01:00
Katharina Irrgang
844bb3277d Revert "always give editor content focus by default (#748)" (#755)
This reverts commit 3c2f3da689.
2017-06-21 18:28:29 +07:00
Katharina Irrgang
203afcb531 🐛 fix image upload for icons: reset input (#754)
closes TryGhost/Ghost#8545
2017-06-20 16:54:27 +07:00
Katharina Irrgang
69b82b9207 🐛 fix date with seconds (#753)
closes #8603

- see https://github.com/TryGhost/Ghost/issues/8603#issuecomment-309538395
- see comment in code base
2017-06-20 15:12:57 +07:00
Aileen Nowak
ff249689d5 ⬆️ Trigger image upload when clicking on image (#735)
* ⬆️  Trigger image upload when clicking on image

closes TryGhost/Ghost#8544

When clicking on an already uploaded icon, logo or cover in Settings -> General we trigger now the file upload to be able to replace it.

* use lowercase event names

* toggle progress bar when replacing image
2017-06-19 11:55:28 +01:00
Kevin Ansfield
b00bdf6f17 set spellchecker to "off" by default (#747)
closes https://github.com/TryGhost/Ghost/issues/8566
- sets codemirror into "markdown" mode during initialisation
2017-06-19 11:32:37 +01:00
Kevin Ansfield
3c2f3da689 always give editor content focus by default (#748)
closes https://github.com/TryGhost/Ghost/issues/8525
- always give focus to the editor content area by default when loading
the editor
- change the editor placeholder text
2017-06-19 11:16:09 +01:00
Aileen Nowak
9b0c542cc1 💄 Fix positioning of loading spinner (#751)
closes TryGhost/Ghost#8556

Use the correct classes consistently for `gh-loading-spinner` component.
2017-06-19 11:09:53 +01:00
David Wolfe
8f58dd92dd Update post save button texts (#736)
closes https://github.com/TryGhost/Ghost/issues/8536, closes https://github.com/TryGhost/Ghost/issues/8500

- Post save button will now display publish/un-publish/schedule/un-schedule/re-schedule/update
- On successful save button will display published/un-published/scheduled/un-scheduled/re-scheduled/updated
2017-06-15 18:35:23 +01:00
Kevin Ansfield
2b353b5f13 📖 update all support.ghost.org links to docs/help.ghost.org (#740)
no issue
- support.ghost.org has gone away, we now have self-host/dev
documentation on https://docs.ghost.org and user documentation at
https://help.ghost.org
2017-06-15 18:19:12 +01:00
David Wolfe
db0ea54f72 Subscribers export button :hover should be blue (#744)
No Issue
- class should be gh-btn-hover-blue not gh-btn-hover-green
2017-06-15 12:43:00 +01:00
David Wolfe
f35ca49913 Add subscribers export button class (#743)
closes https://github.com/TryGhost/Ghost/issues/8553
- adds a href for pointer and hover class to subscribers export button
2017-06-15 10:26:29 +01:00
Kevin Ansfield
b126f21539 🐛 fix Cmd-S save with cursor in slug field
closes https://github.com/TryGhost/Ghost/issues/8551
- move `updateSlug` logic from `gh-post-settings-menu` component to `editor-base-controller` mixin
- put `updateSlug` and `save` into a task group so that concurrent calls are queued - means that pressing Cmd-S with the cursor still in the slug field will first trigger the `updateSlug` call (triggered by the field blur) then trigger the `save` call (triggered by Cmd-S) when `updateSlug` has finished so there are no conflicts and you still see the "saved" notification
2017-06-13 16:04:09 +01:00
Aileen Nowak
c8b8cb8478 🐛 fix styles for password forgot link (#734)
closes TryGhost/Ghost#8550
- use no success- and failure-classes for forgot link `gh-task-button`
- fixes loading spinner fill and positioning.
2017-06-13 10:01:20 +01:00
Aileen Nowak
336ff5667d 🎨 give suspended user badge a little room (#732)
closes #8546
- creates new `.suspended` class as a copy of `.administrator` for better naming and add `15px` of `margin-left` to it.
2017-06-13 09:54:05 +01:00
John O'Nolan
cbd18c6253 Update dark mode
Fixes https://github.com/TryGhost/Ghost/issues/8560

Depends on https://github.com/TryGhost/Ghost-Admin/pull/733
2017-06-12 21:50:17 +01:00
John O'Nolan
d39bbb89ab New tour styles 2017-06-12 21:50:17 +01:00
Kevin Ansfield
8e772ea646 Version bump to 1.0.0-beta.1 2017-06-08 20:46:12 +01:00
Kevin Ansfield
9881a52bea 🐛 fix saving users when slug has been changed (#731)
closes https://github.com/TryGhost/Ghost/issues/8547
- `window.history.state` is no longer a thing (not sure if it's a recent browser change or because we switched to hash-urls) so the URL change logic after a successful user save needs to use `window.location.hash` instead
2017-06-09 00:04:16 +07:00
Kevin Ansfield
05a3a11855 welcome tour (#527)
refs https://github.com/TryGhost/Ghost/issues/5168
- adds a `tour` service that handles syncing and management of tour throbbers & content
- adds a `gh-tour-item` component that handles the display of a throbber and it's associated popover when clicked
- uses settings API endpoint to populate viewed tour items on app boot/signin
- adds `liquid-tether@2.0.3` dependency for attaching throbbers and popups
- adds initial tour contents
2017-06-08 22:00:10 +07:00
John O'Nolan
1288d58f18 Fix display bug on wide aspect ratio images 2017-06-08 10:57:17 +02:00
Aileen Nowak
1a85bf017a 🐛 Use new user image properties for image upload (#729)
closes TryGhost/Ghost#8521
- the image uploader modals in `user.hbs` used the old image properties instead of `coverImage` and `profileImage`.
2017-06-07 09:19:58 +01:00
John O'Nolan
dedd6349ee Update ludicrous invisible notifications to be blue instead of white (#730)
no issue
2017-06-07 09:18:52 +01:00