TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-23 10:53:34 +03:00
Code Issues Projects Releases Wiki Activity
13,488 Commits 252 Branches 1,686 Tags 395 MiB
b045112950
Commit Graph

10 Commits

Author SHA1 Message Date
Naz
b045112950 Renamed exposed _getEmailMemberRows in mega 
no issue

- Exposing internal methods out of the module is a non-standard practice. Adding `_` prefix allows to signal that this method is not for general use.
- When mega is refactored into a proper class this method will become exposed anyways
 2021-07-14 18:56:57 +04:00
Naz
f343e73c92 Removed use of deprecated new Error() syntax 
refs 2f1123d6ca
refs 6f1a3e1774

- As per refed commits, we are removing deprecated use of `new Error()` in the codebase
- This bit cleans up `new Error()` usage in MEGA service
 2021-07-14 18:44:25 +04:00
Hannah Wolfe
f08a55c21f
Renamed tests to .test.js & updated commands 
refs: https://github.com/TryGhost/Team/issues/856
refs: https://github.com/TryGhost/Team/issues/756

- The .test.js extension is better than _spec.js as it's more obvious that it's an extension
- It also meaans we can use the --extension parameter in mocha, which should result in a better default behaviour for `yarn test`
- It also highlights that some of our tests were named incorrectly and were not (and still will not be) run (see https://github.com/TryGhost/Team/issues/856)
- Note: even with this change, `yarn test` is throwing errors, I believe because of this issue https://github.com/TryGhost/Team/issues/756
 2021-07-06 20:45:01 +01:00
Naz
b98854150c Added test illustrating filtering of null segments 
refs https://github.com/TryGhost/Team/issues/861

- The test case illustrates that it's already possible to achieve what's described in the referenced issue (bug where the content is not filtered correctly when a single email segment card is present)
- The bug fix for a general issue should be using this parser's ability to properly filter html/plaintext content
 2021-07-06 17:03:46 +04:00
Naz
df5290089b Fixed lint error 2021-07-01 21:02:06 +04:00
Naz
986a7526f5 Added member partitioner based on segment 
refs https://github.com/TryGhost/Team/issues/828

- Before sending out batches with members we need to partition all members based on the segment they belong to. Special segment "unsegmented" is used in case none of the segments used in the emal cards cover part of the members set (for example only free members card used when emailing all members)
 2021-07-01 20:58:24 +04:00
Thibaut Patel
b94c8bcfd4 Render an email correctly according to the associated member segment 
issue https://github.com/TryGhost/Team/issues/829
 2021-07-01 13:36:42 +02:00
Naz
bb8cf6001e Added unique filtering for segment parser 
refs https://github.com/TryGhost/Team/issues/828

- When detecting email segments and later creating a member filter out of this data we only care about unique segments otherwise we'd be creating multiple batches with the same segment filter
 2021-06-30 17:43:28 +04:00
Naz
e04af28efe Added segment parser logic 
refs https://github.com/TryGhost/Team/issues/828

- This is experimental segment extraction logic, more to follow. Alllows to extract arrays of email segments used in the email's HTML content
 2021-06-30 17:43:28 +04:00
Naz
90cc801394 Added JSDoc and unit tests for email replacement parser 
refs 474e6c4c45

- The method was not easy to understand after skimming through it.
- As we are working on developing a similar pattern for upcoming similar featured created a basic test suited to see input/output relation clearly
 2021-06-23 12:00:03 +04:00