Commit Graph

2397 Commits

Author SHA1 Message Date
Hannah Wolfe
5381db37cd Fix for bug where owner user has name owner
no issue

- in the case that the role is not being assigned, the code assumes it doesn't get a role..
2014-08-11 10:51:14 +01:00
Jason Williams
8fb3cddcf6 Update express and body-parser dependencies.
No Issue
- Upgrade to versions of these packages that use qs >= 1.0.0.
2014-08-11 05:20:31 +00:00
Hannah Wolfe
988ca127b6 Updating docs links to point to support.ghost.org 2014-08-10 23:17:40 +01:00
Hannah Wolfe
e5771b0b3f Merge pull request #3736 from novaugust/ghost-burgers
Fix -navbar events attachment
2014-08-10 22:45:50 +01:00
Matt Enlow
d61e37e799 Fix -navbar events attachment
Closes #3623
- Move hamburger logic to action with terrible name, "toggleSidebarOrGoHome"
- Move ".js-close-sidebar" events to a document.on(event, *selector*, f) to make sure they attach even when the js-close-sidebars aren't on page (ie, hidenav)
2014-08-10 15:31:47 -06:00
Sebastian Gierlinger
85a1902294 Merge pull request #3735 from ErisDS/cache-invalidation
Adding author pages to cache invalidation
2014-08-10 22:01:19 +02:00
Sebastian Gierlinger
d167bb4ff4 Merge pull request #3731 from ErisDS/issue-3724
Expose blog URL to client app
2014-08-10 20:51:45 +02:00
Hannah Wolfe
d556f4723e Adding author pages to cache invalidation 2014-08-10 19:32:46 +01:00
Hannah Wolfe
90fc933f08 Merge pull request #3730 from jyek/auth-route
Update authentication endpoint for subdirectory
2014-08-10 19:23:31 +01:00
Hannah Wolfe
32d72d5daa Expose blog URL to client app
fixes #3724

 - provide config.url to the ember client app via a data attribute
 - create server and client side helpers to output the URL
 - wire up the client side helper
 - add a class for testing, and add tests for both the server and client side
2014-08-10 18:49:37 +01:00
Justin Yek
8393ba727b Update authentication endpoint for subdirectory
Fixes bug where user is unable to log into admin when subdirectory is specified
2014-08-11 01:29:36 +08:00
Robert Jackson
569fb34a1f
Use the ghost-paths consistently.
Always using the utility function ensures that we have the ability to
update/change/etc these paths without scouring the codebase.

For example, if we ever decide to bump the API version it would be nice
if there was only one location it needed to be updated at.
2014-08-10 13:10:29 -04:00
Hannah Wolfe
d210e400b0 Merge pull request #3729 from rwjblue/ensure-author-in-psm-is-reset
Ensure PSM author is reset when changing posts.
2014-08-10 16:26:36 +01:00
Hannah Wolfe
c12b92582c Merge pull request #3722 from hswolff/rss-atom-url
Fix rss content's url to the RSS feed
2014-08-10 16:01:54 +01:00
Robert Jackson
4752fb77c9
Ensure PSM author is reset when changing posts. 2014-08-10 10:40:04 -04:00
Hannah Wolfe
957b1566de Merge pull request #3723 from JohnONolan/wrong-slug
Fix wrong author slug on user settings page
2014-08-10 15:36:01 +01:00
Hannah Wolfe
2d2e61676d MU Importer - Assign objects correctly
fixes #3716

- change the importer to not override any user details
- only set published_by if it is not already set
- import users before anything else
- process the import and map user ids to existing users
- test fix - owner should have owner role
- test fix - catch invalid success in importer
2014-08-10 14:49:23 +01:00
John O'Nolan
85809a8b82 Fix wrong author slug on user settings page 2014-08-10 10:37:28 +03:00
Harry Wolff
5d70604f9b Fix rss content's url to the RSS feed
fixes #3719

- correctly sets the path to the RSS feed for tags and authors
2014-08-09 23:16:27 -04:00
Felix Rieseberg
c4aeab1fde Fix 'broken' debug tools template
closes #3715
- Includes wrapper class for @pauladamdavis css
2014-08-09 09:20:50 -07:00
Felix Rieseberg
4269ca94fa Error if user has already been invited
closes #3681
2014-08-08 16:41:16 -07:00
Hannah Wolfe
d6b62501c0 Merge pull request #3706 from jaswilli/invite-fixup
Close invite user modal immediately after submit.
2014-08-08 22:58:29 +01:00
Hannah Wolfe
2472637321 Merge pull request #3704 from javorszky/iss3649
Sends test email to the person who clicked on the button
2014-08-08 22:54:21 +01:00
Hannah Wolfe
78929cab1a Merge pull request #3705 from wjake/issue-3663
Reset forgotten form on success
2014-08-08 22:45:53 +01:00
Hannah Wolfe
4d4efe26ae Merge pull request #3702 from ErisDS/issue-3694
Switch middleware order to result in proper error
2014-08-08 22:44:30 +01:00
Jason Williams
d488454f10 Close invite user modal immediately after submit.
Closes #3672, Closes #3673, Closes #3680
- Close and reset modal immediately after submit instead
  of waiting until after processing has finished.
2014-08-08 20:44:03 +00:00
Gabor Javorszky
508f669a49 Sends test email to the person who clicked on the button
Closes #3649

* Small refactor of the api route for email test. We no longer need to look up the email in the settings
* Added a user model lookup based on context to the test email method.
2014-08-08 18:41:14 +01:00
Hannah Wolfe
56d29d0206 Merge pull request #3697 from novaugust/close-modal#3652
Close modals when clicking off them
2014-08-08 18:05:13 +01:00
Hannah Wolfe
2d82617726 Merge pull request #3696 from rwjblue/do-not-focus-post-title
Do not focus post title when editing.
2014-08-08 18:03:00 +01:00
Hannah Wolfe
7d37a829c3 Switch middleware order to result in proper error
fixes #3694

- Split the res.isAdmin check out into it's own thing because we need to detect whether we are in the admin, before everything else
2014-08-08 17:17:07 +01:00
Robert Jackson
1d360b3d18
Do not focus post title when editing. 2014-08-08 11:37:24 -04:00
David Balderston
99e77cab3c Removed Username From Initial Blog Description
closes #3631
- Removed the 'by + setupUser.name' from authentication.js
- Removed the 'by Test User' from feed_test.js
- Added a '.' to the end of each per issue comment example
2014-08-08 08:04:46 -07:00
Matt Enlow
1e4d11c734 Close modals when clicking off them
Closes #3652
2014-08-08 08:33:42 -06:00
Hannah Wolfe
8cf270aad2 Merge pull request #3693 from sebgie/issue#3623
Fix Ghost icon is not clickable
2014-08-08 14:38:06 +01:00
Hannah Wolfe
918a911d3f Merge pull request #3686 from sebgie/issue#3660
Improve error handling for authentication
2014-08-08 14:25:40 +01:00
Sebastian Gierlinger
9e65b47007 Merge pull request #3695 from ErisDS/issue-3657
Don't require protocol for website
2014-08-08 15:24:25 +02:00
Hannah Wolfe
648b503cff Merge pull request #3690 from sebgie/issue#3659
Improve handling of SQLITE_READONLY
2014-08-08 14:18:29 +01:00
Hannah Wolfe
e01046df11 Don't require protocol for website
fixes #3657

- we didn't require this previously, and adding it causes issues
2014-08-08 14:15:49 +01:00
Sebastian Gierlinger
d5a34d72e6 Merge pull request #3688 from ErisDS/issue-3658
Catch user validation errors on login
2014-08-08 15:07:37 +02:00
Hannah Wolfe
8d46705dbb Disable user validation and errors on login
fixes #3658

- Catch any errors from user.save() events during login
- Prevent validation from happening at all when only updating status/last_login
- Fixes a problem I introduced with errors which are arrays in logError
2014-08-08 13:12:17 +01:00
Sebastian Gierlinger
22f147c995 Fix Ghost icon is not clickable
closes #3623
- Initialization of the link was done on login page where the ‚burger‘
did not exist.
- initialization in application needs to be done to make it work on
refresh
2014-08-08 13:53:56 +02:00
Sebastian Gierlinger
9cedd1a2b9 Imporve handling of SQLITE_READONLY
closes #3659
- added alternate context/help for SQLITE_READONY error to
errors.logError()
2014-08-08 11:16:51 +02:00
Sebastian Gierlinger
649a0872ec Improve error handling for authentication
closes #3660
- added wrapping in JSON API format to error500()
- added client side handling
2014-08-08 09:44:24 +02:00
Jake Wright
f95a3d349d Reset email form value on success
closes #3663
- Set value of email input as nil string
2014-08-08 02:52:19 +01:00
Hannah Wolfe
8e17efeac9 Merge pull request #3656 from rwjblue/activate-specific-tab-not-toggle
Activate specific tab that is tapped/clicked.
2014-08-07 19:32:14 +01:00
Hannah Wolfe
ae0edc5674 Merge pull request #3655 from rwjblue/dont-loop-keyboard-nav
Do not loop keyboard nav on content list.
2014-08-07 19:30:48 +01:00
Hannah Wolfe
f7664194ca Merge pull request #3628 from novaugust/popover-btn-binding#3603
Add open class to popover buttons
2014-08-07 19:27:46 +01:00
Robert Jackson
493fe8183b
Activate specific tab that is tapped/clicked. 2014-08-07 09:32:10 -04:00
Robert Jackson
b7b797e2fb
Do not loop keyboard nav on content list. 2014-08-07 09:15:24 -04:00
Felix Rieseberg
39f10228f6 Editor: Warn if title change is unsaved
closes #3643
- TitleScratch is compared with Title; if there’s a difference, we have
unsaved changes and open up the modal.
2014-08-06 20:39:19 -07:00
Felix Rieseberg
8453067d70 Accept all versions of 'edit' as URL parameter
closes #3644
2014-08-06 20:07:41 -07:00
Matt Enlow
1f608cf5ab Add open class to popover buttons
Ref#3603
- Popover Buttons now have an `open` class applied to them when their popover is open
- The open class is removed from the popover button at the start of the popover's fadeout
- Consolidated common code into popover-mixin
2014-08-06 18:23:03 -06:00
Hannah Wolfe
4b83dfd6ab Merge pull request #3633 from halfdan/3630-revoke-user
Fix revoke user invite and user.destroy
2014-08-06 22:29:33 +01:00
Fabian Becker
9915fb1268 Fix revoke user invite and user.destroy
fixes #3630
- Extend user adapter in ember to load users with status: all
- Fix user.destroy by loading all users with status: all
2014-08-06 16:48:18 +00:00
shindakun
adbd32c51d Transition to signin with error message on invalid token not 500 error screen
closes #3548
- Add error to hidenav, removes menubar from error screen.
- Wrap atob() in a try/catch
- Added regex to try and validate if params.token at least looks like base64
2014-08-06 08:08:02 -07:00
Hannah Wolfe
c95c9b45cb Merge pull request #3621 from sebgie/fix-refresh-token
Fix token refresh
2014-08-06 10:34:20 +01:00
Sebastian Gierlinger
3908dbdf8f Merge pull request #3620 from ErisDS/issue-3589
Cleaner spam prevention error messages
2014-08-06 11:17:29 +02:00
Sebastian Gierlinger
b2e9d21018 Fix token refresh
no issue
- spam prevention causes token refresh to return an error
2014-08-06 11:11:44 +02:00
Hannah Wolfe
e315148cc5 Cleaner spam prevention error messages
closes #3589

- Full error messages appear in stderr
- Clean error messages for user
2014-08-06 10:00:21 +01:00
Sebastian Gierlinger
1219817628 Merge pull request #3613 from ErisDS/update-notification
Improved Update Notification
2014-08-06 10:55:47 +02:00
Waleed Ali
7009d416cb Improve settings error handling
closes #3450
- Added no-permission error handling for settings edit API.
- In Authentication API integration test, updated the initOwnerUser
  function to insert the roles and user_roles for the owner user so the
  owner can edit settings after adding the no-permission error handling. I
  also added the mail send permission to the test since it's used after
  the user edits the settings.
2014-08-06 09:11:50 +01:00
Robert Jackson
8d2b26daea Restore original display after window resizing.
fixes #3597
2014-08-06 09:04:43 +01:00
Sebastian Gierlinger
22171fd058 Merge pull request #3611 from ErisDS/author-classes
Adding missing body class for author pages
2014-08-06 09:37:06 +02:00
Hannah Wolfe
03a46a0b24 Improved Update Notification
- adding a version number to the notification
- adding a link to the upgrade docs, to make this process easier.
2014-08-06 08:33:00 +01:00
Hannah Wolfe
c4f74097f8 Merge pull request #3618 from jaswilli/issue-3612
Check for server notifications on hard refresh
2014-08-06 08:13:23 +01:00
Sebastian Gierlinger
b6fdcc268e Merge pull request #3614 from ErisDS/remove-apps
No apps screen for 0.5
2014-08-06 08:51:07 +02:00
Jason Williams
fb64de54f6 Check for server notifications on hard refresh
Closes #3612
- Trigger the loadServerNotifications event from the
  ApplicationRoute's afterModel hook, which gets called
  every time the app gets loaded.
2014-08-06 05:01:00 +00:00
Hannah Wolfe
9fb34d6b27 Merge pull request #3550 from halfdan/3542-forgotten-user
Properly show message when resetting password.
2014-08-06 02:18:30 +01:00
Jason Williams
a950e559e7 Cleanup from notifications refactor.
Refs #3521
2014-08-06 00:13:56 +00:00
Hannah Wolfe
6b747be1c1 No apps screen for 0.5
no issue

- The apps screen is nowhere near ready for prime time yet, lets not have
  it in 0.5 at all
2014-08-06 00:54:57 +01:00
Hannah Wolfe
9419f9bbe4 Adding missing body class for author pages
closes #3606
2014-08-05 23:38:57 +01:00
Fabian Becker
a2d5105bcc Changing User.read API to default to active users.
refs #3542
- Properly handle forgotten screen (ember)
- Change Users API to only return active users on read
- Adjust tests
2014-08-06 00:30:48 +02:00
Hannah Wolfe
2326d49e77 Merge pull request #3602 from jaswilli/import-tests
Add catch handlers to import tests.
2014-08-05 22:02:21 +01:00
Paul Adam Davis
6615f7aad3 Swap notification close link for a button
No issue

- Swap out notification <a> close link for <button> (gains a native hover state)
2014-08-05 20:08:03 +01:00
Hannah Wolfe
a2ceffc199 Merge pull request #3590 from felixrieseberg/iss3518
Ghost Logo navigation responds correctly to mobile
2014-08-05 19:08:30 +01:00
Jason Williams
18d12290ff Add catch handlers to import tests.
Refs #3473
- Some tests are checking to make sure errors by using a
  catch handler on the test.  When assertions fail done()
  is never called and results in a mocha timeout, which makes
  it harder to see the cause of the failure.
2014-08-05 18:01:24 +00:00
Hannah Wolfe
28c20cba5d Merge pull request #3596 from sebgie/issue#3518
Add owner role to setup user
2014-08-05 19:01:06 +01:00
Sebastian Gierlinger
5590628d54 Merge pull request #3600 from ErisDS/author-helper
Fix the author context block
2014-08-05 19:59:53 +02:00
Felix Rieseberg
e2348e6802 Ghost Logo navigation responds correctly to mobile
closes #3522
- Previously, the logo had a href attribute which was manually kept
from executing on mobile. Slow mobile devices that didn’t fully load
the JS would therefore navigate “desktop style”
- The href attribute is now set after the event handler has been loaded, ensuring correct navigation behaviour.
2014-08-05 10:05:32 -07:00
Hannah Wolfe
157cf5c3b9 Fix the author context block
fixes #3599

- If the author helper is called as a block (i.e. fn is present) then
  treat it as a with call
2014-08-05 17:03:13 +01:00
Hannah Wolfe
afa4a5299a Merge pull request #3598 from sebgie/fix-embedded-code
Fix embedded code being removed
2014-08-05 16:51:35 +01:00
Hannah Wolfe
014f16991e Merge pull request #3595 from sebgie/issue#3544
Improve spam prevention
2014-08-05 16:50:56 +01:00
Sebastian Gierlinger
aec440bbd0 Fix embedded code being removed
no issue
- changed order of escaping
2014-08-05 14:11:20 +02:00
Sebastian Gierlinger
766e6ff944 Add owner role to setup user
closes #3518
- added owner role to user that is added if no user is available
2014-08-05 13:48:10 +02:00
Hannah Wolfe
954fde1cd2 Cleaning up old html files 2014-08-05 12:02:58 +01:00
Sebastian Gierlinger
c62d7ba43e Improve spam prevention
closes #3544
- limit forgotten password requests to five requests per IP per hour
for different email addresses
- limit forgotten password requests to five requests per email address
- limit signin requests to ten failed requests per IP per hour
- removed special treatment for tests
2014-08-05 12:58:58 +02:00
Hannah Wolfe
1b8c8c27c1 Merge pull request #3593 from morficus/issue-3563
prevent revoking invite for already active users
2014-08-05 11:57:16 +01:00
Sebastian Gierlinger
0a3b070ed1 Merge pull request #3587 from PaulAdamDavis/settings-header-classes
Add classes to settings headers
2014-08-05 09:46:21 +02:00
Maurice Williams
18a1be8850 prevent revoking invite for already active users
closes #3563
- before attempting to revoke an invitation, get updated model info
- reload route and show warning if user info has changed
2014-08-05 00:35:46 -04:00
Felix Rieseberg
6645f7c65a Working delete user modal & button
closes #3529
- Created ‘delete user’ modal (similar to the ‘delete post’ modal) and
controller
-  Modal will be opened if ‘Delete User’ is selected in the user
setting cog menu
2014-08-04 13:29:24 -07:00
Paul Adam Davis
4948994cca Add classes to settings headers
No issue

Refs https://github.com/TryGhost/Ghost-UI/issues/91

- Adds a class to settings page headers, for cleaner CSS selectors
2014-08-04 12:53:55 +01:00
Sebastian Gierlinger
89389b3673 Merge pull request #3569 from morficus/issue-3549
fix most recent post stolen by the last logged in user AND only show active users in post-settings-menu drop-down
2014-08-04 10:51:07 +02:00
Sebastian Gierlinger
c3e7b48a6d Merge pull request #3581 from felixrieseberg/iss3541
Autofocus on input fields after routing
2014-08-03 22:22:48 +02:00
Hannah Wolfe
ac4c3a1d62 Merge pull request #3500 from novaugust/markdown-help
Update markdown help modal
2014-08-03 18:05:12 +01:00
Hannah Wolfe
e12f8bb624 Merge pull request #3567 from novaugust/issue#3564
Return to invite new user; invite multiple users in one go
2014-08-03 17:54:59 +01:00
Matt Enlow
07cd654ab9 Return to invite new user; invite multiple users in one go
Closes #3533, Closes #3547, Closes #3531
- invite-new-user always resets role to author now, allowing for multiple invites on one load
- Added confirm action when hitting return in INUModal's email input
- Don't pass users as the model to invite-new-user-modal
- Move invite-new-user reset to a `finally` clause
- invite-new-user always closes on a confirm
2014-08-03 10:31:42 -06:00
Hannah Wolfe
0d5e199632 Merge pull request #3580 from felixrieseberg/iss3543
Insert inline code shortcut for editor
2014-08-03 17:28:39 +01:00
Hannah Wolfe
27710e88d2 Merge pull request #3578 from morficus/issue-3516
Stop event propagation when hitting "enter" in the gh-blur-input component
2014-08-03 17:25:29 +01:00
Hannah Wolfe
a1dad7b59d Merge pull request #3576 from morficus/issue-3523
Error modifying "author" attribute before post record has been created
2014-08-03 17:24:09 +01:00
Matt Enlow
0c2ad482fa Update markdown help modal
Closes #3499
- Swapped out "Cmd" for the symbol. We're all UTF8, right?
- Removed hint for "Inline Code" until we readd its shortcut
2014-08-03 10:24:00 -06:00