Commit Graph

2213 Commits

Author SHA1 Message Date
Kevin Ansfield
96bcf99332 Added Ctrl/Cmd+P shortcut in editor to open preview in new tab
no issue

- allows quick access to the preview without having to open post settings menu and click the preview link or hit Ctrl/Cmd+S and click the link in the success notification
2020-10-19 08:25:26 +01:00
Kevin Ansfield
95aa341468 Added max length validation to snippet's name field 2020-10-16 19:22:09 +01:00
Kevin Ansfield
3d48ce6bc4 Fixed snippets not loading in background when accessing editor
no issue

- add the missing snippets API query to the editor's background loaded
2020-10-16 19:22:09 +01:00
Peter Zimon
94077449b3 Update portal settings (#1731)
* Added auto focusing preview on the signup page while being on links and clicking on any setting in the sidebar

* Refine upload custom portal icon button

* Updated copy for sidebar and links screen

* Added grouping to links list
2020-10-16 15:34:22 +02:00
Kevin Ansfield
7e169a2a86 Renamed snippet.title to snippet.name for consistency
no issue

- all of our models which allow users to name something use `name` as the field descriptor rather than `title` so `snippet.title` was renamed for consistency
- also fixes typo in the plus-menu component that stopped clicking on snippets from working
2020-10-16 10:15:07 +01:00
Kevin Ansfield
b590ce1b95 Implemented first iteration of content snippets
closes https://github.com/TryGhost/Team/issues/411

- adds "Create snippet" icon to the editor toolbar
- uses the same link input component design for specifying snippet titles
- snippets are loaded in the background when the editor is accessed
- snippets are listed at the bottom of the card menus of the + and / menus
- clicking a snippet inserts the snippet's contents in place of the current blank section
2020-10-15 18:03:35 +01:00
Peter Zimon
bc779bb3e7 Fixed 'null' portal button text
no refs.
- fixing portal button displaying 'null' if the portal button text input field is empty
2020-10-14 14:47:08 +02:00
Peter Zimon
eede9e1141 Updated Portal links design
no refs.
- in Portal settings domain and the path are separated visually so that it conveys the concept of using the relative URL instead of absolute
- for similar reasons, copy link copies only the path part
2020-10-12 13:56:37 +02:00
Peter Zimon
d567e975d2 Removed full stop from scheduling text in editor
no refs.
2020-10-09 16:56:37 +02:00
Peter Zimon
a7c0dc7469 Fixed account menu margin
no refs.
- fixes account menu dropdown button margins disappearing on Firefox for smaller screensizes
2020-10-09 16:56:13 +02:00
Kevin Ansfield
a8f63f9343 Fixed usage of {{enable-developer-experiments}} without sub-expression syntax 2020-10-09 15:52:23 +01:00
Kevin Ansfield
a3d3632e97 Added developer experiments indication to about page
no issue

- without this there's no indication the config flag is set when you have no access to the config file or you don't know which features are currently behind the flag
2020-10-09 11:38:47 +01:00
Kevin Ansfield
235d5f1b8b Added {{enable-developer-experiments}} helper
no issue

- removes the need to have component backing classes with the `config` service injected
2020-10-09 11:10:39 +01:00
Peter Zimon
47a045a935 Updated scheduling copy
no refs.
- updated moment locale to display '1 minute' instead of 'a minute' to be more explicit about scheduled time
- removed full stop from the scheduler message in editor header
2020-10-02 10:45:49 +02:00
Kevin Ansfield
fa240cae53 Fixed content jiggle when selecting cards and card code background position
no issue

- borders are necessary on selected cards to keep consistent spacing between selected/non-selected cards
  - use transparent borders in dark mode rather than eliminating borders
- moved transparent card background style to `_koenig-dark.css` so it only affects dark mode - we want to keep the background colour for light mode so that we don't get mis-aligned backgrounds in certain cards
2020-10-01 16:56:30 +01:00
Kevin Ansfield
171cec2b4e 🐛 Fixed first set of members appearing twice in members list
closes https://github.com/TryGhost/Ghost/issues/12241

- `ella-sparse` exposes a `range.page` property which we can use instead of trying to calculate the page number ourselves
2020-10-01 11:21:34 +01:00
Kevin Ansfield
db68f0248b Update dependency ember-in-viewport to v3.8.0
no issue

- now that we no longer have the `ember-sticky-element` dependency we're free to upgrade `ember-in-viewport`
- remove package.json resolution so latest version gets installed
- remove ember-in-viewport from renovate ignore config
- update `<GhScrollTrigger>` to match latest `ember-in-viewport` usage and convert to a glimmer component
  - ensure `scrollableArea` is always set so that the trigger doesn't stop working after the first trigger
2020-10-01 10:06:53 +01:00
Rish
245dbef994 Allowed empty accent color in portal preview
no issue

- Current logic was not setting empty accent color in portal preview which was misleading when no accent color is set
- Updated preview url to contain empty accent color which is picked by Portal preview
2020-10-01 12:28:24 +05:30
Fabien O'Carroll
a93c9bebe9 Updated magic link expiry information to 24 hours
no-issue

Since https://github.com/TryGhost/Ghost/commit/fd5194ea magic links have
a 24 hour expiry
2020-09-30 10:56:12 +01:00
Fabien 'egg' O'Carroll
177d6f773d 🐛 Fixed tag metadata fields not being populated when editing in admin (#1714)
closes #12190

The "scratch" concept was being used incorrectly for codeinjection fields and was not initialised with all the required fields.
2020-09-28 16:20:53 +01:00
Peter Zimon
da81765bd9 Fixed publication logo display proportions
no refs.
- fixed the styles for publication logo in general settings so that the logo is displayed with correct ratio regardless of its proportions
2020-09-28 14:14:16 +02:00
Peter Zimon
4142b98cdf Fixed loading spinner size for Portal icons
no refs.
- fixed oversized loading spinner for Portal icons
2020-09-24 10:00:22 +02:00
Rish
c7696ca03b Renamed members-modal naming to portal
no issue

- Updated naming for members modal to portal in sync with rest of the codebase
2020-09-24 12:19:35 +05:30
Fabien 'egg' O'Carroll
6ecb38eaa5 Added support for filtering the exported Members CSV (#1716)
no-issue

Co-authored-by: Peter Zimon <zimo@ghost.org>
2020-09-23 14:29:47 +01:00
Rishabh Garg
f1fbbe4685 🐛 Fixed social settings not saved on keyboard shortcut (#1633)
no issue

- Social account(twitter/facebook) values in general settings were only updated to settings upstream on focus out
- Uses `notifyPropertyChange` to avoid multiple `.set()` workarounds

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-09-23 16:58:48 +05:30
Umur Dinçer
2051b65e51 🐛 Fixed missing start date in members chart (#1644)
closes https://github.com/TryGhost/Ghost/issues/12014

- `startDateLabel` was never populated after refactoring the members chart to use the members stats service
- use the first date that's returned as part of the members stats days array so that we can account for any potential time period being selected

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-09-22 08:51:29 +01:00
Paul Davis
8062fa8994 Added margin to bottom of Admin when installed as PWA on newer iOS devices (#1667)
no issue

On newer iOS devices with no home button, we have this bar at the bottom of the screen instead. When installed as a PWA, the mobile nav sits under that bar. I'm unsure how much Ghost is used this way, but this is a small QOL improvement for those who do.

This PR uses the native `env` CSS custom properties Safari has to add a propriety amount of `padding-bottom` to the mobile nav bar, and also the global container to prevent anything in the iframe from being hidden by the taller nav bar. If the device does not support these `env` vars, is has no adverse affect. In order for this to work, the `<meta name="viewport" />` tag needs `viewport-fit=cover` added to it.

MDN docs for reference: https://developer.mozilla.org/en-US/docs/Web/CSS/env
2020-09-22 07:43:17 +01:00
Kukhyeon Heo
c38ca94683 🐛 Fixed Ctrl/Cmd+S triggering browser save when tags or authors input has focus (#1707)
closes https://github.com/TryGhost/Ghost/issues/11786

`GhTokenInput` uses `PowerSelect` component of `ember-power-select` internally in `app/components/gh-token-input/select-multiple`. 

When you open that component, [you can find](d36f38f39e/addon/components/power-select.ts (L262-L278)) that it calls `stopImmediatePropagation` when ctrl/cmd or meta key is down.

```js
  handleTriggerKeydown(e: KeyboardEvent) {
    if (this.args.onKeydown && this.args.onKeydown(this.storedAPI, e) === false) {
      e.stopImmediatePropagation();
      return;
    }
    if (e.ctrlKey || e.metaKey) {
      e.stopImmediatePropagation();
      return;
    }
    if ((e.keyCode >= 48 && e.keyCode <= 90) || isNumpadKeyEvent(e)) { // Keys 0-9, a-z or numpad keys
      (this.triggerTypingTask as unknown as Performable).perform(e);
    } else if (e.keyCode === 32) {  // Space
      this._handleKeySpace(this.storedAPI, e);
    } else {
      return this._routeKeydown(this.storedAPI, e);
    }
  }
```

Because of that, I had to dispatch event directly to the root of the Ghost admin app.
2020-09-21 18:14:57 +01:00
Fabien 'egg' O'Carroll
213434c389 Updated magic link expiry information to 4 hours (#1715)
no-issue

Since https://github.com/TryGhost/Ghost/pull/12218 magic links now have
an expiry of 4 hours.
2020-09-21 16:08:10 +01:00
Rish
ede24fec24 Moved Portal settings behind dedicated flag
no issue
depends on https://github.com/TryGhost/Ghost/pull/12211

- Other than dev flag, the Portal is now also enabled behind a dedicated `portal` flag
- Shows/hides Portal settings based on dev or Portal flag
2020-09-17 19:50:41 +05:30
Peter Zimon
6dc0489b7b Updated Portal icons
no refs.

- updated Portal icons so that it matches the one on members.js
2020-09-16 16:04:38 +02:00
Sanne de Vries
710d6178c1 Added message box on Staff user page that indicates user is locked, and improved boxes naming and styling 2020-09-16 15:37:33 +02:00
Peter Zimon
fc3d83e869 Fixed date format in member Stripe details
no refs.
2020-09-15 07:33:58 +02:00
Sanne de Vries
3c6923989e Changed locked state badge into lock icon and clarified its meaning with tooltip on hover. This commit builds on top of PR #1668 2020-09-14 12:34:18 +02:00
Sanne de Vries
6a7745c9a8 Adjusted dark mode styling of top menu dropdowns on the members page for consistency 2020-09-08 17:56:50 +02:00
Sanne de Vries
7898e22e82 Removed white background and border in code editor in dark mode 2020-09-04 22:17:43 +02:00
Sanne de Vries
5cbd9f0f78 Adjusted code injection fields in settings to dark mode 2020-09-04 21:41:19 +02:00
Peter Zimon
ed1433b809 Added logic to custom portal icon delete
no refs.
- fixed issue that users can't reselect custom icon in portal by making the delete button only visible when the custom icon is selected
2020-09-04 16:10:46 +02:00
Peter Zimon
d65195aba4 Portal custom icon style refinement
no refs.
- refined delete icon style for portal
- refined icon sizes
2020-09-04 15:59:13 +02:00
Sanne de Vries
11699d5172 Fixed transparent background pattern for blog logo and icon in dark mode 2020-09-04 15:25:32 +02:00
Sanne de Vries
0b27a366ff Adjusted styling for user role badges in light and dark mode for improved consistency 2020-09-04 15:25:32 +02:00
Daniel Lockyer
a8ce77b1f7 Removed warning banner for mobile/tablet devices
closes https://github.com/TryGhost/Team/issues/347

- removes the warning banner directing users to use Ghost Desktop/a
  desktop browser because users are happy with the experience of editing
  on mobile/tablets
2020-09-03 17:55:45 +01:00
Daniel Lockyer
47f428b9af Removed suggestion to use Ghost-Desktop
- Ghost-Desktop is now deprecated and so we shouldn't suggest it to
  users
2020-09-03 13:16:44 +01:00
Peter Zimon
4ec6aa3d3e Success button fixes in member email settings
no refs.
- fixed checkmark being too small on support or newsletter success button
- fixed case style for success button
2020-09-02 20:45:52 +02:00
Sanne de Vries
53c2879838 Improved calendar styling in publish and schedule datepickers 2020-09-02 10:32:45 +02:00
Rish
4fa2912bc3 Fixed missing signup text value in Portal preview
closes https://github.com/TryGhost/members.js/issues/91

- Fixes the missing signup text value in input box as it was incorrectly reading from wrong place
2020-09-02 13:28:51 +05:30
Sanne de Vries
03da71cfde Improved date-picker spacing in post publish menu and settings menu 2020-09-01 16:43:22 +02:00
Sanne de Vries
bf6e37f2dd Fixed account menu spacing issue (#1693)
* Fixed spacing issue with account menu by changing verticalPosition of the Ember dropdown component to 'above' and adjusted the top attribute as needed.
2020-09-01 12:44:50 +02:00
Rish
eefbb55d84 Added new support and reply-to address for members
no issue

- Adds 2 new email address fields for members in email settings section - support address and reply-to address
- Support address - Is used for member auth emails as well as in themes and Portal for allowing members to contact support.
- Reply-to address - Is used to set `reply-to` address for newsletter emails that allows configuring where member's reply to emails will go
- Disabled from address update for empty value
- Updated success toast message and copy for from/support address update
- Changed section title + description for email addresses
- Added "public" to support email description
2020-08-31 18:10:26 +05:30
Sanne de Vries
f068f85e38 Improved spacing for account menu 2020-08-31 12:25:55 +02:00