Commit Graph

314 Commits

Author SHA1 Message Date
Hannah Wolfe
06959661c0 Misc grunt /dev updates
- Updated all dev dependencies in the root package.json
- Added `--colors` to mocha when called from grunt test:... so that works better
- Removed non-unit tests from coverage, because they're just not useful
- Updated docker config to generate useful docs again - as a statement of intent, I also updated docs in key files
- Setup grunt watch-docs task for documentation writing easyness
2015-05-28 20:25:14 +01:00
John O'Nolan
13ec196f2e Refactor about page 2015-05-22 19:05:15 +01:00
John O'Nolan
3e6cf30cfd Automate CSScomb 2015-05-22 19:05:11 +01:00
John O'Nolan
208999a77f Introduce CSScomb 2015-05-22 19:05:10 +01:00
John O'Nolan
1daee7cff1 New onboarding markup and styles 2015-05-22 17:50:13 +01:00
Hannah Wolfe
da8752cc88 Merge pull request #5290 from josephwegner/chalk-colors-swap
replace colors with chalk everywhere
2015-05-21 16:28:41 +01:00
Joe Wegner
f26179ae6a replace colors with chalk everywhere
issue #5259
- removes the colors dependency
- adds in chalk dependency, and migrates everything to use that
- reduces some specs now that the log calls are cleaner
2015-05-19 11:07:40 -05:00
Hannah Wolfe
050b03d2bd Cache control middleware refactor
refs #5286

- split cache control middleware into its own file
- split out cache control tests
- add new mochacli command for running just middleware tests
2015-05-18 22:20:26 +01:00
Hannah Wolfe
8e8f4125f4 Improve grunt clean & add grunt test-ember
no issue
- old grunt testem task didn't work - has been renamed and fixed
- grunt clean task updated to clear out dependencies, making it more useful for helping fix cludged envs
2015-05-17 22:41:49 +01:00
Sebastian Gierlinger
a0330b2418 Remove task from test-all
no issue
- listing takes like forever and stalls running the tests during
development
- grunt test-all only runs tests, make sure to run grunt validate
before submitting a PR
2015-04-22 22:39:35 +02:00
Hannah Wolfe
7c1159616b Fix issue with npm-shrinkwrap in release
- wrong order of commands prevented shrinkwrap file from being correctly included in zip file
2015-04-22 17:46:26 +01:00
Hannah Wolfe
6d04ead9f2 Switch test coverage to use Istanbul
closes #4644

- Switch from using blanket to istanbul
- Rename some test files for consistency (and so that they will run)
2015-04-19 15:54:05 +01:00
Hannah Wolfe
e1258f4002 Fixing ember build
- removing --silent so we can see errors
- pinning dependencies
- the error with normalize is resolved by pinning ember-cli-sass to 3.1.0, and breaks if upgrading to 3.1.1 as a result of issues with libsass
2015-03-31 10:50:13 +02:00
cobbspur
511d69cd1c Fix ember-cli commands to work with windows 2015-03-19 18:48:41 +00:00
Matt Enlow
58635b3e0a Serve files to core/built/assets/
- see core/client/lib/assets-delivery/index.js for how this is done
- Turn off ember-cli fingerprinting
- ember-cli 0.2.0; Update .npmignore
- Fallback to old version of ember-cli-sass due to lib-sass errors
- Keep ember-data at beta-14.1 until we find the dep that's breaking on snapshot.attr
- Fix release task to ignore blank lines in .npmignore
2015-03-12 15:59:02 -06:00
Matt Enlow
c7535c42cf Remove client/docs 2015-03-11 12:37:42 -06:00
Jason Williams
5b72a0eb18 fix routes test. ember-mocha@0.4.2 2015-03-11 12:37:42 -06:00
Jason Williams
e492c43067 Fix up ember-cli generated files and misc jscs/jshint errors 2015-03-11 12:37:42 -06:00
Jason Williams
184da01702 Change grunt jshint and jscs tasks 2015-03-11 12:37:42 -06:00
Jason Williams
0b96765321 Set up tests for ember-cli 2015-03-11 12:37:41 -06:00
Matt Enlow
9e7658f98d grunt init, dev
- added grunt-bg-shell
- reorganized asset tasks into one location
- turn off ember-cli analytics
- remove app/config-dev and config-prod
- remove qunit from bower.json
- remove express from package.json
2015-03-11 12:37:41 -06:00
Hannah Wolfe
fa9335290d No more source maps in grunt prod
refs #4955

- needed to build on ubuntu 14.14 with node 12 (DO image)
- barely used anyway, as release task has it disabled
2015-03-09 17:38:08 +00:00
Hannah Wolfe
65fe7374f9 Adding npm shrinkwrap during release 2015-02-27 17:15:38 +00:00
Sebastian Gierlinger
2032410690 Merge pull request #4924 from ErisDS/issue-2990-grunt-testem
Add grunt testem alias + some DRY in Gruntfile.js
2015-02-18 19:53:52 +01:00
Hannah Wolfe
196cd8971e Add grunt testem alias + some DRY in Gruntfile.js
refs #2990

- add an alias for grunt testem
- add test-setup task to dry up some tasks
2015-02-17 19:12:29 +00:00
Paul Adam Davis
68eb6b67b0 Drag & Drop Navigation Reordering
Closes #4540

- Implements drag & drop to reorder navigation items
- Adds a `sort` property to navigation items
- Adds a tiny library to enable touch events for drag & drop. It hooks onto jQuery UI.
- Sort nav items before being saved
- Adds `settings-view-navigation` to route for body class
2015-02-12 17:02:46 +00:00
Jason Williams
2a91a1071e Update Ember to 1.10.0
No issue.
- Ember@1.10.0
- Update grunt-ember-templates to version that supports HTMLBars.
- Update Gruntfile.js to compile templates with HTMLBars.
- Convert Handlebars code to its HTMLBars equivalent.
2015-02-09 16:20:16 +00:00
Jason Williams
e0e39aa160 Retry API request when buildAboutPage gets 202
No Issue.
- top-gh-contribs@1.0.0.
- Enable 'retry' option which will retry the GitHub API request
  in the event it receives a status of 202 (retry momentarily).
2015-02-05 18:52:53 +00:00
Paul Adam Davis
f492502f33 Update grunt-sass to 0.17.0
No issue

- Allows us to use Sass Maps
- Fixes the 'compressed' output style, so we can have minified code
again!
2015-02-03 10:33:25 +00:00
Hannah Wolfe
fb46b7d356 Misc test cleanup
refs #4644

- Changes tests using assert style to use should style for consistency
- Updates moment().subtract() to remove deprecation warning
- Changes test and test-coverage grunt commands to run in a way which is
  compatible with both *nix and win envs
- refs #4644 as this is a step towards getting coverage working properly
  again
2015-01-10 11:39:18 +00:00
Jason Williams
1b8796b993 Make authenticated GitHub API requests from Travis
No Issue
- top-gh-contribs@0.0.5
- Add oauth key to .travis.yml with public-only access
2015-01-08 16:21:22 +00:00
Jason Williams
11c7d75b1b Show info on about page task failure
No Issue.
- gh-top-contribs@0.0.4
- package now provides information when a failure occurs.
2015-01-07 17:28:03 +00:00
Robert Jackson
a1ed9adf92
Remove ObjectController proxying behavior.
Ember.ObjectController (and Ember.ArrayController) will be deprecated in
Ember 1.11 (and removed from core in Ember 2.0). The reasoning is
detailed in the Ember 2.0 RFC.

This PR does the following:

* Updates templates/controllers/views to explicitly reference model
  properties (instead of relying on proxying behavior).
* Clearly delineate where certain properties are being set or retrieved
  from (for example it was not clear exactly where `scratch` and
  `titleScratch` were stored).
* Remove usage of `Ember.ObjectController`.
* Add JSCS rule to prevent future PR's from adding regressions.
2015-01-01 21:51:20 -05:00
Jason Williams
8af41b8aee Fail buildAboutPage task on error
No Issue
- If buildAboutPage encounters a problem, fail the task so
  the entire test suite doesn't run only to fail because the
  template partial is missing.
- Cleaned up task.
2014-12-25 16:50:52 +00:00
Hannah Wolfe
13caeaa65e grunt test task - easily run single test files
no issue
- adds a new grunt test task, which takes a file option representing the path to the test file you want to run
E.g. grunt test --file=unit/config_spec.js OR grunt test --file=integration/import_spec.js
- can run any unit, integration or route task
- can easily be expanded to handle running other tests in future
2014-12-24 13:51:16 +00:00
Jason Williams
837446c570 Move testem.json into client tests directory. 2014-12-05 14:53:45 +00:00
Hannah Wolfe
9783f16e76 Adds markdown highlight support
closes #4574

- adds highlight showdown extension with tests
2014-12-04 13:37:29 +00:00
Hannah Wolfe
13757041d9 Merge pull request #4270 from mispy/footnotes2
Footnotes extension for Showdown
2014-12-03 13:38:47 +00:00
Nazar Gargol
df5a598718 Cleans up HTML data attributes on body in default.hbs
closes #4485

- removes data attributes used on body in default.hbs
- introduces new way to generate configuration through meta tags
- config initializer consumes configurations from the meta tags using parser
- moves blog_title helper/value to be a property in a configuration api
2014-11-29 17:09:43 +01:00
Robert Jackson
ef71d932f3
Add initial client unit test. 2014-11-26 23:20:50 -05:00
Hannah Wolfe
d3f70e3b24 Update showdown to showdown-ghost 0.3.4
closes #2675

- update showdown to the newly published showdown-ghost module which has a fix for the lack of language support in codeblocks
2014-11-15 16:37:35 +00:00
Jaiden Mispy
31eea94b18 Add footnotes extension to showdown
refs 1318
- based on Markdown Extra https://michelf.ca/projects/php-markdown/extra/
- allows [^n] for automatic numbering based on sequence
2014-11-11 19:24:04 +11:00
Paul Adam Davis
df69b6ea82 Use nested output style for Sass
References #4389

As a result of https://github.com/TryGhost/Ghost/pull/4389#issuecomment-61637323 the best way to keep everything working nicely is to use the `nested` outputStyle for now.
2014-11-04 14:35:08 +00:00
Paul Adam Davis
4930e9fd65 Update Sass Grunt task output style
No issue

A recent update to NodeSass changed the keyword for output style from `style` to `outputStyle`.
This updates that, thus making the minfied CSS, actually minfied.
2014-11-03 14:13:19 +00:00
Hannah Wolfe
20fbcc1e59 Merge pull request #4335 from jaswilli/jscs
Enable JSCS checking on client.
2014-10-25 19:44:16 +03:00
Jason Williams
0f17378b26 Enable JSCS checking on client.
Refs #4001
- grunt-jscs@0.8.1 which provides ES6 support.
2014-10-25 16:13:04 +00:00
Robert Jackson
a3456b7e1c Remove lodash from admin client.
* Adds `bind`, `isFinite`, and `isNumber` utility functions from lodash.
* Use new util funtions instead of lodash throughout the codebase.
* Remove lodash from vendor builds.
2014-10-23 18:27:09 +00:00
Jason Williams
b28206c899 Output spaces instead of tabs in buildAbout task
No Issue
2014-10-21 16:27:48 +00:00
Paul Adam Davis
6fd27796f4 Implement popovers 2014-10-20 22:09:45 +01:00
Hannah Wolfe
5199a007b5 frontend functional tests -> frontend route tests
no issue

- Some of the tests were duplicated and all of these tests are faster and easier to do with super test as we aren't testing interactions
- Introduced a new test util to toggle permalinks which allows us to test the different structures
- Using cheerio in route tests to test the HTML / XML output is well formed
2014-10-19 21:10:13 +02:00
Hannah Wolfe
2c6d43a0c0 Refactor helpers & tests into individual files
no issue

- Split theme helpers into individual files for each
- Do the same for tests
- Have utils to share some things between them
- Move assetHash onto config
2014-10-14 22:52:40 +02:00
Hannah Wolfe
00ef9cfcb1 Custom showdown extensions should be linted
ref #4243

- Removing /lib/ from the list of things which aren't linted, as this is
  all custom code
- Fixing up the two files to pass linting, erring on the side of caution
  with disabling regexp rules vs fixing regexes!
2014-10-12 15:28:19 +02:00
Mattias Cibien
f2b2cf2519 Clean up hardcoded ghost paths
closes #4144
- made contributors template use the `gh-path` helper
- Removing blogRoot from application.js
- made error image use the `gh-path` helper
2014-10-06 16:33:58 +02:00
Hannah Wolfe
efea8dc502 Moving nanoscroller to be managed by bower 2014-10-05 22:08:36 +01:00
Fabian Becker
40254adc92 Implements module tests
closes #2521
- Add new module tests
- Implements new `test-module` task to specifically run module tests
2014-09-29 22:33:09 +02:00
Hannah Wolfe
0127dd9e6c Adding size param to contrib images
no issue
- reduces filesize significantly, whilst not impacting quality
2014-09-25 10:53:20 +01:00
Matt Enlow
d4bf80430c Update top-gh-contribs to get contributors within last 90 days
Closes #4130
2014-09-24 22:57:45 -06:00
Fabian Becker
a6cf795029 Fixes sass:compress
no ref
- Use absolute path for compress/sourceMap
2014-09-22 01:21:46 +02:00
Hannah Wolfe
94feb8616a Adds grunt lint task for code style checking
no issue

- convenience function runs both jshint and jscs
2014-09-19 15:52:48 +01:00
Harry Wolff
469aaa398c Add jscs task to grunt file and clean up files to adhere to jscs rules.
resolves #1920

- updates all files to conform to style settings.
2014-09-17 21:44:29 -04:00
Julien Gilli
454abc51ce Support --reporter and --reporter-output when running tests.
When running any Grunt task that runs tests with Mocha, the two
following command line options are now supported:
- --reporter: allows to specify a reporter, default is 'spec'.
- --reporter-output: allows to specify a file where Mocha's output will
  be stored.

These two command line options make it easier to retrieve and parse test
results when tests are run on a continuous integration platform like
Jenkins.

Fixes #4038.
2014-09-17 15:46:39 -07:00
Paul Adam Davis
9b94e71805 Static nanoscroller integration
References #1892

A static integration of https://github.com/jamesflorentino/nanoScrollerJS



This is WIP with the goal of getting feedback on and deciding how we should integrate this into Ghost.
2014-09-14 17:15:57 +01:00
Matt Enlow
12cb93e333 Merge pull request #3953 from halfdan/2666-jshint-test
Apply JSHint to test files.
2014-09-03 13:40:01 -06:00
Fabian Becker
bc558cf0d2 Apply JSHint to test files.
closes #2666
- Add new jshint:test task
- Fix jshint errors
2014-09-03 20:33:58 +02:00
Hannah Wolfe
95a7e36c84 Merge pull request #3945 from novaugust/smart-contributors
Smarter `buildAboutPage` task
2014-09-03 18:19:32 +01:00
Matt Enlow
891e55c265 Smarter buildAboutPage task
No issue
- Only run the buildAboutPage task if the `-contributors.hbs` template doesn't exist,
- ... or if the `--force` option is supplied on the CLI
- Adds the contributors img dir and the contributors template to `grunt clean:built` task
2014-09-03 08:10:42 -06:00
Matt Enlow
7ed7c6653b grunt dev calls default task
Closes #3942
2014-09-02 21:14:32 -06:00
Matt Enlow
737ea3f65e Implement About Ghost page
Closes #3568
- Deleted html placeholders in client
- Added new grunt task, buildAboutPage, which 1)creates -contributors.hbs partial and 2) downloads contributor avatars
- buildAboutPage is called by anything that does an emberTemplates task
- Removed unused code from ghostpaths
2014-09-02 13:49:01 -06:00
Hannah Wolfe
2a843c309e Adding Grunt tasks for Sass 2014-08-31 14:16:58 +01:00
Harry Wolff
583c7970d9 Move config module to be instance based and merge bootstrap into config.
helps with #827, otherwise no issue

- This is general code clean-up and unification.
- Merges code from bootstrap.js into config module as they were both
concerned with managing the config file and as such should be in one
location.
- Updates all relevant tests.
2014-08-23 15:54:43 -04:00
Harry Wolff
5ff2a31ce1 Move Models module to have an init method that sets up all models
resolves #2170

- creates a models.init() function that requires all other model files
and caches them.  This is opposed to the previous functionality where
when you require('./models') it would immediately require all other models.
Now it's done when you want.

- Updates all tests to reflect the new structure of the model module
2014-08-18 15:54:10 -04:00
Hannah Wolfe
103ae008aa Merge pull request #3608 from JayBeavers/fixAzureStdin
Fix Azure compatibility issue around stdin in Gruntfile.js
2014-08-18 19:40:37 +01:00
Pedro Teixeira
c68859cde9 Add --allow-root for ghost_ui grunt task
closes #3753
2014-08-11 21:47:45 +02:00
Hannah Wolfe
140ee3d5e9 Escaping parens in grunt command paths
fixes #3206
2014-08-08 16:14:15 +01:00
Hannah Wolfe
9293c76786 Fix grunt commands to work with spaces in path
closes #3206

- We were escaping paths for the bower commands, but this didn't work on
  windows
- Use the same pattern for the coverage command
2014-08-06 23:17:14 +01:00
Hannah Wolfe
1c83f00ec5 Removing client files from release 2014-08-06 02:01:30 +01:00
sessa
8ce4546e2c Incorrect livereload watch path. 2014-08-05 20:26:42 -04:00
Jay Beavers
d0b1414597 Fix Azure compatibility issue around stdin in Gruntfile.js 2014-08-05 14:07:01 -07:00
Hannah Wolfe
8bfbf13248 Update to release process
- Release does all init & prod tasks necessary to create a full build
- Don't create or include .map files
- Don't include pre-minified prod files
- Don't include export .json files
- Don't include client/html
2014-08-04 22:12:23 +01:00
Paul Adam Davis
3e2533d182 Update Ghost-UI with grunt init
Closes #3554

- Adds a shell command to update Ghost-UI
2014-08-02 12:25:28 +01:00
Jason Williams
a285a561c4 Include development assets in release build.
Closes #3498
2014-08-01 13:48:15 +00:00
Matt Enlow
21abed7f9a Add User Role Dropdown
Closes #3402, Closes #3428

-------------------

 ### Components
- Added GhostSelectComponent to handle async select creation (h/t @rwjblue)
- Added GhostRolesSelector (extends GhostSelect) for displaying user role options
- Created StoreInjector for surgically inserting the store into things that normally wouldn't have them.

 ### Users Settings
- InviteNewUserModal now uses GhostRolesSelector & defaults to Author
- The role dropdown for user settings has permissions set per 3402

 ### User Model
- Added `role` property as an interface to getting and setting `roles`
- Refactored anything that set `roles` to set `role`
- isAdmin, isAuthor, isOwner and isEditor are all keyed off of `role` now

 ### Tests
- Added functional tests for Settings.Users
- updated settings.users and settings.users.user screens
- fix spacing on screens

 ### Server Fixtures
- Fixed owner fixture's roles
2014-07-30 17:59:14 -06:00
Sebastian Gierlinger
d895238571 Add XSS prevention
closes #3387
- added placeholder for <script> and <iframe>
- added google-caja sanitizer
- changed title in posts overview to ‚double-stash‘
2014-07-27 23:03:01 +02:00
Marco Otte-Witte
6406acef5c updated Ember Simple Auth to latest version 2014-07-25 16:04:19 +02:00
Hannah Wolfe
63efa541bd Merge pull request #3367 from jaswilli/issue-3161
Get Ember Admin ready for production
2014-07-23 04:47:19 +01:00
Harry Wolff
be37070fb6 This aims to speed up both the ghost application and tests by
migration from usage of config() to just an object of config.

no relevant issue

- Change 'loadConfig' task to 'ensureConfig' to more accurately reflect
what it is actually doing.  Its sole purpose is to make sure a `config.js`
 file exists, and as such the name now reflects that purpose.

- Update config/index.js to export the ghostConfig object directly
so that it can be accessed from other modules

- Update all references of config(). to config.
This was a blind global find all and replace, treat it as such.

- Fixes to tests to support new config access method

- Allow each test to still work when invoked invidually
2014-07-22 22:37:44 -04:00
Jason Williams
7ae48f1dd3 Get Ember Admin ready for production
Closes #3161
- Add a config.js file for the client which is used to configure
  Ember.Application during runtime. The correct version of config.js
  is copied into place by grunt via the copy:(dev|prod) task from
  either config-dev.js or config-prod.js.
- Serve minified and production versions of libraries where applicable
  including handlebars-runtime and ember-prod.
- Bundle third party libraries into vendor.min.js.
- Bundle Ghost's Ember app and templates into ghost.min.js
- Remove all fixture data and code from the client.
2014-07-22 22:33:49 +00:00
Sebastian Gierlinger
05b3606fd3 Remove inline script from default.hbs
no issue
- added config values as data attributes
- removed inline script
- removed current-user.js
2014-07-21 20:00:54 +02:00
Hannah Wolfe
cf9839c71d Integration tests use consistent teardown methods 2014-07-21 13:25:51 +01:00
Gabor Javorszky
aca0c7daf6 Added example to run a specific integration test to gruntfile
No issue
2014-07-20 15:11:02 +01:00
Jason Williams
979c3f237c Prevent loading setup screen if already setup
Closes #3145
- Prevent navigation to the setup screen if Ghost setup
  has previously been completed.
- Fix templates that were incorrectly using foreach instead of each.
- Add validation for minimum password length.
- Fix up functional tests and split out tests for setup to a separate
  instance of casper because setup requires a new database.
- Add a cleanDatabase task to grunt which resets the database to
  new.
2014-07-16 15:54:42 +00:00
Jesse Tane
371b6bcf54 update grunt-shell to 0.7.0
grunt: pass --allow-root to bower

fixes #3232
2014-07-10 00:18:56 -04:00
Hannah Wolfe
bf1ff2ac0d Improve ember casper test stability
fixes #3171, fixes #2382, refs #3130

- Moved grunt init from travis into grunt validate, this makes sure we get verbose output from grunt init.
- Added `grunt test` task to run just the tests without building if you want
- Upgraded grunt-contrib-concat and added nonull property (had to switch to src/dist for this to work) #2382
- Upgraded bower to 1.3.5, which appears to resolve #3171
- Changed bower git assets to all be referenced the same and removed resolutions again #3130
2014-07-01 13:35:50 +01:00
Hannah Wolfe
9214f25dee Merge pull request #3165 from ErisDS/issue-3056
Replace the old admin with the ember admin
2014-07-01 09:04:22 +01:00
Hannah Wolfe
f70f99b5cf Replace the old admin with the ember admin
closes #3056

- Remove clientold
- Remove clientold tests
- Cleanup old admin helpers
- Remove old routes from admin and controllers from admin controller
- Comment out / remove old and broken tests
- Cleanup Gruntfile.js, bower.js, package.json etc

Still TODO:

- cleanup / add removed tests
- do we still need countable?
2014-07-01 08:33:17 +01:00
Matt Enlow
a82e6e8040 Use Device.js to determine mobile editor use
Ref #2570
- Adds new library, device.js to determine if the user is on an ios mobile
  or tablet.
2014-06-30 18:27:43 -06:00
Hannah Wolfe
48a2f9c70d Merge pull request #3144 from darvelo/sort-new-posts
New posts pass PostsController sorting function at the top
2014-06-30 16:23:51 +01:00
Sebastian Gierlinger
c8e8da4780 oAuth
closes #2759
closes #3027

- added oauth2orize library for server side oAuth handling
- added ember-simple-auth library for admin oAuth handling
- added tables for client, accesstoken and refreshtoken
- implemented RFC6749 4.3 Ressouce Owner Password Credentials Grant
- updated api tests with oAuth
- removed session, authentication is now token based

Known issues:
- Restore spam prevention #3128
- Signin after Signup #3125
- Signin validation #3125

**Attention**
- oldClient doesn't work with this PR anymore, session authentication
was
removed
2014-06-30 14:58:10 +02:00
David Arvelo
a958a66c4c New posts pass PostsController sorting function at the top
- PostsController orderBy function sorts posts with isNew to the top, otherwise their undefined dates fail to compare
- also catch when `updated_at` is undefined, happens when model is being written with results from the server
- catch objects of type Error in validation engine, helps catching client errors
- join server errors with BR tag in ajax util
- add `emberBuild` task to `grunt test-functional`
- add a test helper, `thenTransitionAndWaitForScreenLoad`, to test transitioning to major parts of the app
- add a test that transitions from Content to the Editor, and back to Content
2014-06-29 21:49:32 -04:00
Matt Enlow
3011834177 Add --init param to update_submodules grunt task
Closes #3141
2014-06-27 11:05:09 -06:00