Commit Graph

289 Commits

Author SHA1 Message Date
James Morris
2c013b8db0 Added in some responsive design to the Comments modals for mobile
refs https://github.com/TryGhost/Team/issues/1703
2022-07-22 09:35:52 +01:00
Simon Backx
8d41ec360b Skipped waiting for admin authentication
fixes https://github.com/TryGhost/Team/issues/1700

- Admin authentication requests are non blocking now
2022-07-22 09:44:21 +02:00
James Morris
a5af3f47ce Improved the hidden and removed status where it's now hidding name
- Before, this was still showing name and avatar
- This now reverts to a blank avatar image

refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 19:46:53 +01:00
James Morris
59e29f30b0 Fixed the bug where the portal windows open inside the iFrame
refs https://github.com/TryGhost/Team/issues/1706
2022-07-21 18:43:32 +01:00
James Morris
ea643a4847 Added in some error handling and a few other tiny tweaks to Add Name dialog
- Added in some error handling to catch empty names
- Basic checks for trimmed strings
- Subtle transition effects

refs https://github.com/TryGhost/Team/issues/1682
2022-07-21 18:31:58 +01:00
James Morris
47a8386da2 Spacing tweaks to tighten things up based on John's feedback
refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 18:08:30 +01:00
James Morris
16cccc2fcc Added the reply box disappearing properly with the toggle when finished
refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 17:50:23 +01:00
James Morris
b60f0995d9 Added in the toggle so when blurring from reply textbox it'll undo the reply button too
refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 17:50:23 +01:00
James Morris
5466ca2608 Needing more control over the opening and closing of text box so moved some things around
- Note this may look a bit more complicated but I need more control over opening/closing
- Will look to refactor this and make it simpler soon enough

refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 17:50:20 +01:00
Simon Backx
30cd5c278e Fixed More button not toggling context menu 2022-07-21 17:35:24 +02:00
Simon Backx
dcfebd5e5f Fixed generic dialogs closing when clicking inside them 2022-07-21 17:27:58 +02:00
Simon Backx
b262d7010a Fixed closing context menus when clicking outside them
fixes https://github.com/TryGhost/Team/issues/1702
2022-07-21 17:23:35 +02:00
Simon Backx
20f2b26c23 Removed Modal component 2022-07-21 17:00:10 +02:00
Simon Backx
2980e58201 Updated Popup Modals now using global context 2022-07-21 16:59:18 +02:00
James Morris
15b534f7d3 Push some more style tweaks for iFrame but it may need more
- Includes more dynamic styling for negative margins for iFrames
- This may well change again when looking more closely with themes

refs https://github.com/TryGhost/Team/issues/1701
2022-07-21 15:33:04 +01:00
James Morris
dd8715fa46 Moved iFrame comments adjustments
- Moved where the styling is to not mess with modals
- Added in some padding at the top for edit box

refs https://github.com/TryGhost/Team/issues/1701
2022-07-21 14:44:37 +01:00
Simon Backx
f011de6b5b Cleaned up the modals iframe being in DOM when not shown 2022-07-21 15:31:26 +02:00
James Morris
6d19323df2 Quick fix for iFrame, negative margins and padding to retain shadow
refs https://github.com/TryGhost/Team/issues/1701
2022-07-21 14:09:13 +01:00
Simon Backx
866a020072 Fixed scrolling to reply form 2022-07-21 15:03:40 +02:00
Simon Backx
0b8f92ddbe Switched from Shadow DOM back to Iframes
refs https://github.com/TryGhost/Team/issues/1701

The Selection API is missing in Safari in Shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=163921. So we need to move away from it for now.

- Adds a new component: Modal, which makes sure we can style modals using tailwind, while displaying them outside of the main iframe (inside a different iframe that is positioned fixed)
- Updated GenericDialog to use the new Modal component
- Removed ShadowDOM
2022-07-21 14:35:32 +02:00
James Morris
a9c3ef5444 Fixed the quotes back to double for HTML elements
no issue
2022-07-21 13:11:33 +01:00
James Morris
6b4290694b Added in a simple scroll to reply to ensure it's always in view
refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 13:05:23 +01:00
James Morris
e6cacdb2db Moved reply box to bottom and made it autofocus
refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 12:36:54 +01:00
James Morris
64b6dbd3ee Little tweak to how the Add Name dialog box opens from comments
- Now doesn't jump when opening the Add Name dialog box
- Still some minor things to visually tweak on this but it's an improvement

refs https://github.com/TryGhost/Team/issues/1682
2022-07-21 12:04:08 +01:00
James Morris
269bd6506e Smaller UI and UX tweaks from John's feedback
- Increase rounded border size of submit button
- Make cursor be text when editing
- Remove ugly outlines from actions

refs https://github.com/TryGhost/Team/issues/1703
2022-07-21 11:31:12 +01:00
Rishabh
9e06f28bb5 Wired saving member's name for comments
refs https://github.com/TryGhost/Team/issues/1682

- wires member name to be saved from the popup for adding comments
2022-07-21 15:47:51 +05:30
James Morris
a2e3b06548 Basic modal but needs more work
- This modal style is mostly there
- It needs key behaviours to work with React properly
- It triggers only when there isn't a name present
- It doesn't save yet or anything fancy

refs https://github.com/TryGhost/Team/issues/1682
2022-07-20 18:40:04 +01:00
James Morris
360c5f9779 Uncommented the reporting action
refs https://github.com/TryGhost/Team/issues/1685
2022-07-20 17:36:38 +01:00
James Morris
55f650f964 Updated some of the logic for the dropdowns for hidden, etc
refs https://github.com/TryGhost/Team/issues/1693
2022-07-20 17:26:29 +01:00
James Morris
48b4aaf838 Fixed up the loading state with proper positioning and adjusted colours
refs https://github.com/TryGhost/Team/issues/1692
2022-07-20 16:36:15 +01:00
Simon Backx
6eb32599bd Added darkmode support for loading spinner 2022-07-20 17:03:45 +02:00
Simon Backx
28921a8dbf Fixed randomly not loading comments area
refs https://github.com/TryGhost/Team/issues/1696

- Wait for the iframe to load before sending messages to it
- High chance this fixes the issue, but still need to monitor if this was the real cause.
2022-07-20 16:30:28 +02:00
Simon Backx
723b35bfa6 Added CSS support for custom local setup for Safari 2022-07-20 16:03:07 +02:00
Simon Backx
e4c9ecc621 Wired up really basic reply pagination
refs https://github.com/TryGhost/Team/issues/1689

Needs input on https://github.com/TryGhost/Team/issues/1689#issuecomment-1190189896
2022-07-20 14:16:06 +02:00
James Morris
e4d90f7a82 Basic working empty comments that needs further styling
refs https://github.com/TryGhost/Team/issues/1698
2022-07-20 12:58:28 +01:00
James Morris
75ac4dcdc3 Added a dummy reply pagination button ready to wire up
refs https://github.com/TryGhost/Team/issues/1689
2022-07-20 12:31:35 +01:00
Simon Backx
4a4db114f0 Updated loading state to kick in earlier
refs https://github.com/TryGhost/Team/issues/1692

- Moved Loading component to App (so it shows as a placeholder)
- Disabled loading settings from the API (not used for now), to speed up loading
2022-07-20 11:01:30 +02:00
Simon Backx
2657af11f6 Restricted actions for logged in members and paid members
refs https://github.com/TryGhost/Team/issues/1693

- Added a new data attribute to the injected stript tag: `data-comments-enabled`. This contains the commentsEnabled setting, and can be 'all' or 'paid' (when it is off the comments section is never injected).
- Added a new component `<NotPaidBox>`, which is visible when a member is signed in but doesn't have paid access to comment
- Prevented clicking the reply and like buttons when a member doesn't have access
2022-07-20 10:38:21 +02:00
James Morris
dd5a4bb35e Added a member check for showing more menu or not
- This should stop people who are not logged in from showing more menu

refs https://github.com/TryGhost/Team/issues/1693
2022-07-19 17:51:17 +01:00
James Morris
28b566f95a Added a member check for toggling on and off likes
- This should stop people who are not logged in from liking comments

refs https://github.com/TryGhost/Team/issues/1693
2022-07-19 17:45:22 +01:00
James Morris
dce15950cd Added a proper loading component for comments plus a few tweaks
- New loader component for when comments come in
- New spinner used for loader and the report button progress
- We don't seem to have a working loading state to show it though

refs https://github.com/TryGhost/Team/issues/1692
2022-07-19 17:23:02 +01:00
Simon Backx
a1b1dd9dad Fixed appVersion attribute warning 2022-07-19 16:55:47 +02:00
Simon Backx
98486d159b Added temporary working test 2022-07-19 16:46:16 +02:00
James Morris
4b504130d8 Working progress of the button when sending reporting
refs https://github.com/TryGhost/Team/issues/1685
2022-07-19 15:35:32 +01:00
Simon Backx
0424fcd099 Fixed context menus for comment of deleted member 2022-07-19 16:28:33 +02:00
Simon Backx
0da39ddeeb Added support for deleted members' comments
fixes https://github.com/TryGhost/Team/issues/1690
2022-07-19 16:22:09 +02:00
James Morris
6768ae2d55 First version of basic reporting modal
refs https://github.com/TryGhost/Team/issues/1685
2022-07-19 13:05:42 +01:00
Simon Backx
e84b4e5320 Added temporary report functionality without confirmation 2022-07-18 17:36:09 +02:00
Simon Backx
a0eb8af4ac Fixed empty member names in comments
refs https://github.com/TryGhost/Team/issues/1681

Default to 'Anonymous' for members without a name. Still need some UI to ask for a name.
2022-07-18 09:52:03 +02:00
Rishabh
fc3f091e2d 🐛 Fixed internal css leaking outside iframe
refs https://github.com/TryGhost/Team/issues/1675

- the main css file was imported in the root js script, causing it to be included alongside the final minified bundle and get injected outside the iframe.
- the main css is pushed as a separate file outside of bundle and used directly as link inside the iframe instead
2022-07-13 08:19:52 +05:30