TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-21 09:52:06 +03:00
Code Issues Projects Releases Wiki Activity
31,486 Commits 250 Branches 1,686 Tags 378 MiB
c65b980ada
Commit Graph

5428 Commits

Author SHA1 Message Date
Djordje Vlaisavljevic
836010c0f2 Added back both columns to the all sources modal 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
4630e5122b Fixed all sources modal height 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
4704e7ab31 Added column sorting and removed the dropdown 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
15fbd3d7e6 Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
f4d5271a1f Updated inactive state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
d9b3c1de41 Fixed attribution widget grid 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-07 15:43:59 +05:30
Rishabh
ed688f2cd7 Refined source attribution table on dashboard 
- added back 2 column design for source attribution table
 2022-10-07 15:43:59 +05:30
Djordje Vlaisavljevic
ff4f93f4a5 Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-06 22:26:54 +02:00
Djordje Vlaisavljevic
37dd97b5c5 Updated default mock state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-06 22:26:54 +02:00
Ozan Uslan
220af3b276
🐛 Fixed timezone issue with min/max dates in datetime picker 
fixes #15497

`'now'` option for min/max date used `moment()` function and did not consider the timezone of the site.
 2022-10-06 20:09:36 +02:00
Kevin Ansfield
fc5f0f7c79 Refactored stripe settings form component with Octane patterns 
refs https://github.com/TryGhost/Ghost/issues/14101

- migrated to native class syntax and Glimmer component patterns
 2022-10-06 16:22:32 +01:00
Kevin Ansfield
c2d8950bd5 Moved and renamed stripe settings form component 
no issue

- moved screen-specific component into the `settings/members` folder
- renamed to better reflect the component's purpose
 2022-10-06 16:22:32 +01:00
James Morris
4e3380190b Improving the member filters 
- Closes dropdown when removing labels
- Larger width to handle multiple labels better
- Subtle focuses when using tabs only
- Bigger close button hitpoints on labels
- Added text ellipis for larger labels in dropdown
- Added some event propagation stops

no issue
 2022-10-06 12:21:55 +01:00
Sanne de Vries
a2bfdc7534 Updated error status in post list and the editor 
Refs https://github.com/TryGhost/Team/issues/2009
 2022-10-06 17:37:08 +07:00
Sanne de Vries
08da18e324 Fixed breadcrumbs responsive issues 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- New breadcrumb style broke posts list on smaller screens
- Updated copy to reflect the action taken on the page (e.g. Edit tag)
 2022-10-06 16:25:57 +07:00
Simon Backx
aaabf4b103
🎨 Improved email failure handling and retrying (#15504) 
fixes https://github.com/TryGhost/Team/issues/2009

- When an email is sent, but it failed there was no way to retry once you left the retry screen
- There was no indication that the email failed to send in the post list and editor
 2022-10-06 11:12:11 +02:00
Djordje Vlaisavljevic
94aaa168cd Added disabled state with CTA for Zapier integration 
refs https://github.com/TryGhost/Team/issues/1157
 2022-10-05 15:36:52 +02:00
Kevin Ansfield
524b23c182
Migrated staff user screen to Ember Octane patterns (#15532) 
refs https://github.com/TryGhost/Ghost/issues/14101

- migrated staff user controller to native class syntax
- removed use of `{{action}}` helper
- moved from custom components to native `<input>` and `<textarea>` for form fields
  - added `{{select-on-click}}` modifier to cover the `<GhTextingInput @selectOnClick>` option behaviour for any input element
- added `submitForm()` test helper that finds closest `form` element and trigger's a `submit` event on it simulating <kbd>Enter</kbd> being pressed whilst a field has focus
 2022-10-05 12:05:31 +01:00
Sanne de Vries
b7fd0c04b6 Updated tag and history breadcrumbs 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Updated the copy to follow the common breadcrumb pattern
 2022-10-05 12:40:51 +07:00
Kevin Ansfield
e0430b4efc 🐛 Fixed ctrl/cmd+s not saving focused fields on general/staff settings screens 
no issue

- swapped from route actions triggered by shortcuts mixin to explicit `{{on-key}}` actions
- when saved via keyboard, blur any focused element to trigger it's on-blur action and schedule the save to run after those actions
 2022-10-04 17:55:24 +01:00
Kevin Ansfield
c77c150745 Refactored facebook/twitter URL inputs 
refs https://github.com/TryGhost/Ghost/issues/14101

Twitter/facebook URL validation doesn't follow our typical validation and was duplicated across multiple screens making the controllers unnecessarily complex.

- extracted url input fields and their validation into separate components
- uses tracked scratch values so that the input field values can reset to the saved value on save
  - twitter/facebook URL inputs are different to our other inputs because invalid values won't prevent saving, instead they are reset to their previous value on save
- added `this.validate()` call after a successful save in `settings` service so the service and underlying model validations are both in sync (fixes validation error sticking around after saving with invalid twitter/facebook values that have been reset)
 2022-10-04 17:55:24 +01:00
Djordje Vlaisavljevic
b15451dfa6 Deemphasized unavailable sources and added an explainer 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-04 13:29:25 +02:00
Kevin Ansfield
d8193da005 Revert "Fixed errors thrown from blank twitter/facebook URL fields" 
This reverts commit a523fedccb.

- caused input value to be cleared on focus+blur with no changes
- reverting in favor of an incoming refactor
 2022-10-04 10:30:13 +01:00
Kevin Ansfield
a523fedccb Fixed errors thrown from blank twitter/facebook URL fields 
no issue

- reset logic was incorrect meaning that if you focused a twitter/facebook URL field then moved to a different field without inputting anything an error would be thrown from trying to use `.match()` on `null`
 2022-10-04 10:09:36 +01:00
Sanne de Vries
0124c2f28a Updated member activity page with new breadcrumb styles 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Filtering on specific member activity now uses new breadcrumb pattern
- Fixed double scrollbar issue on member activity and history page
 2022-10-04 13:51:01 +07:00
Sanne de Vries
2c498ab193 Updated breadcrumb and title style across admin 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Separating out the breadcrumbs and the title makes it easier to navigate back on multiple levels for nested pages.
- Avoids very long titles, as it doesn't include breadcrumbs anymore
 2022-10-04 12:35:29 +07:00
Rishabh
09fbe19a31 Fixed anchor chart load for site without paid tiers 
refs https://github.com/TryGhost/Team/issues/2019

- the anchor chart keeps showing the loading spinner for a site that has no paid tiers and the source attribution flag switched on.
- this was because it tries to load the the MRR chart by default, which doesn't has any data when paid tiers are disabled.
- updated the chart to use `total members` data when paid tiers is disabled
 2022-10-04 10:34:44 +05:30
Ronald Langeveld
226794e201
🐛 Fixed broken close buttons on modals (#15514) 
* 🐛 Fixed broken `close` button on modals
no issue

Some modals' close elements containing `{{on "click" @close}}` and `href=""` would not take the 'on cl
ick' function into account, meaning the whole page would get redirected to "/" (back to the root of the dashboard) instead of just closing the modal.
 2022-10-04 06:33:49 +04:00
Kevin Ansfield
cd9a50841e Fixed tests 
refs 85cce39af7

- removed out of date transfer owner modal integration test
- fixed missing `?` in optional chaining in `<GhImageUploader>` error handling
 2022-10-03 22:05:02 +01:00
Kevin Ansfield
bdc5984cdc Fixed linter error 
refs 85cce39af7
 2022-10-03 21:20:37 +01:00
Kevin Ansfield
85cce39af7 Refactored staff user modals 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
- cleaned up the `upload-image` modal which had multiple areas of code that were no longer being used
- disabled `no-duplicate-landmark-elements` template lint rule as it's buggy and mostly gives false positives
 2022-10-03 21:15:34 +01:00
Kevin Ansfield
74d66ca9be Renamed incorrect test selectors on limit modals 
no issue

- selectors hadn't been updated when copy/pasting modal contents
 2022-10-03 21:15:34 +01:00
Stephen Sauceda
eb585f9c02
🐛 Fixed active state bug in sidebar nav (#15511) 
closes: https://github.com/TryGhost/Ghost/issues/15506

- The sidebar items that don't open the editor were missing some relative current-when attributes so the nested views weren't considered "active".
 2022-10-03 19:49:21 +01:00
Djordje Vlaisavljevic
02369ee852 Switched the dash character 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 17:29:07 +02:00
Kevin Ansfield
353cad7ed2 Fixed mirage members route permissions checks 
refs 568e4183e3
refs 258f56ded9

- when in test environment add a `X-Test-User` header to API requests that allows the mirage endpoints to check the logged in user without having to cross boundaries into the application or test contexts
 2022-10-03 14:59:16 +01:00
Rishabh
01249926d5 Refined attribution data on member details page 
refs https://github.com/TryGhost/Team/issues/1986

- hides referrer source on member details page if its `Created manually` as its not useful
 2022-10-03 18:58:48 +05:30
Djordje Vlaisavljevic
c48df76d9b Updated formatting of the signup info 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 14:25:32 +02:00
Djordje Vlaisavljevic
f351064726 Commented out the Learn more link 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 14:20:03 +02:00
Djordje Vlaisavljevic
7fea370faf Fixed all sources modal gradient in dark mode 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 12:24:54 +02:00
Djordje Vlaisavljevic
ee40c92758 Updated cursor for disabled dropdown 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 11:42:50 +02:00
Rishabh
e57502e02f Handled empty attribution section on member detail page 
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if there is no source and page/post attribution
 2022-10-03 14:58:14 +05:30
Rishabh
6dc5f7ebb0 Added empty state mock option for attribution data 
- allows mimicking empty state on dashboard for attribution data
 2022-10-03 14:56:37 +05:30
Peter Zimon
349ef4926c Update engagement copy in Post Analytics 
closes https://github.com/TryGhost/Team/issues/2016

- the absolute value and percentage for Opened and Clicked metrics in the engagement section of the post analytics page were inconsistent
 2022-10-03 08:42:19 +02:00
Rishabh
30efab8401 Fixed lint 2022-09-30 09:38:15 +05:30
Rishabh
579ca615f9 Refined member attribution wording 2022-09-30 01:27:26 +05:30
Djordje Vlaisavljevic
198e43daec Updated disabled state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 20:49:53 +02:00
Djordje Vlaisavljevic
fb2f0b3d3b Updated the all sources modal grid 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 20:33:00 +02:00
Rishabh
fa2292806a Refined all sources list on dashboard 
refs https://github.com/orgs/TryGhost/projects/77

- shows single selected column on the all referrer sources list in dashboard
 2022-09-29 23:47:43 +05:30
Rishabh
5eae093b3c Cleaned up attribution widget on analytics page 
- updates attribution widget on analytics page to work same as dashboard with data
 2022-09-29 23:33:17 +05:30
Djordje Vlaisavljevic
40c66dae6a Made the attribution widget show if you don't have paid tiers 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 19:37:09 +02:00
James Morris
8a6f082b14 Moving opened stats in row over if there are no clickes in post rows 
- When there are no clicks, we are moving over the opened stats in it's place
- There shouldn't be too many times these mix so design should be ok

refs https://github.com/TryGhost/Team/issues/2000
 2022-09-29 18:01:01 +01:00
James Morris
fd977479ee Tweaked up the analytics resources sections 
refs https://github.com/TryGhost/Team/issues/1987
 2022-09-29 17:38:50 +01:00
Simon Backx
648811690a ✨ Added email click tracking 
no issue

Bumped flag to GA.
 2022-09-29 18:14:15 +02:00
Simon Backx
58cabc68ec Fixed analytics button not working 
no issue
 2022-09-29 17:43:06 +02:00
James Morris
c44e7d1536 Improving the newsletter clicks table in post analytics 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-29 16:15:27 +01:00
Djordje Vlaisavljevic
aea7820487 Renamed files 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:45:56 +02:00
Simon Backx
0cd0fc838d
Added email track clicks column and cleaned up frontend checks (#15501) 
fixes https://github.com/TryGhost/Team/issues/2008

- New column that stores email click tracking at the time it was created
- Improved frontend side checks for when to show analytics
 2022-09-29 16:42:45 +02:00
Djordje Vlaisavljevic
22a75ba144 Updated dashboard mocks 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:23:50 +02:00
Djordje Vlaisavljevic
d2d34b1418 Updated all sources modal width 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:23:01 +02:00
Djordje Vlaisavljevic
d811bd512f Fixed modal footer 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:20:21 +02:00
Djordje Vlaisavljevic
9fa48613de Updated hover state for the anchor dropdown 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:14:58 +02:00
James Morris
9e51ba0c31 Removed the button labels from the post rows 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-29 15:07:37 +01:00
Djordje Vlaisavljevic
3fe51c8e9a Set max height for All sources modal 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 15:59:12 +02:00
James Morris
a9308e6394 Adding in new code to bring source attribution more in line 
refs https://github.com/TryGhost/Team/issues/2001
 2022-09-29 14:52:36 +01:00
Simon Backx
1a5ff8d53d
Added back button from editor to analytics (#15493) 
fixes https://github.com/TryGhost/Team/issues/1992

When you edit a post via the editor, the back button on the top of the editor should go back to the analytics page and the status at the top should be removed.
 2022-09-29 14:34:01 +02:00
Simon Backx
0c20950512 Cleaned up indentation in links-table.hbs 2022-09-29 13:05:55 +02:00
Simon Backx
061ae9c018 Added pagination to the links table on analytics page 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-29 13:02:49 +02:00
Simon Backx
99e6f8ddda Moved analytics page to separate component 
refs https://github.com/TryGhost/Team/issues/1976
refs https://ghost.slack.com/archives/C02G9E68C/p1664446234131629

- @tracked properties in controllers are persisted, should use components instead
 2022-09-29 12:41:16 +02:00
James Morris
9be863cc82 Tiny tweaks to styles for post analytics 
- Made the source attribution table half and half
- Adjust the button hover for post rows

no issue
 2022-09-29 11:06:29 +01:00
Djordje Vlaisavljevic
0d6946685e Updated design for multiple subs in sub box edge case 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 10:22:59 +02:00
Djordje Vlaisavljevic
d1c269b2e7 Updated the tooltip offset 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 09:25:59 +02:00
Rishabh
aa6f65ac22 Fixed disabled attribution category selector dropdown 
- removes hardcoded disable on attribution category selector and uses calculated value instead
 2022-09-29 12:17:45 +05:30
Rishabh
b3adaf26c5 Handled attribution table empty data on dashboard 
- updates default dropdown based on availability of paid conversions or signups
- disables dropdown if data is missing for type of attribution
 2022-09-29 11:17:02 +05:30
Rishabh
7e68bc172a Added empty state UI for attribution charts on dashboard 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 11:17:02 +05:30
Rishabh
f9215cbbe4 Refined attribution table unavailable source style 
- updates legend color for Unavailable to match Others as a white transparent dot
 2022-09-29 11:17:02 +05:30
James Morris
5299905851 Added in the static front-end of the pagination 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-28 18:18:45 +01:00
James Morris
4cf5380724 Added in member filtering to rest of stats in analytics 
- This adds member filtering for signups and conversions in analytics
- This also makes all events in rows clickable

refs https://github.com/TryGhost/Team/issues/1969
 2022-09-28 17:10:15 +01:00
Djordje Vlaisavljevic
901708b299 Updated design of Other sources field 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 17:25:51 +02:00
Djordje Vlaisavljevic
e843df75b4 Added commented out footnote 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 17:25:51 +02:00
Simon Backx
b905085d6f
Added opened, clicked and received email filtering to members (#15492) 
fixes https://github.com/TryGhost/Team/issues/1993

- Allows filtering members by opened, clicked and received email
- Adds clicked_links filter relation to Member model.
- Adds emails filter relation to Member model.
- Adds opened_emails filter expansion to Member model.
- Updated GhResourceSelect to be able to only show list posts by setting the `type` attribute to `email`.
- Improved code reuse in `filter-value` component.
 2022-09-28 17:14:32 +02:00
James Morris
59b5cd59b2 Better matching posts and pages and fixing when no members 
refs https://github.com/TryGhost/Team/issues/1995
 2022-09-28 15:56:22 +01:00
Djordje Vlaisavljevic
584546cf1d Updated other sources button 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 16:47:29 +02:00
Djordje Vlaisavljevic
52af7c687d Added attribution help docs link placeholder 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 16:31:52 +02:00
Rishabh
f2430c34cc Updated attribution chart on post analytics page 
refs https://github.com/TryGhost/Team/issues/1986

- added dropdown for paid vs signups selection on attribution chart
 2022-09-28 19:50:29 +05:30
Simon Backx
1caa8f5b9a Hidden analytics page button for published post when attribution is disabled 
fixes https://github.com/TryGhost/Team/issues/1998

- Should not show analytics button when post is not sent via email and attribution is disabled
- Improved checks for the analytics button
 2022-09-28 16:15:03 +02:00
James Morris
dc9ef69547 Better matching up the pages table with the posts table 
refs https://github.com/TryGhost/Team/issues/1995
 2022-09-28 14:17:12 +01:00
James Morris
cd97341ed6 Fixed up the edit and stats buttons based on feedback 
refs https://github.com/TryGhost/Team/issues/1994
 2022-09-28 13:44:58 +01:00
Djordje Vlaisavljevic
b72b51b542 Made the attribution widget look better on smaller screens 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 14:20:40 +02:00
Rishabh
d63f4548c0 Removed attribution sources from UI if site is invite-only 
refs https://github.com/TryGhost/Team/issues/1986

- removes attribution section from dashboard and post analytics if site is invite only
 2022-09-28 17:26:38 +05:30
Rishabh
8c225ee9d0 Fixed lint 
- updates `index` for susbcription detail box
 2022-09-28 17:22:24 +05:30
Djordje Vlaisavljevic
9209a39c29 Added new attribution widget design 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 13:44:28 +02:00
Rishabh
79248cdde9 Fixed dropdown blink for subscription detail box 
refs https://github.com/TryGhost/Team/issues/1986

- creates new component for subscription detail box that avoids re-render of whole block causing flicker
 2022-09-28 17:08:28 +05:30
Rishabh
cf1f41d61c Updated attribution table design to show single column data 
- adds new dropdown that allows switching between signups vs paid conversions
- updates chart data based on dropdown value, keeps the sort column till the design for this is polished
 2022-09-28 16:27:44 +05:30
James Morris
994f0eea64 Tiny padding adjustment for boxes 
refs https://github.com/TryGhost/Team/issues/1968
 2022-09-28 11:11:15 +01:00
Rishabh
8b2db5c017 Refined attribution table on dashboard for list of sources 
- updates table to always show top 5 sources, including the empty sources
- only adds `Other` to list on table if more than 5 sources exist
- updates mock to include `Unavailable` data
 2022-09-28 15:31:41 +05:30
Simon Backx
160469d787 Improved analytics page loading states 
refs https://github.com/TryGhost/Team/issues/1976

- Wait to show any module until everything has been loaded
 2022-09-28 11:58:51 +02:00
Djordje Vlaisavljevic
49a922fbd5 Updated attribution widget empty state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 11:05:28 +02:00
Simon Backx
03bfe2504e Fixed ref instead of rel when stripping querystring from tracked url 
no issue
 2022-09-28 11:03:00 +02:00
Simon Backx
e0965a6262 Readded hash to cleaned tracked links in admin 
fixes https://github.com/TryGhost/Team/issues/1980
 2022-09-28 10:31:18 +02:00
Sanne de Vries
08656ea569 Updated lexical sandbox page structure 
Refs https://github.com/TryGhost/Team/issues/1991
 2022-09-28 11:06:32 +07:00