3 Commits

Author	SHA1	Message	Date
Hannah Wolfe	c86933f44f	Remove common errors (#11848) ... * refactored core/frontend/services/proxy to import common dependency like a normal person * removed all imports of `common/errors` * 🔥 removed common/errors module Co-authored-by: Vikas Potluri <vikaspotluri123.github@gmail.com>	2020-05-26 19:10:29 +01:00
Hannah Wolfe	22e13acd65	Updated var declarations to const/let and no lists ... - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!	2020-04-29 16:51:13 +01:00
Hannah Wolfe	59b9f161dd	Moved non-helper code out of helpers ... - the helper dir also contained some code used with helpers - utils and helper-helpers? - the goal here was for helpers to be the only thing in their folder so we can look at moving them out - all other code has been moved to services/themes for now, which is not the right place either - services/themes is a catch-all for theme storage, loading, validation, rendering and more, needs to be broken down	2020-04-10 12:27:43 +01:00