Commit Graph

10303 Commits

Author SHA1 Message Date
Kevin Ansfield
5fd2b7fed1 Added send_email_when_published query param to posts endpoint
no issue

- having a `send_email_when_published` property on the Post resource that only has an effect at certain times was confusing and was causing issues with clients that needed to know details of how that toggle worked
- makes `post.send_email_when_published` a fully read-only property in the API
- adds support for `?send_email_when_published=true` query param that can be passed in POST/PUT requests to the posts endpoint when scheduling or publishing a post - this is the only way to set `post.send_email_when_published` to `true`
- adds handling to ensure that `post.send_email_when_published` is always reset to `false` when reverting a post back to a draft _unless_ an email has already been sent
2019-11-14 17:29:03 +00:00
Rish
dbae6ccb58 Added site title as sender name for bulk email
no issue
2019-11-14 20:39:51 +05:30
Rish
c4706230d9 Updated fixtures regression test 2019-11-14 20:39:25 +05:30
Naz Gargol
d325912a55
Switched scheduler to use API v3 (#11391)
no issue

- The switch is needed so that mailinglist work when posts are scheduled
- v3 API is the default stable API that should be preferably used by all clients (including Scheduler)
2019-11-14 15:12:52 +07:00
Rish
1d89bbc852 Fixed settings tests 2019-11-14 11:32:34 +05:30
Nazar Gargol
98364e4d66 Removed unused method from bulk-mailer
- This was a leftover from rebase
- The method is not meant to be used anywhere
2019-11-14 12:35:26 +07:00
Rish
22b48cbef3 Fixed mailgun instance not updated on settings change
no issue
2019-11-14 10:45:26 +05:30
Rish
6d1de1b912 Fixed post not showing authors in email
no issue
2019-11-14 10:45:05 +05:30
Rish
eaf7289af3 Fixed bulk settings input serializer 2019-11-14 08:20:16 +05:30
Rish
b7df5c360d Updated send test email to use common email data 2019-11-13 22:53:33 +05:30
Rish
d3229b6ade Wired mailgun provider API keys via config or settings
no issue
2019-11-13 22:29:31 +05:30
Rish
05e9f01f30 Added dynamic fields isEnabled/isConfig on bulk email settings
no issue

Adds 2 new dynamic calculated fields on bulk email settings -

`isEnabled` - If mailgun is configured either with config or admin settings
`isConfig` - If mail is configured via config directly
2019-11-13 22:29:31 +05:30
Rish
572e56f90a Removed redundant bulk email settings migration
no issue
2019-11-13 22:29:31 +05:30
Rish
e540f36a9a Added new top-level bulk email settings
no issue
2019-11-13 22:29:31 +05:30
Peter Zimon
06afa4c042 Refined mail design 2019-11-13 14:11:54 +01:00
Rish
af43c0872c Fixed mailgun not sending test emails due to empty recipient variables
no issue

Mailgun expects `recipient-variables` to be a json object and fails to attempt sending the message in case its undefined, which is the case for test emails as they don't have member `uuid` or `unsubscribe` url. This sets a default empty object for `recipent-variables` in case of no data.
2019-11-13 17:02:56 +05:30
Fabien O'Carroll
d4ab151fce
Removed basic email validation
no-issue

This was rubbish anyway, and we should just rely on the input having `type=email`
2019-11-13 18:18:49 +07:00
Naz Gargol
f5479e1473
Added batching support for bulk email service (#11388)
no issue

- The limitation on Mailgun side of API seems to be 1000 emails per message.
- The only place where I could find a hard limit of 1000 emails per
batch was this PHP SDK issue: https://github.com/mailgun/mailgun-php/issues/469
- To store ids of sent messages introduce a mega column on the emails table. They can be synced with stats or other metrics during even pooling in the future
- Removed redundant `join(',')` statement.The SDK accepts an array of emails as well. Less code - better code :)
2019-11-13 17:52:23 +07:00
Naz Gargol
208b710677
Added tagging support to bul email service (#11390)
no issue

- Tagging needs to be added to be able to group/filter sent messages for various reasons. An example use case is when multiple Ghost instances use the same mailgun account
- Tag value can be provided as a part of config.json file under
`bulkEmail.mailgun.tag` key
2019-11-13 17:36:19 +07:00
renovate[bot]
986df75f43 Update dependency metascraper-author to v5.8.7 (#11369) 2019-11-13 15:16:59 +07:00
renovate[bot]
da0ad2d717 Update dependency metascraper-logo-favicon to v5.8.7 (#11373) 2019-11-13 15:16:27 +07:00
renovate[bot]
fc3182f9f9 Update dependency metascraper-image to v5.8.7 (#11371) 2019-11-13 15:16:00 +07:00
renovate[bot]
4709d1cc6b Update dependency metascraper-title to v5.8.7 (#11375) 2019-11-13 15:14:51 +07:00
renovate[bot]
c531b12a41 Update dependency metascraper-logo-favicon to v5.7.21 (#11362) 2019-11-13 13:57:29 +07:00
renovate[bot]
be9066bb79 Update dependency metascraper-url to v5.8.7 (#11376) 2019-11-13 13:49:23 +07:00
renovate[bot]
fc9187d2ab Update dependency metascraper-description to v5.8.7 (#11370) 2019-11-13 13:48:47 +07:00
renovate[bot]
b78a467890 Update dependency metascraper-logo to v5.8.7 (#11372) 2019-11-13 13:47:06 +07:00
renovate[bot]
3ae8d3b673 Update dependency metascraper to v5.8.7 (#11368) 2019-11-13 13:46:27 +07:00
renovate[bot]
28a69be7ce Update dependency metascraper-publisher to v5.8.7 (#11374) 2019-11-13 13:45:17 +07:00
Renovate Bot
e00f67f04e Update dependency metascraper-title to v5.7.21 2019-11-11 13:22:54 +00:00
Nazar Gargol
25e2ced88b Version bump to 3.0.3 2019-11-11 18:55:36 +07:00
Nazar Gargol
c9bd4a6c97 Updated Ghost-Admin to 3.0.3 2019-11-11 18:55:36 +07:00
Nazar Gargol
d1ae628746 Updated Casper to 3.0.3 2019-11-11 18:55:36 +07:00
Renovate Bot
5a5943e745 Update dependency metascraper-url to v5.7.21 2019-11-11 11:36:37 +00:00
Naz Gargol
45253cfe5f
🐛 Fixed 3.0 SQLite subscribers migration (#11383)
closes #11349

- The main reason for failure was SQLite's 999 variable limit
- More details here https://github.com/TryGhost/Ghost/pull/11270
2019-11-11 18:20:38 +07:00
Nazar Gargol
ae5eb4802c Reverted support to only data.post in meta layer
no issue

- It was partially removed in https://github.com/TryGhost/Ghost/pull/11080/files but didn't take into account hardcoded value in format response stage
2019-11-11 17:49:36 +07:00
Nazar Gargol
6345684556 🐛 Fixed twitter meta description for pages
closes https://github.com/TryGhost/Ghost/issues/11317
refs https://github.com/TryGhost/Ghost/issues/10042

- Introduced with f69f04ae8d
- Description and possible solution available in https://github.com/TryGhost/Ghost/issues/10042#issuecomment-551467666
2019-11-11 17:49:03 +07:00
Renovate Bot
d8ca54fd71 Update dependency metascraper-publisher to v5.7.21 2019-11-11 10:22:16 +00:00
Renovate Bot
d6399f3318 Update dependency metascraper-image to v5.7.21 2019-11-11 09:23:43 +00:00
Renovate Bot
fd4766689d Update dependency metascraper-logo to v5.7.21 2019-11-11 08:22:37 +00:00
Renovate Bot
d1c7e068a8 Update dependency metascraper-author to v5.7.21 2019-11-11 07:19:23 +00:00
Renovate Bot
d273b03169 Update dependency metascraper-description to v5.7.21 2019-11-11 06:21:31 +00:00
Renovate Bot
ccc60a7a50 Update dependency metascraper to v5.7.21 2019-11-11 05:20:07 +00:00
Renovate Bot
e2847ae4cf Update dependency mock-knex to v0.4.7 2019-11-11 04:21:00 +00:00
Renovate Bot
e4a86f0120 Update dependency glob to v7.1.6 2019-11-11 03:25:50 +00:00
Renovate Bot
bd9cb1155b Update dependency csv-parser to v2.3.2 2019-11-11 02:20:33 +00:00
Renovate Bot
3a67245a71 Update dependency @tryghost/members-ssr to v0.7.3 2019-11-11 01:20:49 +00:00
Hannah Wolfe
6c921bf2ef Fix typo in regression test 2019-11-08 17:28:07 +07:00
Fabien O'Carroll
0a47adac88
Updated name of bulk email service config
no-issue
2019-11-08 17:26:05 +07:00
Hannah Wolfe
551e552928 Add a fallback API version, allows tests to pass
- 😏
- this shouldn't really be a thing, but it's better than updating 52 tests...
2019-11-08 17:24:10 +07:00