TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-30 06:12:03 +03:00
Code Issues Projects Releases Wiki Activity
15,123 Commits 250 Branches 1,686 Tags 400 MiB
cabf78e938
Commit Graph

15123 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Lockyer
44ad9fde09 Updated Admin to v4.27.1 2021-12-08 16:02:08 +00:00
Fabien egg O'Carroll
55d7176e51 🐛 Fixed card scripts executing before DOM is parsed 
no-issue

Using the async attribute means that the script is downloaded in
parallel with the parsing of the html into DOM, and then executed upon
completion. This means that the script cannot be sure that particular
parts of the DOM exist as it may not have finished parsing. This has
resulted in bugs with the new toggle card not working.

Switching our script to use the defer attribute means that the script is
still downloaded in parallel with parsing, but it is not executed until
parsing is complete. This means that the script can safely access the
DOM.
 2021-12-08 17:54:37 +02:00
Daniel Lockyer
daed6f53fb v4.27.0 2021-12-08 15:38:07 +00:00
Daniel Lockyer
52491e7a6e Updated Admin to v4.27.0 2021-12-08 15:38:06 +00:00
Daniel Lockyer
b52476df1c 🎨 Updated Casper to v4.4.0 2021-12-08 15:38:06 +00:00
Kevin Ansfield
b3a57f702b Removed quoteStyles flag 
refs https://github.com/TryGhost/Team/issues/1239

- alternative blockquote style feature is no longer behind the flag in Admin so we no longer need the flag server-side
 2021-12-08 15:21:49 +00:00
Fabien egg O'Carroll
d6e6f2e4be ✨ Added support for rich Twitter embeds in emails 
refs https://github.com/TryGhost/Team/issues/1001

This adds custom rendering to Twitter embeds for email newsletters, so
that rather than displaying a plaintext blockquote with the tweet
contents, we render an rich Twitter card.
 2021-12-08 17:19:27 +02:00
Renovate Bot
dd63acf95c Update dependency @sentry/node to v6.16.0 2021-12-08 14:43:05 +00:00
Daniel Lockyer
fa8c3ebe99 Revert "Extract logging from DI patterns, only use @tryghost/logging package" 
This reverts commit 97451a93cb.
 2021-12-08 14:28:41 +00:00
Daniel Lockyer
2d090b8b2a Revert "Remove unnecessary references to ghostVersion" 
This reverts commit 443ee369d2.
 2021-12-08 14:28:41 +00:00
Peter Zimon
3a877253e6 Updated Twitter email card styles 
Fixed media (image or video) spacing for Twitter embeds in emails on mobile sizes.

- bumped `@tryghost/kg-default-cards` to a fixed version
 2021-12-08 14:22:53 +01:00
Sanne de Vries
6e4be46fb3 Updated audio card frontend styles in Chrome 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-08 12:22:39 +00:00
djordje vlaisavljevic
e72092fa5e Updated product card frontend styles 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-08 12:40:57 +01:00
Rishabh
9cbaab119b Refined audio card player with multiple playback rate options 
refs https://github.com/TryGhost/Team/issues/1230

- adds multiple playback rate option to audio card player on click
 2021-12-08 16:36:22 +05:30
Thibaut Patel
62988fe1db Added the tweetGridCard feature flag 
refs https://github.com/TryGhost/Team/issues/1255

- developer flag for enabling tweet grid cards in the card menus
 2021-12-08 10:07:56 +01:00
djordje vlaisavljevic
cb86c06504 Removed unnecessary CSS and !important declarations 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-08 10:03:12 +01:00
Kevin Ansfield
8e1a0e1f02 Added theme checks for alternative blockquote CSS class 
refs https://github.com/TryGhost/Team/issues/1239

- bumped gscan to include a checks for `.kg-blockquote-alt` when the built-in `blockquote` CSS is disabled
 2021-12-08 09:02:05 +00:00
Renovate Bot
7924a52cc2
Update metascraper to v5.25.5 2021-12-07 22:00:35 +00:00
renovate[bot]
c4e5e84ce8
Added the product card parser plugin 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-07 22:58:41 +01:00
renovate[bot]
78c4422615
Updated the product card rendering 
refs https://github.com/TryGhost/Team/issues/1245

- Updated the markup to make it easier to style the card
 2021-12-07 22:57:49 +01:00
djordje vlaisavljevic
88238e6403 Updated frontend styles for product card 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-07 20:58:42 +01:00
djordje vlaisavljevic
325de3e5cf Updated frontend styles for product card 
refs https://github.com/TryGhost/Team/issues/1245
 2021-12-07 20:16:45 +01:00
Rishabh
27ced6cc84 Refined audio card player sliders 
refs https://github.com/TryGhost/Team/issues/1230

- refines seek and volume sliders for audio player to show progress marker with background color
 2021-12-08 00:16:32 +05:30
Renovate Bot
1dd012d9f4
Update dependency multer to v1.4.4 2021-12-07 17:04:32 +00:00
Peter Zimon
990e7640e8 Refined Twitter embed card styles 
Twitter cards in emails needed to be updated to look and work closer to an actual tweet.

- bumped `@tryghost/kg-default-cards` to a fixed version
 2021-12-07 18:01:23 +01:00
djordje vlaisavljevic
bf78df0e07 Added frontend CSS file for product card 
refs https://github.com/TryGhost/Team/issues/1233
 2021-12-07 17:33:13 +01:00
renovate[bot]
16a73f7017
Added a first version of the product card frontend rendering 
refs https://github.com/TryGhost/Team/issues/1233

- renders the card in the same way the Koenig editor does
 2021-12-07 17:23:05 +01:00
Sanne de Vries
31cadeaad0 Updated audio card frontend rendering 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-07 16:02:06 +00:00
Rishabh
52faba6dac Added dynamic play/pause and unmute state for audio card player 
refs https://github.com/TryGhost/Team/issues/1230

- adds dynamic play/pause icon toggle for audio player
- adds dynamic mute/unmute icon toggle for mute behavior
- fixed volume slider not working
 2021-12-07 20:43:20 +05:30
Sam Lord
443ee369d2
Remove unnecessary references to ghostVersion 
refs: https://github.com/TryGhost/Toolbox/issues/146
GhostVersion was passed in here but not used at all. This just removes those unnecessary usages.
 2021-12-07 13:48:22 +00:00
Sanne de Vries
986f731e60 Updated audio card frontend styles 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-07 13:47:36 +00:00
Sanne de Vries
259d40641d Updated audio card playback speed characters 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-07 13:16:04 +00:00
Sanne de Vries
b6544afff5 Updated audio card frontend rendering 
Refs https://github.com/TryGhost/Team/issues/1230
 2021-12-07 13:04:44 +00:00
James Morris
0aaa1b9c75 Removed more unnecessary styles from blockquote card styles 
refs https://github.com/TryGhost/Team/issues/1239
 2021-12-07 11:53:46 +00:00
James Morris
5c4cfc785f Removed blockquote selector from card styles plus email tweaks 
refs https://github.com/TryGhost/Team/issues/1239
 2021-12-07 11:35:58 +00:00
Daniel Lockyer
0d8bc06fb9
Merged v4.26.1 into main 
v4.26.1
 2021-12-07 09:36:54 +00:00
Daniel Lockyer
dd5c5b7551 v4.26.1 2021-12-07 09:35:14 +00:00
Daniel Lockyer
9f0d72f159 Updated Admin to v4.26.1 2021-12-07 09:35:14 +00:00
Fabien egg O'Carroll
2a1eb3de88 Improved rendering for twitter newsletter embeds 
refs https://github.com/TryGhost/Team/issues/1001

This also adds the missing alpha flag so that we can release this when
it's ready.
 2021-12-07 11:23:54 +02:00
djordje vlaisavljevic
aa7d1e240c
🎨 Made toggle card closed by default 
refs https://github.com/TryGhost/Team/issues/1209
 2021-12-07 09:00:43 +00:00
Daniel Lockyer
4673bd05fc
Destroyed connection before restoring DB file 
no issue

- we've seen some instances of SQLite saying "database disk image is malformed"
- I think this happens because we copy the file whilst we are still connected to
  the old DB
- this commit destroys the connection before copying the clean file to the live
  DB file
 2021-12-07 08:23:51 +00:00
Naz
9c0752896c Fixed error wording in fixture-utils 
refs 404b2023e5
refs https://github.com/TryGhost/Toolbox/issues/129

- The previous error message wasn't helpful at all . Now we can tell "what?" fixture was looked-up and then go from there to find out why it is missing
 2021-12-07 11:12:10 +04:00
djordje vlaisavljevic
67b6304807 Made toggle card closed by default 
refs https://github.com/TryGhost/Team/issues/1209
 2021-12-06 22:15:54 +01:00
Sam Lord
97451a93cb
Extract logging from DI patterns, only use @tryghost/logging package 
refs: https://github.com/TryGhost/Toolbox/issues/146

Switched to @tryghost/logging instead of passing around the library. The main sticking points of this change are jobs. When jobs are launched we don't want them to use a separate @tryghost/logging instance because they would start parallel rotation jobs. @tryghost/logging v2.x passes all logs to the parent process if run in a child process, so that we can use the same patterns in jobs and the rest of the codebase.
 2021-12-06 18:00:55 +00:00
Sam Lord
928a30bd98 Prevent TailScale from trying to run in pushes to main branch on forks. 2021-12-06 15:28:05 +00:00
Daniel Lockyer
a3cc66be50 Copied DB for faster SQLite tests 
refs https://github.com/TryGhost/Toolbox/issues/136

- we nuke and reinitialize the DB many times between tests
- this forms a good portion of the time taken and we shouldn't be spending
  so much time on just resetting the DB back to a known state
- this commit switches out the knex-migrator reset + init calls for SQLite to
  a function which keeps a clean copy of the DB and copies the file back
  when we "reset"
- for MySQL, existing functionality is kept
- this massively speeds up tests because it saves ~700ms+ for every reset
- whilst this change seems to work, it's just the start so there's a
  lot more refactoring needed. this change is currently gated to CI until
  it's deemed safe/sane enough to run on local machines without blowing
  up
 2021-12-06 15:22:44 +00:00
Hannah Wolfe
40fee069c9
Moved locale testing out of casper fixture (#13850) 
refs: https://github.com/TryGhost/Toolbox/issues/137#issuecomment-986829141

- Moving the weird customisation of Casper out of the test fixture
- Created a standalone theme for testing locales instead
- This should make it easier for us to update our Casper fixture
 2021-12-06 15:11:54 +00:00
Daniel Lockyer
5d191e90b9 v4.26.0 2021-12-06 13:29:21 +00:00
Daniel Lockyer
070992b316 Updated Admin to v4.26.0 2021-12-06 13:29:21 +00:00
Daniel Lockyer
41d301d78b 🎨 Updated Casper to v4.3.1 2021-12-06 13:29:20 +00:00