Commit Graph

6204 Commits

Author SHA1 Message Date
Austin Burdine
d0a9568cc4 Merge pull request #6673 from kevinansfield/dont-swallow-ajax-errors
Don't swallow error details in ajax service
2016-04-04 09:13:39 -05:00
Kevin Ansfield
6892df8a7b Don't swallow error details in ajax service
no issue
- keep the original `ember-ajax` behaviour rather than returning `false` when we hit an ajax error - we should only be using `normalizeErrorResponse` to normalize our error responses 😉
- ensures our application code has access to the returned status code for ajax errors
2016-04-04 14:19:05 +01:00
Kevin Ansfield
da39239471 Merge pull request #6672 from acburdine/ember-2.4.4
Ember Updates
2016-04-04 07:57:24 +01:00
Hannah Wolfe
af22bae556 Merge pull request #6670 from jaswilli/fix-unit-tests
Fix unit test bugs
2016-04-03 20:02:19 -07:00
Jason Williams
db1d174034 Merge pull request #6667 from joerx/cleanup_sanitize
Remove sanitize() from model/base because clean code
2016-04-03 19:05:56 -05:00
Austin Burdine
5e73700b92 deps: ember-data@2.4.3 2016-04-03 19:03:55 -05:00
Austin Burdine
003ddd9ec7 deps: ember@2.4.4 2016-04-03 19:01:36 -05:00
Jason Williams
8af91c1a4d Fix unit test bugs
- Stub moment instead of using a fake clock.
- Do not mutate fixture data.
- Do not modify express.response.
2016-04-02 21:38:17 -05:00
Joerg Henning
4a3d8c7ae8 Remove sanitize() from model/base because clean code 2016-04-03 08:17:17 +08:00
Jason Williams
5f8ef26eb3 Merge pull request #6654 from ErisDS/fixture-population
Improve fixture population code
2016-04-02 09:04:24 -05:00
Hannah Wolfe
d260f7b010 Merge pull request #6633 from dbalders/password-change
Check Old Password on Password Change
2016-04-01 11:25:33 -07:00
Hannah Wolfe
f4d1afe494 Merge pull request #6665 from jaswilli/uglify
deps: grunt-contrib-uglify@1.0.1
2016-04-01 11:12:38 -07:00
Jason Williams
0148ed383d Merge pull request #6663 from kevinansfield/fix-xregexp-issues
Drop XRegExp dependency
2016-03-31 10:06:47 -05:00
Sebastian Gierlinger
430604d8e5 Merge pull request #6658 from jaswilli/consolidate-tmp
Replace internal tempfile name generator
2016-03-31 16:16:58 +02:00
Sebastian Gierlinger
7dfd3d0de5 Merge pull request #6660 from cobbspur/pages
Add structured data to static pages
2016-03-31 16:08:27 +02:00
Austin Burdine
0e6c6c4549 Merge pull request #6666 from kevinansfield/ember-cli-2-4-3
deps: ember-cli@2.4.3
2016-03-31 06:05:28 -05:00
Hannah Wolfe
d16433085f Improve fixtures & population code
refs #6301

- The order of model fixtures matters, so they should be in an array
- By splitting out the population code into a utils file, it'll be possible to use this to do updates as well
- This should make it much easier to do permissions updates in future
2016-03-31 11:48:44 +01:00
Kevin Ansfield
95e041b2ea deps: ember-cli@2.4.3
no issue
- https://github.com/ember-cli/ember-cli/releases/tag/v2.4.3
2016-03-31 10:13:15 +01:00
David Balderston
110a5be253 Check Old Password on Password Change
Closes #6620

* Changed it from always returning true, to evaluate if it is the
current logged in user, and if so, check the old password. If not,
ignore
2016-03-30 21:04:19 -07:00
Jason Williams
401fbb1c71 deps: grunt-contrib-uglify@1.0.1 2016-03-30 17:22:33 -05:00
Kevin Ansfield
9eef2616e4 Drop XRegExp dependency
closes #6102
- removes the `xregexp` dependency
- pulls in the non-alphnumeric unicode list directly from the XRegExp library to ensure the word count helper still takes into account unicode strings

The XRegExp dependency was breaking as new browsers add more es6 support as evidenced in #6102. Upgrading to version 3.1.0 fixed the Chrome "experimental JS" issue but was still broken in Safari Technology Preview.

We only use one feature of `XRegExp` in a single place for a relatively non-critical feature: calculating the word count. As such I figured it may be better to drop the 63KB minified dependency and simply copy the result of the compiled regex directly until such time as XRegExp has native support in our supported browsers.
2016-03-30 19:45:20 +01:00
cobbspur
5102637b8e Add structured data to static pages
refs #6534

- adds structured data on static pages
- selects post context object for static pages
- updates tests
2016-03-30 12:57:13 +01:00
Jason Williams
0ed0a72c35 Replace internal tempfile name generator
- Drops "tempfile" module in favor of using the "tmp"
  external package.
- Drop unused "rimraf-then" package.
2016-03-29 15:19:42 -05:00
Hannah Wolfe
48b846b13d Merge pull request #6631 from dbalders/draft-slug
Update Post Slug while Draft on Title Changes
2016-03-29 15:35:08 +01:00
Hannah Wolfe
5bd30ef183 Merge pull request #6650 from jaswilli/upload-test
Remove method stubs from upload API tests
2016-03-29 14:23:26 +01:00
Austin Burdine
f0e5eab8b5 Merge pull request #6653 from kevinansfield/deps-ember-sinon
deps: ember-sinon@0.5.0
2016-03-29 07:23:29 -05:00
Kevin Ansfield
7ef06ea748 deps: ember-sinon@0.5.0
no issue
- pulls sinon.js from NPM instead of bower - https://github.com/csantero/ember-sinon/releases/tag/v0.5.0
- only dependency updates and ember-cli changes - https://github.com/csantero/ember-sinon/compare/v0.3.0...v0.5.0
2016-03-29 13:03:59 +01:00
Jason Williams
bdcb25a0cd Remove method stubs from upload API tests 2016-03-28 23:02:23 -05:00
Hannah Wolfe
dd64deb75b Merge pull request #6610 from dbalders/foreach-last
Change default setting for `to` inside foreach helper
2016-03-28 18:42:06 +01:00
Sebastian Gierlinger
f0e364b42e Merge pull request #6643 from ErisDS/drop-iojs
Remove support for old io.js version
2016-03-26 16:12:32 +01:00
Hannah Wolfe
bd0f16aea7 Remove support for old io.js version
- io.js and node merged some time ago now
- we only ever had support for a single random and now very old version of io.js anyway
2016-03-26 14:54:23 +00:00
Jason Williams
dde27f4dcf Merge pull request #6638 from ErisDS/knex-config
Make it possible to override `useNullAsDefault`
2016-03-25 10:17:01 -05:00
Hannah Wolfe
115eb46d7d Merge pull request #6641 from kevinansfield/deps-liquid-tether
deps: liquid-tether@1.0.0
2016-03-25 09:17:43 +00:00
Kevin Ansfield
e23cb9e8a7 deps: liquid-tether@1.0.0
no issue
- contains cleanup and test fixes - https://github.com/pzuraq/liquid-tether/compare/v0.1.11...v1.0.0
2016-03-25 09:00:38 +00:00
Sebastian Gierlinger
31e68acb85 Merge pull request #6639 from ErisDS/fixture-cleanup
Data & fixture migration cleanup
2016-03-25 09:51:01 +01:00
Hannah Wolfe
681e9f9f51 Data & fixture migration cleanup
refs #6621, #6622

- remove unneeded `return new Promise.resolve()` lines
- reduce code in tests
- improve quality of tests checking that all task functions are executed
- add missing test coverage
2016-03-24 22:24:57 +00:00
Hannah Wolfe
57271878c0 Make it possible to override useNullAsDefault
refs #6623, #6637

- this was supposed to be in the original
2016-03-24 16:34:48 +00:00
Jason Williams
e72dddbf97 Merge pull request #6637 from ErisDS/knex-config
Disable knex useNullAsDefault warning
2016-03-24 08:15:06 -05:00
Hannah Wolfe
8c74f55b36 Disable knex useNullAsDefault warning
refs #6623

- automatically set useNullAsDefault to false for sqlite3 so that we don't get a warning
- we should *not* be relying on the behaviour of interpretting undefined anywhere, so it is correct that an error should be output if this happens so that we can fix the bad behaviour
2016-03-24 12:49:06 +00:00
Hannah Wolfe
a8fc2969cc Merge pull request #6635 from kevinansfield/remove-hammerjs
Remove jquery-hammerjs bower dependency
2016-03-24 11:18:40 +00:00
Kevin Ansfield
3d06b053d2 Remove jquery-hammerjs bower dependency
no issue
- removes `jquery-hammerjs` as it doesn't appear to be used anywhere and isn't included in the build by ember-cli
2016-03-24 10:04:52 +00:00
David Balderston
81c215dbe5 Update Post Slug while Draft on Title Changes
Closes #5062

* As long as the post has never been published, update the slug to
match the new title if the title is changed
2016-03-23 10:20:22 -07:00
Hannah Wolfe
192086bd98 Merge pull request #6615 from jaswilli/delete-204
Use HTTP status 204 on deletes
2016-03-22 18:43:49 +00:00
Hannah Wolfe
66fb70337f Merge pull request #6623 from jaswilli/knex
Update knex and bookshelf
2016-03-22 17:09:12 +00:00
Jason Williams
136bdbd9ff Return http status 204 on deletes
Closes #2871
- Refactor api http handlers.
- Update tests.
- Remove special handling of responses in ember adapter.
2016-03-22 11:42:48 -05:00
Hannah Wolfe
bba7bdd8eb Merge pull request #6613 from jaswilli/delete-content-refactor
Refactor content deletion
2016-03-22 16:39:43 +00:00
Kevin Ansfield
94abaca531 Merge pull request #6611 from dbalders/ember-navitems
Remove Nav Item Placeholder and Set as Base Url Value
2016-03-22 16:18:28 +01:00
Jason Williams
9fe573a0c5 Refactor content deletion
- Simplify the `init` method in `models/index.js` so that it no longer
  returns a promise. Easier to use.
- Eliminates the `deleteAllContent` method from `models/index.js` as it
  can all be handled at the API layer in a single spot.
- Optimize `destroyAllContent` in `api/db.js`. Eliminates
  double-fetching every post from the database and converting it to
  JSON. Also only fetches ids from the database instead of the entire
  model.
- Eliminates the custom static method `destroy` in the Post model in
  favor of handling detaching tag relations in a single place (the
  `destroying` event). This also eliminates a big source of unneeded
  database round trips--needing to get post ids to feed into
  `Post.destroy()` which then re-fetches the post again.
2016-03-22 10:10:09 -05:00
Sebastian Gierlinger
229c2925a6 Merge pull request #6622 from ErisDS/migration-messaging
Migration messaging improvements
2016-03-22 15:24:13 +01:00
David Balderston
9eb0a8a690 Remove Nav Item Placeholder and Set as Base Url Value
Closes #6440

* Removed the `.fake-placeholder`class from the input, test, and css
* On adding a nav item, if the url value has not been set by the user,
then set it to the base url as shown in the input
* If url has been set by the user, just do what it has always done
2016-03-22 07:11:20 -07:00